9058 2006-05-23 02:30:36 -0700 add wrappers for primitive css types when bridged to objective-c 2007-10-11 18:31:56 -0700 1 1 1 Unclassified WebKit WebKit API 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 speth webkit-unassigned oldest_to_newest 43250 0 speth 2006-05-23 02:30:36 -0700 There are a few remaining classes that need to be wrapped properly when bridged to objective-c. These are the ones that did not get fixed in bug 8331. They are DOMRGBColor, DOMRect, and DOMCounter, and I'm sure that it would be a straight-forward fix, and i'm just missing something. I'm attaching a patch in case someone wants to look at what i tried (it doesn't work), and possibly shed some light on this. 43251 1 8477 speth 2006-05-23 02:31:44 -0700 Created attachment 8477 broken patch - why doesn't it work? 43285 2 ggaren 2006-05-23 10:51:29 -0700 More info on why this doesn't work would be helpful (failed compile? test case fails?). I think the issue is that you need to implement the xxxWith: methods for the classes in question. 58332 3 eric 2007-10-11 18:31:56 -0700 These have all been fixed by now. 8477 2006-05-23 02:31:44 -0700 2006-05-23 02:31:44 -0700 broken patch - why doesn't it work? patch-broken-types text/plain 1632 speth LS0tIERPTVV0aWxpdHkubW0JMjAwNi0wNS0yMyAwMjoxNTo1OS4wMDAwMDAwMDAgLTA3MDAKKysr IERPTVV0aWxpdHkrYnJva2VudHlwZXMubW0JMjAwNi0wNS0yMyAwMTo1NjowNy4wMDAwMDAwMDAg LTA3MDAKQEAgLTg2LDYgKzg2LDIzIEBAIHN0YXRpYyBpbmxpbmUgaWQgY3JlYXRlT2JqQ0RPTUNT U1ZhbHVlKFcKICAgICByZXR1cm4gW0RPTUNTU1ZhbHVlIF92YWx1ZVdpdGg6aW1wbF07CiB9CiAK KyNpZiAwICAgLy8gSkdTIC0gdGhlc2UgZG9uJ3Qgd29yaworc3RhdGljIGlubGluZSBpZCBjcmVh dGVPYmpDRE9NUkdCQ29sb3IoV2ViQ29yZTo6UkdCQ29sb3IgKmltcGwpCit7CisgICAgcmV0dXJu IFtET01SR0JDb2xvciBfY29sb3JXaXRoOmltcGxdOworfQorCitzdGF0aWMgaW5saW5lIGlkIGNy ZWF0ZU9iakNET01SZWN0KFdlYkNvcmU6OlJlY3RJbXBsICppbXBsKQoreworICAgIHJldHVybiBb RE9NUmVjdCBfcmVjdFdpdGg6aW1wbF07Cit9CisKK3N0YXRpYyBpbmxpbmUgaWQgY3JlYXRlT2Jq Q0RPTUNvdW50ZXIoV2ViQ29yZTo6Q291bnRlciAqaW1wbCkKK3sKKyAgICByZXR1cm4gW0RPTUNv dW50ZXIgX2NvdW50ZXJXaXRoOmltcGxdOworfQorI2VuZGlmCisKIG5hbWVzcGFjZSBLSlMgewog CiB2b2lkICpTY3JpcHRJbnRlcnByZXRlcjo6Y3JlYXRlT2JqY0luc3RhbmNlRm9yVmFsdWUoRXhl Y1N0YXRlICpleGVjLCBKU09iamVjdCAqdmFsdWUsIGNvbnN0IEJpbmRpbmdzOjpSb290T2JqZWN0 ICpvcmlnaW4sIGNvbnN0IEJpbmRpbmdzOjpSb290T2JqZWN0ICpjdXJyZW50KQpAQCAtMTEyLDYg KzEyOSwxNCBAQCB2b2lkICpTY3JpcHRJbnRlcnByZXRlcjo6Y3JlYXRlT2JqY0luc3RhCiAgICAg ICAgIG5ld09iaiA9IGNyZWF0ZU9iakNET01NZWRpYUxpc3Qoc3RhdGljX2Nhc3Q8RE9NTWVkaWFM aXN0ICo+KHZhbHVlKS0+aW1wbCgpKTsKICAgICBlbHNlIGlmICh2YWx1ZS0+aW5oZXJpdHMoJkRP TUNTU1ZhbHVlOjppbmZvKSkKICAgICAgICAgbmV3T2JqID0gY3JlYXRlT2JqQ0RPTUNTU1ZhbHVl KHN0YXRpY19jYXN0PERPTUNTU1ZhbHVlICo+KHZhbHVlKS0+aW1wbCgpKTsKKyNpZiAwICAgLy8g SkdTIC0gdGhlc2UgZG9uJ3Qgd29yaworICAgIGVsc2UgaWYgKHZhbHVlLT5pbmhlcml0cygmRE9N UkdCQ29sb3I6OmluZm8pKQorICAgICAgICBuZXdPYmogPSBjcmVhdGVPYmpDRE9NUkdCQ29sb3Io c3RhdGljX2Nhc3Q8RE9NUkdCQ29sb3IgKj4odmFsdWUpLT5pbXBsKCkpOworICAgIGVsc2UgaWYg KHZhbHVlLT5pbmhlcml0cygmRE9NUmVjdDo6aW5mbykpCisgICAgICAgIG5ld09iaiA9IGNyZWF0 ZU9iakNET01SZWN0KHN0YXRpY19jYXN0PERPTVJlY3QgKj4odmFsdWUpLT5pbXBsKCkpOworICAg IGVsc2UgaWYgKHZhbHVlLT5pbmhlcml0cygmRE9NQ291bnRlcjo6aW5mbykpCisgICAgICAgIG5l d09iaiA9IGNyZWF0ZU9iakNET01Db3VudGVyKHN0YXRpY19jYXN0PERPTUNvdW50ZXIgKj4odmFs dWUpLT5pbXBsKCkpOworI2VuZGlmCiAgICAgCiAgICAgaWYgKG5ld09iaikKICAgICAgICAgW25l d09iaiBfaW5pdGlhbGl6ZVdpdGhPYmplY3RJbXA6dmFsdWUgb3JpZ2luRXhlY3V0aW9uQ29udGV4 dDpvcmlnaW4gZXhlY3V0aW9uQ29udGV4dDpjdXJyZW50XTsK