90578 2012-07-04 17:52:29 -0700 AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode 2012-07-04 20:30:52 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 li.yin li.yin crogers eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 663204 0 li.yin 2012-07-04 17:52:29 -0700 From http://www.w3.org/TR/webaudio/#AudioDestinationNode-section An AudioSourceNode has no inputs and a single output. An AudioDestinationNode has one input and no outputs. Currently, the test webaudio/audionode.html has covered AudioSourceNode, it will be better to cover AudioDestinationNode. 663206 1 150854 li.yin 2012-07-04 17:59:34 -0700 Created attachment 150854 Patch 663264 2 150854 webkit.review.bot 2012-07-04 20:30:48 -0700 Comment on attachment 150854 Patch Clearing flags on attachment: 150854 Committed r121877: <http://trac.webkit.org/changeset/121877> 663265 3 webkit.review.bot 2012-07-04 20:30:52 -0700 All reviewed patches have been landed. Closing bug. 150854 2012-07-04 17:59:34 -0700 2012-07-04 20:30:48 -0700 Patch bug-90578-20120706090340.patch text/plain 3300 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQ5M2Q2ZDEwZGM5OGEyNWU0N2Q3 ZjM4ODFiNTM1NjEwZmJmODUzZS4uOWQ5NDRhNWY5NzM0OGI1ZjYzOThkYzcyYmJjMTMwYTFiODIy YzNiYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTA1ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIEF1ZGlvTm9kZSB0ZXN0IHNob3VsZCBjb3ZlciBudW1iZXJP ZklucHV0cyBhbmQgbnVtYmVyT2ZPdXRwdXRzIG9mIEF1ZGlvRGVzdGluYXRpb25Ob2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDU3OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHA6Ly93 d3cudzMub3JnL1RSL3dlYmF1ZGlvLyNBdWRpb0Rlc3RpbmF0aW9uTm9kZS1zZWN0aW9uCisgICAg ICAgIEFuIEF1ZGlvU291cmNlTm9kZSBoYXMgbm8gaW5wdXRzIGFuZCBhIHNpbmdsZSBvdXRwdXQu CisgICAgICAgIEFuIEF1ZGlvRGVzdGluYXRpb25Ob2RlIGhhcyBvbmUgaW5wdXQgYW5kIG5vIG91 dHB1dHMuCisgICAgICAgIEN1cnJlbnRseSwgdGhlIHRlc3Qgd2ViYXVkaW8vYXVkaW9ub2RlLmh0 bWwgaGFzIGNvdmVyZWQgQXVkaW9Tb3VyY2VOb2RlLAorICAgICAgICBpdCBpcyBzdGlsbCByZXF1 aXJlZCB0byBjb3ZlciBBdWRpb0Rlc3RpbmF0aW9uTm9kZS4KKworICAgICAgICAqIHdlYmF1ZGlv L2F1ZGlvbm9kZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogd2ViYXVkaW8vYXVkaW9ub2RlLmh0 bWw6CisKIDIwMTItMDctMDMgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVuaW5nIGZvciBXaW4gYnVpbGQK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb25vZGUtZXhwZWN0ZWQudHh0CmluZGV4IDM1MmQ2 YWY1YzM1NGM0ZjUzM2Q1YzQyZDcwNWMzMTZlNjYzOTg1ZGYuLjA1NDBmZTc0OTlmMDk4MjlhMzll OTYyOGVmMWRiOGJlMDBmYjk4ZGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1 ZGlvbm9kZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9ub2Rl LWV4cGVjdGVkLnR4dApAQCAtNyw2ICs3LDggQEAgUEFTUyBhdWRpb05vZGUubm90ZUdyYWluT24o KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KIFBBU1Mg YXVkaW9Ob2RlLm5vdGVPZmYoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdo IGFyZ3VtZW50cy4KIFBBU1MgU291cmNlIEF1ZGlvTm9kZSBoYXMgbm8gaW5wdXRzLgogUEFTUyBT b3VyY2UgQXVkaW9Ob2RlIGhhcyBvbmUgb3V0cHV0LgorUEFTUyBEZXN0aW5hdGlvbiBBdWRpb05v ZGUgaGFzIG9uZSBpbnB1dC4KK1BBU1MgRGVzdGluYXRpb24gQXVkaW9Ob2RlIGhhcyBubyBvdXRw dXRzLgogUEFTUyBjb25uZWN0KCkgZXhjZXB0aW9uIHRocm93biBmb3IgaWxsZWdhbCBkZXN0aW5h dGlvbiBBdWRpb05vZGUuCiBQQVNTIGNvbm5lY3QoKSBleGNlcHRpb24gdGhyb3duIGZvciBpbGxl Z2FsIG91dHB1dCBpbmRleC4KIFBBU1MgY29ubmVjdCgpIGV4Y2VwdGlvbiB0aHJvd24gZm9yIGls bGVnYWwgaW5wdXQgaW5kZXguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRp b25vZGUuaHRtbCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS5odG1sCmluZGV4IGRh MDBkYTI4NzJiYWQyN2E3NTc2OTk1NTdhNzdkOWU0Y2MwZmFhYWUuLmRkMGRjMzI5NThhNWVkMmY4 ZDdiYWY0YzRkNjRkZTEzNGFkN2Y1MjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlv L2F1ZGlvbm9kZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS5odG1s CkBAIC0zMSwxNyArMzEsMjggQEAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICBzaG91bGRUaHJv dygiYXVkaW9Ob2RlLm5vdGVHcmFpbk9uKCkiKTsKICAgICBzaG91bGRUaHJvdygiYXVkaW9Ob2Rl Lm5vdGVPZmYoKSIpOwogCi0gICAgLy8gQ2hlY2sgbnVtYmVyIG9mIGlucHV0cyBhbmQgb3V0cHV0 cy4KLSAgICBpZiAoYXVkaW9Ob2RlLm51bWJlck9mSW5wdXRzID09IDApCisgICAgLy8gQ2hlY2sg aW5wdXQgYW5kIG91dHB1dCBudW1iZXJzIG9mIEF1ZGlvU291cmNlTm9kZS4KKyAgICBpZiAoYXVk aW9Ob2RlLm51bWJlck9mSW5wdXRzID09PSAwKQogICAgICAgICB0ZXN0UGFzc2VkKCJTb3VyY2Ug QXVkaW9Ob2RlIGhhcyBubyBpbnB1dHMuIik7CiAgICAgZWxzZQogICAgICAgICB0ZXN0RmFpbGVk KCJTb3VyY2UgQXVkaW9Ob2RlIHNob3VsZCBub3QgaGF2ZSBpbnB1dHMuIik7CiAgICAgCi0gICAg aWYgKGF1ZGlvTm9kZS5udW1iZXJPZk91dHB1dHMgPT0gMSkKKyAgICBpZiAoYXVkaW9Ob2RlLm51 bWJlck9mT3V0cHV0cyA9PT0gMSkKICAgICAgICAgdGVzdFBhc3NlZCgiU291cmNlIEF1ZGlvTm9k ZSBoYXMgb25lIG91dHB1dC4iKTsKICAgICBlbHNlCiAgICAgICAgIHRlc3RGYWlsZWQoIlNvdXJj ZSBBdWRpb05vZGUgc2hvdWxkIGhhdmUgb25lIG91dHB1dC4iKTsKIAorICAgIC8vIENoZWNrIGlu cHV0IGFuZCBvdXRwdXQgbnVtYmVycyBvZiBBdWRpb0Rlc3RpbmF0aW9uTm9kZQorICAgIGlmIChj b250ZXh0LmRlc3RpbmF0aW9uLm51bWJlck9mSW5wdXRzID09PSAxKQorICAgICAgICB0ZXN0UGFz c2VkKCJEZXN0aW5hdGlvbiBBdWRpb05vZGUgaGFzIG9uZSBpbnB1dC4iKTsKKyAgICBlbHNlCisg ICAgICAgIHRlc3RGYWlsZWQoIkRlc3RpbmF0aW9uIEF1ZGlvTm9kZSBzaG91bGQgaGF2ZSBvbmUg aW5wdXQuIik7CisKKyAgICBpZiAoY29udGV4dC5kZXN0aW5hdGlvbi5udW1iZXJPZk91dHB1dHMg PT09IDApCisgICAgICAgIHRlc3RQYXNzZWQoIkRlc3RpbmF0aW9uIEF1ZGlvTm9kZSBoYXMgbm8g b3V0cHV0cy4iKTsKKyAgICBlbHNlCisgICAgICAgIHRlc3RGYWlsZWQoIkRlc3RpbmF0aW9uIEF1 ZGlvTm9kZSBzaG91bGQgaGF2ZSBubyBvdXRwdXRzLiIpOworCiAgICAgLy8gVHJ5IGNhbGxpbmcg Y29ubmVjdCgpIG1ldGhvZCB3aXRoIGlsbGVnYWwgdmFsdWVzLgogCiAgICAgdHJ5IHsK