90563 2012-07-04 09:08:17 -0700 [chromium] Add a method didChangeFormState to WebViewClient. 2012-07-05 07:24:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olilan olilan abarth dglazkov eric fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 663004 0 olilan 2012-07-04 09:08:17 -0700 [chromium] Add a method didChangeFocusedFormNodeState to WebViewClient. 663008 1 150811 olilan 2012-07-04 09:12:12 -0700 Created attachment 150811 Patch 663009 2 webkit.review.bot 2012-07-04 09:15:20 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 663014 3 150811 abarth 2012-07-04 09:23:43 -0700 Comment on attachment 150811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150811&action=review > Source/WebKit/chromium/src/ChromeClientImpl.cpp:845 > + if (node->focused() && m_webView->client()) > + m_webView->client()->didChangeFocusedFormNodeState(); Should we pass |node| to the client, or does it not care? Should we have a client callback that we call unconditionally and let the embedder test for node->focused() ? 663045 4 150811 olilan 2012-07-04 09:56:29 -0700 Comment on attachment 150811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150811&action=review >> Source/WebKit/chromium/src/ChromeClientImpl.cpp:845 >> + m_webView->client()->didChangeFocusedFormNodeState(); > > Should we pass |node| to the client, or does it not care? Should we have a client callback that we call unconditionally and let the embedder test for node->focused() ? For the current purposes of the Android port this is sufficient, but passing the node unconditionally and allowing the client to perform whatever logic is required makes sense. Happy to make this change. 663075 5 abarth 2012-07-04 11:20:01 -0700 Yeah, let's do that. It will probably save us from having to add another callback later. 663526 6 150935 olilan 2012-07-05 06:42:21 -0700 Created attachment 150935 Patch 663527 7 olilan 2012-07-05 06:45:05 -0700 OK, the new patch implements the above. As WebNode did not have a focused method, the patch also adds a focused method to WebNode to allow the new method to be used as discussed. 663540 8 150935 abarth 2012-07-05 07:08:44 -0700 Comment on attachment 150935 Patch Thanks! 663547 9 150935 webkit.review.bot 2012-07-05 07:24:02 -0700 Comment on attachment 150935 Patch Clearing flags on attachment: 150935 Committed r121904: <http://trac.webkit.org/changeset/121904> 663548 10 webkit.review.bot 2012-07-05 07:24:08 -0700 All reviewed patches have been landed. Closing bug. 150811 2012-07-04 09:12:12 -0700 2012-07-05 06:42:17 -0700 Patch bug-90563-20120704171210.patch text/plain 4933 olilan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZkYjUxMDIzMTJkODg1NGEwNDI1YmRiZmIyODEwODFjYjZiY2NjNDEuLmJiMGNlYjE0NjA5OGZj ODM3ODQzMzFkMmZhNmQwZDliNDIzNTRjMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMzMgQEAKKzIwMTItMDctMDQgIE9saSBMYW4gIDxvbGlsYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGEgbWV0aG9kIGRpZENoYW5nZUZvY3VzZWRGb3Jt Tm9kZVN0YXRlIHRvIFdlYlZpZXdDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MDU2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBtZXRob2QgZGlkQ2hhbmdl Rm9jdXNlZEZvcm1Ob2RlU3RhdGUgdG8gV2ViVmlld0NsaWVudCwKKyAgICAgICAgYW5kIGNhbGxz IGl0IGZyb20gQ2hyb21lQ2xpZW50SW1wbDo6Zm9ybVN0YXRlRGlkQ2hhbmdlIHdoZW4gdGhlIGNo YW5nZWQgbm9kZQorICAgICAgICB3YXMgZm9jdXNlZC4KKworICAgICAgICBUaGlzIG5ldyBtZXRo b2QgY2FuIGJlIHVzZWQgZm9yIGV4YW1wbGUgYnkgdGhlIEFuZHJvaWQgcG9ydCB0byB1cGRhdGUg dGhlIGJyb3dzZXIncworICAgICAgICBJTUUgd2hlbiB0aGUgc3RhdGUgb2YgdGhlIGN1cnJlbnRs eSBmb2N1c2VkIHRleHQgbm9kZSBoYXMgY2hhbmdlZC4KKworICAgICAgICBBIG5ldyB0ZXN0IGhh cyBiZWVuIGFkZGVkIHRvIFdlYlZpZXdUZXN0LiBUaGlzIHRlc3QgY2hlY2tzIHRoYXQgZGlkQ2hh bmdlRm9jdXNlZEZvcm1Ob2RlU3RhdGUKKyAgICAgICAgaXMgY2FsbGVkIHdoZW4gYW4gaW5wdXQn cyB2YWx1ZSBpcyBjaGFuZ2VkIHdoaWxlIHRoZSBmaWVsZCBpcyBmb2N1c2VkLCBhbmQgYWxzbyBj aGVja3MgdGhhdAorICAgICAgICB0aGUgbWV0aG9kIGlzIG5vdCBjYWxsZWQgaWYgdGhlIGZpZWxk IGlzIG5vdCBmb2N1c2VkLgorCisgICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0NsaWVudDo6ZGlkQ2hhbmdlRm9jdXNlZEZvcm1Ob2RlU3Rh dGUpOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9ybVN0YXRlRGlkQ2hhbmdlKToKKyAgICAgICAgKiB0ZXN0 cy9XZWJWaWV3VGVzdC5jcHA6CisgICAgICAgIChGb2N1c2VkRm9ybU5vZGVDaGFuZ2VXZWJWaWV3 Q2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6Rm9jdXNlZEZvcm1Ob2RlQ2hhbmdlV2ViVmlld0Ns aWVudDo6ZGlkQ2hhbmdlRm9jdXNlZEZvcm1Ob2RlU3RhdGUpOgorICAgICAgICAoV2ViS2l0OjpG b2N1c2VkRm9ybU5vZGVDaGFuZ2VXZWJWaWV3Q2xpZW50OjpyZXNldCk6CisgICAgICAgIChXZWJL aXQ6OkZvY3VzZWRGb3JtTm9kZUNoYW5nZVdlYlZpZXdDbGllbnQ6Ondhc0NoYW5nZUNhbGxlZCk6 CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorCiAyMDEyLTA3 LTA0ICBJYW4gVm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJv bWl1bV0gQ29ycmVjdGx5IHJlamVjdCBhY2NlbGVyYXRlZCBhbmltYXRpb25zIHdpdGggY2VydGFp biByb3RhdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xp ZW50LmgKaW5kZXggNjM5M2EwNzQxY2YwZDMzNDNkNGU5MjI5NjNhNzEyNGI3ZWUzYjg0Mi4uN2Rh MDM3YmQzZDkwNGM5NzQ1Njk1ZGUyNmRjYWY4MTA2OGJiMjg0MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMTg3LDYgKzE4Nyw3IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlQ29udGVudHMoKSB7IH0KICAgICB2aXJ0 dWFsIHZvaWQgZGlkRXhlY3V0ZUNvbW1hbmQoY29uc3QgV2ViU3RyaW5nJiBjb21tYW5kTmFtZSkg eyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZEVuZEVkaXRpbmcoKSB7IH0KKyAgICB2aXJ0dWFsIHZv aWQgZGlkQ2hhbmdlRm9jdXNlZEZvcm1Ob2RlU3RhdGUoKSB7IH0KIAogICAgIC8vIFRoaXMgbWV0 aG9kIGlzIGNhbGxlZCBpbiByZXNwb25zZSB0byBXZWJWaWV3J3MgaGFuZGxlSW5wdXRFdmVudCgp CiAgICAgLy8gd2hlbiB0aGUgZGVmYXVsdCBhY3Rpb24gZm9yIHRoZSBjdXJyZW50IGtleWJvYXJk IGV2ZW50IGlzIG5vdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hy b21lQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGll bnRJbXBsLmNwcAppbmRleCA2MDMxNGQyZTMyNGI0ODVhNTU5MDQ5MzM1OGVlMTk5N2E0ZTQ4ZGRl Li4yMjhjZTU5MGZkOTE0MDNjYTdhZGY0YjdmMjEwOTQ2M2RjZTdhOTFlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtODQxLDYgKzg0 MSw5IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0TmV3V2luZG93TmF2aWdhdGlvblBvbGlj eShXZWJOYXZpZ2F0aW9uUG9saWN5IHBvbGljeSkKIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpm b3JtU3RhdGVEaWRDaGFuZ2UoY29uc3QgTm9kZSogbm9kZSkKIHsKKyAgICBpZiAobm9kZS0+Zm9j dXNlZCgpICYmIG1fd2ViVmlldy0+Y2xpZW50KCkpCisgICAgICAgIG1fd2ViVmlldy0+Y2xpZW50 KCktPmRpZENoYW5nZUZvY3VzZWRGb3JtTm9kZVN0YXRlKCk7CisKICAgICAvLyBUaGUgY3VycmVu dCBoaXN0b3J5IGl0ZW0gaXMgbm90IHVwZGF0ZWQgeWV0LiAgVGhhdCBoYXBwZW5zIGxhemlseSB3 aGVuCiAgICAgLy8gV2ViRnJhbWU6OmN1cnJlbnRIaXN0b3J5SXRlbSBpcyByZXF1ZXN0ZWQuCiAg ICAgV2ViRnJhbWVJbXBsKiB3ZWJmcmFtZSA9IFdlYkZyYW1lSW1wbDo6ZnJvbUZyYW1lKG5vZGUt PmRvY3VtZW50KCktPmZyYW1lKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9XZWJWaWV3VGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dl YlZpZXdUZXN0LmNwcAppbmRleCA4ZWNjZjJjNGE2OWIyNWM1YjFmMTNhYWI4ZjhlMDNmMDRjM2Iw Njk5Li4zMWFjN2UyMDZjM2JjNmNiMDNlMWQ5MzM0MDJjYmRhMWNkNmIyZTY0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlZpZXdUZXN0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlZpZXdUZXN0LmNwcApAQCAtOTIsNiArOTIsMTkg QEAgcHJpdmF0ZToKICAgICBUZXN0RGF0YSBtX3Rlc3REYXRhOwogfTsKIAorY2xhc3MgRm9jdXNl ZEZvcm1Ob2RlQ2hhbmdlV2ViVmlld0NsaWVudCA6IHB1YmxpYyBXZWJWaWV3Q2xpZW50IHsKK3B1 YmxpYzoKKyAgICAvLyBXZWJWaWV3Q2xpZW50IG1ldGhvZHMKKyAgICB2aXJ0dWFsIHZvaWQgZGlk Q2hhbmdlRm9jdXNlZEZvcm1Ob2RlU3RhdGUoKSB7IGNoYW5nZUNhbGxlZCA9IHRydWU7IH0KKwor ICAgIC8vIExvY2FsIG1ldGhvZHMKKyAgICB2b2lkIHJlc2V0KCkgeyBjaGFuZ2VDYWxsZWQgPSBm YWxzZTsgfQorICAgIGJvb2wgd2FzQ2hhbmdlQ2FsbGVkKCkgeyByZXR1cm4gY2hhbmdlQ2FsbGVk OyB9CisKK3ByaXZhdGU6CisgICAgYm9vbCBjaGFuZ2VDYWxsZWQ7Cit9OworCiBjbGFzcyBXZWJW aWV3VGVzdCA6IHB1YmxpYyB0ZXN0aW5nOjpUZXN0IHsKIHB1YmxpYzoKICAgICBXZWJWaWV3VGVz dCgpCkBAIC0zMzcsNCArMzUwLDE3IEBAIFRFU1RfRihXZWJWaWV3VGVzdCwgU2V0RWRpdGFibGVT ZWxlY3Rpb25PZmZzZXRzQW5kVGV4dElucHV0SW5mbykKICAgICB3ZWJWaWV3LT5jbG9zZSgpOwog fQogCitURVNUX0YoV2ViVmlld1Rlc3QsIEZvY3VzZWRGb3JtTm9kZUNoYW5nZSkKK3sKKyAgICBG b2N1c2VkRm9ybU5vZGVDaGFuZ2VXZWJWaWV3Q2xpZW50IGNsaWVudDsKKyAgICBjbGllbnQucmVz ZXQoKTsKKyAgICBGcmFtZVRlc3RIZWxwZXJzOjpyZWdpc3Rlck1vY2tlZFVSTExvYWQobV9iYXNl VVJMLCAiaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxlX2ZvY3VzZWQuaHRtbCIpOworICAgIFdl YlZpZXcqIHdlYlZpZXcgPSBGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZCht X2Jhc2VVUkwgKyAiaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxlX2ZvY3VzZWQuaHRtbCIsIHRy dWUsIDAsICZjbGllbnQpOworICAgIEVYUEVDVF9UUlVFKGNsaWVudC53YXNDaGFuZ2VDYWxsZWQo KSk7CisgICAgY2xpZW50LnJlc2V0KCk7CisgICAgRnJhbWVUZXN0SGVscGVyczo6cmVnaXN0ZXJN b2NrZWRVUkxMb2FkKG1fYmFzZVVSTCwgImlucHV0X2ZpZWxkX3NldF92YWx1ZV93aGlsZV9ub3Rf Zm9jdXNlZC5odG1sIik7CisgICAgd2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdl YlZpZXdBbmRMb2FkKG1fYmFzZVVSTCArICJpbnB1dF9maWVsZF9zZXRfdmFsdWVfd2hpbGVfbm90 X2ZvY3VzZWQuaHRtbCIsIHRydWUsIDAsICZjbGllbnQpOworICAgIEVYUEVDVF9GQUxTRShjbGll bnQud2FzQ2hhbmdlQ2FsbGVkKCkpOworfQorCiB9Cg== 150935 2012-07-05 06:42:21 -0700 2012-07-05 07:24:02 -0700 Patch bug-90563-20120705144220.patch text/plain 7753 olilan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZkYjUxMDIzMTJkODg1NGEwNDI1YmRiZmIyODEwODFjYjZiY2NjNDEuLjVkMWM3YjE0ZDZhODlj NzA4ODkzZTYyMjkyZDJmODY1NDRiOGE4MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsNDAgQEAKKzIwMTItMDctMDUgIE9saSBMYW4gIDxvbGlsYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGEgbWV0aG9kIGRpZENoYW5nZUZvcm1TdGF0ZSB0 byBXZWJWaWV3Q2xpZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTA1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBuZXcgbWV0aG9kIGRpZENoYW5nZUZvcm1TdGF0ZSB0 byBXZWJWaWV3Q2xpZW50LAorICAgICAgICBhbmQgY2FsbHMgaXQgZnJvbSBDaHJvbWVDbGllbnRJ bXBsOjpmb3JtU3RhdGVEaWRDaGFuZ2Ugd2l0aCB0aGUgY2hhbmdlZCBub2RlLgorCisgICAgICAg IFRoaXMgbmV3IG1ldGhvZCBjYW4gYmUgdXNlZCBmb3IgZXhhbXBsZSBieSB0aGUgQW5kcm9pZCBw b3J0IHRvIHVwZGF0ZSB0aGUgYnJvd3NlcidzCisgICAgICAgIElNRSB3aGVuIHRoZSBzdGF0ZSBv ZiB0aGUgY3VycmVudGx5IGZvY3VzZWQgdGV4dCBub2RlIGhhcyBjaGFuZ2VkLiBUbyBmYWNpbGl0 YXRlIHRoaXMKKyAgICAgICAgdXNhZ2UsIGEgZm9jdXNlZCgpIG1ldGhvZCBoYXMgYmVlbiBhZGRl ZCB0byBXZWJOb2RlLgorCisgICAgICAgIEEgbmV3IHRlc3QgaGFzIGJlZW4gYWRkZWQgdG8gV2Vi Vmlld1Rlc3QuIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBkaWRDaGFuZ2VGb3JtU3RhdGUKKyAgICAg ICAgaXMgY2FsbGVkIHdoZW4gYW4gaW5wdXQncyB2YWx1ZSBpcyBjaGFuZ2VkLCBhbmQgYWxzbyBj aGVja3MgdGhhdCBXZWJOb2RlOjpmb2N1c2VkKCkgcmV0dXJucworICAgICAgICB0aGUgY29ycmVj dCB2YWx1ZSBmb3IgdGhlIHByb3ZpZGVkIG5vZGUsIGluIGJvdGggdGhlIGZvY3VzZWQgYW5kIG5v bi1mb2N1c2VkIGNhc2VzLgorCisgICAgICAgICogcHVibGljL1dlYk5vZGUuaDoKKyAgICAgICAg KiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Q2xpZW50 OjpkaWRDaGFuZ2VGb3JtU3RhdGUpOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9ybVN0YXRlRGlkQ2hhbmdl KToKKyAgICAgICAgKiBzcmMvV2ViTm9kZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYk5vZGU6 OmZvY3VzZWQpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiB0ZXN0cy9XZWJWaWV3VGVz dC5jcHA6CisgICAgICAgIChGb3JtQ2hhbmdlV2ViVmlld0NsaWVudCk6CisgICAgICAgIChXZWJL aXQ6OkZvcm1DaGFuZ2VXZWJWaWV3Q2xpZW50OjpkaWRDaGFuZ2VGb3JtU3RhdGUpOgorICAgICAg ICAoV2ViS2l0OjpGb3JtQ2hhbmdlV2ViVmlld0NsaWVudDo6cmVzZXQpOgorICAgICAgICAoV2Vi S2l0OjpGb3JtQ2hhbmdlV2ViVmlld0NsaWVudDo6Y2FsbGVkKToKKyAgICAgICAgKFdlYktpdDo6 Rm9ybUNoYW5nZVdlYlZpZXdDbGllbnQ6OmZvY3VzZWQpOgorICAgICAgICAoV2ViS2l0KToKKyAg ICAgICAgKFdlYktpdDo6VEVTVF9GKToKKyAgICAgICAgKiB0ZXN0cy9kYXRhL2lucHV0X2ZpZWxk X3NldF92YWx1ZV93aGlsZV9mb2N1c2VkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHRlc3RzL2Rh dGEvaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxlX25vdF9mb2N1c2VkLmh0bWw6IEFkZGVkLgor CiAyMDEyLTA3LTA0ICBJYW4gVm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gQ29ycmVjdGx5IHJlamVjdCBhY2NlbGVyYXRlZCBhbmltYXRpb25zIHdp dGggY2VydGFpbiByb3RhdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJOb2RlLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJOb2Rl LmgKaW5kZXggZDRlZTg3NGU5ZDZiMmU4MzljYjQyOWJkMjZhNDg3ZjZlZGVjNTY2MC4uNTI4MWRi MTk5NGFjMmQzOGNiYTRlMDA3NjNmNzcxYWJiNTQ3NTUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYk5vZGUuaApAQCAtMTExLDYgKzExMSw3IEBAIHB1YmxpYzoKICAgICBXRUJL SVRfRVhQT1JUIHZvaWQgc2ltdWxhdGVDbGljaygpOwogICAgIFdFQktJVF9FWFBPUlQgV2ViTm9k ZUxpc3QgZ2V0RWxlbWVudHNCeVRhZ05hbWUoY29uc3QgV2ViU3RyaW5nJikgY29uc3Q7CiAgICAg V0VCS0lUX0VYUE9SVCBXZWJFbGVtZW50IHJvb3RFZGl0YWJsZUVsZW1lbnQoKSBjb25zdDsKKyAg ICBXRUJLSVRfRVhQT1JUIGJvb2wgZm9jdXNlZCgpIGNvbnN0OwogCiAgICAgLy8gUmV0dXJucyB0 cnVlIGlmIHRoZSBub2RlIGhhcyBhIG5vbi1lbXB0eSBib3VuZGluZyBib3ggaW4gbGF5b3V0Lgog ICAgIC8vIFRoaXMgZG9lcyBub3QgMTAwJSBndWFyYW50ZWUgdGhlIHVzZXIgY2FuIHNlZSBpdCwg YnV0IGlzIHByZXR0eSBjbG9zZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlZpZXdDbGllbnQuaAppbmRleCA2MzkzYTA3NDFjZjBkMzM0M2Q0ZTkyMjk2M2E3MTI0YjdlZTNi ODQyLi42NjI0MDlmN2FmY2IyYzQ4NDM1OGY3MzQ2NWM2M2Q4YWZiMjMxYTQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC0xODcsNiArMTg3 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VDb250ZW50cygpIHsgfQog ICAgIHZpcnR1YWwgdm9pZCBkaWRFeGVjdXRlQ29tbWFuZChjb25zdCBXZWJTdHJpbmcmIGNvbW1h bmROYW1lKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlkRW5kRWRpdGluZygpIHsgfQorICAgIHZp cnR1YWwgdm9pZCBkaWRDaGFuZ2VGb3JtU3RhdGUoY29uc3QgV2ViTm9kZSYpIHsgfQogCiAgICAg Ly8gVGhpcyBtZXRob2QgaXMgY2FsbGVkIGluIHJlc3BvbnNlIHRvIFdlYlZpZXcncyBoYW5kbGVJ bnB1dEV2ZW50KCkKICAgICAvLyB3aGVuIHRoZSBkZWZhdWx0IGFjdGlvbiBmb3IgdGhlIGN1cnJl bnQga2V5Ym9hcmQgZXZlbnQgaXMgbm90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IDYwMzE0ZDJlMzI0YjQ4NWE1NTkwNDkzMzU4ZWUx OTk3YTRlNDhkZGUuLjM0OTczMzkxOTRjZjA0NGM1NTEzMDNkNTA2OTQzZjdlMjA2YzRlMzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCkBA IC04NDEsNiArODQxLDkgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzZXROZXdXaW5kb3dOYXZp Z2F0aW9uUG9saWN5KFdlYk5hdmlnYXRpb25Qb2xpY3kgcG9saWN5KQogCiB2b2lkIENocm9tZUNs aWVudEltcGw6OmZvcm1TdGF0ZURpZENoYW5nZShjb25zdCBOb2RlKiBub2RlKQogeworICAgIGlm IChtX3dlYlZpZXctPmNsaWVudCgpKQorICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5kaWRD aGFuZ2VGb3JtU3RhdGUoV2ViTm9kZShjb25zdF9jYXN0PE5vZGUqPihub2RlKSkpOworCiAgICAg Ly8gVGhlIGN1cnJlbnQgaGlzdG9yeSBpdGVtIGlzIG5vdCB1cGRhdGVkIHlldC4gIFRoYXQgaGFw cGVucyBsYXppbHkgd2hlbgogICAgIC8vIFdlYkZyYW1lOjpjdXJyZW50SGlzdG9yeUl0ZW0gaXMg cmVxdWVzdGVkLgogICAgIFdlYkZyYW1lSW1wbCogd2ViZnJhbWUgPSBXZWJGcmFtZUltcGw6OmZy b21GcmFtZShub2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYk5vZGUuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViTm9kZS5jcHAKaW5kZXggNDlkY2RkOThlY2M5MWZkODBkMjNhYWY5ZmEyNjFjOGRiZGY4 ZWQ1ZS4uMTRkYTFkNTcwMzc4YmM2MDg0NTY2YzhjZDYxNGMwYjgyZWZjMDdhNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTm9kZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViTm9kZS5jcHAKQEAgLTIxMyw2ICsyMTMsMTEgQEAgV2ViRWxl bWVudCBXZWJOb2RlOjpyb290RWRpdGFibGVFbGVtZW50KCkgY29uc3QKICAgICByZXR1cm4gV2Vi RWxlbWVudChtX3ByaXZhdGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKSk7CiB9CiAKK2Jvb2wgV2Vi Tm9kZTo6Zm9jdXNlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+Zm9jdXNlZCgp OworfQorCiBib29sIFdlYk5vZGU6Omhhc05vbkVtcHR5Qm91bmRpbmdCb3goKSBjb25zdAogewog ICAgIG1fcHJpdmF0ZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxl c2hlZXRzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlZp ZXdUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3Bw CmluZGV4IDhlY2NmMmM0YTY5YjI1YzViMWYxM2FhYjhmOGUwM2YwNGMzYjA2OTkuLjc5MDM3MjFk OTc2YjRhMzBmZjliYTYxZTZmOWU1NTk4ZGE4ZTZhZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCkBAIC05Miw2ICs5MiwyOSBAQCBwcml2YXRlOgog ICAgIFRlc3REYXRhIG1fdGVzdERhdGE7CiB9OwogCitjbGFzcyBGb3JtQ2hhbmdlV2ViVmlld0Ns aWVudCA6IHB1YmxpYyBXZWJWaWV3Q2xpZW50IHsKK3B1YmxpYzoKKyAgICAvLyBXZWJWaWV3Q2xp ZW50IG1ldGhvZHMKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlRm9ybVN0YXRlKGNvbnN0IFdl Yk5vZGUmIG5vZGUpCisgICAgeworICAgICAgICBtX2ZvY3VzZWQgPSBub2RlLmZvY3VzZWQoKTsK KyAgICAgICAgbV9jYWxsZWQgPSB0cnVlOworICAgIH0KKworICAgIC8vIExvY2FsIG1ldGhvZHMK KyAgICB2b2lkIHJlc2V0KCkKKyAgICB7CisgICAgICAgIG1fY2FsbGVkID0gZmFsc2U7CisgICAg ICAgIG1fZm9jdXNlZCA9IGZhbHNlOworICAgIH0KKyAgICBib29sIGNhbGxlZCgpIHsgcmV0dXJu IG1fY2FsbGVkOyB9CisgICAgYm9vbCBmb2N1c2VkKCkgeyByZXR1cm4gbV9mb2N1c2VkOyB9CisK K3ByaXZhdGU6CisgICAgYm9vbCBtX2NhbGxlZDsKKyAgICBib29sIG1fZm9jdXNlZDsKK307CisK IGNsYXNzIFdlYlZpZXdUZXN0IDogcHVibGljIHRlc3Rpbmc6OlRlc3QgewogcHVibGljOgogICAg IFdlYlZpZXdUZXN0KCkKQEAgLTMzNyw0ICszNjAsMjAgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBT ZXRFZGl0YWJsZVNlbGVjdGlvbk9mZnNldHNBbmRUZXh0SW5wdXRJbmZvKQogICAgIHdlYlZpZXct PmNsb3NlKCk7CiB9CiAKK1RFU1RfRihXZWJWaWV3VGVzdCwgRm9ybUNoYW5nZSkKK3sKKyAgICBG b3JtQ2hhbmdlV2ViVmlld0NsaWVudCBjbGllbnQ7CisgICAgY2xpZW50LnJlc2V0KCk7CisgICAg RnJhbWVUZXN0SGVscGVyczo6cmVnaXN0ZXJNb2NrZWRVUkxMb2FkKG1fYmFzZVVSTCwgImlucHV0 X2ZpZWxkX3NldF92YWx1ZV93aGlsZV9mb2N1c2VkLmh0bWwiKTsKKyAgICBXZWJWaWV3KiB3ZWJW aWV3ID0gRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0FuZExvYWQobV9iYXNlVVJMICsg ImlucHV0X2ZpZWxkX3NldF92YWx1ZV93aGlsZV9mb2N1c2VkLmh0bWwiLCB0cnVlLCAwLCAmY2xp ZW50KTsKKyAgICBFWFBFQ1RfVFJVRShjbGllbnQuY2FsbGVkKCkpOworICAgIEVYUEVDVF9UUlVF KGNsaWVudC5mb2N1c2VkKCkpOworICAgIGNsaWVudC5yZXNldCgpOworICAgIEZyYW1lVGVzdEhl bHBlcnM6OnJlZ2lzdGVyTW9ja2VkVVJMTG9hZChtX2Jhc2VVUkwsICJpbnB1dF9maWVsZF9zZXRf dmFsdWVfd2hpbGVfbm90X2ZvY3VzZWQuaHRtbCIpOworICAgIHdlYlZpZXcgPSBGcmFtZVRlc3RI ZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZChtX2Jhc2VVUkwgKyAiaW5wdXRfZmllbGRfc2V0 X3ZhbHVlX3doaWxlX25vdF9mb2N1c2VkLmh0bWwiLCB0cnVlLCAwLCAmY2xpZW50KTsKKyAgICBF WFBFQ1RfVFJVRShjbGllbnQuY2FsbGVkKCkpOworICAgIEVYUEVDVF9GQUxTRShjbGllbnQuZm9j dXNlZCgpKTsKKyAgICB3ZWJWaWV3LT5jbG9zZSgpOworfQorCiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxl X2ZvY3VzZWQuaHRtbCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvZGF0YS9pbnB1dF9m aWVsZF9zZXRfdmFsdWVfd2hpbGVfZm9jdXNlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU2YzczZWFjYTU1 M2E4NzAwNDdjOWIyZTgzMmEwOWJlODE0ZmRiNDUKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxlX2Zv Y3VzZWQuaHRtbApAQCAtMCwwICsxLDYgQEAKKzxpbnB1dCBpZD0nZmllbGQnLz4KKzxzY3JpcHQ+ CisgIHZhciBmaWVsZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmaWVsZCcpOworICBmaWVs ZC5mb2N1cygpOworICBmaWVsZC52YWx1ZSA9ICdzb21lIHRleHQnOworPC9zY3JpcHQ+CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvaW5wdXRfZmllbGRfc2V0 X3ZhbHVlX3doaWxlX25vdF9mb2N1c2VkLmh0bWwgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL2RhdGEvaW5wdXRfZmllbGRfc2V0X3ZhbHVlX3doaWxlX25vdF9mb2N1c2VkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNGU1NzhkNDRkOTFhMGVhYTZiMWMyNTA1OTM1NjE3Y2U0NTkwNTVkNQotLS0gL2Rl di9udWxsCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvZGF0YS9pbnB1dF9maWVs ZF9zZXRfdmFsdWVfd2hpbGVfbm90X2ZvY3VzZWQuaHRtbApAQCAtMCwwICsxLDUgQEAKKzxpbnB1 dCBpZD0nZmllbGQnLz4KKzxzY3JpcHQ+CisgIHZhciBmaWVsZCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdmaWVsZCcpOworICBmaWVsZC52YWx1ZSA9ICdzb21lIHRleHQnOworPC9zY3JpcHQ+ Cg==