<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90562</bug_id>
          
          <creation_ts>2012-07-04 09:05:58 -0700</creation_ts>
          <short_desc>[Qt] ShadowBlur does not use GraphicsContext internal brush properties</short_desc>
          <delta_ts>2014-02-03 03:21:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>90082</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Bruno Abinader (history only)">bruno.abinader</reporter>
          <assigned_to name="Bruno Abinader (history only)">bruno.abinader</assigned_to>
          <cc>allan.jensen</cc>
    
    <cc>igor.oliveira</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>663003</commentid>
    <comment_count>0</comment_count>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2012-07-04 09:05:58 -0700</bug_when>
    <thetext>Currently GraphicsContext::fillRect(const FloatRect&amp; rect) implementation uses ShadowBlur&apos;s beginShadowLayer/endShadowLayer functions to handle shadow drawing. These can get optimized by using drawRectShadow, however it seems that ShadowBlur&apos;s implementation is not taking in consideration Qt&apos;s current brush properties. This bug intends to implement full support of drawRectShadow() usage on fillRect function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>851783</commentid>
    <comment_count>1</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-09 05:53:34 -0800</bug_when>
    <thetext>ShadowBlur will in drawShadowBuffer() set a new fillcolor which completely replaces the current brush with a new solid brush of that color. If part of the current brush properties are supposed to be preserved, maybe our implementation of setPlatformFillColor is reseting too much?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852177</commentid>
    <comment_count>2</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-11 04:05:16 -0700</bug_when>
    <thetext>I noticed this comment in GraphicsContextCG:  // Don&apos;t use ShadowBlur for canvas yet.

So perhaps tiled ShadowBlur is not yet ready for shadowsIgnoreTransforms, disabling it for canvas solves the regressions from bug #90082</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>975499</commentid>
    <comment_count>3</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2014-02-03 03:21:35 -0800</bug_when>
    <thetext>=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>