90559 2012-07-04 08:43:18 -0700 Hidden dirs are not copied when creating the built product archive 2012-07-05 00:24:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90569 1 svillar svillar cgarcia ossy pnormand svillar webkit.review.bot oldest_to_newest 662991 0 svillar 2012-07-04 08:43:18 -0700 Hidden dirs are not copied when creating the built product archive 662992 1 150806 svillar 2012-07-04 08:45:57 -0700 Created attachment 150806 Patch 662993 2 svillar 2012-07-04 08:48:25 -0700 The asterisk ("*") was added as part of another change, I think it had nothing to do with it, and was probably added thinking that it wouldn't hurt. Ossy? 663007 3 svillar 2012-07-04 09:11:39 -0700 I have just checked that neither Qt nor EFL had hidden dirs under bin/ and lib/ (the directories they archive) so this will be harmless for them. 663029 4 150806 cgarcia 2012-07-04 09:34:16 -0700 Comment on attachment 150806 Patch Ok, if it doesn't affect the other ports, the change looks good to me. Thanks! 663036 5 150806 svillar 2012-07-04 09:43:14 -0700 Comment on attachment 150806 Patch Clearing flags on attachment: 150806 Committed r121862: <http://trac.webkit.org/changeset/121862> 663037 6 svillar 2012-07-04 09:43:21 -0700 All reviewed patches have been landed. Closing bug. 663057 7 webkit.review.bot 2012-07-04 10:42:06 -0700 Re-opened since this is blocked by 90569 663065 8 150822 svillar 2012-07-04 10:54:34 -0700 Created attachment 150822 Patch 663067 9 svillar 2012-07-04 10:56:09 -0700 If we want to keep the explicit target directory creation then we have to replace the "*" by a "." to include hidden dirs. 663073 10 150822 pnormand 2012-07-04 11:11:14 -0700 Comment on attachment 150822 Patch Hum, this patch should be based on trunk I think. Right now it doesn't seem to take the rollout in account. 663353 11 svillar 2012-07-05 00:04:34 -0700 (In reply to comment #10) > (From update of attachment 150822 [details]) > Hum, this patch should be based on trunk I think. Right now it doesn't seem to take the rollout in account. Yes it does, the original line contained an "*", then the invalid patch removed it. Now I'm replacing the "*" with a ".", so it means that I'm taking into account the rollout. 663356 12 150822 cgarcia 2012-07-05 00:07:23 -0700 Comment on attachment 150822 Patch Ok, let's try again then. 663365 13 svillar 2012-07-05 00:24:40 -0700 Committed r121886: <http://trac.webkit.org/changeset/121886> 150806 2012-07-04 08:45:57 -0700 2012-07-04 10:54:29 -0700 Patch bug-90559-20120704174555.patch text/plain 1831 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTIwMjM4MjM2MDVlN2VhMTg5ZmZiNzRkMmUzNTg4MzI3 OTMyMjVkYy4uMzQyNjg2MjIwOGI3ZWFlMDY3MzljOWY5YmYxMDUwNDFhZDA0MDhjYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDEyLTA3LTA0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgogCisgICAgICAgIEhpZGRlbiBkaXJzIGFyZSBub3QgY29waWVkIHdoZW4gY3JlYXRpbmcgdGhl IGJ1aWx0IHByb2R1Y3QgYXJjaGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTA1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBIaWRkZW4gZGlycyBhcmUgbm90IGNvcGllZCBpbnNpZGUgdGhlIGJ1aWx0 IHByb2R1Y3QgYXJjaGl2ZSBiZWNhdXNlCisgICAgICAgIHRoZSByZWN1cnNpdmUgY29weSBjb21t YW5kIHdhcyBpZ25vcmluZyB0aGVtLiBXZSBuZWVkIHRob3NlIGhpZGRlbgorICAgICAgICBkaXJl Y3RvcmllcyBmb3IgdGhlIEdUSyBXZWJLaXQyIHRlc3RpbmcgYm90IHRvIHdvcmsgZmluZS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToKKyAgICAg ICAgKGFyY2hpdmVCdWlsdFByb2R1Y3QpOiByZW1vdmVkIHRoZSB0cmFpbGluZyAiKiIgZnJvbSB0 aGUgY29weQorICAgICAgICBjb21tYW5kLgorCisyMDEyLTA3LTA0ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtXSzJdIFtHVEtdIFdLMiB0ZXN0 aW5nIGJvdCB1bmFibGUgdG8gZmluZCB0aGUgSW5qZWN0ZWRCdW5kbGUgbGlicmFyeQogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1NDEKIApkaWZmIC0t Z2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCmluZGV4IGQ1ZDdlZDQ5 MDA1ZWI1ZTMwYWY2MmY2YjNhYjJhYzQwM2JiYjY1OGEuLjlmOWU2YTVmNzRmMTE3M2M2Y2IyZmUz NzM5ZDQ4ZjhkN2EzMGIzMjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWx0LXByb2R1Y3QtYXJjaGl2ZQorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1w cm9kdWN0LWFyY2hpdmUKQEAgLTE0Nyw3ICsxNDcsNyBAQCBkZWYgYXJjaGl2ZUJ1aWx0UHJvZHVj dChjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSk6CiAgICAgICAgICAgICBuZWVkZWREaXJlY3Rvcmll cyA9IFsiUHJvZ3JhbXMiLCAiLmxpYnMiLCAiTGlicmFyaWVzIl0KIAogICAgICAgICBmb3IgZGly bmFtZSBpbiBuZWVkZWREaXJlY3RvcmllczoKLSAgICAgICAgICAgIGZyb21EaXIgPSBvcy5wYXRo LmpvaW4oY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCBkaXJuYW1lLCAiKiIpCisgICAgICAg ICAgICBmcm9tRGlyID0gb3MucGF0aC5qb2luKGNvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeSwg ZGlybmFtZSkKICAgICAgICAgICAgIHRvRGlyID0gb3MucGF0aC5qb2luKHRoaW5EaXJlY3Rvcnks IGRpcm5hbWUpCiAgICAgICAgICAgICBvcy5tYWtlZGlycyh0b0RpcikKICAgICAgICAgICAgIGlm IHN1YnByb2Nlc3MuY2FsbCgnY3AgLVIgJXMgJXMnICUgKGZyb21EaXIsIHRvRGlyKSwgc2hlbGw9 VHJ1ZSk6Cg== 150822 2012-07-04 10:54:34 -0700 2012-07-05 00:07:23 -0700 Patch bug-90559-20120704195432.patch text/plain 1745 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDFmMDY4Yzc1MTE2YWE2Yjg3ZGY1MGU2ODBlM2Q3MzIz ZTI0YjNmNC4uYjM5MzczYzA2YjQ5MjNmOGU4ZDVjYjE2ZDUxZjI5Mzk4NjY0Y2E5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA3LTA0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgorCisgICAgICAgIEhpZGRlbiBkaXJzIGFyZSBub3QgY29waWVkIHdoZW4gY3JlYXRpbmcgdGhl IGJ1aWx0IHByb2R1Y3QgYXJjaGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTA1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBIaWRkZW4gZGlycyBhcmUgbm90IGNvcGllZCBpbnNpZGUgdGhlIGJ1aWx0 IHByb2R1Y3QgYXJjaGl2ZQorICAgICAgICBiZWNhdXNlIHRoZSByZWN1cnNpdmUgY29weSBjb21t YW5kIHdhcyBpZ25vcmluZyB0aGVtLiBXZSBuZWVkIHRob3NlCisgICAgICAgIGhpZGRlbiBkaXJl Y3RvcmllcyBmb3IgdGhlIEdUSyBXZWJLaXQyIHRlc3RpbmcgYm90IHRvIHdvcmsgZmluZS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToKKyAgICAg ICAgKGFyY2hpdmVCdWlsdFByb2R1Y3QpOiByZXBsYWNlZCAiKiIgYnkgIi4iIHRvIGluY2x1ZGUg aGlkZGVuCisgICAgICAgIGRpcnMvZmlsZXMuCisKIDIwMTItMDctMDQgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMjE4NjIuCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls dC1wcm9kdWN0LWFyY2hpdmUgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0 LWFyY2hpdmUKaW5kZXggZDVkN2VkNDkwMDVlYjVlMzBhZjYyZjZiM2FiMmFjNDAzYmJiNjU4YS4u YWU2N2UyMWI3ODk5ZjYxN2YzOGI5NWI2ZmFhOWJiOGVmNDYwMmQ2NSAxMDA2NDQKLS0tIGEvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCisrKyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQpAQCAtMTQ3LDcgKzE0Nyw3IEBA IGRlZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKToKICAgICAg ICAgICAgIG5lZWRlZERpcmVjdG9yaWVzID0gWyJQcm9ncmFtcyIsICIubGlicyIsICJMaWJyYXJp ZXMiXQogCiAgICAgICAgIGZvciBkaXJuYW1lIGluIG5lZWRlZERpcmVjdG9yaWVzOgotICAgICAg ICAgICAgZnJvbURpciA9IG9zLnBhdGguam9pbihjb25maWd1cmF0aW9uQnVpbGREaXJlY3Rvcnks IGRpcm5hbWUsICIqIikKKyAgICAgICAgICAgIGZyb21EaXIgPSBvcy5wYXRoLmpvaW4oY29uZmln dXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCBkaXJuYW1lLCAiLiIpCiAgICAgICAgICAgICB0b0RpciA9 IG9zLnBhdGguam9pbih0aGluRGlyZWN0b3J5LCBkaXJuYW1lKQogICAgICAgICAgICAgb3MubWFr ZWRpcnModG9EaXIpCiAgICAgICAgICAgICBpZiBzdWJwcm9jZXNzLmNhbGwoJ2NwIC1SICVzICVz JyAlIChmcm9tRGlyLCB0b0RpciksIHNoZWxsPVRydWUpOgo=