<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90558</bug_id>
          
          <creation_ts>2012-07-04 08:36:27 -0700</creation_ts>
          <short_desc>[CMake] Fix some CMake warnings</short_desc>
          <delta_ts>2012-07-05 11:13:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rwlbuis</reporter>
          <assigned_to name="Rob Buis">rwlbuis</assigned_to>
          <cc>dbates</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>662985</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-04 08:36:27 -0700</bug_when>
    <thetext>CMake 2.8.5 reports warnings like this:

Manually-specified variables were not used by the project:

    ENABLE_LINK_PRERENDER</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>662988</commentid>
    <comment_count>1</comment_count>
      <attachid>150805</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-04 08:41:10 -0700</bug_when>
    <thetext>Created attachment 150805
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663162</commentid>
    <comment_count>2</comment_count>
      <attachid>150805</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-07-04 14:18:23 -0700</bug_when>
    <thetext>Comment on attachment 150805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150805&amp;action=review

&gt; ChangeLog:3
&gt; +        [BlackBerry] Fix some CMake warnings

Shouldn&apos;t this rather have [CMake] instead of [BlackBerry] in the title? Other ports which use CMake have the same warnings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663163</commentid>
    <comment_count>3</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-04 14:20:41 -0700</bug_when>
    <thetext>Hi Raphael,

(In reply to comment #2)
&gt; (From update of attachment 150805 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=150805&amp;action=review
&gt; 
&gt; &gt; ChangeLog:3
&gt; &gt; +        [BlackBerry] Fix some CMake warnings
&gt; 
&gt; Shouldn&apos;t this rather have [CMake] instead of [BlackBerry] in the title? Other ports which use CMake have the same warnings.

Yes, you are right, sorry! Do you feel like reviewing?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663170</commentid>
    <comment_count>4</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-07-04 14:37:45 -0700</bug_when>
    <thetext>Looks fine to me(In reply to comment #3)
&gt; Do you feel like reviewing?

You probably also need to add the new flags to Source/cmakeconfig.h.cmake. I don&apos;t have reviewer superpowers, though :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663176</commentid>
    <comment_count>5</comment_count>
      <attachid>150845</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-04 14:51:12 -0700</bug_when>
    <thetext>Created attachment 150845
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663177</commentid>
    <comment_count>6</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-04 14:52:18 -0700</bug_when>
    <thetext>Hi Raphael,

(In reply to comment #4)
&gt; Looks fine to me(In reply to comment #3)
&gt; &gt; Do you feel like reviewing?
&gt;
&gt; You probably also need to add the new flags to Source/cmakeconfig.h.cmake. I don&apos;t have reviewer superpowers, though :-(

Thanks! I am not complete sure if our port needs the cmakeconfig.h.cmake addtion, but I did update it in my latest patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663193</commentid>
    <comment_count>7</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-07-04 16:34:47 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; I am not complete sure if our port needs the cmakeconfig.h.cmake addtion, but I did update it in my latest patch.

It might not need it now due to the features being disabled by default, but all CMake-based ports use that for the ENABLE() and USE() macros to work, otherwise the macro definitions will never be set.

Shouldn&apos;t you set the WTF_* entries in cmakeconfig.h.cmake as well?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663550</commentid>
    <comment_count>8</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-05 07:39:50 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; I am not complete sure if our port needs the cmakeconfig.h.cmake addtion, but I did update it in my latest patch.
&gt; 
&gt; It might not need it now due to the features being disabled by default, but all CMake-based ports use that for the ENABLE() and USE() macros to work, otherwise the macro definitions will never be set.

Ok.

&gt; Shouldn&apos;t you set the WTF_* entries in cmakeconfig.h.cmake as well?

You are right, however I do not see our port using these two in the near future. If you think your port will, I can add them?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663563</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-07-05 08:04:16 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; &gt; Shouldn&apos;t you set the WTF_* entries in cmakeconfig.h.cmake as well?
&gt; 
&gt; You are right, however I do not see our port using these two in the near future. If you think your port will, I can add them?

Right now it&apos;s mostly to make the patch consistent (otherwise even though the CMake warnings are fixed the other half of adding something to WebKitFeatures.cmake will not have been done).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663570</commentid>
    <comment_count>10</comment_count>
      <attachid>150943</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-05 08:20:42 -0700</bug_when>
    <thetext>Created attachment 150943
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663625</commentid>
    <comment_count>11</comment_count>
      <attachid>150943</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2012-07-05 10:36:29 -0700</bug_when>
    <thetext>Comment on attachment 150943
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663657</commentid>
    <comment_count>12</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-07-05 11:13:25 -0700</bug_when>
    <thetext>Committed r121914: &lt;http://trac.webkit.org/changeset/121914&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>150805</attachid>
            <date>2012-07-04 08:41:10 -0700</date>
            <delta_ts>2012-07-04 14:51:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90558-20120704114247.patch</filename>
            <type>text/plain</type>
            <size>2253</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k
ZXggOWNkZDgzMjE5NDFjODk5YTQ0M2NlYWUwMDVjYjU2ODFmNjIwNDI1MS4uYjExNzAzNjljZGQz
ZWYyODkxODgyM2Y3MmMyNzI1NmZmMWIxZjZjYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl
YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr
ZQpAQCAtNjIsNiArNjIsNyBAQCBNQUNSTyAoV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJL
SVRfT1BUSU9OX0RFRklORShFTkFCTEVfTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OICJUb29nbGUg
bGVnYWN5IHZpZXdwb3J0IGFkYXB0aW9uIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo
RU5BQkxFX0xFR0FDWV9XRUJLSVRfQkxPQl9CVUlMREVSICJUb2dnbGUgTGVnYWN5IFdlYktpdCBC
bG9iIEJ1aWxkZXIgU3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJM
RV9MSU5LX1BSRUZFVENIICJUb2dnbGUgcHJlIGZldGNoaW5nIHN1cHBvcnQiIE9GRikKKyAgICBX
RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTElOS19QUkVSRU5ERVIgIlRvZ2dsZSBwcmUgcmVu
ZGVyaW5nIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTUFU
SE1MICJUb2dnbGUgTWF0aE1MIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F
KEVOQUJMRV9NRURJQV9TT1VSQ0UgIlRvZ2dsZSBNZWRpYSBTb3VyY2Ugc3VwcG9ydCIgT0ZGKQog
ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTICJUb2dnbGUg
TWVkaWEgU3RhdGlzdGljcyBzdXBwb3J0IiBPRkYpCkBAIC0xMDQsOCArMTA1LDggQEAgTUFDUk8g
KFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dP
UktFUlMgIlRvZ2dsZSBXZWIgV29ya2VycyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElP
Tl9ERUZJTkUoRU5BQkxFX1hTTFQgIlRvZ2dsZSBYU0xUIHN1cHBvcnQiIE9OKQogICAgIFdFQktJ
VF9PUFRJT05fREVGSU5FKFVTRV9TWVNURU1fTUFMTE9DICJUb2dnbGUgc3lzdGVtIGFsbG9jYXRv
ciBpbnN0ZWFkIG9mIFRDbWFsbG9jIiBPRkYpCi0gICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF
X1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRvZ2dsZSBUaWxlZCBCYWNraW5nIFN0b3JlIHN1cHBvcnQi
IE9GRikKLSAgICBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfV1RGVVJMICJUb29nbGUgdGhlIHVz
ZSBvZiBXVEZVUkwgZm9yIFVSTCBwYXJzaW5nIiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJ
TkUoV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFICJUb2dnbGUgVGlsZWQgQmFja2luZyBTdG9y
ZSBzdXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoV1RGX1VTRV9XVEZVUkwg
IlRvb2dsZSB0aGUgdXNlIG9mIFdURlVSTCBmb3IgVVJMIHBhcnNpbmciIE9GRikKIEVORE1BQ1JP
ICgpCiAKIE1BQ1JPIChXRUJLSVRfT1BUSU9OX0VORCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi
L0NoYW5nZUxvZwppbmRleCBhNjdiODdkM2ExYzU3NGY3M2QzOTA2OGUxMWMxNTg0NmZjYmY0YjM0
Li43YzVkNzliOGY1OTlmZTljMDc5MzkyMWIyNGMxYTRjZjUwYjU5MmVlIDEwMDY0NAotLS0gYS9D
aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDctMDQgIFJv
YiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRml4IHNvbWUg
Q01ha2Ugd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTkwNTU4CisKKyAgICAgICAgRml4IFdlYktpdCBvcHRpb25zIHNvIHRoZXkgbWF0Y2gg
d2l0aCBGZWF0dXJlTGlzdC5wbS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAx
Mi0wNy0wNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg
W0NNQUtFXSBBZGQgR0VORVJBVEVfQklORElOR1MgbWFjcm8gdG8gc2hhcmUgdGhlIGNvZGVzIHdo
aWNoIHVzZSBnZW5lcmF0ZS1iaW5kaW5ncy5wbC4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>150845</attachid>
            <date>2012-07-04 14:51:12 -0700</date>
            <delta_ts>2012-07-05 08:20:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90558-20120704175249.patch</filename>
            <type>text/plain</type>
            <size>2841</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k
ZXggOWNkZDgzMjE5NDFjODk5YTQ0M2NlYWUwMDVjYjU2ODFmNjIwNDI1MS4uYjExNzAzNjljZGQz
ZWYyODkxODgyM2Y3MmMyNzI1NmZmMWIxZjZjYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl
YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr
ZQpAQCAtNjIsNiArNjIsNyBAQCBNQUNSTyAoV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJL
SVRfT1BUSU9OX0RFRklORShFTkFCTEVfTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OICJUb29nbGUg
bGVnYWN5IHZpZXdwb3J0IGFkYXB0aW9uIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo
RU5BQkxFX0xFR0FDWV9XRUJLSVRfQkxPQl9CVUlMREVSICJUb2dnbGUgTGVnYWN5IFdlYktpdCBC
bG9iIEJ1aWxkZXIgU3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJM
RV9MSU5LX1BSRUZFVENIICJUb2dnbGUgcHJlIGZldGNoaW5nIHN1cHBvcnQiIE9GRikKKyAgICBX
RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTElOS19QUkVSRU5ERVIgIlRvZ2dsZSBwcmUgcmVu
ZGVyaW5nIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTUFU
SE1MICJUb2dnbGUgTWF0aE1MIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F
KEVOQUJMRV9NRURJQV9TT1VSQ0UgIlRvZ2dsZSBNZWRpYSBTb3VyY2Ugc3VwcG9ydCIgT0ZGKQog
ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTICJUb2dnbGUg
TWVkaWEgU3RhdGlzdGljcyBzdXBwb3J0IiBPRkYpCkBAIC0xMDQsOCArMTA1LDggQEAgTUFDUk8g
KFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dP
UktFUlMgIlRvZ2dsZSBXZWIgV29ya2VycyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElP
Tl9ERUZJTkUoRU5BQkxFX1hTTFQgIlRvZ2dsZSBYU0xUIHN1cHBvcnQiIE9OKQogICAgIFdFQktJ
VF9PUFRJT05fREVGSU5FKFVTRV9TWVNURU1fTUFMTE9DICJUb2dnbGUgc3lzdGVtIGFsbG9jYXRv
ciBpbnN0ZWFkIG9mIFRDbWFsbG9jIiBPRkYpCi0gICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF
X1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRvZ2dsZSBUaWxlZCBCYWNraW5nIFN0b3JlIHN1cHBvcnQi
IE9GRikKLSAgICBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfV1RGVVJMICJUb29nbGUgdGhlIHVz
ZSBvZiBXVEZVUkwgZm9yIFVSTCBwYXJzaW5nIiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJ
TkUoV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFICJUb2dnbGUgVGlsZWQgQmFja2luZyBTdG9y
ZSBzdXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoV1RGX1VTRV9XVEZVUkwg
IlRvb2dsZSB0aGUgdXNlIG9mIFdURlVSTCBmb3IgVVJMIHBhcnNpbmciIE9GRikKIEVORE1BQ1JP
ICgpCiAKIE1BQ1JPIChXRUJLSVRfT1BUSU9OX0VORCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr
ZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggODZhMzhh
ZDliNjQ0ODE5MTlhMjNjYTMzNDFjODNmOWZmZTljYjc3Mi4uZmZhMmM2M2YzMjAwMmUyZDk1ODIw
MGY3ODVlYTlmNDdmM2NiNjUwOCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21h
a2UKKysrIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTUxLDYgKzUxLDggQEAKICNj
bWFrZWRlZmluZTAxIEVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSCiAjY21ha2VkZWZpbmUwMSBF
TkFCTEVfSklUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfTEVHQUNZX05PVElGSUNBVElPTlMKKyNj
bWFrZWRlZmluZTAxIEVOQUJMRV9MSU5LX1BSRUZFVENICisjY21ha2VkZWZpbmUwMSBFTkFCTEVf
TElOS19QUkVSRU5ERVIKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9MRUdBQ1lfV0VCS0lUX0JMT0Jf
QlVJTERFUgogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX01BVEhNTAogI2NtYWtlZGVmaW5lMDEgRU5B
QkxFX01FRElBX1NUUkVBTQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4
IGE2N2I4N2QzYTFjNTc0ZjczZDM5MDY4ZTExYzE1ODQ2ZmNiZjRiMzQuLjRkZjY4YWUzMmM3NTBi
MGRlMDM5ZWVkN2RjOWRjZjcxM2Y0ZTdkYWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0wNCAgUm9iIEJ1aXMgIDxyYnVpc0By
aW0uY29tPgorCisgICAgICAgIFtDTWFrZV0gRml4IHNvbWUgQ01ha2Ugd2FybmluZ3MKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNTU4CisKKyAgICAg
ICAgRml4IFdlYktpdCBvcHRpb25zIHNvIHRoZXkgbWF0Y2ggd2l0aCBGZWF0dXJlTGlzdC5wbS4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJj
ZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25m
aWcuaC5jbWFrZToKKwogMjAxMi0wNy0wNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3Vu
Zy5jb20+CiAKICAgICAgICAgW0NNQUtFXSBBZGQgR0VORVJBVEVfQklORElOR1MgbWFjcm8gdG8g
c2hhcmUgdGhlIGNvZGVzIHdoaWNoIHVzZSBnZW5lcmF0ZS1iaW5kaW5ncy5wbC4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>150943</attachid>
            <date>2012-07-05 08:20:42 -0700</date>
            <delta_ts>2012-07-05 10:36:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90558-20120705112220.patch</filename>
            <type>text/plain</type>
            <size>3057</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k
ZXggOWNkZDgzMjE5NDFjODk5YTQ0M2NlYWUwMDVjYjU2ODFmNjIwNDI1MS4uYjExNzAzNjljZGQz
ZWYyODkxODgyM2Y3MmMyNzI1NmZmMWIxZjZjYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl
YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr
ZQpAQCAtNjIsNiArNjIsNyBAQCBNQUNSTyAoV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJL
SVRfT1BUSU9OX0RFRklORShFTkFCTEVfTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OICJUb29nbGUg
bGVnYWN5IHZpZXdwb3J0IGFkYXB0aW9uIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo
RU5BQkxFX0xFR0FDWV9XRUJLSVRfQkxPQl9CVUlMREVSICJUb2dnbGUgTGVnYWN5IFdlYktpdCBC
bG9iIEJ1aWxkZXIgU3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJM
RV9MSU5LX1BSRUZFVENIICJUb2dnbGUgcHJlIGZldGNoaW5nIHN1cHBvcnQiIE9GRikKKyAgICBX
RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTElOS19QUkVSRU5ERVIgIlRvZ2dsZSBwcmUgcmVu
ZGVyaW5nIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTUFU
SE1MICJUb2dnbGUgTWF0aE1MIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F
KEVOQUJMRV9NRURJQV9TT1VSQ0UgIlRvZ2dsZSBNZWRpYSBTb3VyY2Ugc3VwcG9ydCIgT0ZGKQog
ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTICJUb2dnbGUg
TWVkaWEgU3RhdGlzdGljcyBzdXBwb3J0IiBPRkYpCkBAIC0xMDQsOCArMTA1LDggQEAgTUFDUk8g
KFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dP
UktFUlMgIlRvZ2dsZSBXZWIgV29ya2VycyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElP
Tl9ERUZJTkUoRU5BQkxFX1hTTFQgIlRvZ2dsZSBYU0xUIHN1cHBvcnQiIE9OKQogICAgIFdFQktJ
VF9PUFRJT05fREVGSU5FKFVTRV9TWVNURU1fTUFMTE9DICJUb2dnbGUgc3lzdGVtIGFsbG9jYXRv
ciBpbnN0ZWFkIG9mIFRDbWFsbG9jIiBPRkYpCi0gICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF
X1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRvZ2dsZSBUaWxlZCBCYWNraW5nIFN0b3JlIHN1cHBvcnQi
IE9GRikKLSAgICBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfV1RGVVJMICJUb29nbGUgdGhlIHVz
ZSBvZiBXVEZVUkwgZm9yIFVSTCBwYXJzaW5nIiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJ
TkUoV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFICJUb2dnbGUgVGlsZWQgQmFja2luZyBTdG9y
ZSBzdXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoV1RGX1VTRV9XVEZVUkwg
IlRvb2dsZSB0aGUgdXNlIG9mIFdURlVSTCBmb3IgVVJMIHBhcnNpbmciIE9GRikKIEVORE1BQ1JP
ICgpCiAKIE1BQ1JPIChXRUJLSVRfT1BUSU9OX0VORCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr
ZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggODZhMzhh
ZDliNjQ0ODE5MTlhMjNjYTMzNDFjODNmOWZmZTljYjc3Mi4uMjBmYTQ0NjhjNmM4YjFhYmUwNmJm
ZWY0YjFmMGM1YzIzMzZiZTc3MCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21h
a2UKKysrIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTUxLDYgKzUxLDggQEAKICNj
bWFrZWRlZmluZTAxIEVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSCiAjY21ha2VkZWZpbmUwMSBF
TkFCTEVfSklUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfTEVHQUNZX05PVElGSUNBVElPTlMKKyNj
bWFrZWRlZmluZTAxIEVOQUJMRV9MSU5LX1BSRUZFVENICisjY21ha2VkZWZpbmUwMSBFTkFCTEVf
TElOS19QUkVSRU5ERVIKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9MRUdBQ1lfV0VCS0lUX0JMT0Jf
QlVJTERFUgogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX01BVEhNTAogI2NtYWtlZGVmaW5lMDEgRU5B
QkxFX01FRElBX1NUUkVBTQpAQCAtOTAsNSArOTIsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5BQkxF
X1dPUktFUlMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9YU0xUCiAjY21ha2VkZWZpbmUwMSBVU0Vf
U1lTVEVNX01BTExPQworI2NtYWtlZGVmaW5lMDEgV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JF
CisjY21ha2VkZWZpbmUwMSBXVEZfVVNFX1dURlVSTAogCiAjZW5kaWYgLyogQ01BS0VDT05GSUdf
SCAqLwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGE2N2I4N2QzYTFj
NTc0ZjczZDM5MDY4ZTExYzE1ODQ2ZmNiZjRiMzQuLjRkZjY4YWUzMmM3NTBiMGRlMDM5ZWVkN2Rj
OWRjZjcxM2Y0ZTdkYWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNSBAQAorMjAxMi0wNy0wNCAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgorCisg
ICAgICAgIFtDTWFrZV0gRml4IHNvbWUgQ01ha2Ugd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNTU4CisKKyAgICAgICAgRml4IFdlYktp
dCBvcHRpb25zIHNvIHRoZXkgbWF0Y2ggd2l0aCBGZWF0dXJlTGlzdC5wbS4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJL
aXRGZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZToK
KwogMjAxMi0wNy0wNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAg
ICAgICAgW0NNQUtFXSBBZGQgR0VORVJBVEVfQklORElOR1MgbWFjcm8gdG8gc2hhcmUgdGhlIGNv
ZGVzIHdoaWNoIHVzZSBnZW5lcmF0ZS1iaW5kaW5ncy5wbC4K
</data>
<flag name="review"
          id="159304"
          type_id="1"
          status="+"
          setter="dbates"
    />
          </attachment>
      

    </bug>

</bugzilla>