90550 2012-07-04 07:51:13 -0700 Wheel events on a page with frames are not handled in fixed layout 2012-07-30 07:23:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All Linux RESOLVED FIXED http://www.quackit.com/html/templates/frames/frames_example_1.html Qt P2 Normal --- 90547 1 abecsi abecsi allan.jensen hausmann kenneth tonikitoo oldest_to_newest 662939 0 abecsi 2012-07-04 07:51:13 -0700 Since r117069 we also use ScrollView::updateScrollbars() if scroll is delegated (invisible scrollbars). This results in erroneous behavior in fixed layout mode on pages which use frames. This is due to fixed layout enabling frame flattening in which case updateScrollbars disables the scrollbars on the page since the document size is equal to the frame size. This is reproducible with MiniBrowser on the given URL by double tapping to zoom in and then trying to scroll. 662954 1 150797 abecsi 2012-07-04 08:04:09 -0700 Created attachment 150797 proposed patch 662962 2 150797 abecsi 2012-07-04 08:13:07 -0700 Comment on attachment 150797 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=150797&action=review > Source/WebCore/ChangeLog:17 > + Need to figure out a way to test this, probably with > + a QML API test since WTR does not use frame flattening. Turns out that there is testRunner.setFrameFlatteningEnabled(true), and there are layout tests for this. Need to check the Skipped list as well. 662968 3 abecsi 2012-07-04 08:16:03 -0700 This patch in combination with the patch of bug 90547 also fixes the scrolling in a simple QML WebView loading a simple local html. 664778 4 150797 abecsi 2012-07-09 03:47:28 -0700 Comment on attachment 150797 proposed patch Even though the patch fixes the scrolling issue it does not seem to be the right solution. I'll revisit this later. Removing patch from review queue. 678043 5 150797 allan.jensen 2012-07-25 07:55:34 -0700 Comment on attachment 150797 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=150797&action=review > Source/WebCore/platform/ScrollView.cpp:509 > IntSize frameSize = frameRect().size(); > + bool usesFixedLayout = useFixedLayout(); > > if (hScroll == ScrollbarAuto) { > newHasHorizontalScrollbar = docSize.width() > visibleWidth(); > - if (newHasHorizontalScrollbar && !m_updateScrollbarsPass && docSize.width() <= frameSize.width() && docSize.height() <= frameSize.height()) > + if (newHasHorizontalScrollbar && !m_updateScrollbarsPass && !usesFixedLayout && docSize.width() <= frameSize.width() && docSize.height() <= frameSize.height()) I think the real problem here is the use of frameRect().size() since with fixedLayout the frameRect is always the size of the document. It should use visibleContentRect(true) instead. 678085 6 154364 allan.jensen 2012-07-25 08:30:40 -0700 Created attachment 154364 Patch A quick alternative patch based on my observersion. This solves most of the problems, though some frames does not create the invisible scroll-bars until the page has been manipulated in some way. Though that is probably a separate bug with a missing updateScrollbar() call somewhere. 678218 7 154364 tonikitoo 2012-07-25 10:43:21 -0700 Comment on attachment 154364 Patch why is this Qt specific? 678255 8 allan.jensen 2012-07-25 11:09:45 -0700 (In reply to comment #7) > (From update of attachment 154364 [details]) > why is this Qt specific? I guess it isn't as such, it is only specific to the way Qt uses FrameView, anyone using it the same way would have the same problem. 681924 9 allan.jensen 2012-07-30 05:46:20 -0700 But besides the commit title, is there any other comments to the solution, or can it go in? 681945 10 tonikitoo 2012-07-30 06:13:33 -0700 By any chance, do you set fixedLayout for non-mainframe ScrollViews? 681968 11 allan.jensen 2012-07-30 06:30:32 -0700 (In reply to comment #10) > By any chance, do you set fixedLayout for non-mainframe ScrollViews? I don't think so, not unless it is a part of frame-flattening (I haven't checked that code in that much detail yet). 682000 12 allan.jensen 2012-07-30 07:23:32 -0700 Committed r124024: <http://trac.webkit.org/changeset/124024> 150797 2012-07-04 08:04:09 -0700 2012-07-25 07:55:34 -0700 proposed patch patch.diff text/plain 2632 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNjU2MDU0Li40ODkxYTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDctMDQgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisK KyAgICAgICAgW1F0XSBXaGVlbCBldmVudHMgb24gYSBwYWdlIHdpdGggZnJhbWVzIGFyZSBub3Qg aGFuZGxlZCBpbiBmaXhlZCBsYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkwNTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2luY2UgcjExNzA2OSB3ZSBhbHNvIHVzZSBTY3JvbGxWaWV3Ojp1cGRh dGVTY3JvbGxiYXJzKCkKKyAgICAgICAgaWYgc2Nyb2xsIGlzIGRlbGVnYXRlZCAoaW52aXNpYmxl IHNjcm9sbGJhcnMpLgorICAgICAgICBUaGlzIHJlc3VsdHMgaW4gZXJyb25lb3VzIGJlaGF2aW9y IGluIGZpeGVkIGxheW91dCBtb2RlCisgICAgICAgIG9uIHBhZ2VzIHdoaWNoIHVzZSBmcmFtZXMg ZHVlIHRvIGZpeGVkIGxheW91dCBlbmFibGluZworICAgICAgICBmcmFtZSBmbGF0dGVuaW5nIGlu IHdoaWNoIGNhc2UgdXBkYXRlU2Nyb2xsYmFycyBkaXNhYmxlcworICAgICAgICB0aGUgc2Nyb2xs YmFycyBvbiB0aGUgcGFnZSBzaW5jZSB0aGUgZG9jdW1lbnQgc2l6ZSBpcworICAgICAgICBlcXVh bCB0byB0aGUgZnJhbWUgc2l6ZS4KKworICAgICAgICBOZWVkIHRvIGZpZ3VyZSBvdXQgYSB3YXkg dG8gdGVzdCB0aGlzLCBwcm9iYWJseSB3aXRoCisgICAgICAgIGEgUU1MIEFQSSB0ZXN0IHNpbmNl IFdUUiBkb2VzIG5vdCB1c2UgZnJhbWUgZmxhdHRlbmluZy4KKworICAgICAgICAqIHBsYXRmb3Jt L1Njcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6dXBkYXRlU2Ny b2xsYmFycyk6CisKIDIwMTItMDctMDQgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBDb3JyZWN0bHkgcmVqZWN0IGFjY2VsZXJhdGVkIGFu aW1hdGlvbnMgd2l0aCBjZXJ0YWluIHJvdGF0aW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsVmlldy5jcHAKaW5kZXggOTRlZTNmOS4uOTliM2ZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vU2Nyb2xsVmlldy5jcHAKQEAgLTUwMiwxNSArNTAyLDE2IEBAIHZvaWQgU2Nyb2xsVmlldzo6 dXBkYXRlU2Nyb2xsYmFycyhjb25zdCBJbnRTaXplJiBkZXNpcmVkT2Zmc2V0KQogICAgICAgICAK ICAgICAgICAgSW50U2l6ZSBkb2NTaXplID0gY29udGVudHNTaXplKCk7CiAgICAgICAgIEludFNp emUgZnJhbWVTaXplID0gZnJhbWVSZWN0KCkuc2l6ZSgpOworICAgICAgICBib29sIHVzZXNGaXhl ZExheW91dCA9IHVzZUZpeGVkTGF5b3V0KCk7CiAKICAgICAgICAgaWYgKGhTY3JvbGwgPT0gU2Ny b2xsYmFyQXV0bykgewogICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGRv Y1NpemUud2lkdGgoKSA+IHZpc2libGVXaWR0aCgpOwotICAgICAgICAgICAgaWYgKG5ld0hhc0hv cml6b250YWxTY3JvbGxiYXIgJiYgIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgJiYgZG9jU2l6ZS53 aWR0aCgpIDw9IGZyYW1lU2l6ZS53aWR0aCgpICYmIGRvY1NpemUuaGVpZ2h0KCkgPD0gZnJhbWVT aXplLmhlaWdodCgpKQorICAgICAgICAgICAgaWYgKG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIg JiYgIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgJiYgIXVzZXNGaXhlZExheW91dCAmJiBkb2NTaXpl LndpZHRoKCkgPD0gZnJhbWVTaXplLndpZHRoKCkgJiYgZG9jU2l6ZS5oZWlnaHQoKSA8PSBmcmFt ZVNpemUuaGVpZ2h0KCkpCiAgICAgICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJh ciA9IGZhbHNlOwogICAgICAgICB9CiAgICAgICAgIGlmICh2U2Nyb2xsID09IFNjcm9sbGJhckF1 dG8pIHsKICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZG9jU2l6ZS5oZWln aHQoKSA+IHZpc2libGVIZWlnaHQoKTsKLSAgICAgICAgICAgIGlmIChuZXdIYXNWZXJ0aWNhbFNj cm9sbGJhciAmJiAhbV91cGRhdGVTY3JvbGxiYXJzUGFzcyAmJiBkb2NTaXplLndpZHRoKCkgPD0g ZnJhbWVTaXplLndpZHRoKCkgJiYgZG9jU2l6ZS5oZWlnaHQoKSA8PSBmcmFtZVNpemUuaGVpZ2h0 KCkpCisgICAgICAgICAgICBpZiAobmV3SGFzVmVydGljYWxTY3JvbGxiYXIgJiYgIW1fdXBkYXRl U2Nyb2xsYmFyc1Bhc3MgJiYgIXVzZXNGaXhlZExheW91dCAmJiBkb2NTaXplLndpZHRoKCkgPD0g ZnJhbWVTaXplLndpZHRoKCkgJiYgZG9jU2l6ZS5oZWlnaHQoKSA8PSBmcmFtZVNpemUuaGVpZ2h0 KCkpCiAgICAgICAgICAgICAgICAgbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgPSBmYWxzZTsKICAg ICAgICAgfQogCg== 154364 2012-07-25 08:30:40 -0700 2012-07-30 06:12:32 -0700 Patch Patch text/plain 2847 allan.jensen Y29tbWl0IDZiMzM0M2I0Y2ZjZjlhOTRmN2NhN2RlOWY5YzgzYjg3YTcwZjU0ZWQKQXV0aG9yOiBB bGxhbiBTYW5kZmVsZCBKZW5zZW4gPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CkRhdGU6ICAgV2Vk IEp1bCAyNSAxNzoyNTowNiAyMDEyICswMjAwCgogICAgW1F0XSBXaGVlbCBldmVudHMgb24gYSBw YWdlIHdpdGggZnJhbWVzIGFyZSBub3QgaGFuZGxlZCBpbiBmaXhlZCBsYXlvdXQKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggZGMyYTA1Yi4uZDVmODdlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEy LTA3LTI1ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgog CisgICAgICAgIFtRdF0gV2hlZWwgZXZlbnRzIG9uIGEgcGFnZSB3aXRoIGZyYW1lcyBhcmUgbm90 IGhhbmRsZWQgaW4gZml4ZWQgbGF5b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MDU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZyYW1lLXJlY3Qgc2l6ZSBpcyBub3QgdGhlIHJpZ2h0IHZhbHVlIHRv IGNoZWNrIGFnYWluc3QgdG8gc2VlIGlmIHRoZSBkb2N1bWVudAorICAgICAgICBjYW4gYmUgY29u dGFpbmVkIHdpdGhpbiB0aGUgZnVsbCB2aXNpYmxlIGNvbnRlbnQgcmVjdCwgc2luY2UgaXQgZG9l cyBub3QgaGFuZGxlCisgICAgICAgIGZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LiBJbnN0ZWFkIHZp c2libGVDb250ZW50UmVjdCh0cnVlKSBzaG91bGQgYmUgdXNlZCB3aGljaAorICAgICAgICByZXR1 cm5zIHRoZSBmdWxsIHZpc2libGUgY29udGVudCByZWN0IGRpc3JlZ2FyZGluZyBzY3JvbGxiYXJz LCBhbmQgd2hpY2ggaXMKKyAgICAgICAgdGhlIHNhbWUgYSBmcmFtZS1yZWN0IHNpemUgd2hlbiBm aXhlZFZpc2libGVDb250ZW50UmVjdCBpcyBub3Qgc2V0LgorCisgICAgICAgICogcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp1cGRhdGVTY3Jv bGxiYXJzKToKKworMjAxMi0wNy0yNSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVu c2VuQG5va2lhLmNvbT4KKwogICAgICAgICBBdXRvLXZlY3Rvcml6ZSBjb21waWxlciBoaW50Lgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyNDkKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCA5NGVlM2Y5Li44NWQ3NWRh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApAQCAtNTAxLDE2ICs1MDEs MTYgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKGNvbnN0IEludFNpemUmIGRl c2lyZWRPZmZzZXQpCiAgICAgICAgIGJvb2wgc2VuZENvbnRlbnRSZXNpemVkTm90aWZpY2F0aW9u ID0gZmFsc2U7CiAgICAgICAgIAogICAgICAgICBJbnRTaXplIGRvY1NpemUgPSBjb250ZW50c1Np emUoKTsKLSAgICAgICAgSW50U2l6ZSBmcmFtZVNpemUgPSBmcmFtZVJlY3QoKS5zaXplKCk7Cisg ICAgICAgIEludFNpemUgZnVsbFZpc2libGVTaXplID0gdmlzaWJsZUNvbnRlbnRSZWN0KHRydWUg LyppbmNsdWRlU2Nyb2xsYmFycyovKS5zaXplKCk7CiAKICAgICAgICAgaWYgKGhTY3JvbGwgPT0g U2Nyb2xsYmFyQXV0bykgewogICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9 IGRvY1NpemUud2lkdGgoKSA+IHZpc2libGVXaWR0aCgpOwotICAgICAgICAgICAgaWYgKG5ld0hh c0hvcml6b250YWxTY3JvbGxiYXIgJiYgIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgJiYgZG9jU2l6 ZS53aWR0aCgpIDw9IGZyYW1lU2l6ZS53aWR0aCgpICYmIGRvY1NpemUuaGVpZ2h0KCkgPD0gZnJh bWVTaXplLmhlaWdodCgpKQorICAgICAgICAgICAgaWYgKG5ld0hhc0hvcml6b250YWxTY3JvbGxi YXIgJiYgIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgJiYgZG9jU2l6ZS53aWR0aCgpIDw9IGZ1bGxW aXNpYmxlU2l6ZS53aWR0aCgpICYmIGRvY1NpemUuaGVpZ2h0KCkgPD0gZnVsbFZpc2libGVTaXpl LmhlaWdodCgpKQogICAgICAgICAgICAgICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgPSBm YWxzZTsKICAgICAgICAgfQogICAgICAgICBpZiAodlNjcm9sbCA9PSBTY3JvbGxiYXJBdXRvKSB7 CiAgICAgICAgICAgICBuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhciA9IGRvY1NpemUuaGVpZ2h0KCkg PiB2aXNpYmxlSGVpZ2h0KCk7Ci0gICAgICAgICAgICBpZiAobmV3SGFzVmVydGljYWxTY3JvbGxi YXIgJiYgIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgJiYgZG9jU2l6ZS53aWR0aCgpIDw9IGZyYW1l U2l6ZS53aWR0aCgpICYmIGRvY1NpemUuaGVpZ2h0KCkgPD0gZnJhbWVTaXplLmhlaWdodCgpKQor ICAgICAgICAgICAgaWYgKG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyICYmICFtX3VwZGF0ZVNjcm9s bGJhcnNQYXNzICYmIGRvY1NpemUud2lkdGgoKSA8PSBmdWxsVmlzaWJsZVNpemUud2lkdGgoKSAm JiBkb2NTaXplLmhlaWdodCgpIDw9IGZ1bGxWaXNpYmxlU2l6ZS5oZWlnaHQoKSkKICAgICAgICAg ICAgICAgICBuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhciA9IGZhbHNlOwogICAgICAgICB9CiAK