90549 2012-07-04 07:07:16 -0700 Web Inspector: UISourceCode should take care of adding revision after committing working copy. 2012-07-04 08:14:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 662924 0 vsevik 2012-07-04 07:07:16 -0700 Edited data should be saved and revision should be added even if domain specific edit commit (css edit, js live edit). This means UISourceCode should take care of adding revision and should do it synchronously. 662928 1 150789 vsevik 2012-07-04 07:11:37 -0700 Created attachment 150789 Patch 662965 2 vsevik 2012-07-04 08:14:21 -0700 Committed r121855: <http://trac.webkit.org/changeset/121855> 150789 2012-07-04 07:11:37 -0700 2012-07-04 08:00:26 -0700 Patch bug-90549-20120704181135.patch text/plain 5164 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiMDMzOTUwYmJiOWFi ZjRlYTQwNjY2MzMyMDM0NWI2NTIyYTUzNy4uYjBhZTliMTA0MTdmODI0ODZhMjQ0YTJlNGFmNGVi MmVlYzFmNmY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA3LTA0ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFVJU291cmNlQ29kZSBzaG91bGQgdGFrZSBjYXJlIG9mIGFkZGluZyByZXZpc2lvbiBhZnRl ciBjb21taXR0aW5nIHdvcmtpbmcgY29weS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTkwNTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmV2aXNpb24gaXMgbm93IGFkZGVkIGluIFVJU291cmNlQ29kZS5j b21taXRXb3JraW5nQ29weSBzeW5jaHJvbm91c2x5IGV2ZW4gaWYgc2F2aW5nIHRvIEpTIFZNIG9y IENTUyBtb2RlbCBmYWlsZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0 eWxlTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVNb2RlbFJlc291cmNl QmluZGluZy5wcm90b3R5cGUuc2V0U3R5bGVDb250ZW50KToKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2UuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2 YVNjcmlwdFNvdXJjZS5wcm90b3R5cGUud29ya2luZ0NvcHlDb21taXR0ZWQpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvVUlTb3VyY2VDb2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlVJU291cmNlQ29kZS5wcm90b3R5cGUuY29tbWl0V29ya2luZ0NvcHkpOgorCisyMDEyLTA3 LTA0ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IEdldCByaWQgb2YgUmVzb3VyY2VEb21haW5Nb2RlbEJpbmRpbmcgYW5kIERl YnVnZ2VyUmVzb3VyY2VCaW5kaW5nLCBtYWtlIFJlc291cmNlLnNldENvbnRlbnQgcHJpdmF0ZS4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNTMxCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVN b2RlbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVNb2Rl bC5qcwppbmRleCAyODRlOTRlNTZlMzc1MWM1M2RmN2Q3NTU1MzIwZmE5NTRhYjA5YWVkLi4xYmNj YWRhNzBmY2MzNjk4MWNiNDJlYzIxYTI3MTY0MTEzY2Q1Mjk0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DU1NTdHlsZU1vZGVsLmpzCkBAIC05NTUsMjMg Kzk1NSwxMCBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVNb2RlbFJlc291cmNlQmluZGluZy5wcm90 b3R5cGUgPSB7CiAgICAgewogICAgICAgICB2YXIgcmVzb3VyY2UgPSBzdHlsZVNvdXJjZS5yZXNv dXJjZSgpOwogICAgICAgICBpZiAodGhpcy5fc3R5bGVTaGVldElkRm9yUmVzb3VyY2UocmVzb3Vy Y2UpKSB7Ci0gICAgICAgICAgICB0aGlzLl9pbm5lclNldENvbnRlbnQocmVzb3VyY2UsIGNvbnRl bnQsIG1ham9yQ2hhbmdlLCBpbm5lckNhbGxiYWNrLCBudWxsKTsKKyAgICAgICAgICAgIHRoaXMu X2lubmVyU2V0Q29udGVudChyZXNvdXJjZSwgY29udGVudCwgbWFqb3JDaGFuZ2UsIHVzZXJDYWxs YmFjaywgbnVsbCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICAgICAgdGhp cy5fbG9hZFN0eWxlU2hlZXRIZWFkZXJzKHRoaXMuX2lubmVyU2V0Q29udGVudC5iaW5kKHRoaXMs IHJlc291cmNlLCBjb250ZW50LCBtYWpvckNoYW5nZSwgaW5uZXJDYWxsYmFjaykpOwotICAgICAg ICAKLSAgICAgICAgZnVuY3Rpb24gaW5uZXJDYWxsYmFjayhlcnJvcikKLSAgICAgICAgewotICAg ICAgICAgICAgaWYgKGVycm9yKSB7Ci0gICAgICAgICAgICAgICAgdXNlckNhbGxiYWNrKGVycm9y KTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICAg IGlmIChtYWpvckNoYW5nZSkKLSAgICAgICAgICAgICAgICByZXNvdXJjZS5hZGRSZXZpc2lvbihj b250ZW50KTsKLQotICAgICAgICAgICAgdXNlckNhbGxiYWNrKG51bGwpOwotICAgICAgICB9Cisg ICAgICAgIHRoaXMuX2xvYWRTdHlsZVNoZWV0SGVhZGVycyh0aGlzLl9pbm5lclNldENvbnRlbnQu YmluZCh0aGlzLCByZXNvdXJjZSwgY29udGVudCwgbWFqb3JDaGFuZ2UsIHVzZXJDYWxsYmFjaykp OwogICAgIH0sCiAKICAgICAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZS5qcwppbmRleCBjMjlmMDJmYjI3ZGQ5ZWZjZmYx ZjU5MmJmYTExN2U5ZTI0M2Q1YTNlLi41M2FmYzkwNmYzZGUyMTM1MzU1NjM4N2U4MjI3MTg1ZTJm OGZjZjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ph dmFTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9KYXZhU2NyaXB0U291cmNlLmpzCkBAIC0yMDcsMzYgKzIwNyw5IEBAIFdlYkluc3BlY3Rvci5K YXZhU2NyaXB0U291cmNlLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGNhbGxiYWNrKGVycm9y KTsKICAgICAgICAgfQogCi0gICAgICAgIHRoaXMuX3NldFNjcmlwdFNvdXJjZSh0aGlzLndvcmtp bmdDb3B5KCksIGlubmVyQ2FsbGJhY2suYmluZCh0aGlzKSk7Ci0gICAgfSwKLQotICAgIC8qKgot ICAgICAqIEBwYXJhbSB7c3RyaW5nfSBuZXdTb3VyY2UKLSAgICAgKiBAcGFyYW0ge2Z1bmN0aW9u KD9Qcm90b2NvbC5FcnJvcil9IGNhbGxiYWNrCi0gICAgICovCi0gICAgX3NldFNjcmlwdFNvdXJj ZTogZnVuY3Rpb24obmV3U291cmNlLCBjYWxsYmFjaykKLSAgICB7CiAgICAgICAgIHZhciByYXdM b2NhdGlvbiA9IHRoaXMudWlMb2NhdGlvblRvUmF3TG9jYXRpb24oMCwgMCk7CiAgICAgICAgIHZh ciBzY3JpcHQgPSBXZWJJbnNwZWN0b3IuZGVidWdnZXJNb2RlbC5zY3JpcHRGb3JJZChyYXdMb2Nh dGlvbi5zY3JpcHRJZCk7Ci0KLSAgICAgICAgLyoqCi0gICAgICAgICAqIEB0aGlzIHtXZWJJbnNw ZWN0b3IuSmF2YVNjcmlwdFNvdXJjZX0KLSAgICAgICAgICogQHBhcmFtIHs/UHJvdG9jb2wuRXJy b3J9IGVycm9yCi0gICAgICAgICAqLwotICAgICAgICBmdW5jdGlvbiBkaWRFZGl0U2NyaXB0U291 cmNlKGVycm9yKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAg ICAgICAgICBjYWxsYmFjayhlcnJvcik7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAg ICAgICAgfQotCi0gICAgICAgICAgICB2YXIgcmVzb3VyY2UgPSB0aGlzLnJlc291cmNlKCk7Ci0g ICAgICAgICAgICBpZiAocmVzb3VyY2UpCi0gICAgICAgICAgICAgICAgcmVzb3VyY2UuYWRkUmV2 aXNpb24obmV3U291cmNlKTsKLQotICAgICAgICAgICAgY2FsbGJhY2sobnVsbCk7Ci0gICAgICAg IH0KLSAgICAgICAgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTW9kZWwuc2V0U2NyaXB0U291cmNlKHNj cmlwdC5zY3JpcHRJZCwgbmV3U291cmNlLCBkaWRFZGl0U2NyaXB0U291cmNlLmJpbmQodGhpcykp OworICAgICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNb2RlbC5zZXRTY3JpcHRTb3VyY2Uoc2Ny aXB0LnNjcmlwdElkLCB0aGlzLndvcmtpbmdDb3B5KCksIGlubmVyQ2FsbGJhY2suYmluZCh0aGlz KSk7CiAgICAgfSwKIAogICAgIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9VSVNvdXJjZUNvZGUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1VJU291cmNlQ29kZS5qcwppbmRleCBhZThjNTBhMWE0ODZjMzNmMzRmZTA0Zjk5 MzkzMzhhNDk4YjcwMmZkLi4wYTI3Y2UxOGM2NzlkMGM5MTIzZjNlNDFiYzdkNWJmMGRmZGJlNjc1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1VJU291cmNl Q29kZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1VJU291cmNl Q29kZS5qcwpAQCAtMjA1LDE5ICsyMDUsMTQgQEAgV2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZS5w cm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICAv KioKLSAgICAgICAgICogQHBhcmFtIHs/c3RyaW5nfSBlcnJvcgotICAgICAgICAgKi8KLSAgICAg ICAgZnVuY3Rpb24gaW5uZXJDYWxsYmFjayhlcnJvcikKLSAgICAgICAgewotICAgICAgICAgICAg ZGVsZXRlIHRoaXMuX2NvbW1pdHRpbmdXb3JraW5nQ29weTsKLSAgICAgICAgICAgIHRoaXMuY29u dGVudENoYW5nZWQobmV3Q29udGVudCwgdGhpcy5fbWltZVR5cGUpOwotICAgICAgICAgICAgY2Fs bGJhY2soZXJyb3IpOwotICAgICAgICB9Ci0KICAgICAgICAgdmFyIG5ld0NvbnRlbnQgPSB0aGlz Ll93b3JraW5nQ29weTsKICAgICAgICAgdGhpcy5fY29tbWl0dGluZ1dvcmtpbmdDb3B5ID0gdHJ1 ZTsKLSAgICAgICAgdGhpcy53b3JraW5nQ29weUNvbW1pdHRlZChpbm5lckNhbGxiYWNrLmJpbmQo dGhpcykpOworICAgICAgICB0aGlzLndvcmtpbmdDb3B5Q29tbWl0dGVkKGNhbGxiYWNrKTsKKyAg ICAgICAgaWYgKHRoaXMucmVzb3VyY2UoKSkKKyAgICAgICAgICAgIHRoaXMucmVzb3VyY2UoKS5h ZGRSZXZpc2lvbihuZXdDb250ZW50KTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2NvbW1pdHRpbmdX b3JraW5nQ29weTsKKyAgICAgICAgdGhpcy5jb250ZW50Q2hhbmdlZChuZXdDb250ZW50LCB0aGlz Ll9taW1lVHlwZSk7CisKICAgICB9LAogCiAgICAgLyoqCg==