90548 2012-07-04 06:41:34 -0700 [WK2][EFL] Add API to Ewk_View to set / get zoom level 2012-07-05 01:04:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 61838 1 cdumez cdumez d-r gyuyoung.kim kenneth rakuco ryuan.choi tonikitoo oldest_to_newest 662914 0 cdumez 2012-07-04 06:41:34 -0700 We should add methods to the Ewk_View to set and get the zoom levels for both the page and the text. 662915 1 150784 cdumez 2012-07-04 06:43:54 -0700 Created attachment 150784 Patch 663223 2 150784 kenneth 2012-07-04 19:07:20 -0700 Comment on attachment 150784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150784&action=review > Source/WebKit2/ChangeLog:10 > + > + Add methods to Ewk_View and retrieve and set the > + zoom levels for both the page and the text. > + zoom level is really legacy, and for accessibility I guess some min font sizes should be used instead. Are you sure you want to add this? 663310 3 cdumez 2012-07-04 22:32:25 -0700 (In reply to comment #2) > (From update of attachment 150784 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150784&action=review > > > Source/WebKit2/ChangeLog:10 > > + > > + Add methods to Ewk_View and retrieve and set the > > + zoom levels for both the page and the text. > > + > > zoom level is really legacy, and for accessibility I guess some min font sizes should be used instead. Are you sure you want to add this? I did not know those were legacy. We had those methods in WK1 and use them at least in EWKLauncher so I added them back so not to loose functionality. The WK2 GTK port has those methods as well. I checked the Qt port and only the "page" zoom is marked as legacy, not the "text" one. I know EWSLauncher uses the zoom feature and I was planning to do the same for EFL MiniBrowser after this patch landed. 663337 4 kenneth 2012-07-04 23:43:32 -0700 The reason that I am mentioning this is that there is an ongoing consolidation of mobile and desktop browser behavior and lots of pieces to fall into their right spots. This relates to viewport interaction, layout sizes etc. And in this light the zoom is like a legacy accesibility feature which doesn't really belong on mobile devices and it is hard to find where it really fits. I actually believe it is a very seldom used feature today, because it can totally break layout and it does more so today that earlier due to pages using more detailed layout and due to web apps expecting specific sizes. For Qt we are trying to not open a can of worms and only add support like this when we know there is a proper understood use-case and when we know how it all fits together. 663345 5 cdumez 2012-07-04 23:51:32 -0700 gyuyoung, ryuan, do you have use for those APIs? Dominik, any opinion? If we consider other targets than mobile (in particular TV and IVI), does it make more sense? I don't mind dropping the patch if we don't have any use for it on any target. I would just like to make sure everyone thinks this way. 663357 6 gyuyoung.kim 2012-07-05 00:16:16 -0700 Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now. In addition, as you may know, Tizen is using WebKit EFL as web engine. - https://www.tizen.org/about Tizen goal is to be ported to many devices. So, in my humble opinion, it is good to add this APIs for EFL port. 663368 7 kenneth 2012-07-05 00:41:53 -0700 (In reply to comment #6) > Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now. This it should be solved differently depending on target DPI as well as distance to the screen. CSS is specified as 96dpi, but mobile content is laid out as the screen is using 160dpi (if different it is scaled up/down with the device pixel ratio), as that fits with 96dpi given the most common viewing distance. Something similar should be done for TV's. That is the right way to solve it. 663377 8 cdumez 2012-07-05 01:04:15 -0700 Marking as WONTFIX for later reference. I'll implement device pixel ratio is a separate bug. 663378 9 gyuyoung.kim 2012-07-05 01:04:49 -0700 (In reply to comment #7) > (In reply to comment #6) > > Though I'm not sure now, in my opinion, EFL port may be used by TV, tablet and other electronics in future. I was told there is a project to port WebKit EFL to other devices now. > > This it should be solved differently depending on target DPI as well as distance to the screen. CSS is specified as 96dpi, but mobile content is laid out as the screen is using 160dpi (if different it is scaled up/down with the device pixel ratio), as that fits with 96dpi given the most common viewing distance. > > Something similar should be done for TV's. That is the right way to solve it. I see what is your point on #webkit-efl irc. Ok, I agree with your advice. Thanks. 150784 2012-07-04 06:43:54 -0700 2012-07-05 01:04:29 -0700 Patch 90548_zoom_level.patch text/plain 3965 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOTEzZjJkLi5lYmYwY2M0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTItMDctMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbV0syXVtFRkxdIEFkZCBBUEkgdG8gRXdrX1ZpZXcgdG8gc2V0IC8g Z2V0IHpvb20gbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkwNTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIG1ldGhvZHMgdG8gRXdrX1ZpZXcgYW5kIHJldHJpZXZlIGFuZCBzZXQgdGhlCisg ICAgICAgIHpvb20gbGV2ZWxzIGZvciBib3RoIHRoZSBwYWdlIGFuZCB0aGUgdGV4dC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3 X3pvb21fZ2V0KToKKyAgICAgICAgKGV3a192aWV3X3pvb21fc2V0KToKKyAgICAgICAgKGV3a192 aWV3X3RleHRfem9vbV9nZXQpOgorICAgICAgICAoZXdrX3ZpZXdfdGV4dF96b29tX3NldCk6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKworMjAxMi0wNy0wNCAgQ2hy aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCiAgICAgICAgIFtF RkxdW1dLMl0gRXdrX1ZpZXcgc2hvdWxkIHJlcG9ydCBsb2FkIGVycm9ycwogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA0NzkKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IGU3OWJkMzIuLmYyYWVi NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAK QEAgLTUyOSw2ICs1MjksNDAgQEAgY29uc3QgY2hhciogZXdrX3ZpZXdfdXJpX2dldChjb25zdCBF dmFzX09iamVjdCogZXdrVmlldykKICAgICByZXR1cm4gcHJpdi0+dXJpOwogfQogCitmbG9hdCBl d2tfdmlld196b29tX2dldChjb25zdCBFdmFzX09iamVjdCogZXdrVmlldykKK3sKKyAgICBFV0tf VklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgMSk7CisgICAgRVdLX1ZJ RVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJpdiwgMSk7CisKKyAgICByZXR1cm4g V0tQYWdlR2V0UGFnZVpvb21GYWN0b3IodG9BUEkocHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpKSk7 Cit9CisKK0VpbmFfQm9vbCBld2tfdmlld196b29tX3NldChFdmFzX09iamVjdCogZXdrVmlldywg ZmxvYXQgem9vbUZhY3RvcikKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1Zp ZXcsIHNtYXJ0RGF0YSwgZmFsc2UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihz bWFydERhdGEsIHByaXYsIGZhbHNlKTsKKworICAgIFdLUGFnZVNldFBhZ2Vab29tRmFjdG9yKHRv QVBJKHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKSksIHpvb21GYWN0b3IpOworICAgIHJldHVybiB0 cnVlOworfQorCitmbG9hdCBld2tfdmlld190ZXh0X3pvb21fZ2V0KGNvbnN0IEV2YXNfT2JqZWN0 KiBld2tWaWV3KQoreworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21h cnREYXRhLCAxKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBw cml2LCAxKTsKKworICAgIHJldHVybiBXS1BhZ2VHZXRUZXh0Wm9vbUZhY3Rvcih0b0FQSShwcml2 LT5wYWdlQ2xpZW50LT5wYWdlKCkpKTsKK30KKworRWluYV9Cb29sIGV3a192aWV3X3RleHRfem9v bV9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGZsb2F0IHpvb21GYWN0b3IpCit7CisgICAgRVdL X1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIGZhbHNlKTsKKyAgICBF V0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2LCBmYWxzZSk7CisKKyAg ICBXS1BhZ2VTZXRUZXh0Wm9vbUZhY3Rvcih0b0FQSShwcml2LT5wYWdlQ2xpZW50LT5wYWdlKCkp LCB6b29tRmFjdG9yKTsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogRWluYV9Cb29sIGV3a192aWV3 X3JlbG9hZChFdmFzX09iamVjdCogZXdrVmlldykKIHsKICAgICBFV0tfVklFV19TRF9HRVRfT1Jf UkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgZmFsc2UpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKaW5kZXggMzc1MDZiYi4uYzZhMTcyZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBAIC0xNzUsNiArMTc1LDQ0 IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3X3VyaV9zZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0 IGNoYXIgKnVyaSk7CiBFQVBJIGNvbnN0IGNoYXIgKmV3a192aWV3X3VyaV9nZXQoY29uc3QgRXZh c19PYmplY3QgKm8pOwogCiAvKioKKyAqIEdldHMgdGhlIGN1cnJlbnQgcGFnZSB6b29tIGxldmVs IG9mIHRoZSBtYWluIGZyYW1lLgorICoKKyAqIEBwYXJhbSBvIHZpZXcgb2JqZWN0IHRvIGdldCB0 aGUgem9vbSBsZXZlbAorICoKKyAqIEByZXR1cm4gY3VycmVudCB6b29tIGxldmVsIGluIHVzZQor ICovCitFQVBJIGZsb2F0IGV3a192aWV3X3pvb21fZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsK KworLyoqCisgKiBTZXRzIHRoZSBjdXJyZW50IHBhZ2Ugem9vbSBsZXZlbCBvZiB0aGUgbWFpbiBm cmFtZS4KKyAqCisgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBzZXQgdGhlIHpvb20gbGV2ZWwK KyAqIEBwYXJhbSB6b29tX2ZhY3RvciBhIG5ldyBsZXZlbCB0byBzZXQKKyAqCisgKiBAcmV0dXJu IEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzIG9yIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlCisgKi8K K0VBUEkgRWluYV9Cb29sIGV3a192aWV3X3pvb21fc2V0KEV2YXNfT2JqZWN0ICpvLCBmbG9hdCB6 b29tX2ZhY3Rvcik7CisKKy8qKgorICogR2V0cyB0aGUgY3VycmVudCB0ZXh0IHpvb20gbGV2ZWwg b2YgdGhlIG1haW4gZnJhbWUuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gZ2V0IHRo ZSB6b29tIGxldmVsCisgKgorICogQHJldHVybiBjdXJyZW50IHpvb20gbGV2ZWwgaW4gdXNlCisg Ki8KK0VBUEkgZmxvYXQgZXdrX3ZpZXdfdGV4dF96b29tX2dldChjb25zdCBFdmFzX09iamVjdCAq byk7CisKKy8qKgorICogU2V0cyB0aGUgY3VycmVudCB0ZXh0IHpvb20gbGV2ZWwgb2YgdGhlIG1h aW4gZnJhbWUuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gc2V0IHRoZSB0ZXh0IHpv b20gbGV2ZWwKKyAqIEBwYXJhbSB6b29tX2ZhY3RvciBhIG5ldyBsZXZlbCB0byBzZXQKKyAqCisg KiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzIG9yIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3 aXNlCisgKi8KK0VBUEkgRWluYV9Cb29sIGV3a192aWV3X3RleHRfem9vbV9zZXQoRXZhc19PYmpl Y3QgKm8sIGZsb2F0IHpvb21fZmFjdG9yKTsKKworLyoqCiAgKiBBc2tzIHRoZSBtYWluIGZyYW1l IHRvIHJlbG9hZCB0aGUgY3VycmVudCBkb2N1bWVudC4KICAqCiAgKiBAcGFyYW0gbyB2aWV3IG9i amVjdCB0byByZWxvYWQgY3VycmVudCBkb2N1bWVudAo=