90535 2012-07-04 02:36:04 -0700 Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it 2012-08-12 21:18:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kinuko kinuko abarth haraken japhet jianli jochen webkit.review.bot oldest_to_newest 662789 0 kinuko 2012-07-04 02:36:04 -0700 Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it (on the platforms where it is still exposed, i.e. chromium) 662791 1 150745 kinuko 2012-07-04 02:38:36 -0700 Created attachment 150745 Patch 693222 2 150745 eric 2012-08-12 03:46:13 -0700 Comment on attachment 150745 Patch OK. 693223 3 150745 eric 2012-08-12 03:46:48 -0700 Comment on attachment 150745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150745&action=review > Source/WebCore/fileapi/WebKitBlobBuilder.h:49 > + BlobConstructionReasonMax, This Max isn't needed. But I expect (hope?) that this code won't be aroudn very long anyway. 693226 4 150745 webkit.review.bot 2012-08-12 03:48:18 -0700 Comment on attachment 150745 Patch Rejecting attachment 150745 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: k #1 succeeded at 138 (offset -1 lines). patching file Source/WebCore/fileapi/WebKitBlobBuilder.cpp Hunk #1 FAILED at 35. Hunk #2 succeeded at 158 with fuzz 1 (offset 17 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/fileapi/WebKitBlobBuilder.cpp.rej patching file Source/WebCore/fileapi/WebKitBlobBuilder.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13476764 693362 5 kinuko 2012-08-12 21:18:05 -0700 Committed r125386: <http://trac.webkit.org/changeset/125386> 150745 2012-07-04 02:38:36 -0700 2012-08-12 03:48:18 -0700 Patch bug-90535-20120704183834.patch text/plain 4376 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTYwNmFkOTk5ZjIyNDc3 ZGI3Yjg4ZWRkOGZmYzU4ZDI1YTllODA0MC4uYzQ1NDUxYjVkNTNjMjhlYmY4NzhlNDZhYTU3NWQy ODM1OGM4ZjZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA3LTA0ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWNvcmQgbWV0cmlj cyB0byBtZWFzdXJlIHRoZSB1c2FnZSBvZiBXZWJLaXRCbG9iQnVpbGRlciB0byBldmVudHVhbGx5 IGRlcHJlY2F0ZSBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTA1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBoYXMgbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisg ICAgICAgICogYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkpTQmxvYkNvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU0Jsb2IpOgorICAgICAgICAqIGJpbmRpbmdz L3Y4L2N1c3RvbS9WOEJsb2JDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhCbG9iOjpj b25zdHJ1Y3RvckNhbGxiYWNrKToKKyAgICAgICAgKiBmaWxlYXBpL1dlYktpdEJsb2JCdWlsZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdEJsb2JCdWlsZGVyOjpnZXRCbG9iKToKKyAg ICAgICAgKiBmaWxlYXBpL1dlYktpdEJsb2JCdWlsZGVyLmg6CisgICAgICAgIChXZWJLaXRCbG9i QnVpbGRlcik6CisKIDIwMTItMDctMDMgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW50cm9kdWNlIFdvcmtzcGFjZSBtYWtl IGl0IFVJU291cmNlQ29kZSBwcm92aWRlciBmb3IgU2NyaXB0c1BhbmVsLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQmxvYkN1c3RvbS5jcHAKaW5kZXggNzM4NGY3M2ZjMzJjZDNhODU1 MzFlMzQ5YjY3Y2QzYzE4YWE2YWQxNS4uNmE5MTIyYzJlMzMzNWQ2NmQzNjZiMzU2NWIzNjg1MDFj OTg3OGQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3Vz dG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Jsb2JDdXN0b20uY3Bw CkBAIC0xMzYsNyArMTM2LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0Jsb2JD b25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNCbG9iKEV4ZWNTdGF0ZSogZXhlYykKICAgICAgICAgfQog ICAgIH0KIAotICAgIFJlZlB0cjxCbG9iPiBibG9iID0gYmxvYkJ1aWxkZXItPmdldEJsb2IodHlw ZSk7CisgICAgUmVmUHRyPEJsb2I+IGJsb2IgPSBibG9iQnVpbGRlci0+Z2V0QmxvYih0eXBlLCBC bG9iQ29uc3RydWN0ZWRCeUNvbnN0cnVjdG9yKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KENSRUFURV9ET01fV1JBUFBFUihleGVjLCBqc0NvbnN0cnVjdG9yLT5nbG9iYWxPYmplY3QoKSwg QmxvYiwgYmxvYi5nZXQoKSkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhCbG9iQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOEJsb2JDdXN0b20uY3BwCmluZGV4IGJhYzNiMGYyMDk1NGU5MDkzMDA5NmZi NTU3Y2ZlZmJiNzM3MGMyODYuLjVkZDM0OWM1MWY5ZDFiODkxNTQyZDRmODJhZTc2MWM3MDAxOWE0 ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEJsb2JD dXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEJsb2JD dXN0b20uY3BwCkBAIC0xMzksNyArMTM5LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4Qmxv Yjo6Y29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogICAgICAg ICB9CiAgICAgfQogCi0gICAgUmVmUHRyPEJsb2I+IGJsb2IgPSBibG9iQnVpbGRlci0+Z2V0Qmxv Yih0eXBlKTsKKyAgICBSZWZQdHI8QmxvYj4gYmxvYiA9IGJsb2JCdWlsZGVyLT5nZXRCbG9iKHR5 cGUsIEJsb2JDb25zdHJ1Y3RlZEJ5Q29uc3RydWN0b3IpOwogICAgIHJldHVybiB0b1Y4KGJsb2Iu Z2V0KCksIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZmlsZWFwaS9XZWJLaXRCbG9iQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBp L1dlYktpdEJsb2JCdWlsZGVyLmNwcAppbmRleCA1ZjdhODU4ZjQwMGNmODc3ZjQ2ZDMyNzJmNWM3 MWNkOGE5M2M1Y2I3Li5iMDA0ODdjZDI2ZTVkYzc5NjdiYTM4NTA5OGE4YzQzZGNlODAxM2JjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL1dlYktpdEJsb2JCdWlsZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL1dlYktpdEJsb2JCdWlsZGVyLmNwcApAQCAtMzUs NiArMzUsNyBAQAogI2luY2x1ZGUgIkJsb2IuaCIKICNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgi CiAjaW5jbHVkZSAiRmlsZS5oIgorI2luY2x1ZGUgIkhpc3RvZ3JhbVN1cHBvcnQuaCIKICNpbmNs dWRlICJMaW5lRW5kaW5nLmgiCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgog I2luY2x1ZGUgIlRleHRFbmNvZGluZy5oIgpAQCAtMTQxLDggKzE0MiwxMCBAQCB2b2lkIFdlYktp dEJsb2JCdWlsZGVyOjphcHBlbmQoQmxvYiogYmxvYikKICAgICB9CiB9CiAKLVBhc3NSZWZQdHI8 QmxvYj4gV2ViS2l0QmxvYkJ1aWxkZXI6OmdldEJsb2IoY29uc3QgU3RyaW5nJiBjb250ZW50VHlw ZSkKK1Bhc3NSZWZQdHI8QmxvYj4gV2ViS2l0QmxvYkJ1aWxkZXI6OmdldEJsb2IoY29uc3QgU3Ry aW5nJiBjb250ZW50VHlwZSwgQmxvYkNvbnN0cnVjdGlvblJlYXNvbiBjb25zdHJ1Y3Rpb25SZWFz b24pCiB7CisgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIldlYkNv cmUuQmxvYkJ1aWxkZXIuZ2V0QmxvYiIsIGNvbnN0cnVjdGlvblJlYXNvbiwgQmxvYkNvbnN0cnVj dGlvblJlYXNvbk1heCk7CisKICAgICBPd25QdHI8QmxvYkRhdGE+IGJsb2JEYXRhID0gQmxvYkRh dGE6OmNyZWF0ZSgpOwogICAgIGJsb2JEYXRhLT5zZXRDb250ZW50VHlwZShjb250ZW50VHlwZSk7 CiAgICAgYmxvYkRhdGEtPnN3YXBJdGVtcyhtX2l0ZW1zKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2ZpbGVhcGkvV2ViS2l0QmxvYkJ1aWxkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVh cGkvV2ViS2l0QmxvYkJ1aWxkZXIuaAppbmRleCBiNzhjN2E2OTY4YzdjODkzZmQ3OGI4MTBhOTk0 NThmY2JjNzkyY2E2Li43YmYyOTY0MWQxODBlOTI1OTI2YWJhNDIwNzExNjdiMjQ5NzA0NzlmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL1dlYktpdEJsb2JCdWlsZGVyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9XZWJLaXRCbG9iQnVpbGRlci5oCkBAIC00Myw2ICs0 MywxMiBAQCBjbGFzcyBUZXh0RW5jb2Rpbmc7CiAKIHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7 CiAKK2VudW0gQmxvYkNvbnN0cnVjdGlvblJlYXNvbiB7CisgICAgQmxvYkNvbnN0cnVjdGVkQnlC bG9iQnVpbGRlciwKKyAgICBCbG9iQ29uc3RydWN0ZWRCeUNvbnN0cnVjdG9yLAorICAgIEJsb2JD b25zdHJ1Y3Rpb25SZWFzb25NYXgsCit9OworCiBjbGFzcyBXZWJLaXRCbG9iQnVpbGRlciA6IHB1 YmxpYyBSZWZDb3VudGVkPFdlYktpdEJsb2JCdWlsZGVyPiB7CiBwdWJsaWM6CiAgICAgLy8gQ2Fs bGVkIHdoZW4gQmxvYkJ1aWxkZXIgaXMgaW5zdGFudGlhdGVkIGluIEpTIEFQSS4gV2Ugc2hvdyBk ZXByZWNhdGUgd2FybmluZyBtZXNzYWdlLgpAQCAtNTksNyArNjUsNyBAQCBwdWJsaWM6CiAgICAg dm9pZCBhcHBlbmQoQXJyYXlCdWZmZXJWaWV3Kik7CiAjZW5kaWYKIAotICAgIFBhc3NSZWZQdHI8 QmxvYj4gZ2V0QmxvYihjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlID0gU3RyaW5nKCkpOworICAg IFBhc3NSZWZQdHI8QmxvYj4gZ2V0QmxvYihjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlID0gU3Ry aW5nKCksIEJsb2JDb25zdHJ1Y3Rpb25SZWFzb24gPSBCbG9iQ29uc3RydWN0ZWRCeUJsb2JCdWls ZGVyKTsKIAogcHJpdmF0ZToKICAgICBXZWJLaXRCbG9iQnVpbGRlcigpOwo=