90525 2012-07-04 00:58:32 -0700 [EFL] Simplify runTest function by defining default arguments. 2012-07-09 04:36:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 68509 1 k.czech k.czech cshu g.czajkowski gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 662725 0 k.czech 2012-07-04 00:58:32 -0700 Default arguments will simplify macro RUN_TEST. Function will only have one mandatory argument, callback test function. 662733 1 150734 k.czech 2012-07-04 01:04:11 -0700 Created attachment 150734 [EFL] Modified runTest function by added two default arguments. Callback set to "load,finished" and data argument set to 0. 662761 2 gyuyoung.kim 2012-07-04 01:58:53 -0700 From the viewpoint of reducing parameter, looks fine. BTW, generally, we don't write bug title to description field. 662763 3 150734 gyuyoung.kim 2012-07-04 01:59:09 -0700 Comment on attachment 150734 [EFL] Modified runTest function by added two default arguments. Callback set to "load,finished" and data argument set to 0. View in context: https://bugs.webkit.org/attachment.cgi?id=150734&action=review > Source/WebKit/efl/tests/test_ewk_view.cpp:30 > +static void ewkViewEditableGetCb(void* eventInfo, Evas_Object* o, void* data) I think it is good to mention this change to ChangeLog as well. 662937 4 150793 k.czech 2012-07-04 07:43:14 -0700 Created attachment 150793 Modified runTest function, added default arguments. Updating unit tests 663295 5 150793 gyuyoung.kim 2012-07-04 21:45:53 -0700 Comment on attachment 150793 Modified runTest function, added default arguments. Updating unit tests Looks fine. 663327 6 g.czajkowski 2012-07-04 23:19:17 -0700 LGTM. 663480 7 tmpsantos 2012-07-05 04:21:41 -0700 LGTM - 1 nit. The only thing I don't like is the title of this bug and the ChangeLog. I would use something like: [EFL] Simplify runTest by defining default arguments 664201 8 150793 cshu 2012-07-06 10:55:19 -0700 Comment on attachment 150793 Modified runTest function, added default arguments. Updating unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=150793&action=review > Source/WebKit/efl/ChangeLog:3 > + [EFL] Modified runTest function by added two default arguments. Callback set to "load,finished" and data argument set to 0. I prefer the title of the bug to describe what's broken or what's missing instead of what's done in the patch. 664770 9 151223 k.czech 2012-07-09 03:29:11 -0700 Created attachment 151223 [EFL] Simplify runTest function. 664801 10 151223 webkit.review.bot 2012-07-09 04:36:52 -0700 Comment on attachment 151223 [EFL] Simplify runTest function. Clearing flags on attachment: 151223 Committed r122102: <http://trac.webkit.org/changeset/122102> 664802 11 webkit.review.bot 2012-07-09 04:36:58 -0700 All reviewed patches have been landed. Closing bug. 150734 2012-07-04 01:04:11 -0700 2012-07-04 07:43:14 -0700 [EFL] Modified runTest function by added two default arguments. Callback set to "load,finished" and data argument set to 0. ut-patch-update.patch text/plain 3270 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3ZGM5YTIyLi5iODUzM2RjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMDctMDMgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZpZWQgcnVuVGVzdCBmdW5jdGlvbiBieSBh ZGRlZCB0d28gZGVmYXVsdCBhcmd1bWVudHMuIENhbGxiYWNrIHNldCB0byAibG9hZCxmaW5pc2hl ZCIgYW5kIGRhdGEgYXJndW1lbnQgc2V0IHRvIDAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDUyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERlZmF1bHQgYXJndW1lbnRzIHdpbGwgc2ltcGxpZnkgbWFj cm8gUlVOX1RFU1QuCisgICAgICAgIEZ1bmN0aW9uIHdpbGwgb25seSBoYXZlIG9uZSBtYW5kYXRv cnkgYXJndW1lbnQsIGNhbGxiYWNrIHRlc3QgZnVuY3Rpb24uCisKKyAgICAgICAgKiB0ZXN0cy9V bml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmg6CisgICAgICAgIChFV0tUZXN0QmFzZSk6CisgICAg ICAgICogdGVzdHMvdGVzdF9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tWaWV3RWRpdGFibGVH ZXRDYik6CisgICAgICAgIChURVNUKToKKyAgICAgICAgKGV3a1ZpZXdVcmlHZXRDYik6CisKIDIw MTItMDctMDIgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRG8gbm90IGRvIGFueSBsb2dnaW5nIGluaXRpYWxpemF0aW9uIHdoZW4gbG9nZ2luZyBpcyBk aXNhYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvdGVzdHMvVW5pdFRlc3RVdGls cy9FV0tUZXN0QmFzZS5oIGIvU291cmNlL1dlYktpdC9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9F V0tUZXN0QmFzZS5oCmluZGV4IGMwZDM3NzYuLmZjMWQyNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLVGVzdEJhc2UuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmgKQEAgLTU5LDggKzU5 LDggQEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIHN0YXJ0VGVzdCgpOwogICAgIHN0YXRpYyB2 b2lkIGVuZFRlc3QoKTsKIAotICAgIHN0YXRpYyBib29sIHJ1blRlc3QoY29uc3QgY2hhciogdXJs LCB2b2lkICgqZXZlbnRfY2FsbGJhY2spKHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQqKSwgY29u c3QgY2hhciogZXZlbnRfbmFtZSwgdm9pZCogZXZlbnRfZGF0YSk7Ci0gICAgc3RhdGljIGJvb2wg cnVuVGVzdCh2b2lkICgqZXZlbnRfY2FsbGJhY2spKHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQq KSwgY29uc3QgY2hhciogZXZlbnRfbmFtZSwgdm9pZCogZXZlbnRfZGF0YSk7CisgICAgc3RhdGlj IGJvb2wgcnVuVGVzdChjb25zdCBjaGFyKiB1cmwsIHZvaWQgKCpldmVudF9jYWxsYmFjaykodm9p ZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCopLCBjb25zdCBjaGFyKiBldmVudF9uYW1lID0gImxvYWQs ZmluaXNoZWQiLCB2b2lkKiBldmVudF9kYXRhID0gMCk7CisgICAgc3RhdGljIGJvb2wgcnVuVGVz dCh2b2lkICgqZXZlbnRfY2FsbGJhY2spKHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQqKSwgY29u c3QgY2hhciogZXZlbnRfbmFtZSA9ICJsb2FkLGZpbmlzaGVkIiwgdm9pZCogZXZlbnRfZGF0YSA9 IDApOwogCiAgICAgc3RhdGljIGludCB1c2VYMTFXaW5kb3c7CiB9OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvdGVzdHMvdGVzdF9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC90ZXN0cy90ZXN0X2V3a192aWV3LmNwcAppbmRleCAyNGExYzg5Li4yZDQ5MDc5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC90ZXN0cy90ZXN0X2V3a192aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC90ZXN0cy90ZXN0X2V3a192aWV3LmNwcApAQCAtMjcsNyArMjcsNyBAQCB1 c2luZyBuYW1lc3BhY2UgRVdLVW5pdFRlc3RzOwogLyoqCiAqIEBicmllZiBDaGVja2luZyB3aGV0 aGVyIGZ1bmN0aW9uIHByb3Blcmx5IHJldHVybnMgY29ycmVjdCB2YWx1ZS4KICovCi12b2lkIGV3 a1ZpZXdFZGl0YWJsZUdldENiKHZvaWQqIGV2ZW50SW5mbywgRXZhc19PYmplY3QqIG8sIHZvaWQq IGRhdGEpCitzdGF0aWMgdm9pZCBld2tWaWV3RWRpdGFibGVHZXRDYih2b2lkKiBldmVudEluZm8s IEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQogewogICAgIGV3a192aWV3X2VkaXRhYmxlX3Nl dChvLCBFSU5BX0ZBTFNFKTsKICAgICBFWFBFQ1RfRVEoRUlOQV9GQUxTRSwgZXdrX3ZpZXdfZWRp dGFibGVfZ2V0KG8pKTsKQEAgLTM2LDEzICszNiwxMyBAQCB2b2lkIGV3a1ZpZXdFZGl0YWJsZUdl dENiKHZvaWQqIGV2ZW50SW5mbywgRXZhc19PYmplY3QqIG8sIHZvaWQqIGRhdGEpCiAKIFRFU1Qo dGVzdF9ld2tfdmlldywgZXdrX3ZpZXdfZWRpdGFibGVfZ2V0KQogewotICAgIFJVTl9URVNUKGV3 a1ZpZXdFZGl0YWJsZUdldENiLCAibG9hZCxmaW5pc2hlZCIsIDApOworICAgIFJVTl9URVNUKGV3 a1ZpZXdFZGl0YWJsZUdldENiKTsKIH0KIAogLyoqCiAqIEBicmllZiBDaGVja2luZyB3aGV0aGVy IGZ1bmN0aW9uIHJldHVybnMgY29ycmVjdCB1cmkgc3RyaW5nLgogKi8KLXZvaWQgZXdrVmlld1Vy aUdldENiKHZvaWQqIGV2ZW50SW5mbywgRXZhc19PYmplY3QqIG8sIHZvaWQqIGRhdGEpCitzdGF0 aWMgdm9pZCBld2tWaWV3VXJpR2V0Q2Iodm9pZCogZXZlbnRJbmZvLCBFdmFzX09iamVjdCogbywg dm9pZCogZGF0YSkKIHsKICAgICBFWFBFQ1RfU1RSRVEoImh0dHA6Ly93d3cud2Via2l0Lm9yZy8i LCBld2tfdmlld191cmlfZ2V0KG8pKTsKICAgICBFTkRfVEVTVCgpOwpAQCAtNTAsNSArNTAsNSBA QCB2b2lkIGV3a1ZpZXdVcmlHZXRDYih2b2lkKiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2 b2lkKiBkYXRhKQogCiBURVNUKHRlc3RfZXdrX3ZpZXcsIGV3a192aWV3X3VyaV9nZXQpCiB7Ci0g ICAgUlVOX1RFU1QoImh0dHA6Ly93d3cud2Via2l0Lm9yZyIsIGV3a1ZpZXdVcmlHZXRDYiwgImxv YWQsZmluaXNoZWQiLCAwKTsKKyAgICBSVU5fVEVTVCgiaHR0cDovL3d3dy53ZWJraXQub3JnIiwg ZXdrVmlld1VyaUdldENiKTsKIH0K 150793 2012-07-04 07:43:14 -0700 2012-07-09 03:29:11 -0700 Modified runTest function, added default arguments. Updating unit tests ut-patch-update.patch text/plain 3325 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3ZGM5YTIyLi5kNzcwN2YzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMDMgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZpZWQgcnVuVGVzdCBmdW5jdGlvbiBieSBh ZGRlZCB0d28gZGVmYXVsdCBhcmd1bWVudHMuIENhbGxiYWNrIHNldCB0byAibG9hZCxmaW5pc2hl ZCIgYW5kIGRhdGEgYXJndW1lbnQgc2V0IHRvIDAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDUyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERlZmF1bHQgYXJndW1lbnRzIHdpbGwgc2ltcGxpZnkgbWFj cm8gUlVOX1RFU1QuCisgICAgICAgIEZ1bmN0aW9uIHdpbGwgb25seSBoYXZlIG9uZSBtYW5kYXRv cnkgYXJndW1lbnQsIGNhbGxiYWNrIHRlc3QgZnVuY3Rpb24uCisgICAgICAgIEFkZGVkIHN0YXRp YyBtb2RpZmllcnMgdG8gY2FsbGJhY2sgZnVuY3Rpb25zLgorCisgICAgICAgICogdGVzdHMvVW5p dFRlc3RVdGlscy9FV0tUZXN0QmFzZS5oOgorICAgICAgICAoRVdLVGVzdEJhc2UpOgorICAgICAg ICAqIHRlc3RzL3Rlc3RfZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrVmlld0VkaXRhYmxlR2V0 Q2IpOgorICAgICAgICAoVEVTVCk6CisgICAgICAgIChld2tWaWV3VXJpR2V0Q2IpOgorCiAyMDEy LTA3LTAyICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAg IERvIG5vdCBkbyBhbnkgbG9nZ2luZyBpbml0aWFsaXphdGlvbiB3aGVuIGxvZ2dpbmcgaXMgZGlz YWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMv RVdLVGVzdEJhc2UuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdL VGVzdEJhc2UuaAppbmRleCBjMGQzNzc2Li5mYzFkMjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmgKKysrIGIvU291cmNlL1dl YktpdC9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0tUZXN0QmFzZS5oCkBAIC01OSw4ICs1OSw4 IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgdm9pZCBzdGFydFRlc3QoKTsKICAgICBzdGF0aWMgdm9p ZCBlbmRUZXN0KCk7CiAKLSAgICBzdGF0aWMgYm9vbCBydW5UZXN0KGNvbnN0IGNoYXIqIHVybCwg dm9pZCAoKmV2ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiksIGNvbnN0 IGNoYXIqIGV2ZW50X25hbWUsIHZvaWQqIGV2ZW50X2RhdGEpOwotICAgIHN0YXRpYyBib29sIHJ1 blRlc3Qodm9pZCAoKmV2ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiks IGNvbnN0IGNoYXIqIGV2ZW50X25hbWUsIHZvaWQqIGV2ZW50X2RhdGEpOworICAgIHN0YXRpYyBi b29sIHJ1blRlc3QoY29uc3QgY2hhciogdXJsLCB2b2lkICgqZXZlbnRfY2FsbGJhY2spKHZvaWQq LCBFdmFzX09iamVjdCosIHZvaWQqKSwgY29uc3QgY2hhciogZXZlbnRfbmFtZSA9ICJsb2FkLGZp bmlzaGVkIiwgdm9pZCogZXZlbnRfZGF0YSA9IDApOworICAgIHN0YXRpYyBib29sIHJ1blRlc3Qo dm9pZCAoKmV2ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiksIGNvbnN0 IGNoYXIqIGV2ZW50X25hbWUgPSAibG9hZCxmaW5pc2hlZCIsIHZvaWQqIGV2ZW50X2RhdGEgPSAw KTsKIAogICAgIHN0YXRpYyBpbnQgdXNlWDExV2luZG93OwogfTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL3Rlc3RzL3Rlc3RfZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv dGVzdHMvdGVzdF9ld2tfdmlldy5jcHAKaW5kZXggMjRhMWM4OS4uMmQ0OTA3OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9lZmwvdGVzdHMvdGVzdF9ld2tfdmlldy5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvdGVzdHMvdGVzdF9ld2tfdmlldy5jcHAKQEAgLTI3LDcgKzI3LDcgQEAgdXNp bmcgbmFtZXNwYWNlIEVXS1VuaXRUZXN0czsKIC8qKgogKiBAYnJpZWYgQ2hlY2tpbmcgd2hldGhl ciBmdW5jdGlvbiBwcm9wZXJseSByZXR1cm5zIGNvcnJlY3QgdmFsdWUuCiAqLwotdm9pZCBld2tW aWV3RWRpdGFibGVHZXRDYih2b2lkKiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBk YXRhKQorc3RhdGljIHZvaWQgZXdrVmlld0VkaXRhYmxlR2V0Q2Iodm9pZCogZXZlbnRJbmZvLCBF dmFzX09iamVjdCogbywgdm9pZCogZGF0YSkKIHsKICAgICBld2tfdmlld19lZGl0YWJsZV9zZXQo bywgRUlOQV9GQUxTRSk7CiAgICAgRVhQRUNUX0VRKEVJTkFfRkFMU0UsIGV3a192aWV3X2VkaXRh YmxlX2dldChvKSk7CkBAIC0zNiwxMyArMzYsMTMgQEAgdm9pZCBld2tWaWV3RWRpdGFibGVHZXRD Yih2b2lkKiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQogCiBURVNUKHRl c3RfZXdrX3ZpZXcsIGV3a192aWV3X2VkaXRhYmxlX2dldCkKIHsKLSAgICBSVU5fVEVTVChld2tW aWV3RWRpdGFibGVHZXRDYiwgImxvYWQsZmluaXNoZWQiLCAwKTsKKyAgICBSVU5fVEVTVChld2tW aWV3RWRpdGFibGVHZXRDYik7CiB9CiAKIC8qKgogKiBAYnJpZWYgQ2hlY2tpbmcgd2hldGhlciBm dW5jdGlvbiByZXR1cm5zIGNvcnJlY3QgdXJpIHN0cmluZy4KICovCi12b2lkIGV3a1ZpZXdVcmlH ZXRDYih2b2lkKiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQorc3RhdGlj IHZvaWQgZXdrVmlld1VyaUdldENiKHZvaWQqIGV2ZW50SW5mbywgRXZhc19PYmplY3QqIG8sIHZv aWQqIGRhdGEpCiB7CiAgICAgRVhQRUNUX1NUUkVRKCJodHRwOi8vd3d3LndlYmtpdC5vcmcvIiwg ZXdrX3ZpZXdfdXJpX2dldChvKSk7CiAgICAgRU5EX1RFU1QoKTsKQEAgLTUwLDUgKzUwLDUgQEAg dm9pZCBld2tWaWV3VXJpR2V0Q2Iodm9pZCogZXZlbnRJbmZvLCBFdmFzX09iamVjdCogbywgdm9p ZCogZGF0YSkKIAogVEVTVCh0ZXN0X2V3a192aWV3LCBld2tfdmlld191cmlfZ2V0KQogewotICAg IFJVTl9URVNUKCJodHRwOi8vd3d3LndlYmtpdC5vcmciLCBld2tWaWV3VXJpR2V0Q2IsICJsb2Fk LGZpbmlzaGVkIiwgMCk7CisgICAgUlVOX1RFU1QoImh0dHA6Ly93d3cud2Via2l0Lm9yZyIsIGV3 a1ZpZXdVcmlHZXRDYik7CiB9Cg== 151223 2012-07-09 03:29:11 -0700 2012-07-09 04:36:52 -0700 [EFL] Simplify runTest function. ut-patch-update.patch text/plain 3259 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3ZGM5YTIyLi42OTdkOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMDMgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gU2ltcGxpZnkgcnVuVGVzdCBmdW5jdGlvbiBieSBk ZWZpbmluZyBkZWZhdWx0IGFyZ3VtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTkwNTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hhbmcgU2h1 LgorCisgICAgICAgIERlZmF1bHQgYXJndW1lbnRzIHdpbGwgc2ltcGxpZnkgbWFjcm8gUlVOX1RF U1QuCisgICAgICAgIEZ1bmN0aW9uIHdpbGwgb25seSBoYXZlIG9uZSBtYW5kYXRvcnkgYXJndW1l bnQsIGNhbGxiYWNrIHRlc3QgZnVuY3Rpb24uCisgICAgICAgIEFkZGVkIHN0YXRpYyBtb2RpZmll cnMgdG8gY2FsbGJhY2sgZnVuY3Rpb25zLgorCisgICAgICAgICogdGVzdHMvVW5pdFRlc3RVdGls cy9FV0tUZXN0QmFzZS5oOgorICAgICAgICAoRVdLVGVzdEJhc2UpOgorICAgICAgICAqIHRlc3Rz L3Rlc3RfZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrVmlld0VkaXRhYmxlR2V0Q2IpOgorICAg ICAgICAoVEVTVCk6CisgICAgICAgIChld2tWaWV3VXJpR2V0Q2IpOgorCiAyMDEyLTA3LTAyICBC ZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIERvIG5vdCBk byBhbnkgbG9nZ2luZyBpbml0aWFsaXphdGlvbiB3aGVuIGxvZ2dpbmcgaXMgZGlzYWJsZWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLVGVzdEJh c2UuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLVGVzdEJhc2Uu aAppbmRleCBjMGQzNzc2Li5mYzFkMjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC90 ZXN0cy9Vbml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwv dGVzdHMvVW5pdFRlc3RVdGlscy9FV0tUZXN0QmFzZS5oCkBAIC01OSw4ICs1OSw4IEBAIHB1Ymxp YzoKICAgICBzdGF0aWMgdm9pZCBzdGFydFRlc3QoKTsKICAgICBzdGF0aWMgdm9pZCBlbmRUZXN0 KCk7CiAKLSAgICBzdGF0aWMgYm9vbCBydW5UZXN0KGNvbnN0IGNoYXIqIHVybCwgdm9pZCAoKmV2 ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiksIGNvbnN0IGNoYXIqIGV2 ZW50X25hbWUsIHZvaWQqIGV2ZW50X2RhdGEpOwotICAgIHN0YXRpYyBib29sIHJ1blRlc3Qodm9p ZCAoKmV2ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiksIGNvbnN0IGNo YXIqIGV2ZW50X25hbWUsIHZvaWQqIGV2ZW50X2RhdGEpOworICAgIHN0YXRpYyBib29sIHJ1blRl c3QoY29uc3QgY2hhciogdXJsLCB2b2lkICgqZXZlbnRfY2FsbGJhY2spKHZvaWQqLCBFdmFzX09i amVjdCosIHZvaWQqKSwgY29uc3QgY2hhciogZXZlbnRfbmFtZSA9ICJsb2FkLGZpbmlzaGVkIiwg dm9pZCogZXZlbnRfZGF0YSA9IDApOworICAgIHN0YXRpYyBib29sIHJ1blRlc3Qodm9pZCAoKmV2 ZW50X2NhbGxiYWNrKSh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiksIGNvbnN0IGNoYXIqIGV2 ZW50X25hbWUgPSAibG9hZCxmaW5pc2hlZCIsIHZvaWQqIGV2ZW50X2RhdGEgPSAwKTsKIAogICAg IHN0YXRpYyBpbnQgdXNlWDExV2luZG93OwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv ZWZsL3Rlc3RzL3Rlc3RfZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvdGVzdHMvdGVz dF9ld2tfdmlldy5jcHAKaW5kZXggMjRhMWM4OS4uMmQ0OTA3OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvdGVzdHMvdGVzdF9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvdGVzdHMvdGVzdF9ld2tfdmlldy5jcHAKQEAgLTI3LDcgKzI3LDcgQEAgdXNpbmcgbmFtZXNw YWNlIEVXS1VuaXRUZXN0czsKIC8qKgogKiBAYnJpZWYgQ2hlY2tpbmcgd2hldGhlciBmdW5jdGlv biBwcm9wZXJseSByZXR1cm5zIGNvcnJlY3QgdmFsdWUuCiAqLwotdm9pZCBld2tWaWV3RWRpdGFi bGVHZXRDYih2b2lkKiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQorc3Rh dGljIHZvaWQgZXdrVmlld0VkaXRhYmxlR2V0Q2Iodm9pZCogZXZlbnRJbmZvLCBFdmFzX09iamVj dCogbywgdm9pZCogZGF0YSkKIHsKICAgICBld2tfdmlld19lZGl0YWJsZV9zZXQobywgRUlOQV9G QUxTRSk7CiAgICAgRVhQRUNUX0VRKEVJTkFfRkFMU0UsIGV3a192aWV3X2VkaXRhYmxlX2dldChv KSk7CkBAIC0zNiwxMyArMzYsMTMgQEAgdm9pZCBld2tWaWV3RWRpdGFibGVHZXRDYih2b2lkKiBl dmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQogCiBURVNUKHRlc3RfZXdrX3Zp ZXcsIGV3a192aWV3X2VkaXRhYmxlX2dldCkKIHsKLSAgICBSVU5fVEVTVChld2tWaWV3RWRpdGFi bGVHZXRDYiwgImxvYWQsZmluaXNoZWQiLCAwKTsKKyAgICBSVU5fVEVTVChld2tWaWV3RWRpdGFi bGVHZXRDYik7CiB9CiAKIC8qKgogKiBAYnJpZWYgQ2hlY2tpbmcgd2hldGhlciBmdW5jdGlvbiBy ZXR1cm5zIGNvcnJlY3QgdXJpIHN0cmluZy4KICovCi12b2lkIGV3a1ZpZXdVcmlHZXRDYih2b2lk KiBldmVudEluZm8sIEV2YXNfT2JqZWN0KiBvLCB2b2lkKiBkYXRhKQorc3RhdGljIHZvaWQgZXdr Vmlld1VyaUdldENiKHZvaWQqIGV2ZW50SW5mbywgRXZhc19PYmplY3QqIG8sIHZvaWQqIGRhdGEp CiB7CiAgICAgRVhQRUNUX1NUUkVRKCJodHRwOi8vd3d3LndlYmtpdC5vcmcvIiwgZXdrX3ZpZXdf dXJpX2dldChvKSk7CiAgICAgRU5EX1RFU1QoKTsKQEAgLTUwLDUgKzUwLDUgQEAgdm9pZCBld2tW aWV3VXJpR2V0Q2Iodm9pZCogZXZlbnRJbmZvLCBFdmFzX09iamVjdCogbywgdm9pZCogZGF0YSkK IAogVEVTVCh0ZXN0X2V3a192aWV3LCBld2tfdmlld191cmlfZ2V0KQogewotICAgIFJVTl9URVNU KCJodHRwOi8vd3d3LndlYmtpdC5vcmciLCBld2tWaWV3VXJpR2V0Q2IsICJsb2FkLGZpbmlzaGVk IiwgMCk7CisgICAgUlVOX1RFU1QoImh0dHA6Ly93d3cud2Via2l0Lm9yZyIsIGV3a1ZpZXdVcmlH ZXRDYik7CiB9Cg==