90505 2012-07-03 16:20:52 -0700 Set the access qualifier of two methods to query frame specific info of BitmapImage to protected. 2012-08-12 05:13:15 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned ap darin eric noel.gordon webkit.review.bot oldest_to_newest 662551 0 dongseong.hwang 2012-07-03 16:20:52 -0700 Set the access qualifier of two methods about querying frame specific info of BitmapImage protected. Following 4 methods are protected. size_t frameCount(); NativeImagePtr frameAtIndex(size_t); bool frameIsCompleteAtIndex(size_t); float frameDurationAtIndex(size_t); So, 2 methds also should be protected. bool frameHasAlphaAtIndex(size_t); ImageOrientation frameOrientationAtIndex(size_t); 662552 1 150688 dongseong.hwang 2012-07-03 16:23:11 -0700 Created attachment 150688 patch 662564 2 150689 dongseong.hwang 2012-07-03 16:34:55 -0700 Created attachment 150689 patch v.2 Correct grammar of title. 663122 3 ap 2012-07-04 13:00:11 -0700 Could you please elaborate why this needs to be done? Clearly, this is not a build fix. - bool hasAlpha = image->isBitmapImage() ? static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0) : true; + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; This looks suspicious - are frame 0 and current one the same? 664329 4 dongseong.hwang 2012-07-06 20:57:06 -0700 (In reply to comment #3) > Could you please elaborate why this needs to be done? Clearly, this is not a build fix. > > - bool hasAlpha = image->isBitmapImage() ? static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0) : true; > + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; > > This looks suspicious - are frame 0 and current one the same? PNG, JPEG, BMP, and WEBP's current is always 0. GIF and ICO can have an other integer as current index. It means that previous implementation has bug about alpha because the impl expects the alpha of image->nativeImageForCurrentFrame() is image->frameHasAlphaAtIndex(0). 664330 5 dongseong.hwang 2012-07-06 20:58:51 -0700 (In reply to comment #4) > (In reply to comment #3) > > Could you please elaborate why this needs to be done? Clearly, this is not a build fix. > > > > - bool hasAlpha = image->isBitmapImage() ? static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0) : true; > > + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; > > > > This looks suspicious - are frame 0 and current one the same? > > PNG, JPEG, BMP, and WEBP's current is always 0. > > GIF and ICO can have an other integer as current index. > > It means that previous implementation has bug about alpha because the impl expects the alpha of image->nativeImageForCurrentFrame() is image->frameHasAlphaAtIndex(0). Is it better that I comment it on Changelog or CPP file? 664349 6 ap 2012-07-06 23:50:05 -0700 > Is it better that I comment it on Changelog or CPP file? ChangeLog. As you're fixing a bug, the obvious question is - can it be tested? 664654 7 151186 dongseong.hwang 2012-07-08 22:45:31 -0700 Created attachment 151186 patch v.3 664658 8 dongseong.hwang 2012-07-08 22:56:04 -0700 (In reply to comment #6) > > Is it better that I comment it on Changelog or CPP file? > > ChangeLog. I added the explanation in ChangeLog. > > As you're fixing a bug, the obvious question is - can it be tested? Unfortunately, I could not verify my statement by test. I mentioned CG port possibly had a bug after reading code, not testing. I tried to make test it but it is hard to get the animated GIF that has the frame with alpha channel and another frame without alpha channel. And, most animated GIF is with alpha channel or without channel, not hybrid, so previous implementation rarely show the defect in real sites or tests. IMHO, changing frameHasAlphaAtIndex(0) to currentFrameHasAlpha() is proper and easy to understand, but if it is not enough due to the lack of test, I'll try to make the test again. 693224 9 151186 eric 2012-08-12 03:47:54 -0700 Comment on attachment 151186 patch v.3 View in context: https://bugs.webkit.org/attachment.cgi?id=151186&action=review > Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:103 > - bool hasAlpha = image->isBitmapImage() ? static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0) : true; > + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; Why is this the right thing for gif and other multi-frame images? 693225 10 151186 eric 2012-08-12 03:48:13 -0700 Comment on attachment 151186 patch v.3 View in context: https://bugs.webkit.org/attachment.cgi?id=151186&action=review >> Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:103 >> + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; > > Why is this the right thing for gif and other multi-frame images? Do we end up using the current frame anyway? 693227 11 151186 eric 2012-08-12 03:48:40 -0700 Comment on attachment 151186 patch v.3 View in context: https://bugs.webkit.org/attachment.cgi?id=151186&action=review >>> Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:103 >>> + bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true; >> >> Why is this the right thing for gif and other multi-frame images? > > Do we end up using the current frame anyway? Ah, I've now read your ChangeLog, sorry. 693250 12 151186 webkit.review.bot 2012-08-12 05:13:11 -0700 Comment on attachment 151186 patch v.3 Clearing flags on attachment: 151186 Committed r125374: <http://trac.webkit.org/changeset/125374> 693251 13 webkit.review.bot 2012-08-12 05:13:15 -0700 All reviewed patches have been landed. Closing bug. 150688 2012-07-03 16:23:11 -0700 2012-07-03 16:34:55 -0700 patch 0001-Set-the-access-qualifier-of-two-methods-about-queryi.patch text/plain 4070 dongseong.hwang RnJvbSBlN2VlZDdkNzdjMWNjNTJiMjg0YzNiZjQ3Y2I2MzQ5N2MwZjQ3NDQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFR1ZSwgMyBKdWwgMjAxMiAyMTowNDozNSArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IFNldCB0aGUgYWNjZXNzIHF1YWxpZmllciBvZiB0d28gbWV0aG9kcyBhYm91dCBxdWVyeWluZyBm cmFtZQogc3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJbWFnZSBwcm90ZWN0ZWQuCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1MDUKCkZvbGxvd2luZyA0IG1ldGhvZHMg YXJlIHByb3RlY3RlZC4KICBzaXplX3QgZnJhbWVDb3VudCgpOwogIE5hdGl2ZUltYWdlUHRyIGZy YW1lQXRJbmRleChzaXplX3QpOwogIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChzaXplX3Qp OwogIGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CgpTbywgMiBtZXRoZHMgYWxz byBzaG91bGQgYmUgcHJvdGVjdGVkLgogIGJvb2wgZnJhbWVIYXNBbHBoYUF0SW5kZXgoc2l6ZV90 KTsKICBJbWFnZU9yaWVudGF0aW9uIGZyYW1lT3JpZW50YXRpb25BdEluZGV4KHNpemVfdCk7Ci0t LQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDI1ICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9CaXRtYXBJbWFnZS5oICAgICB8ICAgIDQgKystLQogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2Nn L0dyYXBoaWNzQ29udGV4dDNEQ0cuY3BwICAgfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDI4 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1NzE0YzEuLjFh MTIzMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMCBAQAogMjAxMi0wNy0wMyAgSHVhbmcgRG9u Z3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAorICAgICAgICBTZXQgdGhlIGFjY2Vz cyBxdWFsaWZpZXIgb2YgdHdvIG1ldGhvZHMgYWJvdXQgcXVlcnlpbmcgZnJhbWUgc3BlY2lmaWMg aW5mbyBvZgorICAgICAgICBCaXRtYXBJbWFnZSBwcm90ZWN0ZWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDUwNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvd2luZyA0IG1ldGhvZHMgYXJlIHBy b3RlY3RlZC4KKyAgICAgICAgICBzaXplX3QgZnJhbWVDb3VudCgpOworICAgICAgICAgIE5hdGl2 ZUltYWdlUHRyIGZyYW1lQXRJbmRleChzaXplX3QpOworICAgICAgICAgIGJvb2wgZnJhbWVJc0Nv bXBsZXRlQXRJbmRleChzaXplX3QpOworICAgICAgICAgIGZsb2F0IGZyYW1lRHVyYXRpb25BdElu ZGV4KHNpemVfdCk7CisKKyAgICAgICAgU28sIDIgbWV0aGRzIGFsc28gc2hvdWxkIGJlIHByb3Rl Y3RlZC4KKyAgICAgICAgICBib29sIGZyYW1lSGFzQWxwaGFBdEluZGV4KHNpemVfdCk7CisgICAg ICAgICAgSW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJbmRleChzaXplX3QpOwor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAgICAg IChCaXRtYXBJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3ND b250ZXh0M0RDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Z2V0 SW1hZ2VEYXRhKToKKworMjAxMi0wNy0wMyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21w YW55MTAwLm5ldD4KKwogICAgICAgICBBZGQgdmlydHVhbCBrZXl3b3JkIHRvIH5CaXRtYXBJbWFn ZSBhbmQgflN0aWxsSW1hZ2UgYmVjYXVzZSB+SW1hZ2UgaXMgdmlydHVhbC4KICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNDQ3CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCmluZGV4IDIxODg1Y2QuLmZi NWQ0MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1h cEltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1h Z2UuaApAQCAtMTY5LDExICsxNjksOSBAQCBwdWJsaWM6CiAjZW5kaWYKIAogICAgIHZpcnR1YWwg TmF0aXZlSW1hZ2VQdHIgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKLSAgICBib29sIGZy YW1lSGFzQWxwaGFBdEluZGV4KHNpemVfdCk7CiAgICAgdmlydHVhbCBib29sIGN1cnJlbnRGcmFt ZUhhc0FscGhhKCk7CiAKICAgICBJbWFnZU9yaWVudGF0aW9uIGN1cnJlbnRGcmFtZU9yaWVudGF0 aW9uKCk7Ci0gICAgSW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJbmRleChzaXpl X3QpOwogCiAjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIHZpcnR1YWwgYm9vbCBub3RTb2xpZENv bG9yKCk7CkBAIC0yMTEsNiArMjA5LDggQEAgcHJvdGVjdGVkOgogICAgIE5hdGl2ZUltYWdlUHRy IGZyYW1lQXRJbmRleChzaXplX3QpOwogICAgIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChz aXplX3QpOwogICAgIGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CisgICAgYm9v bCBmcmFtZUhhc0FscGhhQXRJbmRleChzaXplX3QpOworICAgIEltYWdlT3JpZW50YXRpb24gZnJh bWVPcmllbnRhdGlvbkF0SW5kZXgoc2l6ZV90KTsKIAogICAgIC8vIERlY29kZXMgYW5kIGNhY2hl cyBhIGZyYW1lLiBOZXZlciBhY2Nlc3NlZCBleGNlcHQgaW50ZXJuYWxseS4KICAgICB2b2lkIGNh Y2hlRnJhbWUoc2l6ZV90IGluZGV4KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dDNEQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKaW5kZXggZTA0NGI4 ZC4uNTNkNTNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKQEAgLTEwMCw3ICsxMDAsNyBAQCBi b29sIEdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbWFnZURhdGEoSW1hZ2UqIGltYWdlLAogICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgQ0dJbWFnZVJlZiBjZ0ltYWdlOwogICAgIFJldGFpblB0cjxD R0ltYWdlUmVmPiBkZWNvZGVkSW1hZ2U7Ci0gICAgYm9vbCBoYXNBbHBoYSA9IGltYWdlLT5pc0Jp dG1hcEltYWdlKCkgPyBzdGF0aWNfY2FzdDxCaXRtYXBJbWFnZSo+KGltYWdlKS0+ZnJhbWVIYXNB bHBoYUF0SW5kZXgoMCkgOiB0cnVlOworICAgIGJvb2wgaGFzQWxwaGEgPSBpbWFnZS0+aXNCaXRt YXBJbWFnZSgpID8gaW1hZ2UtPmN1cnJlbnRGcmFtZUhhc0FscGhhKCkgOiB0cnVlOwogICAgIGlm ICgoaWdub3JlR2FtbWFBbmRDb2xvclByb2ZpbGUgfHwgKGhhc0FscGhhICYmICFwcmVtdWx0aXBs eUFscGhhKSkgJiYgaW1hZ2UtPmRhdGEoKSkgewogICAgICAgICBJbWFnZVNvdXJjZSBkZWNvZGVy KEltYWdlU291cmNlOjpBbHBoYU5vdFByZW11bHRpcGxpZWQsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaWdub3JlR2FtbWFBbmRDb2xvclByb2ZpbGUgPyBJbWFnZVNvdXJjZTo6R2FtbWFB bmRDb2xvclByb2ZpbGVJZ25vcmVkIDogSW1hZ2VTb3VyY2U6OkdhbW1hQW5kQ29sb3JQcm9maWxl QXBwbGllZCk7Ci0tIAoxLjcuOS41Cgo= 150689 2012-07-03 16:34:55 -0700 2012-07-08 22:45:31 -0700 patch v.2 0001-Set-the-access-qualifier-of-two-methods-to-query-fra.patch text/plain 4064 dongseong.hwang RnJvbSA1MDZlZWEyODJjZTk3ZDYzZWMzMjE2MTViODg0MmM0MWM5ZmY4MDIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFR1ZSwgMyBKdWwgMjAxMiAyMTowNDozNSArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IFNldCB0aGUgYWNjZXNzIHF1YWxpZmllciBvZiB0d28gbWV0aG9kcyB0byBxdWVyeSBmcmFtZQog c3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJbWFnZSB0byBwcm90ZWN0ZWQuCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1MDUKCkZvbGxvd2luZyA0IG1ldGhvZHMgYXJl IHByb3RlY3RlZC4KICBzaXplX3QgZnJhbWVDb3VudCgpOwogIE5hdGl2ZUltYWdlUHRyIGZyYW1l QXRJbmRleChzaXplX3QpOwogIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChzaXplX3QpOwog IGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CgpTbywgMiBtZXRoZHMgYWxzbyBz aG91bGQgYmUgcHJvdGVjdGVkLgogIGJvb2wgZnJhbWVIYXNBbHBoYUF0SW5kZXgoc2l6ZV90KTsK ICBJbWFnZU9yaWVudGF0aW9uIGZyYW1lT3JpZW50YXRpb25BdEluZGV4KHNpemVfdCk7Ci0tLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDI1 ICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9C aXRtYXBJbWFnZS5oICAgICB8ICAgIDQgKystLQogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dy YXBoaWNzQ29udGV4dDNEQ0cuY3BwICAgfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDI4IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1NzE0YzEuLjc5NDhl ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMCBAQAogMjAxMi0wNy0wMyAgSHVhbmcgRG9uZ3N1 bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAorICAgICAgICBTZXQgdGhlIGFjY2VzcyBx dWFsaWZpZXIgb2YgdHdvIG1ldGhvZHMgdG8gcXVlcnkgZnJhbWUgc3BlY2lmaWMgaW5mbyBvZgor ICAgICAgICBCaXRtYXBJbWFnZSB0byBwcm90ZWN0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDUwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvd2luZyA0IG1ldGhvZHMgYXJlIHByb3RlY3Rl ZC4KKyAgICAgICAgICBzaXplX3QgZnJhbWVDb3VudCgpOworICAgICAgICAgIE5hdGl2ZUltYWdl UHRyIGZyYW1lQXRJbmRleChzaXplX3QpOworICAgICAgICAgIGJvb2wgZnJhbWVJc0NvbXBsZXRl QXRJbmRleChzaXplX3QpOworICAgICAgICAgIGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNp emVfdCk7CisKKyAgICAgICAgU28sIDIgbWV0aGRzIGFsc28gc2hvdWxkIGJlIHByb3RlY3RlZC4K KyAgICAgICAgICBib29sIGZyYW1lSGFzQWxwaGFBdEluZGV4KHNpemVfdCk7CisgICAgICAgICAg SW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJbmRleChzaXplX3QpOworCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlvci4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAgICAgIChCaXRt YXBJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0 M0RDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VE YXRhKToKKworMjAxMi0wNy0wMyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAw Lm5ldD4KKwogICAgICAgICBBZGQgdmlydHVhbCBrZXl3b3JkIHRvIH5CaXRtYXBJbWFnZSBhbmQg flN0aWxsSW1hZ2UgYmVjYXVzZSB+SW1hZ2UgaXMgdmlydHVhbC4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNDQ3CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCmluZGV4IDIxODg1Y2QuLmZiNWQ0MWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaApA QCAtMTY5LDExICsxNjksOSBAQCBwdWJsaWM6CiAjZW5kaWYKIAogICAgIHZpcnR1YWwgTmF0aXZl SW1hZ2VQdHIgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKLSAgICBib29sIGZyYW1lSGFz QWxwaGFBdEluZGV4KHNpemVfdCk7CiAgICAgdmlydHVhbCBib29sIGN1cnJlbnRGcmFtZUhhc0Fs cGhhKCk7CiAKICAgICBJbWFnZU9yaWVudGF0aW9uIGN1cnJlbnRGcmFtZU9yaWVudGF0aW9uKCk7 Ci0gICAgSW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJbmRleChzaXplX3QpOwog CiAjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIHZpcnR1YWwgYm9vbCBub3RTb2xpZENvbG9yKCk7 CkBAIC0yMTEsNiArMjA5LDggQEAgcHJvdGVjdGVkOgogICAgIE5hdGl2ZUltYWdlUHRyIGZyYW1l QXRJbmRleChzaXplX3QpOwogICAgIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChzaXplX3Qp OwogICAgIGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CisgICAgYm9vbCBmcmFt ZUhhc0FscGhhQXRJbmRleChzaXplX3QpOworICAgIEltYWdlT3JpZW50YXRpb24gZnJhbWVPcmll bnRhdGlvbkF0SW5kZXgoc2l6ZV90KTsKIAogICAgIC8vIERlY29kZXMgYW5kIGNhY2hlcyBhIGZy YW1lLiBOZXZlciBhY2Nlc3NlZCBleGNlcHQgaW50ZXJuYWxseS4KICAgICB2b2lkIGNhY2hlRnJh bWUoc2l6ZV90IGluZGV4KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dDNEQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKaW5kZXggZTA0NGI4ZC4uNTNk NTNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3Jh cGhpY3NDb250ZXh0M0RDRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKQEAgLTEwMCw3ICsxMDAsNyBAQCBib29sIEdy YXBoaWNzQ29udGV4dDNEOjpnZXRJbWFnZURhdGEoSW1hZ2UqIGltYWdlLAogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgQ0dJbWFnZVJlZiBjZ0ltYWdlOwogICAgIFJldGFpblB0cjxDR0ltYWdl UmVmPiBkZWNvZGVkSW1hZ2U7Ci0gICAgYm9vbCBoYXNBbHBoYSA9IGltYWdlLT5pc0JpdG1hcElt YWdlKCkgPyBzdGF0aWNfY2FzdDxCaXRtYXBJbWFnZSo+KGltYWdlKS0+ZnJhbWVIYXNBbHBoYUF0 SW5kZXgoMCkgOiB0cnVlOworICAgIGJvb2wgaGFzQWxwaGEgPSBpbWFnZS0+aXNCaXRtYXBJbWFn ZSgpID8gaW1hZ2UtPmN1cnJlbnRGcmFtZUhhc0FscGhhKCkgOiB0cnVlOwogICAgIGlmICgoaWdu b3JlR2FtbWFBbmRDb2xvclByb2ZpbGUgfHwgKGhhc0FscGhhICYmICFwcmVtdWx0aXBseUFscGhh KSkgJiYgaW1hZ2UtPmRhdGEoKSkgewogICAgICAgICBJbWFnZVNvdXJjZSBkZWNvZGVyKEltYWdl U291cmNlOjpBbHBoYU5vdFByZW11bHRpcGxpZWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaWdub3JlR2FtbWFBbmRDb2xvclByb2ZpbGUgPyBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xv clByb2ZpbGVJZ25vcmVkIDogSW1hZ2VTb3VyY2U6OkdhbW1hQW5kQ29sb3JQcm9maWxlQXBwbGll ZCk7Ci0tIAoxLjcuOS41Cgo= 151186 2012-07-08 22:45:31 -0700 2012-08-12 05:13:11 -0700 patch v.3 0001-Set-the-access-qualifier-of-two-methods-to-query-fra.patch text/plain 5365 dongseong.hwang RnJvbSBkZjUzNDkwN2M2MGUzYTk4Y2VlNGUwZWI0YzY2ZTk2YzkxZWI4Y2RhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFR1ZSwgMyBKdWwgMjAxMiAyMTowNDozNSArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IFNldCB0aGUgYWNjZXNzIHF1YWxpZmllciBvZiB0d28gbWV0aG9kcyB0byBxdWVyeSBmcmFtZQog c3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJbWFnZSB0byBwcm90ZWN0ZWQuCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1MDUKCkZvbGxvd2luZyA0IG1ldGhvZHMgYXJl IHByb3RlY3RlZC4KICBzaXplX3QgZnJhbWVDb3VudCgpOwogIE5hdGl2ZUltYWdlUHRyIGZyYW1l QXRJbmRleChzaXplX3QpOwogIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChzaXplX3QpOwog IGZsb2F0IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CgpTbywgMiBtZXRoZHMgYWxzbyBz aG91bGQgYmUgcHJvdGVjdGVkIGJlY2F1c2UgdGhlIGZyYW1lIGluZm8gaXMgb25seSBzcGVjaWZp YyBvZgpCaXRtYXBJbWFnZS4KICBib29sIGZyYW1lSGFzQWxwaGFBdEluZGV4KHNpemVfdCk7CiAg SW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJbmRleChzaXplX3QpOwoKT24gdGhl IG90aGVyIGhhbmQsIHRoaXMgcGF0Y2ggYW1lbmRlZCBHcmFwaGljc0NvbnRleHQzRENHLgotIHN0 YXRpY19jYXN0PEJpdG1hcEltYWdlKj4oaW1hZ2UpLT5mcmFtZUhhc0FscGhhQXRJbmRleCgwKQor IGltYWdlLT5jdXJyZW50RnJhbWVIYXNBbHBoYSgpCgpUaGlzIHBhdGNoIGRvZXMgbm90IGFmZmVj dCBQTkcsIEpQRUcsIEJNUCwgYW5kIFdFQlAgYmVjYXVzZSB0aG9zZSBpbWFnZXMKaGF2ZSBvbmx5 IDAgaW5kZXhlZCBmcmFtZS4KVGh1cywgR0lGLCBhbmQgSUNPIGFyZSBhZmZlY3RlZC4gSG93ZXZl ciwgYW4gYWJvdmUgcXVlcnkgdG8gZ2V0IEFscGhhCmlzIGZvciB0aGUgaW1hZ2UgdGhhdCBpcyBj cmVhdGVkIGJ5IGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLCBzbyBpdAppcyBw cm9wZXIgdG8gdXNlIGltYWdlLT5jdXJyZW50RnJhbWVIYXNBbHBoYSgpIGluc3RlYWQgb2YKaW1h Z2UtPmZyYW1lSGFzQWxwaGFBdEluZGV4KDApLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAzOCArKysrKysrKysrKysrKysrKysrKwog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaCAgICAgfCAgICA0 ICstLQogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dDNEQ0cuY3BwICAg fCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDI1MjVjZDYuLjMxOGFhMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSw0MSBAQAorMjAxMi0wNy0wOCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAw Lm5ldD4KKworICAgICAgICBTZXQgdGhlIGFjY2VzcyBxdWFsaWZpZXIgb2YgdHdvIG1ldGhvZHMg dG8gcXVlcnkgZnJhbWUgc3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJbWFnZSB0byBwcm90ZWN0ZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDUwNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvd2lu ZyA0IG1ldGhvZHMgYXJlIHByb3RlY3RlZC4KKyAgICAgICAgICBzaXplX3QgZnJhbWVDb3VudCgp OworICAgICAgICAgIE5hdGl2ZUltYWdlUHRyIGZyYW1lQXRJbmRleChzaXplX3QpOworICAgICAg ICAgIGJvb2wgZnJhbWVJc0NvbXBsZXRlQXRJbmRleChzaXplX3QpOworICAgICAgICAgIGZsb2F0 IGZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVfdCk7CisKKyAgICAgICAgU28sIDIgbWV0aGRzIGFs c28gc2hvdWxkIGJlIHByb3RlY3RlZCBiZWNhdXNlIHRoZSBmcmFtZSBpbmZvIGlzIG9ubHkgc3Bl Y2lmaWMgb2YKKyAgICAgICAgQml0bWFwSW1hZ2UuCisgICAgICAgICAgYm9vbCBmcmFtZUhhc0Fs cGhhQXRJbmRleChzaXplX3QpOworICAgICAgICAgIEltYWdlT3JpZW50YXRpb24gZnJhbWVPcmll bnRhdGlvbkF0SW5kZXgoc2l6ZV90KTsKKworICAgICAgICBPbiB0aGUgb3RoZXIgaGFuZCwgdGhp cyBwYXRjaCBhbWVuZGVkIEdyYXBoaWNzQ29udGV4dDNEQ0cuCisgICAgICAgIC0gc3RhdGljX2Nh c3Q8Qml0bWFwSW1hZ2UqPihpbWFnZSktPmZyYW1lSGFzQWxwaGFBdEluZGV4KDApCisgICAgICAg ICsgaW1hZ2UtPmN1cnJlbnRGcmFtZUhhc0FscGhhKCkKKworICAgICAgICBUaGlzIHBhdGNoIGRv ZXMgbm90IGFmZmVjdCBQTkcsIEpQRUcsIEJNUCwgYW5kIFdFQlAgYmVjYXVzZSB0aG9zZSBpbWFn ZXMKKyAgICAgICAgaGF2ZSBvbmx5IDAgaW5kZXhlZCBmcmFtZS4KKyAgICAgICAgVGh1cywgR0lG LCBhbmQgSUNPIGFyZSBhZmZlY3RlZC4gSG93ZXZlciwgYW4gYWJvdmUgcXVlcnkgdG8gZ2V0IEFs cGhhCisgICAgICAgIGlzIGZvciB0aGUgaW1hZ2UgdGhhdCBpcyBjcmVhdGVkIGJ5IGltYWdlLT5u YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLCBzbyBpdAorICAgICAgICBpcyBwcm9wZXIgdG8g dXNlIGltYWdlLT5jdXJyZW50RnJhbWVIYXNBbHBoYSgpIGluc3RlYWQgb2YKKyAgICAgICAgaW1h Z2UtPmZyYW1lSGFzQWxwaGFBdEluZGV4KDApLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSBpdCBpcyBoYXJkIHRvIHRlc3QuIFdlIG5lZWQgYW4gYW5pbWF0ZWQgR0lGIHRoYXQKKyAg ICAgICAgb25lIGZyYW1lIGhhcyBhbHBoYSBhbmQgYW5vdGhlciBmcmFtZSBkb2VzIG5vdCBoYXZl IGFscGhhLiBIb3dldmVyLCBJCisgICAgICAgIGNhbm5vdCBmaW5kIHRoZSBhbmltYXRlZCBHSUYg ZmlsZSB0aGF0IHN1ZmZpY2VzIHRoZSByZXF1aXJlbWVudC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAgICAgIChCaXRtYXBJbWFnZSk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKToKKwogMjAxMi0wNy0w OCAgVml2ZWsgR2FsYXRhZ2UgIDx2aXZla2dhbGF0YWdlQGdtYWlsLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5IHNob3VsZCBub3QgZ2VuZXJh dGUgc3RhdGVtZW50cyB3aXRoIG5vIGVmZmVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKaW5kZXggMjE4ODVjZC4uZmI1ZDQxYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCkBAIC0xNjksMTEg KzE2OSw5IEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgdmlydHVhbCBOYXRpdmVJbWFnZVB0ciBu YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOwotICAgIGJvb2wgZnJhbWVIYXNBbHBoYUF0SW5k ZXgoc2l6ZV90KTsKICAgICB2aXJ0dWFsIGJvb2wgY3VycmVudEZyYW1lSGFzQWxwaGEoKTsKIAog ICAgIEltYWdlT3JpZW50YXRpb24gY3VycmVudEZyYW1lT3JpZW50YXRpb24oKTsKLSAgICBJbWFn ZU9yaWVudGF0aW9uIGZyYW1lT3JpZW50YXRpb25BdEluZGV4KHNpemVfdCk7CiAKICNpZiAhQVNT RVJUX0RJU0FCTEVECiAgICAgdmlydHVhbCBib29sIG5vdFNvbGlkQ29sb3IoKTsKQEAgLTIxMSw2 ICsyMDksOCBAQCBwcm90ZWN0ZWQ6CiAgICAgTmF0aXZlSW1hZ2VQdHIgZnJhbWVBdEluZGV4KHNp emVfdCk7CiAgICAgYm9vbCBmcmFtZUlzQ29tcGxldGVBdEluZGV4KHNpemVfdCk7CiAgICAgZmxv YXQgZnJhbWVEdXJhdGlvbkF0SW5kZXgoc2l6ZV90KTsKKyAgICBib29sIGZyYW1lSGFzQWxwaGFB dEluZGV4KHNpemVfdCk7CisgICAgSW1hZ2VPcmllbnRhdGlvbiBmcmFtZU9yaWVudGF0aW9uQXRJ bmRleChzaXplX3QpOwogCiAgICAgLy8gRGVjb2RlcyBhbmQgY2FjaGVzIGEgZnJhbWUuIE5ldmVy IGFjY2Vzc2VkIGV4Y2VwdCBpbnRlcm5hbGx5LgogICAgIHZvaWQgY2FjaGVGcmFtZShzaXplX3Qg aW5kZXgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv R3JhcGhpY3NDb250ZXh0M0RDRy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jZy9HcmFwaGljc0NvbnRleHQzRENHLmNwcAppbmRleCBlMDQ0YjhkLi41M2Q1M2E5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRl eHQzRENHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFw aGljc0NvbnRleHQzRENHLmNwcApAQCAtMTAwLDcgKzEwMCw3IEBAIGJvb2wgR3JhcGhpY3NDb250 ZXh0M0Q6OmdldEltYWdlRGF0YShJbWFnZSogaW1hZ2UsCiAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICBDR0ltYWdlUmVmIGNnSW1hZ2U7CiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGRlY29k ZWRJbWFnZTsKLSAgICBib29sIGhhc0FscGhhID0gaW1hZ2UtPmlzQml0bWFwSW1hZ2UoKSA/IHN0 YXRpY19jYXN0PEJpdG1hcEltYWdlKj4oaW1hZ2UpLT5mcmFtZUhhc0FscGhhQXRJbmRleCgwKSA6 IHRydWU7CisgICAgYm9vbCBoYXNBbHBoYSA9IGltYWdlLT5pc0JpdG1hcEltYWdlKCkgPyBpbWFn ZS0+Y3VycmVudEZyYW1lSGFzQWxwaGEoKSA6IHRydWU7CiAgICAgaWYgKChpZ25vcmVHYW1tYUFu ZENvbG9yUHJvZmlsZSB8fCAoaGFzQWxwaGEgJiYgIXByZW11bHRpcGx5QWxwaGEpKSAmJiBpbWFn ZS0+ZGF0YSgpKSB7CiAgICAgICAgIEltYWdlU291cmNlIGRlY29kZXIoSW1hZ2VTb3VyY2U6OkFs cGhhTm90UHJlbXVsdGlwbGllZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZ25vcmVH YW1tYUFuZENvbG9yUHJvZmlsZSA/IEltYWdlU291cmNlOjpHYW1tYUFuZENvbG9yUHJvZmlsZUln bm9yZWQgOiBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclByb2ZpbGVBcHBsaWVkKTsKLS0gCjEu Ny45LjUKCg==