90448 2012-07-03 04:53:40 -0700 [EFL] Enable CSS variables support at compile time 2012-07-03 18:56:39 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 662129 0 cdumez 2012-07-03 04:53:40 -0700 We should turn on the CSS_VARIABLES flag at compile time. The feature is currently disabled by default at run-time but at least it can be enabled for testing. 662130 1 150584 cdumez 2012-07-03 04:58:33 -0700 Created attachment 150584 Patch FYI, there is no need to unskip the CSS Variables test cases because they are automatically skipped by checking for the CSSVariableValue symbol in the WebCore library. As a consequence, the tests will get unskipped automagically. 662634 2 150584 webkit.review.bot 2012-07-03 18:56:25 -0700 Comment on attachment 150584 Patch Clearing flags on attachment: 150584 Committed r121819: <http://trac.webkit.org/changeset/121819> 662635 3 webkit.review.bot 2012-07-03 18:56:39 -0700 All reviewed patches have been landed. Closing bug. 150584 2012-07-03 04:58:33 -0700 2012-07-03 18:56:25 -0700 Patch 90448_css_variables.patch text/plain 3067 cdumez ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlYWI3NGU4Li4wY2Y2MGJk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMDctMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KKworICAgICAgICBbRUZMXSBFbmFibGUgQ1NTIHZhcmlhYmxlcyBzdXBwb3J0IGF0IGNvbXBp bGUgdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU dXJuIG9uIENTU19WQVJJQUJMRVMgZmxhZyBieSBkZWZhdWx0IG9uIEVGTCBwb3J0LgorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisgICAgICAgICogU291cmNlL2Nt YWtlY29uZmlnLmguY21ha2U6CisKIDIwMTItMDctMDIgIEdlb3JnZSBTdGFpa29zICA8c3RhaWtv c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgc2NvcGVkIHN0eWxl IGZvciBCbGFja0JlcnJ5LgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCA3OWUyZWI0Li5iYTlkOGFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNzAsNiArNzAsNyBAQCBXRUJLSVRfT1BUSU9OX0JF R0lOKCkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9CQVRURVJZX1NU QVRVUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9CTE9CIE9O KQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19JTUFHRV9TRVQg T04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1NTX1ZBUklBQkxF UyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9EQVRBTElTVCBP TikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9EUkFHX1NVUFBPUlQg T04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRkFTVF9NT0JJTEVf U0NST0xMSU5HIE9OKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UgYi9T b3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCBhOTQ0OGJhLi44NmEzOGFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcu aC5jbWFrZQpAQCAtMTgsNiArMTgsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19CT1hf REVDT1JBVElPTl9CUkVBSwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19JTUFHRV9SRVNPTFVU SU9OCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX0lNQUdFX1NFVAorI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0NTU19WQVJJQUJMRVMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DVVNUT01fU0NIRU1F X0hBTkRMRVIKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9EQVRBTElTVAogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0RBVEFfVFJBTlNGRVJfSVRFTVMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzQ2YTM2Li5jZjg0NDVjIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTIt MDctMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMXSBFbmFibGUgQ1NTIHZhcmlhYmxlcyBzdXBwb3J0IGF0IGNvbXBpbGUgdGlt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA0NDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUdXJuIG9u IENTU19WQVJJQUJMRVMgZmxhZyBieSBkZWZhdWx0IG9uIEVGTCBwb3J0LgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtOgorCiAyMDEyLTA3LTAyICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRW5h YmxlIHNjb3BlZCBzdHlsZSBmb3IgQmxhY2tCZXJyeS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9G ZWF0dXJlTGlzdC5wbQppbmRleCAzZmI0NWY0Li4yMzViZDJjIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRwZXJsL0ZlYXR1cmVMaXN0LnBtCkBAIC0xNzUsNyArMTc1LDcgQEAgbXkgQGZlYXR1cmVzID0g KAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfQ1NTX1NIQURFUlMiLCBkZWZhdWx0ID0+IGlzQXBw bGVNYWNXZWJLaXQoKSwgdmFsdWUgPT4gXCRjc3NTaGFkZXJzU3VwcG9ydCB9LAogCiAgICAgeyBv cHRpb24gPT4gImNzcy12YXJpYWJsZXMiLCBkZXNjID0+ICJUb2dnbGUgQ1NTIFZhcmlhYmxlIHN1 cHBvcnQiLAotICAgICAgZGVmaW5lID0+ICJFTkFCTEVfQ1NTX1ZBUklBQkxFUyIsIGRlZmF1bHQg PT4gMCwgdmFsdWUgPT4gXCRjc3NWYXJpYWJsZXNTdXBwb3J0IH0sCisgICAgICBkZWZpbmUgPT4g IkVOQUJMRV9DU1NfVkFSSUFCTEVTIiwgZGVmYXVsdCA9PiBpc0VmbCgpLCB2YWx1ZSA9PiBcJGNz c1ZhcmlhYmxlc1N1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9uID0+ICJjdXN0b20tc2NoZW1lLWhh bmRsZXIiLCBkZXNjID0+ICJUb2dnbGUgQ3VzdG9tIFNjaGVtZSBIYW5kbGVyIHN1cHBvcnQiLAog ICAgICAgZGVmaW5lID0+ICJFTkFCTEVfQ1VTVE9NX1NDSEVNRV9IQU5ETEVSIiwgZGVmYXVsdCA9 PiAwLCB2YWx1ZSA9PiBcJGN1c3RvbVNjaGVtZUhhbmRsZXJTdXBwb3J0IH0sCg==