90447 2012-07-03 04:33:00 -0700 Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual. 2012-07-04 23:54:20 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned ap darin eric webkit.review.bot oldest_to_newest 662121 0 dongseong.hwang 2012-07-03 04:33:00 -0700 Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual. Other sub-Image classes explicitly specify virtual on the destructors. > grep "~.*Image(" `find -name "*.h"` ./graphics/BitmapImage.h: ~BitmapImage(); ./graphics/qt/StillImageQt.h: ~StillImage(); ./graphics/chromium/LayerTextureSubImage.h: ~LayerTextureSubImage(); <- not implement Image ./graphics/GeneratorGeneratedImage.h: virtual ~GeneratorGeneratedImage() ./graphics/Image.h: virtual ~Image(); ./graphics/cg/PDFDocumentImage.h: virtual ~PDFDocumentImage(); 662123 1 150581 dongseong.hwang 2012-07-03 04:34:50 -0700 Created attachment 150581 patch 663347 2 150581 webkit.review.bot 2012-07-04 23:54:16 -0700 Comment on attachment 150581 patch Clearing flags on attachment: 150581 Committed r121884: <http://trac.webkit.org/changeset/121884> 663348 3 webkit.review.bot 2012-07-04 23:54:20 -0700 All reviewed patches have been landed. Closing bug. 150581 2012-07-03 04:34:50 -0700 2012-07-04 23:54:16 -0700 patch 0001-Add-virtual-keyword-to-BitmapImage-and-StillImage-be.patch text/plain 2380 dongseong.hwang RnJvbSA4YWNkNTJkMjZlZmViYjUyYjNhMjc5NjQ2ZGExNmNiNGQ4ZjY3N2E3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFdlZCwgMjMgTWF5IDIwMTIgMTU6NDg6MjMgKzA5MDAKU3ViamVjdDogW1BBVENI XSBBZGQgdmlydHVhbCBrZXl3b3JkIHRvIH5CaXRtYXBJbWFnZSBhbmQgflN0aWxsSW1hZ2UgYmVj YXVzZQogfkltYWdlIGlzIHZpcnR1YWwuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTA0NDcKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oICAgICB8ICAgIDIgKy0KIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5oIHwgICAgMiArLQogMyBmaWxlcyBj aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBh MWM1MDUxLi5kNTcxNGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTItMDctMDMg IEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgQWRk IHZpcnR1YWwga2V5d29yZCB0byB+Qml0bWFwSW1hZ2UgYW5kIH5TdGlsbEltYWdlIGJlY2F1c2Ug fkltYWdlIGlzIHZpcnR1YWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MDQ0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAgICAg IChCaXRtYXBJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFn ZVF0Lmg6CisgICAgICAgIChTdGlsbEltYWdlKToKKworMjAxMi0wNy0wMyAgSHVhbmcgRG9uZ3N1 bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBBZGQgYSBjb21tZW50IGlu IG9yZGVyIHRvIGNsYXJpZnkgd2h5CiAgICAgICAgIEJpdG1hcEltYWdlOjpmcmFtZUhhc0FscGhh QXRJbmRleCByZXR1cm5zIHRydWUgYXMgZGVmYXVsdC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaAppbmRleCA2NGM4MWM3Li4yMTg4NWNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKQEAgLTExMiw3 ICsxMTIsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEJp dG1hcEltYWdlKG9ic2VydmVyKSk7CiAgICAgfQotICAgIH5CaXRtYXBJbWFnZSgpOworICAgIHZp cnR1YWwgfkJpdG1hcEltYWdlKCk7CiAgICAgCiAgICAgdmlydHVhbCBib29sIGlzQml0bWFwSW1h Z2UoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvU3RpbGxJbWFnZVF0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9TdGlsbEltYWdlUXQuaAppbmRleCAzNjgyNjZhLi4yNmRmNDcxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQuaApAQCAtNTgsNyAr NTgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgcHJpdmF0ZToKICAgICAgICAgU3RpbGxJ bWFnZShjb25zdCBRUGl4bWFwJiBwaXhtYXApOwogICAgICAgICBTdGlsbEltYWdlKGNvbnN0IFFQ aXhtYXAqIHBpeG1hcCk7Ci0gICAgICAgIH5TdGlsbEltYWdlKCk7CisgICAgICAgIHZpcnR1YWwg flN0aWxsSW1hZ2UoKTsKICAgICAgICAgCiAgICAgICAgIGNvbnN0IFFQaXhtYXAqIG1fcGl4bWFw OwogICAgICAgICBib29sIG1fb3duc1BpeG1hcDsKLS0gCjEuNy45LjUKCg==