90444 2012-07-03 04:09:12 -0700 Update unit test after r121724 2012-07-03 10:21:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 90413 1 ossy webkit-unassigned abarth dpranke galpeter kadam ojan ossy webkit.review.bot oldest_to_newest 662109 0 ossy 2012-07-03 04:09:12 -0700 http://trac.webkit.org/changeset/121724 broke the following unittest: FAILURE: webkitpy.tool.servers.gardeningserver_unittest.GardeningServerTest.test_rebaseline_new_port -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 205, in test_rebaseline_new_port self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 178, in _post_to_path OutputCapture().assert_outputs(self, handler.do_POST, expected_stderr=expected_stderr, expected_stdout=expected_stdout) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 94, in assert_outputs testcase.assertEqual(stderr_string, expected_stderr) AssertionError: 'MOCK run_command: [\'echo\', \'rebaseline-json\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n' != 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n' 662115 1 galpeter 2012-07-03 04:21:18 -0700 (In reply to comment #0) > http://trac.webkit.org/changeset/121724 broke the following unittest: > It seems the testcase wasn't updated after the renaming of the command. 662120 2 150580 kadam 2012-07-03 04:32:24 -0700 Created attachment 150580 proposed patch I have updated the unit test. Do you think the changelog is correct now? 662122 3 150580 ossy 2012-07-03 04:34:40 -0700 Comment on attachment 150580 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=150580&action=review LGTM, r=me with a little changelog fix. > Tools/ChangeLog:3 > + Update unit test after r121724. Could you include the URL of this bug? 662125 4 150582 kadam 2012-07-03 04:40:14 -0700 Created attachment 150582 proposed fix I fixed it. 662126 5 150582 ossy 2012-07-03 04:44:04 -0700 Comment on attachment 150582 proposed fix r=me 662144 6 150582 webkit.review.bot 2012-07-03 05:38:41 -0700 Comment on attachment 150582 proposed fix Clearing flags on attachment: 150582 Committed r121759: <http://trac.webkit.org/changeset/121759> 662145 7 webkit.review.bot 2012-07-03 05:38:45 -0700 All reviewed patches have been landed. Closing bug. 662331 8 ojan 2012-07-03 10:21:48 -0700 Thanks for fixing this! 150580 2012-07-03 04:32:24 -0700 2012-07-03 04:40:14 -0700 proposed patch 20120703fix.patch text/plain 1750 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZGQw MjM3Li5hNzIzMDlkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDctMDMgIMOBZMOhbSBLYWxsYWkgIDxrYWRh bUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgVXBkYXRlIHVuaXQgdGVzdCBhZnRlciByMTIx NzI0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoR2FyZGVuaW5nU2VydmVyVGVzdC50ZXN0X3JlYmFzZWxpbmVfbmV3X3BvcnQp OgorCiAyMDEyLTA3LTAzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIxNzQ5LgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyX3Vu aXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5n c2VydmVyX3VuaXR0ZXN0LnB5CmluZGV4IDFiYTA2OGMuLjE2NmQxOTEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlcl91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdz ZXJ2ZXJfdW5pdHRlc3QucHkKQEAgLTIwMCw3ICsyMDAsNyBAQCBjbGFzcyBHYXJkZW5pbmdTZXJ2 ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogICAgIGRlZiB0ZXN0X3JlYmFzZWxpbmVfbmV3 X3BvcnQoc2VsZik6CiAgICAgICAgIGJ1aWxkZXJzLl9leGFjdF9tYXRjaGVzID0geyJNT0NLIGJ1 aWxkZXIiOiB7InBvcnRfbmFtZSI6ICJ0ZXN0LW1hYy1sZW9wYXJkIiwgInNwZWNpZmllcnMiOiBz ZXQoWyJtb2NrLXNwZWNpZmllciJdKSwgIm1vdmVfb3ZlcndyaXR0ZW5fYmFzZWxpbmVzX3RvIjog WyJtb2NrLXBvcnQtZmFsbGJhY2siLCAibW9jay1wb3J0LWZhbGxiYWNrMiJdfX0KLSAgICAgICAg ZXhwZWN0ZWRfc3RkZXJyID0gJ01PQ0sgcnVuX2NvbW1hbmQ6IFtcJ2VjaG9cJywgXCdyZWJhc2Vs aW5lLWFsbFwnXSwgY3dkPS9tb2NrLWNoZWNrb3V0LCBpbnB1dD17InVzZXItc2NyaXB0cy9hbm90 aGVyLXRlc3QuaHRtbCI6eyJNT0NLIGJ1aWxkZXIiOiBbInR4dCIsInBuZyJdfX1cbicKKyAgICAg ICAgZXhwZWN0ZWRfc3RkZXJyID0gJ01PQ0sgcnVuX2NvbW1hbmQ6IFtcJ2VjaG9cJywgXCdyZWJh c2VsaW5lLWpzb25cJ10sIGN3ZD0vbW9jay1jaGVja291dCwgaW5wdXQ9eyJ1c2VyLXNjcmlwdHMv YW5vdGhlci10ZXN0Lmh0bWwiOnsiTU9DSyBidWlsZGVyIjogWyJ0eHQiLCJwbmciXX19XG4nCiAg ICAgICAgIGV4cGVjdGVkX3N0ZG91dCA9ICI9PSBCZWdpbiBSZXNwb25zZSA9PVxuc3VjY2Vzc1xu PT0gRW5kIFJlc3BvbnNlID09XG4iCiAgICAgICAgIHNlbGYuX3Bvc3RfdG9fcGF0aCgiL3JlYmFz ZWxpbmVhbGwiLCBib2R5PSd7InVzZXItc2NyaXB0cy9hbm90aGVyLXRlc3QuaHRtbCI6eyJNT0NL IGJ1aWxkZXIiOiBbInR4dCIsInBuZyJdfX0nLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3Rk ZXJyLCBleHBlY3RlZF9zdGRvdXQ9ZXhwZWN0ZWRfc3Rkb3V0KQogCg== 150582 2012-07-03 04:40:14 -0700 2012-07-03 05:38:41 -0700 proposed fix 20120703fix.patch text/plain 1805 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZGQw MjM3Li42NmE3ODYxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDctMDMgIMOBZMOhbSBLYWxsYWkgIDxrYWRh bUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgVXBkYXRlIHVuaXQgdGVzdCBhZnRlciByMTIx NzI0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA0 NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlcl91bml0dGVzdC5weToK KyAgICAgICAgKEdhcmRlbmluZ1NlcnZlclRlc3QudGVzdF9yZWJhc2VsaW5lX25ld19wb3J0KToK KwogMjAxMi0wNy0wMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMTc0OS4KZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlcl91bml0 dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3Nl cnZlcl91bml0dGVzdC5weQppbmRleCAxYmEwNjhjLi4xNjZkMTkxIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXJfdW5pdHRlc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2Vy dmVyX3VuaXR0ZXN0LnB5CkBAIC0yMDAsNyArMjAwLDcgQEAgY2xhc3MgR2FyZGVuaW5nU2VydmVy VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVzdF9yZWJhc2VsaW5lX25ld19w b3J0KHNlbGYpOgogICAgICAgICBidWlsZGVycy5fZXhhY3RfbWF0Y2hlcyA9IHsiTU9DSyBidWls ZGVyIjogeyJwb3J0X25hbWUiOiAidGVzdC1tYWMtbGVvcGFyZCIsICJzcGVjaWZpZXJzIjogc2V0 KFsibW9jay1zcGVjaWZpZXIiXSksICJtb3ZlX292ZXJ3cml0dGVuX2Jhc2VsaW5lc190byI6IFsi bW9jay1wb3J0LWZhbGxiYWNrIiwgIm1vY2stcG9ydC1mYWxsYmFjazIiXX19Ci0gICAgICAgIGV4 cGVjdGVkX3N0ZGVyciA9ICdNT0NLIHJ1bl9jb21tYW5kOiBbXCdlY2hvXCcsIFwncmViYXNlbGlu ZS1hbGxcJ10sIGN3ZD0vbW9jay1jaGVja291dCwgaW5wdXQ9eyJ1c2VyLXNjcmlwdHMvYW5vdGhl ci10ZXN0Lmh0bWwiOnsiTU9DSyBidWlsZGVyIjogWyJ0eHQiLCJwbmciXX19XG4nCisgICAgICAg IGV4cGVjdGVkX3N0ZGVyciA9ICdNT0NLIHJ1bl9jb21tYW5kOiBbXCdlY2hvXCcsIFwncmViYXNl bGluZS1qc29uXCddLCBjd2Q9L21vY2stY2hlY2tvdXQsIGlucHV0PXsidXNlci1zY3JpcHRzL2Fu b3RoZXItdGVzdC5odG1sIjp7Ik1PQ0sgYnVpbGRlciI6IFsidHh0IiwicG5nIl19fVxuJwogICAg ICAgICBleHBlY3RlZF9zdGRvdXQgPSAiPT0gQmVnaW4gUmVzcG9uc2UgPT1cbnN1Y2Nlc3Ncbj09 IEVuZCBSZXNwb25zZSA9PVxuIgogICAgICAgICBzZWxmLl9wb3N0X3RvX3BhdGgoIi9yZWJhc2Vs aW5lYWxsIiwgYm9keT0neyJ1c2VyLXNjcmlwdHMvYW5vdGhlci10ZXN0Lmh0bWwiOnsiTU9DSyBi dWlsZGVyIjogWyJ0eHQiLCJwbmciXX19JywgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVy ciwgZXhwZWN0ZWRfc3Rkb3V0PWV4cGVjdGVkX3N0ZG91dCkKIAo=