90437 2012-07-03 01:12:41 -0700 [GTK] Don't show accel labels in context menu items 2012-07-03 23:18:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned xan.lopez oldest_to_newest 662034 0 cgarcia 2012-07-03 01:12:41 -0700 When a context menu item is created with a GtkMenuItem that has been created from a GtkAction, if the action has an accelerator, it's shown in the menu item label, like menu items in a menu bar. In that case we should reset the accel closure of the menu item label, like GtkUIManager does for popup menus, to make sure the accelerator is not shown. This isn't needed for all other ContextMenuIem constructors, because the GtkAction is created without accelerator by webkit in those cases. 662036 1 150554 cgarcia 2012-07-03 01:15:59 -0700 Created attachment 150554 Patch 662222 2 150554 mrobinson 2012-07-03 08:06:30 -0700 Comment on attachment 150554 Patch I'm not totally sure I understand the patch. Is the issue that accelerator labels are still showing up or that they are both showing up and active? Does gtk_accel_label_set_accel_closure have the side effect of hiding accelerator labels and disabling the accelerator? 662239 3 cgarcia 2012-07-03 08:31:49 -0700 (In reply to comment #2) > (From update of attachment 150554 [details]) > I'm not totally sure I understand the patch. Is the issue that accelerator labels are still showing up or that they are both showing up and active? Does gtk_accel_label_set_accel_closure have the side effect of hiding accelerator labels and disabling the accelerator? This doesn't affect the action accelerator which is not active while the context menu is shown. For example, if you create a GtkAction for Paste with CTRL+V as shortcut, and _Paste as label. When the context menu is not active you can do CTRL+V to trigger the paste action. When the context menu is active you can just press 'p' to trigger the action, but CTRL+V won't work. When the context menu is built, GTK+ doesn't know whether the menu is part of a menubar or a popup, and the shortcut (CTRL + V) is shown at the right of the menu item. To avoid it, we can simply reset the accel closure of the label contained in the menu item (in case it's an accel label, of course). 662675 4 cgarcia 2012-07-03 23:18:40 -0700 Committed r121829: <http://trac.webkit.org/changeset/121829> 150554 2012-07-03 01:15:59 -0700 2012-07-03 09:14:46 -0700 Patch wk-context-menu-items-accels.diff text/plain 2090 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZjNmZDQ2Li5lYzAwZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDctMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvbid0IHNob3cgYWNjZWwgbGFiZWxzIGluIGNvbnRleHQgbWVu dSBpdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGEgY29udGV4dCBtZW51IGl0ZW0gaXMgY3JlYXRlZCB3aXRoIGEgR3RrTWVudUl0ZW0gdGhh dCBoYXMKKyAgICAgICAgYmVlbiBjcmVhdGVkIGZyb20gYSBHdGtBY3Rpb24sIGlmIHRoZSBhY3Rp b24gaGFzIGFuIGFjY2VsZXJhdG9yLAorICAgICAgICBpdCdzIHNob3duIGluIHRoZSBtZW51IGl0 ZW0gbGFiZWwsIGxpa2UgbWVudSBpdGVtcyBpbiBhIG1lbnUKKyAgICAgICAgYmFyLiBJbiB0aGF0 IGNhc2Ugd2Ugc2hvdWxkIHJlc2V0IHRoZSBhY2NlbCBjbG9zdXJlIG9mIHRoZSBtZW51CisgICAg ICAgIGl0ZW0gbGFiZWwsIGxpa2UgR3RrVUlNYW5hZ2VyIGRvZXMgZm9yIHBvcHVwIG1lbnVzLCB0 byBtYWtlIHN1cmUKKyAgICAgICAgdGhlIGFjY2VsZXJhdG9yIGlzIG5vdCBzaG93bi4gVGhpcyBp c24ndCBuZWVkZWQgZm9yIGFsbCBvdGhlcgorICAgICAgICBDb250ZXh0TWVudUllbSBjb25zdHJ1 Y3RvcnMsIGJlY2F1c2UgdGhlIEd0a0FjdGlvbiBpcyBjcmVhdGVkCisgICAgICAgIHdpdGhvdXQg YWNjZWxlcmF0b3IgYnkgd2Via2l0IGluIHRob3NlIGNhc2VzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL0NvbnRleHRNZW51SXRlbUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZXh0 TWVudUl0ZW06OkNvbnRleHRNZW51SXRlbSk6CisKIDIwMTItMDctMDIgIE1hcnRpbiBSb2JpbnNv biAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtUZXh0dXJlTWFwcGVyXSBUaGUg VGV4dHVyZU1hcHBlciBzaG91bGQgc3VwcG9ydCBlZGdlLWRpc3RhbmNlIGFudGktYW50aWFsaWFz aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ29udGV4dE1lbnVJ dGVtR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1H dGsuY3BwCmluZGV4IDY4YWU1YTUuLmQ3MGI1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCkBAIC0xNDQsNiArMTQ0LDE3IEBA IHN0YXRpYyBQbGF0Zm9ybU1lbnVJdGVtRGVzY3JpcHRpb24gY3JlYXRlUGxhdGZvcm1NZW51SXRl bURlc2NyaXB0aW9uKENvbnRleHRNZW51CiBDb250ZXh0TWVudUl0ZW06OkNvbnRleHRNZW51SXRl bShQbGF0Zm9ybU1lbnVJdGVtRGVzY3JpcHRpb24gaXRlbSkKICAgICA6IG1fcGxhdGZvcm1EZXNj cmlwdGlvbihpdGVtKQogeworICAgIC8vIERvbid0IHNob3cgYWNjZWwgbGFiZWxzIGluIGNvbnRl eHQgbWVudSBpdGVtcy4KKyAgICBHdGtBY3Rpb24qIGFjdGlvbiA9IGd0a0FjdGlvbigpOworICAg IGlmICghYWN0aW9uKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoIWd0a19hY3Rpb25fZ2V0 X2FjY2VsX3BhdGgoYWN0aW9uKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgR3RrV2lkZ2V0KiBj aGlsZCA9IGd0a19iaW5fZ2V0X2NoaWxkKEdUS19CSU4oaXRlbSkpOworICAgIGlmIChHVEtfSVNf QUNDRUxfTEFCRUwoY2hpbGQpKQorICAgICAgICBndGtfYWNjZWxfbGFiZWxfc2V0X2FjY2VsX2Ns b3N1cmUoR1RLX0FDQ0VMX0xBQkVMKGNoaWxkKSwgMCk7CiB9CiAKIENvbnRleHRNZW51SXRlbTo6 Q29udGV4dE1lbnVJdGVtKENvbnRleHRNZW51KiBzdWJNZW51KQo=