90417 2012-07-02 17:57:58 -0700 Fix new -Wunused-private-field violations 2012-07-02 19:04:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis cc-bugs jamesr webkit.review.bot oldest_to_newest 661843 0 thakis 2012-07-02 17:57:58 -0700 Fix new -Wunused-private-field violations 661845 1 150508 thakis 2012-07-02 18:00:35 -0700 Created attachment 150508 Patch 661847 2 150510 thakis 2012-07-02 18:01:22 -0700 Created attachment 150510 Patch 661881 3 150510 webkit.review.bot 2012-07-02 19:04:18 -0700 Comment on attachment 150510 Patch Clearing flags on attachment: 150510 Committed r121720: <http://trac.webkit.org/changeset/121720> 661882 4 webkit.review.bot 2012-07-02 19:04:30 -0700 All reviewed patches have been landed. Closing bug. 150508 2012-07-02 18:00:35 -0700 2012-07-02 18:01:17 -0700 Patch bug-90417-20120702180033.patch text/plain 3541 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY3NTQ2ZGM4YTEzOTBm ZmViZWI3MDhmYTM2MmU0ODhjNDY1MjAwYy4uMmYwY2U5YTQxNWRlMjMxNWZjMjJhMWRjNWJiZDM0 ZWE5ZGFjMDc1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTAyICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggbmV3IC1XdW51c2Vk LXByaXZhdGUtZmllbGQgdmlvbGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTA0MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBpbnRlbmRlZCBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUHJpb3JpdGl6 ZWRUZXh0dXJlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1ByaW9yaXRpemVkVGV4 dHVyZU1hbmFnZXI6OkNDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlcik6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyLmg6 CisgICAgICAgIChDQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXIpOgorCiAyMDEyLTA3LTAyICBL d2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQSBzdGFydCAi Ym9keSIgdGFnIGluIHRoZSAiaW4gYm9keSIgaW5zZXJ0aW9uIG1vZGUgaXMgYSBwYXJzZSBlcnJv cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZpbGVTeXN0 ZW1BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3Rl bUFnZW50LmNwcAppbmRleCBhZGFmZWVhN2ZhZjVlNGE0YTc3MTkxODAyYmU5ZTIxZDhhMDQ0ODgz Li42ZTlhZjhiMTJlZDhlNmY0ZDlkZjQzMDM1NGU2YTNjZTBlOTdhZmQ1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcApA QCAtNDYxLDE0ICs0NjEsMTMgQEAgcHJpdmF0ZToKICAgICAgICAgLCBtX3VybChQYXJzZWRVUkxT dHJpbmcsIHVybCkKICAgICAgICAgLCBtX3N0YXJ0KHN0YXJ0KQogICAgICAgICAsIG1fZW5kKGVu ZCkKLSAgICAgICAgLCBtX2N1cnJlbnQoc3RhcnQpIHsgfQorICAgICAgICB7IH0KIAogICAgIFJl ZlB0cjxGcm9udGVuZFByb3ZpZGVyPiBtX2Zyb250ZW5kUHJvdmlkZXI7CiAgICAgaW50IG1fcmVx dWVzdElkOwogICAgIEtVUkwgbV91cmw7CiAgICAgaW50IG1fc3RhcnQ7CiAgICAgbG9uZyBsb25n IG1fZW5kOwotICAgIGxvbmcgbG9uZyBtX2N1cnJlbnQ7CiAKICAgICBSZWZQdHI8RmlsZVJlYWRl cj4gbV9yZWFkZXI7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUHJpb3JpdGl6ZWRUZXh0 dXJlTWFuYWdlci5jcHAKaW5kZXggYjY0MmI5OWViNmEzNzViMjM5ZTkzZWNlYWZiYjA1MTljYTZk NzBjYi4uMjUwODViOGQ1Y2UzYmQwODhkNDU2ZmYwYjZlZDg4Njk4ZWMzN2FjMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0 aXplZFRleHR1cmVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXIuY3BwCkBAIC0zNiw5 ICszNiw4IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAot Q0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyOjpDQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXIo c2l6ZV90IG1heE1lbW9yeUxpbWl0Qnl0ZXMsIHNpemVfdCBwcmVmZXJyZWRNZW1vcnlMaW1pdEJ5 dGVzLCBpbnQgbWF4VGV4dHVyZVNpemUpCi0gICAgOiBtX21heFRleHR1cmVTaXplKG1heFRleHR1 cmVTaXplKQotICAgICwgbV9tYXhNZW1vcnlMaW1pdEJ5dGVzKG1heE1lbW9yeUxpbWl0Qnl0ZXMp CitDQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXI6OkNDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdl cihzaXplX3QgbWF4TWVtb3J5TGltaXRCeXRlcywgc2l6ZV90IHByZWZlcnJlZE1lbW9yeUxpbWl0 Qnl0ZXMsIGludCkKKyAgICA6IG1fbWF4TWVtb3J5TGltaXRCeXRlcyhtYXhNZW1vcnlMaW1pdEJ5 dGVzKQogICAgICwgbV9wcmVmZXJyZWRNZW1vcnlMaW1pdEJ5dGVzKHByZWZlcnJlZE1lbW9yeUxp bWl0Qnl0ZXMpCiAgICAgLCBtX21heE1lbW9yeVByaW9yaXR5Q3V0b2ZmKENDUHJpb3JpdHlDYWxj dWxhdG9yOjp2aXNpYmxlUHJpb3JpdHkoKSkKICAgICAsIG1fcHJpb3JpdHlDdXRvZmYoQ0NQcmlv cml0eUNhbGN1bGF0b3I6Omxvd2VzdFByaW9yaXR5KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ByaW9yaXRpemVkVGV4dHVyZU1h bmFnZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND UHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlci5oCmluZGV4IDdmYzJjNmVhNDhlNjJkOGMwNTVlODVh MmUyOGQxMDgzNDlhMzI0MDAuLmY4NzBlNzdlMWFiYjA0MGRhNWJjYjg0MmY0NzZlNDE1MmIxM2Q5 YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlci5o CkBAIC0xMTcsNyArMTE3LDYgQEAgcHJpdmF0ZToKICAgICBDQ1ByaW9yaXRpemVkVGV4dHVyZTo6 QmFja2luZyogY3JlYXRlQmFja2luZyhJbnRTaXplLCBHQzNEZW51bSBmb3JtYXQsIFRleHR1cmVB bGxvY2F0b3IqKTsKICAgICB2b2lkIGRlc3Ryb3lCYWNraW5nKENDUHJpb3JpdGl6ZWRUZXh0dXJl OjpCYWNraW5nKiwgVGV4dHVyZUFsbG9jYXRvciopOwogCi0gICAgaW50IG1fbWF4VGV4dHVyZVNp emU7CiAgICAgc2l6ZV90IG1fbWF4TWVtb3J5TGltaXRCeXRlczsKICAgICBzaXplX3QgbV9wcmVm ZXJyZWRNZW1vcnlMaW1pdEJ5dGVzOwogICAgIHVuc2lnbmVkIG1fbWF4TWVtb3J5UHJpb3JpdHlD dXRvZmY7Cg== 150510 2012-07-02 18:01:22 -0700 2012-07-02 19:04:18 -0700 Patch bug-90417-20120702180120.patch text/plain 3588 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY3NTQ2ZGM4YTEzOTBm ZmViZWI3MDhmYTM2MmU0ODhjNDY1MjAwYy4uMmYwY2U5YTQxNWRlMjMxNWZjMjJhMWRjNWJiZDM0 ZWE5ZGFjMDc1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTAyICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggbmV3IC1XdW51c2Vk LXByaXZhdGUtZmllbGQgdmlvbGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTA0MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBpbnRlbmRlZCBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUHJpb3JpdGl6 ZWRUZXh0dXJlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1ByaW9yaXRpemVkVGV4 dHVyZU1hbmFnZXI6OkNDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlcik6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyLmg6 CisgICAgICAgIChDQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXIpOgorCiAyMDEyLTA3LTAyICBL d2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQSBzdGFydCAi Ym9keSIgdGFnIGluIHRoZSAiaW4gYm9keSIgaW5zZXJ0aW9uIG1vZGUgaXMgYSBwYXJzZSBlcnJv cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZpbGVTeXN0 ZW1BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3Rl bUFnZW50LmNwcAppbmRleCBhZGFmZWVhN2ZhZjVlNGE0YTc3MTkxODAyYmU5ZTIxZDhhMDQ0ODgz Li5kZmZlZjA5MTBmYzIxODM5NDBjOGYwODkzNTNjZmVmZGM3MTg3ZTlmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcApA QCAtNDYwLDE1ICs0NjAsMTMgQEAgcHJpdmF0ZToKICAgICAgICAgLCBtX3JlcXVlc3RJZChyZXF1 ZXN0SWQpCiAgICAgICAgICwgbV91cmwoUGFyc2VkVVJMU3RyaW5nLCB1cmwpCiAgICAgICAgICwg bV9zdGFydChzdGFydCkKLSAgICAgICAgLCBtX2VuZChlbmQpCi0gICAgICAgICwgbV9jdXJyZW50 KHN0YXJ0KSB7IH0KKyAgICAgICAgLCBtX2VuZChlbmQpIHsgfQogCiAgICAgUmVmUHRyPEZyb250 ZW5kUHJvdmlkZXI+IG1fZnJvbnRlbmRQcm92aWRlcjsKICAgICBpbnQgbV9yZXF1ZXN0SWQ7CiAg ICAgS1VSTCBtX3VybDsKICAgICBpbnQgbV9zdGFydDsKICAgICBsb25nIGxvbmcgbV9lbmQ7Ci0g ICAgbG9uZyBsb25nIG1fY3VycmVudDsKIAogICAgIFJlZlB0cjxGaWxlUmVhZGVyPiBtX3JlYWRl cjsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9jYy9DQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2Vy LmNwcAppbmRleCBiNjQyYjk5ZWI2YTM3NWIyMzllOTNlY2VhZmJiMDUxOWNhNmQ3MGNiLi4yNTA4 NWI4ZDVjZTNiZDA4OGQ0NTZmZjBiNmVkODg2OThlYzM3YWMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ByaW9yaXRpemVkVGV4dHVy ZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlci5jcHAKQEAgLTM2LDkgKzM2LDggQEAg dXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1DQ1ByaW9yaXRp emVkVGV4dHVyZU1hbmFnZXI6OkNDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlcihzaXplX3QgbWF4 TWVtb3J5TGltaXRCeXRlcywgc2l6ZV90IHByZWZlcnJlZE1lbW9yeUxpbWl0Qnl0ZXMsIGludCBt YXhUZXh0dXJlU2l6ZSkKLSAgICA6IG1fbWF4VGV4dHVyZVNpemUobWF4VGV4dHVyZVNpemUpCi0g ICAgLCBtX21heE1lbW9yeUxpbWl0Qnl0ZXMobWF4TWVtb3J5TGltaXRCeXRlcykKK0NDUHJpb3Jp dGl6ZWRUZXh0dXJlTWFuYWdlcjo6Q0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyKHNpemVfdCBt YXhNZW1vcnlMaW1pdEJ5dGVzLCBzaXplX3QgcHJlZmVycmVkTWVtb3J5TGltaXRCeXRlcywgaW50 KQorICAgIDogbV9tYXhNZW1vcnlMaW1pdEJ5dGVzKG1heE1lbW9yeUxpbWl0Qnl0ZXMpCiAgICAg LCBtX3ByZWZlcnJlZE1lbW9yeUxpbWl0Qnl0ZXMocHJlZmVycmVkTWVtb3J5TGltaXRCeXRlcykK ICAgICAsIG1fbWF4TWVtb3J5UHJpb3JpdHlDdXRvZmYoQ0NQcmlvcml0eUNhbGN1bGF0b3I6OnZp c2libGVQcmlvcml0eSgpKQogICAgICwgbV9wcmlvcml0eUN1dG9mZihDQ1ByaW9yaXR5Q2FsY3Vs YXRvcjo6bG93ZXN0UHJpb3JpdHkoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlci5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXpl ZFRleHR1cmVNYW5hZ2VyLmgKaW5kZXggN2ZjMmM2ZWE0OGU2MmQ4YzA1NWU4NWEyZTI4ZDEwODM0 OWEzMjQwMC4uZjg3MGU3N2UxYWJiMDQwZGE1YmNiODQyZjQ3NmU0MTUyYjEzZDlhMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlv cml0aXplZFRleHR1cmVNYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NQcmlvcml0aXplZFRleHR1cmVNYW5hZ2VyLmgKQEAgLTExNyw3 ICsxMTcsNiBAQCBwcml2YXRlOgogICAgIENDUHJpb3JpdGl6ZWRUZXh0dXJlOjpCYWNraW5nKiBj cmVhdGVCYWNraW5nKEludFNpemUsIEdDM0RlbnVtIGZvcm1hdCwgVGV4dHVyZUFsbG9jYXRvciop OwogICAgIHZvaWQgZGVzdHJveUJhY2tpbmcoQ0NQcmlvcml0aXplZFRleHR1cmU6OkJhY2tpbmcq LCBUZXh0dXJlQWxsb2NhdG9yKik7CiAKLSAgICBpbnQgbV9tYXhUZXh0dXJlU2l6ZTsKICAgICBz aXplX3QgbV9tYXhNZW1vcnlMaW1pdEJ5dGVzOwogICAgIHNpemVfdCBtX3ByZWZlcnJlZE1lbW9y eUxpbWl0Qnl0ZXM7CiAgICAgdW5zaWduZWQgbV9tYXhNZW1vcnlQcmlvcml0eUN1dG9mZjsK