90407 2012-07-02 15:33:52 -0700 DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it creates are not shouldGenerate() 2012-07-02 17:10:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 661766 0 fpizlo 2012-07-02 15:33:52 -0700 We already assert this in later phases. But asserting sooner will make tracking bugs easier, not to mention that it makes the phase more self-documenting. 661767 1 150484 fpizlo 2012-07-02 15:35:21 -0700 Created attachment 150484 the patch Already reviewed in person by Mark. Putting up for EWS while I run my own tests. 661826 2 fpizlo 2012-07-02 17:10:42 -0700 Landed in http://trac.webkit.org/changeset/121712 150484 2012-07-02 15:35:21 -0700 2012-07-02 15:35:21 -0700 the patch assertphantomargs_patch_1.diff text/plain 2926 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxNzA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTA3LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpBcmd1bWVudHNTaW1wbGlmaWNhdGlvblBoYXNlIHNob3VsZCBhc3NlcnQgdGhhdCB0aGUg UGhhbnRvbUFyZ3VtZW50cyBub2RlcyBpdCBjcmVhdGVzIGFyZSBub3Qgc2hvdWxkR2VuZXJhdGUo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA0MDcK KworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIEhhaG5lbmJlcmcuCisKKyAgICAgICAgKiBkZmcv REZHQXJndW1lbnRzU2ltcGxpZmljYXRpb25QaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6 QXJndW1lbnRzU2ltcGxpZmljYXRpb25QaGFzZTo6cnVuKToKKwogMjAxMi0wNy0wMiAgR2F2aW4g QmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgQXJyYXkucHJv dG90eXBlLnBvcCBzaG91bGQgdGhyb3cgaWYgcHJvcGVydHkgaXMgbm90IGNvbmZpZ3VyYWJsZQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNTaW1wbGlmaWNhdGlv blBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fy Z3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAxMjE3MDMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02MjcsOCArNjI3LDkgQEAgcHVibGljOgogICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICAvLyBJZiB0aGlzIGlzIGEgQ3JlYXRl QXJndW1lbnRzIGZvciBhbiBJbmxpbmVDYWxsRnJhbWUqIHRoYXQgZG9lcwogICAgICAgICAgICAg ICAgIC8vIG5vdCBjcmVhdGUgYXJndW1lbnRzLCB0aGVuIHJlcGxhY2UgaXQgd2l0aCBhIFBoYW50 b21Bcmd1bWVudHMuCi0gICAgICAgICAgICAgICAgLy8gUGhhbnRvbUFyZ3VtZW50cyBpcyBhIGNv bnN0YW50IHRoYXQgcmVwcmVzZW50cyBKU1ZhbHVlKCkgKHRoZQotICAgICAgICAgICAgICAgIC8v IGVtcHR5IHZhbHVlKSBpbiBERkcgYW5kIGFyZ3VtZW50cyBjcmVhdGlvbiBmb3IgT1NSIGV4aXQu CisgICAgICAgICAgICAgICAgLy8gUGhhbnRvbUFyZ3VtZW50cyBpcyBhIG5vbi1leGVjdXRpbmcg bm9kZSB0aGF0IGp1c3QgaW5kaWNhdGVzCisgICAgICAgICAgICAgICAgLy8gdGhhdCB0aGUgbm9k ZSBzaG91bGQgYmUgcmVpZmllZCBhcyBhbiBhcmd1bWVudHMgb2JqZWN0IG9uIE9TUgorICAgICAg ICAgICAgICAgIC8vIGV4aXQuCiAgICAgICAgICAgICAgICAgaWYgKG1fY3JlYXRlc0FyZ3VtZW50 cy5jb250YWlucyhub2RlLmNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lKSkKICAgICAgICAgICAg ICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgaWYgKG5vZGUuc2hvdWxkR2VuZXJh dGUoKSkgewpAQCAtNjQxLDEyICs2NDIsMzAgQEAgcHVibGljOgogICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICBub2RlLnNldE9wQW5kRGVmYXVsdEZsYWdzKFBoYW50b21Bcmd1bWVu dHMpOwogICAgICAgICAgICAgICAgIG5vZGUuY2hpbGRyZW4ucmVzZXQoKTsKKyAgICAgICAgICAg ICAgICBjaGFuZ2VkID0gdHJ1ZTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGluc2VydGlv blNldC5leGVjdXRlKCpibG9jayk7CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIGlmIChj aGFuZ2VkKQorICAgICAgICBpZiAoY2hhbmdlZCkgewogICAgICAgICAgICAgbV9ncmFwaC5jb2xs ZWN0R2FyYmFnZSgpOworICAgICAgICAgICAgCisgICAgICAgICAgICAvLyBWZXJpZnkgdGhhdCBQ aGFudG9tQXJndW1lbnRzIG5vZGVzIGFyZSBub3Qgc2hvdWxkR2VuZXJhdGUoKS4KKyNpZiAhQVNT RVJUX0RJU0FCTEVECisgICAgICAgICAgICBmb3IgKEJsb2NrSW5kZXggYmxvY2tJbmRleCA9IDA7 IGJsb2NrSW5kZXggPCBtX2dyYXBoLm1fYmxvY2tzLnNpemUoKTsgKytibG9ja0luZGV4KSB7Cisg ICAgICAgICAgICAgICAgQmFzaWNCbG9jayogYmxvY2sgPSBtX2dyYXBoLm1fYmxvY2tzW2Jsb2Nr SW5kZXhdLmdldCgpOworICAgICAgICAgICAgICAgIGlmICghYmxvY2spCisgICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaW5kZXhJbkJs b2NrID0gMDsgaW5kZXhJbkJsb2NrIDwgYmxvY2stPnNpemUoKTsgKytpbmRleEluQmxvY2spIHsK KyAgICAgICAgICAgICAgICAgICAgTm9kZUluZGV4IG5vZGVJbmRleCA9IGJsb2NrLT5hdChpbmRl eEluQmxvY2spOworICAgICAgICAgICAgICAgICAgICBOb2RlJiBub2RlID0gbV9ncmFwaFtub2Rl SW5kZXhdOworICAgICAgICAgICAgICAgICAgICBpZiAobm9kZS5vcCgpICE9IFBoYW50b21Bcmd1 bWVudHMpCisgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAg ICAgICAgQVNTRVJUKCFub2RlLnNob3VsZEdlbmVyYXRlKCkpOworICAgICAgICAgICAgICAgIH0K KyAgICAgICAgICAgIH0KKyNlbmRpZgorICAgICAgICB9CiAgICAgICAgIAogICAgICAgICByZXR1 cm4gY2hhbmdlZDsKICAgICB9Cg==