90401 2012-07-02 14:19:54 -0700 Compositing layer sync should cause deferred repaints to be fired immediately 2012-07-02 15:15:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned koivisto simon.fraser webkit-bug-importer oldest_to_newest 661717 0 thorton 2012-07-02 14:19:54 -0700 When we sync compositing layer state, we need to paint immediately, no matter what; otherwise we might see a visible flash before painting occurs. 661718 1 webkit-bug-importer 2012-07-02 14:20:32 -0700 <rdar://problem/11792028> 661724 2 150475 thorton 2012-07-02 14:30:09 -0700 Created attachment 150475 patch 661741 3 150475 simon.fraser 2012-07-02 14:51:42 -0700 Comment on attachment 150475 patch View in context: https://bugs.webkit.org/attachment.cgi?id=150475&action=review > Source/WebCore/page/FrameView.cpp:752 > root->compositor()->flushPendingLayerChanges(rootFrameForSync == m_frame); > > + // If we sync compositing layers and allow the repaint to be deferred, there is time for a > + // visible flash to occur. Instead, stop the deferred repaint timer and repaint immediately. > + stopDelayingDeferredRepaints(); I think we should swap these around. If deferred repaints at some point affects compositing layers (it does not yet), then we'd want those repaints to get flushed. 661748 4 150475 koivisto 2012-07-02 15:00:44 -0700 Comment on attachment 150475 patch View in context: https://bugs.webkit.org/attachment.cgi?id=150475&action=review > Source/WebCore/page/FrameView.cpp:1948 > + if (!m_deferredRepaintTimer.isActive()) > + return; > + > m_deferredRepaintTimer.stop(); This does not make any sense. 661749 5 150475 koivisto 2012-07-02 15:03:07 -0700 Comment on attachment 150475 patch View in context: https://bugs.webkit.org/attachment.cgi?id=150475&action=review >> Source/WebCore/page/FrameView.cpp:1948 >> m_deferredRepaintTimer.stop(); > > This does not make any sense. Actually it does, I misread! 661752 6 thorton 2012-07-02 15:15:23 -0700 http://trac.webkit.org/changeset/121708 150475 2012-07-02 14:30:09 -0700 2012-07-02 15:03:07 -0700 patch deferred-repaint-layer-flush.diff text/plain 2863 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNzQ2N2Y1Li4wNzJkNDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDctMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQ29tcG9zaXRpbmcgbGF5ZXIgc3luYyBzaG91bGQgY2F1c2UgZGVmZXJyZWQgcmVw YWludHMgdG8gYmUgZmlyZWQgaW1tZWRpYXRlbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNDAxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTc5 MjAyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ ZiB3ZSBzeW5jIGNvbXBvc2l0aW5nIGxheWVycyBhbmQgYWxsb3cgdGhlIHJlcGFpbnQgdG8gYmUg ZGVmZXJyZWQsIHRoZXJlIGlzIHRpbWUgZm9yIGEKKyAgICAgICAgdmlzaWJsZSBmbGFzaCB0byBv Y2N1ci4gSW5zdGVhZCwgc3RvcCB0aGUgZGVmZXJyZWQgcmVwYWludCB0aW1lciBhbmQgcmVwYWlu dCBpbW1lZGlhdGVseS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvbmZpZ3VyYXRpb24gYW5k IHRpbWluZyBkZXBlbmRlbnQuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnN5bmNDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0ZyYW1l KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6Y2hlY2tTdG9wRGVsYXlpbmdEZWZlcnJl ZFJlcGFpbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c3RvcERlbGF5aW5nRGVm ZXJyZWRSZXBhaW50cyk6IFNwbGl0IG9mZiBmcm9tIGNoZWNrU3RvcERlbGF5aW5nRGVmZXJyZWRS ZXBhaW50cy4KKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5oOgorICAgICAgICAoRnJhbWVWaWV3 KTogQWRkIHN0b3BEZWxheWluZ0RlZmVycmVkUmVwYWludHMuCisKIDIwMTItMDYtMjkgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRhdGUgY29tcGxleCBmb250 cyBvbiBBbmRyb2lkIHRvIHVzZSBmb250cyBmcm9tIGEgbmV3ZXIgU0RLCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKaW5kZXggOTEwNDYzZi4uZTg3ODQ3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcApAQCAtNzQ3LDYgKzc0NywxMCBAQCBib29sIEZyYW1lVmlldzo6c3luY0NvbXBvc2l0 aW5nU3RhdGVGb3JUaGlzRnJhbWUoRnJhbWUqIHJvb3RGcmFtZUZvclN5bmMpCiAKICAgICByb290 LT5jb21wb3NpdG9yKCktPmZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcyhyb290RnJhbWVGb3JTeW5j ID09IG1fZnJhbWUpOwogCisgICAgLy8gSWYgd2Ugc3luYyBjb21wb3NpdGluZyBsYXllcnMgYW5k IGFsbG93IHRoZSByZXBhaW50IHRvIGJlIGRlZmVycmVkLCB0aGVyZSBpcyB0aW1lIGZvciBhCisg ICAgLy8gdmlzaWJsZSBmbGFzaCB0byBvY2N1ci4gSW5zdGVhZCwgc3RvcCB0aGUgZGVmZXJyZWQg cmVwYWludCB0aW1lciBhbmQgcmVwYWludCBpbW1lZGlhdGVseS4KKyAgICBzdG9wRGVsYXlpbmdE ZWZlcnJlZFJlcGFpbnRzKCk7CisKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMTkyOSwxMyAr MTkzMywxOCBAQCB2b2lkIEZyYW1lVmlldzo6c3RhcnREZWZlcnJlZFJlcGFpbnRUaW1lcihkb3Vi bGUgZGVsYXkpCiAKIHZvaWQgRnJhbWVWaWV3OjpjaGVja1N0b3BEZWxheWluZ0RlZmVycmVkUmVw YWludHMoKQogewotICAgIGlmICghbV9kZWZlcnJlZFJlcGFpbnRUaW1lci5pc0FjdGl2ZSgpKQot ICAgICAgICByZXR1cm47Ci0KICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1 bWVudCgpOwogICAgIGlmIChkb2N1bWVudCAmJiAoZG9jdW1lbnQtPnBhcnNpbmcoKSB8fCBkb2N1 bWVudC0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKS0+cmVxdWVzdENvdW50KCkpKQogICAgICAgICBy ZXR1cm47CisKKyAgICBzdG9wRGVsYXlpbmdEZWZlcnJlZFJlcGFpbnRzKCk7Cit9CiAgICAgCit2 b2lkIEZyYW1lVmlldzo6c3RvcERlbGF5aW5nRGVmZXJyZWRSZXBhaW50cygpCit7CisgICAgaWYg KCFtX2RlZmVycmVkUmVwYWludFRpbWVyLmlzQWN0aXZlKCkpCisgICAgICAgIHJldHVybjsKKwog ICAgIG1fZGVmZXJyZWRSZXBhaW50VGltZXIuc3RvcCgpOwogCiAgICAgZG9EZWZlcnJlZFJlcGFp bnRzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCA4Y2NiZThjLi4wOGNlZWZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTIwOSw2ICsyMDksNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBiZWdpbkRlZmVycmVkUmVwYWludHMoKTsKICAgICB2b2lkIGVuZERlZmVycmVkUmVwYWludHMo KTsKICAgICB2b2lkIGNoZWNrU3RvcERlbGF5aW5nRGVmZXJyZWRSZXBhaW50cygpOworICAgIHZv aWQgc3RvcERlbGF5aW5nRGVmZXJyZWRSZXBhaW50cygpOwogICAgIHZvaWQgc3RhcnREZWZlcnJl ZFJlcGFpbnRUaW1lcihkb3VibGUgZGVsYXkpOwogICAgIHZvaWQgcmVzZXREZWZlcnJlZFJlcGFp bnREZWxheSgpOwogCg==