90380 2012-07-02 05:51:58 -0700 [MICRODATA] Build failure in html/HTMLElement.cpp 2012-07-08 19:13:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 90378 P2 Normal --- 90377 1 cdumez cdumez arko darin rniwa oldest_to_newest 661427 0 cdumez 2012-07-02 05:51:58 -0700 Turning on the MICRODATA flag causes the following build failure: /home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp: In member function ‘WebCore::HTMLPropertiesCollection* WebCore::HTMLElement::properties()’: /home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp:993:53: error: cannot convert ‘WebCore::HTMLCollection*’ to ‘WebCore::HTMLPropertiesCollection*’ in return /home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp:994:1: warning: control reaches end of non-void function [-Wreturn-type] make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/html/HTMLElement.cpp.o] Error 1 661431 1 150407 cdumez 2012-07-02 05:59:42 -0700 Created attachment 150407 Patch 661455 2 arko 2012-07-02 06:44:34 -0700 Hi Christophe, I have already filed a bug for this error : https://bugs.webkit.org/show_bug.cgi?id=90378. Can we mark this as a duplicate of 90378? Thanks for pointing out. 661456 3 cdumez 2012-07-02 06:46:50 -0700 Ok, done. I failed to notice the existing bug report, sorry. *** This bug has been marked as a duplicate of bug 90378 *** 664541 4 150407 laszlo.gombos 2012-07-08 19:13:59 -0700 Comment on attachment 150407 Patch Marking the patch obsolete as the fix is landed in r121692 to take it out from the review queue. 150407 2012-07-02 05:59:42 -0700 2012-07-08 19:13:59 -0700 Patch 90380_microdata_buildfix.patch text/plain 1487 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OTQ4ZjhmLi4xNTEwNTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbTUlDUk9EQVRBXSBCdWlsZCBmYWlsdXJlIGluIGh0bWwvSFRNTEVs ZW1lbnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MDM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVzIGNvbXBpbGF0aW9uIGlzc3VlIGluIEhUTUxFbGVtZW50Ojpwcm9wZXJ0aWVzKCkgd2hl bgorICAgICAgICBNSUNST0RBVEEgZmxhZyBpcyBlbmFibGVkLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgYnVpbGQgZml4LgorCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6cHJvcGVydGllcyk6CisKIDIwMTItMDYtMjIgIFZz ZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW1wbGVtZW50IHNuaXBwZXRzIGV2YWx1YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVs ZW1lbnQuY3BwCmluZGV4IGU5MmU5NTYuLmM1ZmUzMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVs ZW1lbnQuY3BwCkBAIC00NCw2ICs0NCw3IEBACiAjaW5jbHVkZSAiSFRNTEZvcm1FbGVtZW50Lmgi CiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFBhcnNlcklkaW9tcy5oIgor I2luY2x1ZGUgIkhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5oIgogI2luY2x1ZGUgIkhUTUxUZXh0 Rm9ybUNvbnRyb2xFbGVtZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyV29yZEJyZWFrLmgiCiAjaW5j bHVkZSAiU2NyaXB0RXZlbnRMaXN0ZW5lci5oIgpAQCAtOTkwLDcgKzk5MSw3IEBAIHZvaWQgSFRN TEVsZW1lbnQ6OnNldEl0ZW1WYWx1ZVRleHQoY29uc3QgU3RyaW5nJiB2YWx1ZSwgRXhjZXB0aW9u Q29kZSYgZWMpCiAKIEhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbiogSFRNTEVsZW1lbnQ6OnByb3Bl cnRpZXMoKQogewotICAgIHJldHVybiBlbnN1cmVDYWNoZWRIVE1MQ29sbGVjdGlvbihJdGVtUHJv cGVydGllcyk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PEhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlv bio+KGVuc3VyZUNhY2hlZEhUTUxDb2xsZWN0aW9uKEl0ZW1Qcm9wZXJ0aWVzKSk7CiB9CiAjZW5k aWYKIAo=