90372 2012-07-02 04:53:59 -0700 [Qt][WK2] New API tests introduced in r121620 fail 2012-07-02 12:12:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 70236 84532 1 ossy noam cmarcelo luiz menard noam webkit.review.bot zoltan oldest_to_newest 661398 0 ossy 2012-07-02 04:53:59 -0700 FAIL! : tst_qrawwebview::noBackground1() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] FAIL! : tst_qrawwebview::noBackground2() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] FAIL! : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)] Sholdn't we mark them as expected fails? If there are many failing tests on the bot, it's so hard to catch new regressions. 661423 1 noam 2012-07-02 05:48:37 -0700 Yes, let's mark as expected fails for now and we'll fix those. 661567 2 150437 noam 2012-07-02 09:53:02 -0700 Created attachment 150437 Patch 661663 3 150437 webkit.review.bot 2012-07-02 12:12:45 -0700 Comment on attachment 150437 Patch Clearing flags on attachment: 150437 Committed r121698: <http://trac.webkit.org/changeset/121698> 661664 4 webkit.review.bot 2012-07-02 12:12:50 -0700 All reviewed patches have been landed. Closing bug. 150437 2012-07-02 09:53:02 -0700 2012-07-02 12:12:45 -0700 Patch bug-90372-20120702095251.patch text/plain 2497 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDNhNDY0Y2MxMmM1M2Mz NWU5NTdmM2M3Y2RjYmI2ODdiMTkxMWMyNS4uYWU5N2VjOTY0OTJjZTBlZGI3MTVkYjA4NmMzNDhh ZDBmMzRmMjA4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTAyICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtX SzJdIE5ldyBBUEkgdGVzdHMgaW50cm9kdWNlZCBpbiByMTIxNjIwIGZhaWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMzcyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0aGUgcGl4ZWwgY29t cGFyaXNvbiB0byBwcm9kdWNlIG1vcmUgcHJlZGljdGFibGUgcmVzdWx0cy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3FyYXd3ZWJ2aWV3LmNwcDoK KyAgICAgICAgKGNvbXBhcmVJbWFnZXMpOgorCiAyMDEyLTA3LTAyICBTaGVyaWZmIEJvdCAgPHdl YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTIwMzI5LCByMTIxMTEzLCBhbmQgcjEyMTEzOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3FyYXd3ZWJ2aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcv dHN0X3FyYXd3ZWJ2aWV3LmNwcAppbmRleCBhZTAxNWUzYTgyZDQ0NmU0OGY3NmYxOTlmZDI2Yjdh NTYyMDdmMTNmLi45ZjY4ODgxODBhNTFiM2Y3ZTA1MDMzZTk4NmUyNjhiMTM5YzQ0NGNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FyYXd3ZWJ2aWV3 L3RzdF9xcmF3d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9xcmF3d2Vidmlldy90c3RfcXJhd3dlYnZpZXcuY3BwCkBAIC0xMTksMjYgKzExOSwx OSBAQCB2b2lkIFdlYlZpZXc6OmZpbmlzaExvYWRGb3JGcmFtZShXS1BhZ2VSZWYgcGFnZSwgV0tG cmFtZVJlZiBmcmFtZSwgV0tUeXBlUmVmIHVzZQogICAgIG9iai0+bV9mcmFtZUxvYWRlZCA9IHRy dWU7CiB9CiAKLXN0YXRpYyBib29sIGNvbXBhcmVJbWFnZXMoY29uc3QgUUltYWdlJiBpMSwgY29u c3QgUUltYWdlJiBpMiwgY29uc3QgUVBvaW50JiBwMSwgY29uc3QgUVBvaW50JiBwMiwgaW50IGl0 ZXIpCi17Ci0gICAgY29uc3QgUVBvaW50IHBvaW50KChwMS54KCkgKyBwMi54KCkpID4+IDEsIChw MS55KCkgKyBwMi55KCkpID4+IDEpOwotCi0gICAgaWYgKGkxLnBpeGVsKHBvaW50KSAhPSBpMi5w aXhlbChwb2ludCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIGlmICghaXRlcikKLSAg ICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICAtLWl0ZXI7Ci0gICAgcmV0dXJuIGNvbXBhcmVJbWFn ZXMoaTEsIGkyLCBwb2ludCwgcDEsIGl0ZXIpICYmIGNvbXBhcmVJbWFnZXMoaTEsIGkyLCBwb2lu dCwgcDIsIGl0ZXIpCi0gICAgICAgICYmIGNvbXBhcmVJbWFnZXMoaTEsIGkyLCBwb2ludCwgUVBv aW50KHAxLngoKSwgcDIueSgpKSwgaXRlcikgJiYgY29tcGFyZUltYWdlcyhpMSwgaTIsIHBvaW50 LCBRUG9pbnQocDIueCgpLCBwMS55KCkpLCBpdGVyKTsKLX0KLQotc3RhdGljIGJvb2wgY29tcGFy ZUltYWdlcyhjb25zdCBRSW1hZ2UmIGkxLCBjb25zdCBRSW1hZ2UmIGkyLCBpbnQgaXRlcikKK3N0 YXRpYyBib29sIGNvbXBhcmVJbWFnZXMoY29uc3QgUUltYWdlJiBpMSwgY29uc3QgUUltYWdlJiBp MiwgaW50IGNvdW50KQogewogICAgIGlmIChpMS5zaXplKCkgIT0gaTIuc2l6ZSgpKQogICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJuIGNvbXBhcmVJbWFnZXMoaTEsIGkyLCBRUG9pbnQo MCwgMCksIFFQb2ludChpMS5zaXplKCkud2lkdGgoKSwgaTEuc2l6ZSgpLmhlaWdodCgpKSwgaXRl cik7CisgICAgZm9yIChpbnQgeCA9IDA7IHggPCBjb3VudDsgKyt4KSB7CisgICAgICAgIGZvciAo aW50IHkgPSAwOyB5IDwgY291bnQ7ICsreSkgeworICAgICAgICAgICAgUVBvaW50IHBvaW50KHgg KiBpMS53aWR0aCgpIC8gY291bnQsIHkgKiBpMS5oZWlnaHQoKSAvIGNvdW50KTsKKyAgICAgICAg ICAgIGlmIChpMS5waXhlbChwb2ludCkgIT0gaTIucGl4ZWwocG9pbnQpKQorICAgICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQorICAgIH0KKworICAgIHJldHVybiB0cnVlOwog fQogCiBjbGFzcyB0c3RfcXJhd3dlYnZpZXcgOiBwdWJsaWMgUU9iamVjdCB7Cg==