<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90371</bug_id>
          
          <creation_ts>2012-07-02 03:31:49 -0700</creation_ts>
          <short_desc>REGRESSION(r121497): It switched off and broke many unittests</short_desc>
          <delta_ts>2012-07-02 12:46:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>89706</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Csaba Osztrogonác">ossy</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>galpeter</cc>
    
    <cc>jbadics</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
    
    <cc>rtoy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>661364</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-07-02 03:31:49 -0700</bug_when>
    <thetext>-class PortTestCase(unittest.TestCase):
+class PortTestCase(object):

This change switched off 231 unittest case, I think accidentally.
I tried to revert this change, tests run, but I got 22 new failures:

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_all_test_configurations
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 63, in test_all_test_configurations
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_build_path
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py&quot;, line 77, in test_build_path
    self.assert_build_path(options, [&apos;/mock-checkout/Source/WebKit/chromium/out&apos;], &apos;/foo&apos;)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 344, in assert_build_path
    port = self.make_port(options=options)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_check_build
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 225, in test_check_build
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_check_wdiff
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 229, in test_check_wdiff
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_default_pixel_tests
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 52, in test_default_pixel_tests
    self.assertEquals(self.make_port().default_pixel_tests(), True)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_default_timeout_ms
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 48, in test_default_timeout_ms
    self.assertEquals(self.make_port(options=MockOptions(configuration=&apos;Release&apos;)).default_timeout_ms(), 6000)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_actual
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 215, in test_diff_image__missing_actual
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_both
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 208, in test_diff_image__missing_both
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_expected
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 220, in test_diff_image__missing_expected
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_driver_cmd_line
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 73, in test_driver_cmd_line
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_driver_name_option
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py&quot;, line 92, in test_driver_name_option
    self.assertTrue(self.make_port()._path_to_driver().endswith(&apos;DumpRenderTree&apos;))
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_expectations_files
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 160, in test_expectations_files
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_get_crash_log
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 320, in test_get_crash_log
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_missing_symbol_to_skipped_tests
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 56, in test_missing_symbol_to_skipped_tests
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_operating_system
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py&quot;, line 72, in test_operating_system
    self.assertEqual(&apos;mac&apos;, self.make_port().operating_system())
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_path_to_image_diff
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py&quot;, line 96, in test_path_to_image_diff
    self.assertEquals(self.make_port()._path_to_image_diff(), &apos;/mock-checkout/out/Release/ImageDiff&apos;)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_test_configuration
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 290, in test_test_configuration
    port = self.make_port()
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_uses_apache
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 83, in test_uses_apache
    self.assertTrue(self.make_port()._uses_apache())
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_versions
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py&quot;, line 47, in test_versions
    self.assertTrue(self.make_port().name() in (&apos;chromium-mac-snowleopard&apos;, &apos;chromium-mac-lion&apos;, &apos;chromium-mac-future&apos;))
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py&quot;, line 63, in make_port
    return self.port_maker(host, port_name, options=options, config=config, **kwargs)
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&quot;, line 75, in __init__
    assert self._version in self.SUPPORTED_OS_VERSIONS
AssertionError

================================================================================
FAILURE: webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_all_test_configurations
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py&quot;, line 80, in test_all_test_configurations
    TestConfiguration(&apos;lucid&apos;, &apos;x86_64&apos;, &apos;release&apos;),
AssertionError: set([TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;icecreamsandwich&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;win7&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;xp&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;win7&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;icecreamsandwich&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;xp&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;)]) != set([TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;leopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;icecreamsandwich&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;win7&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;xp&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;icecreamsandwich&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;win7&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lucid&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;xp&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;leopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;)])

--------------------------------------------------------------------------------
Ran 1451 tests in 12.645s
FAILED (failures=22, errors=0)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>661378</commentid>
    <comment_count>1</comment_count>
      <attachid>150393</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-07-02 03:50:47 -0700</bug_when>
    <thetext>Created attachment 150393
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>661543</commentid>
    <comment_count>2</comment_count>
      <attachid>150393</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-02 09:26:09 -0700</bug_when>
    <thetext>Comment on attachment 150393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150393&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47
&gt; -class PortTestCase(object):
&gt; +class PortTestCase(unittest.TestCase):

I see.  This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>661559</commentid>
    <comment_count>3</comment_count>
      <attachid>150393</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-07-02 09:46:55 -0700</bug_when>
    <thetext>Comment on attachment 150393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150393&amp;action=review

&gt;&gt; Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47
&gt;&gt; +class PortTestCase(unittest.TestCase):
&gt; 
&gt; I see.  This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Hm. PortTestCase is supposed to derive from unittest.TestCase, so this is good; I had experimented with something else, and I guess that I missed reverting this part, but I&apos;m not sure how I missed that :(.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>661674</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-07-02 12:45:43 -0700</bug_when>
    <thetext>Committed r121701: &lt;http://trac.webkit.org/changeset/121701&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>661675</commentid>
    <comment_count>5</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-07-02 12:46:20 -0700</bug_when>
    <thetext>(I landed this myself to fix things :) Hope that&apos;s okay.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>150393</attachid>
            <date>2012-07-02 03:50:47 -0700</date>
            <delta_ts>2012-07-02 09:46:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90371-20120702125045.patch</filename>
            <type>text/plain</type>
            <size>3444</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTJhM2M3Mjc1Y2EyMzA4OTU0MDExYTgxZjQ1MzU5ZDA0
ZTVhOWEwZC4uMjYwZWUwYzBkYjM1ZDRhZDVhZTUyNzc4MWY3OWQzNDI1NjIzM2I2OSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDEyLTA3LTAyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK
KyAgICAgICAgUkVHUkVTU0lPTihyMTIxNDk3KTogSXQgc3dpdGNoZWQgb2ZmIGFuZCBicm9rZSBt
YW55IHVuaXR0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9OTAzNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3Vu
aXR0ZXN0LnB5OgorICAgICAgICAoQ2hyb21pdW1NYWNQb3J0VGVzdCk6IFVzZSBzbm93bGVvcGFy
ZCBhcyBvc192ZXJzaW9uIGluc3RlYWQgb2YgbGVvcGFyZCwgYmVjYXVzZSBpdCBpc24ndCBzdXBw
b3J0ZWQgYW55bW9yZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L2Nocm9taXVtX3BvcnRfdGVzdGNhc2UucHk6CisgICAgICAgIChDaHJvbWl1bVBvcnRUZXN0
Q2FzZS50ZXN0X2FsbF90ZXN0X2NvbmZpZ3VyYXRpb25zKTogUmVtb3ZlIGxlb3BhcmQgdGVzdGNh
c2VzLCBiZWNhdXNlIGl0IGlzbid0IHN1cHBvcnRlZCBhbnltb3JlLgorICAgICAgICAqIFNjcmlw
dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weToKKyAgICAgICAg
KFBvcnRUZXN0Q2FzZSk6IEluaGVyaXQgY2xhc3MgUG9ydFRlc3RDYXNlIGZyb20gdW5pdHRlc3Qu
VGVzdENhc2UgaW5zdGVhZCBvZiBvYmplY3QuCisKIDIwMTItMDctMDEgIENocmlzdG9waGUgRHVt
ZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgR2Ft
ZXBhZCBzdXBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5CmluZGV4IGE1NzJl
NWQ0MTE5NTE4YTA4ZGQyM2U1NDQwMzUxZTAzOGI5NDIzMGEuLjg3OTA0YTgwNDg0ODFiNTVjMTU2
ZmMzYzZiYzA3ZWRjMmJlYjcyNDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5
CkBAIC0zNSw3ICszNSw3IEBAIGZyb20gd2Via2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9j
a09wdGlvbnMKIAogY2xhc3MgQ2hyb21pdW1NYWNQb3J0VGVzdChjaHJvbWl1bV9wb3J0X3Rlc3Rj
YXNlLkNocm9taXVtUG9ydFRlc3RDYXNlKToKICAgICBvc19uYW1lID0gJ21hYycKLSAgICBvc192
ZXJzaW9uID0gJ2xlb3BhcmQnCisgICAgb3NfdmVyc2lvbiA9ICdzbm93bGVvcGFyZCcKICAgICBw
b3J0X25hbWUgPSAnY2hyb21pdW0tbWFjJwogICAgIHBvcnRfbWFrZXIgPSBjaHJvbWl1bV9tYWMu
Q2hyb21pdW1NYWNQb3J0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fcG9ydF90ZXN0Y2FzZS5weSBiL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fcG9ydF90ZXN0Y2FzZS5weQppbmRl
eCA4YjViMDJhYmRmMGFmM2NlODQ4NmVjNGI0ZDQ4OTQwOTQ0ZWVkYjY2Li5kYTZlNDBmNzVmMGFm
ZjViN2M1NjgwNjlhM2Y3Njk4OGZhMDg5YmY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3BvcnRfdGVzdGNhc2UucHkKKysrIGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9wb3J0X3Rl
c3RjYXNlLnB5CkBAIC02NCw4ICs2NCw2IEBAIGNsYXNzIENocm9taXVtUG9ydFRlc3RDYXNlKHBv
cnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoc2V0
KHBvcnQuYWxsX3Rlc3RfY29uZmlndXJhdGlvbnMoKSksIHNldChbCiAgICAgICAgICAgICBUZXN0
Q29uZmlndXJhdGlvbignaWNlY3JlYW1zYW5kd2ljaCcsICd4ODYnLCAnZGVidWcnKSwKICAgICAg
ICAgICAgIFRlc3RDb25maWd1cmF0aW9uKCdpY2VjcmVhbXNhbmR3aWNoJywgJ3g4NicsICdyZWxl
YXNlJyksCi0gICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignbGVvcGFyZCcsICd4ODYnLCAn
ZGVidWcnKSwKLSAgICAgICAgICAgIFRlc3RDb25maWd1cmF0aW9uKCdsZW9wYXJkJywgJ3g4Nics
ICdyZWxlYXNlJyksCiAgICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignc25vd2xlb3BhcmQn
LCAneDg2JywgJ2RlYnVnJyksCiAgICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignc25vd2xl
b3BhcmQnLCAneDg2JywgJ3JlbGVhc2UnKSwKICAgICAgICAgICAgIFRlc3RDb25maWd1cmF0aW9u
KCdsaW9uJywgJ3g4NicsICdkZWJ1ZycpLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CmluZGV4IDRjM2U2YjFh
OWE0ZWVjMGNjYzdmODYzZjdmNmQwMzljNDU0YzcwZjYuLjlmNzc4MzJhYTQyOWU4YzBjZmE1NzNj
NjAyOGI0N2MzOWFkMGNkYjEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKQEAgLTQ0LDcgKzQ0LDcgQEAg
ZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5jb25maWdfbW9jayBpbXBvcnQgTW9ja0Nv
bmZpZwogZnJvbSB3ZWJraXRweS50b29sLm1vY2t0b29sIGltcG9ydCBNb2NrT3B0aW9ucwogCiAK
LWNsYXNzIFBvcnRUZXN0Q2FzZShvYmplY3QpOgorY2xhc3MgUG9ydFRlc3RDYXNlKHVuaXR0ZXN0
LlRlc3RDYXNlKToKICAgICAiIiJUZXN0cyB0aGF0IGFsbCBQb3J0IGltcGxlbWVudGF0aW9ucyBt
dXN0IHBhc3MuIiIiCiAgICAgSFRUUF9QT1JUUyA9ICg4MDAwLCA4MDgwLCA4NDQzKQogICAgIFdF
QlNPQ0tFVF9QT1JUUyA9ICg4ODgwLCkK
</data>
<flag name="review"
          id="158635"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>