90369 2012-07-02 02:42:41 -0700 [EFL] Fix compilation error in GamepadsEfl.cpp in debug mode 2012-07-02 03:44:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 661349 0 cdumez 2012-07-02 02:42:41 -0700 Compilation error: /opt/tmpsantos/projects/webkit-efl/Source/WebCore/platform/efl/GamepadsEfl.cpp: In member function ‘void WebCore::GamepadsEfl::registerDevice(const WTF::String&)’: /opt/tmpsantos/projects/webkit-efl/Source/WebCore/platform/efl/GamepadsEfl.cpp:182:13: error: ‘LOG_CHANNEL_PREFIXGamepad’ was not declared in this scope /opt/tmpsantos/projects/webkit-efl/Source/WebCore/platform/efl/GamepadsEfl.cpp: In member function ‘void WebCore::GamepadsEfl::unregisterDevice(const WTF::String&)’: /opt/tmpsantos/projects/webkit-efl/Source/WebCore/platform/efl/GamepadsEfl.cpp:199:13: error: ‘LOG_CHANNEL_PREFIXGamepad’ was not declared in this scope 661350 1 150386 cdumez 2012-07-02 02:43:55 -0700 Created attachment 150386 Patch Could someone please cq+ ? 661372 2 150386 webkit.review.bot 2012-07-02 03:44:22 -0700 Comment on attachment 150386 Patch Clearing flags on attachment: 150386 Committed r121668: <http://trac.webkit.org/changeset/121668> 661373 3 webkit.review.bot 2012-07-02 03:44:26 -0700 All reviewed patches have been landed. Closing bug. 150386 2012-07-02 02:43:55 -0700 2012-07-02 03:44:22 -0700 Patch 90369_buildfix.patch text/plain 1715 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MTIxOWI2Li5hN2NlZjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDctMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBGaXggY29tcGlsYXRpb24gZXJyb3IgaW4gR2FtZXBhZHNF ZmwuY3BwIGluIGRlYnVnIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkwMzY5CisKKyAgICAgICAgVW5yZXZpZXdlZCwgRUZMIGJ1aWxkIGZpeC4K KworICAgICAgICAqIHBsYXRmb3JtL2VmbC9HYW1lcGFkc0VmbC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHYW1lcGFkc0VmbDo6cmVnaXN0ZXJEZXZpY2UpOgorICAgICAgICAoV2ViQ29yZTo6R2Ft ZXBhZHNFZmw6OnVucmVnaXN0ZXJEZXZpY2UpOgorCiAyMDEyLTA3LTAyICBWaW5lZXQgQ2hhdWRo YXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBbVjhCaW5kaW5nXSBNZXJnaW5n IHY4TnVtYmVyQXJyYXkoKS92OE51bWJlckFycmF5VG9WZWN0b3IoKSB0byB2OEFycmF5KCkvdG9O YXRpdmVBcnJheSgpIHJlc3BlY3RpdmVseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9HYW1lcGFkc0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv R2FtZXBhZHNFZmwuY3BwCmluZGV4IGJlOTMwOGIuLjUzMDQ5NmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9HYW1lcGFkc0VmbC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL0dhbWVwYWRzRWZsLmNwcApAQCAtMTc5LDggKzE3OSw2IEBAIHZvaWQg R2FtZXBhZHNFZmw6OnJlZ2lzdGVyRGV2aWNlKGNvbnN0IFN0cmluZyYgc3lzcGF0aCkKICAgICBp ZiAoIWRldmljZUZpbGUgfHwgIWVpbmFfc3RyX2hhc19wcmVmaXgoZGV2aWNlRmlsZSwgam95c3Rp Y2tQcmVmaXgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBMT0coR2FtZXBhZCwgIlJlZ2lzdGVy aW5nIGdhbWVwYWQgYXQgJXMsIGRldmljZUZpbGU6ICVzIiwgc3lzcGF0aC51dGY4KCkuZGF0YSgp LCBkZXZpY2VGaWxlKTsKLQogICAgIGNvbnN0IHNpemVfdCBzbG90Q291bnQgPSBtX3Nsb3RzLnNp emUoKTsKICAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwgc2xvdENvdW50OyArK2lu ZGV4KSB7CiAgICAgICAgIGlmICghbV9zbG90c1tpbmRleF0pIHsKQEAgLTE5Niw4ICsxOTQsNiBA QCB2b2lkIEdhbWVwYWRzRWZsOjp1bnJlZ2lzdGVyRGV2aWNlKGNvbnN0IFN0cmluZyYgc3lzcGF0 aCkKICAgICBpZiAoIW1fZGV2aWNlTWFwLmNvbnRhaW5zKHN5c3BhdGgpKQogICAgICAgICByZXR1 cm47CiAKLSAgICBMT0coR2FtZXBhZCwgIlJlZ2lzdGVyaW5nIGdhbWVwYWQgYXQgJXMsIiwgc3lz cGF0aC51dGY4KCkuZGF0YSgpKTsKLQogICAgIEdhbWVwYWREZXZpY2VFZmwqIGdhbWVwYWREZXZp Y2UgPSBtX2RldmljZU1hcC50YWtlKHN5c3BhdGgpOwogICAgIGNvbnN0IHNpemVfdCBpbmRleCA9 IG1fc2xvdHMuZmluZChnYW1lcGFkRGV2aWNlKTsKICAgICBBU1NFUlQoaW5kZXggIT0gbm90Rm91 bmQpOwo=