90351 2012-07-01 14:22:39 -0700 IndexedDB custom bindings missing String type 2012-07-10 21:45:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos charles.wei jsbell levin rwlbuis tonikitoo webkit.review.bot yong.li.webkit zimmermann oldest_to_newest 661164 0 staikos 2012-07-01 14:22:39 -0700 JSIDBAnyCustom is missing support for String in the switch. 661165 1 150338 staikos 2012-07-01 14:24:16 -0700 Created attachment 150338 Patch to implement String 661223 2 150338 charles.wei 2012-07-01 19:07:57 -0700 Comment on attachment 150338 Patch to implement String LGTM. 661227 3 150338 charles.wei 2012-07-01 19:14:13 -0700 Comment on attachment 150338 Patch to implement String commit. 661228 4 150338 webkit.review.bot 2012-07-01 19:14:52 -0700 Comment on attachment 150338 Patch to implement String Rejecting attachment 150338 from review queue. charles.wei@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 663832 5 staikos 2012-07-05 18:59:12 -0700 Adding some indexeddb gurus for thoughts on this two-line patch :) 664420 6 staikos 2012-07-07 14:51:21 -0700 Can anyone review this? It's a two line patch. 664426 7 150338 zimmermann 2012-07-07 15:28:52 -0700 Comment on attachment 150338 Patch to implement String Doesn't this need a test? (Or is it untestable at present?) 664427 8 staikos 2012-07-07 15:48:11 -0700 (In reply to comment #7) > (From update of attachment 150338 [details]) > Doesn't this need a test? (Or is it untestable at present?) Not sure. Maybe Charles can comment. I'd hope the tests already are present. 664428 9 jsbell 2012-07-07 15:49:36 -0700 Is the stringToUstring call necessary? The JSIDBKeyCustom impl doesn't have it. This will be covered by existing IDB key path tests when enabled for a port. IDBAny::StringType was a recent addition and I failed to account for the JSC version when I added it. Looks good from an IDB perspective. 664440 10 staikos 2012-07-07 19:11:19 -0700 (In reply to comment #9) > Is the stringToUstring call necessary? The JSIDBKeyCustom impl doesn't have it. > > This will be covered by existing IDB key path tests when enabled for a port. IDBAny::StringType was a recent addition and I failed to account for the JSC version when I added it. > > Looks good from an IDB perspective. Seems to be the case. Updating the patch now. 664441 11 151152 staikos 2012-07-07 19:12:03 -0700 Created attachment 151152 Patch to implement String 664480 12 151152 zimmermann 2012-07-08 05:26:18 -0700 Comment on attachment 151152 Patch to implement String View in context: https://bugs.webkit.org/attachment.cgi?id=151152&action=review rs=me, please modify the ChangeLog before landing: > Source/WebCore/ChangeLog:7 > + Joshuas explanation should be added to the ChangeLog. It's missing the "why" answers, as discussed recently on webkit-dev. Just include a line saying that this is covered by existing tests for ports that use JSC and have IndexDB available - at least that's how I understand it. 666254 13 151574 staikos 2012-07-10 18:55:33 -0700 Created attachment 151574 Patch to implement String 666329 14 151574 webkit.review.bot 2012-07-10 21:45:17 -0700 Comment on attachment 151574 Patch to implement String Clearing flags on attachment: 151574 Committed r122295: <http://trac.webkit.org/changeset/122295> 666330 15 webkit.review.bot 2012-07-10 21:45:23 -0700 All reviewed patches have been landed. Closing bug. 150338 2012-07-01 14:24:16 -0700 2012-07-07 19:12:03 -0700 Patch to implement String 90351.patch text/plain 1247 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTAxICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgbWlzc2luZyBiaW5k aW5nIHR5cGUgU3RyaW5nIGZvciBJbmRleGVkREIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6dG9KUyk6CisKIDIwMTItMDctMDEgIEtvbnJhZCBQaWFzY2lrICA8 a3BpYXNjaWtAcmltLmNvbT4KIAogICAgICAgICBbRUZMXSBbR1RLXSBbUVRdIGZhc3Qvdmlld3Bv cnQvdmlld3BvcnQtOTEuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHIxMjE1NTUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQkFueUN1c3RvbS5jcHAJKHJldmlzaW9uIDEy MTExOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3VzdG9tLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjQsNiArNjQsOCBAQCBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBl eGVjLCBKU0RPTUdsb2JhCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwogICAgIGNhc2Ug SURCQW55OjpOdWxsVHlwZToKICAgICAgICAgcmV0dXJuIGpzTnVsbCgpOworICAgIGNhc2UgSURC QW55OjpTdHJpbmdUeXBlOgorICAgICAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgc3RyaW5nVG9V U3RyaW5nKGlkYkFueS0+c3RyaW5nKCkpKTsKICAgICBjYXNlIElEQkFueTo6RE9NU3RyaW5nTGlz dFR5cGU6CiAgICAgICAgIHJldHVybiB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCwgaWRiQW55LT5k b21TdHJpbmdMaXN0KCkpOwogICAgIGNhc2UgSURCQW55OjpJREJDdXJzb3JUeXBlOgo= 151152 2012-07-07 19:12:03 -0700 2012-07-10 18:55:33 -0700 Patch to implement String 90351.patch text/plain 1230 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTAxICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgbWlzc2luZyBiaW5k aW5nIHR5cGUgU3RyaW5nIGZvciBJbmRleGVkREIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6dG9KUyk6CisKIDIwMTItMDctMDEgIEtvbnJhZCBQaWFzY2lrICA8 a3BpYXNjaWtAcmltLmNvbT4KIAogICAgICAgICBbRUZMXSBbR1RLXSBbUVRdIGZhc3Qvdmlld3Bv cnQvdmlld3BvcnQtOTEuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHIxMjE1NTUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQkFueUN1c3RvbS5jcHAJKHJldmlzaW9uIDEy MTExOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3VzdG9tLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjQsNiArNjQsOCBAQCBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBl eGVjLCBKU0RPTUdsb2JhCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwogICAgIGNhc2Ug SURCQW55OjpOdWxsVHlwZToKICAgICAgICAgcmV0dXJuIGpzTnVsbCgpOworICAgIGNhc2UgSURC QW55OjpTdHJpbmdUeXBlOgorICAgICAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgaWRiQW55LT5z dHJpbmcoKSk7CiAgICAgY2FzZSBJREJBbnk6OkRPTVN0cmluZ0xpc3RUeXBlOgogICAgICAgICBy ZXR1cm4gdG9KUyhleGVjLCBnbG9iYWxPYmplY3QsIGlkYkFueS0+ZG9tU3RyaW5nTGlzdCgpKTsK ICAgICBjYXNlIElEQkFueTo6SURCQ3Vyc29yVHlwZToK 151574 2012-07-10 18:55:33 -0700 2012-07-10 21:45:17 -0700 Patch to implement String 90351.patch text/plain 1301 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTAxICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgbWlzc2luZyBiaW5k aW5nIHR5cGUgU3RyaW5nIGZvciBJbmRleGVkREIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5pa29s YXMgWmltbWVybWFubi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBpdCdzIGFscmVh ZHkgY292ZXJlZCBieSBJREIgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0lEQkFu eUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0pTKToKKwogMjAxMi0wNy0wMSAgS29u cmFkIFBpYXNjaWsgIDxrcGlhc2Npa0ByaW0uY29tPgogCiAgICAgICAgIFtFRkxdIFtHVEtdIFtR VF0gZmFzdC92aWV3cG9ydC92aWV3cG9ydC05MS5odG1sIGlzIGZhaWxpbmcgYWZ0ZXIgcjEyMTU1 NQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3VzdG9tLmNw cAkocmV2aXNpb24gMTIxMTE5KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJREJB bnlDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2ICs2NCw4IEBAIEpTVmFsdWUgdG9K UyhFeGVjU3RhdGUqIGV4ZWMsIEpTRE9NR2xvYmEKICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVk KCk7CiAgICAgY2FzZSBJREJBbnk6Ok51bGxUeXBlOgogICAgICAgICByZXR1cm4ganNOdWxsKCk7 CisgICAgY2FzZSBJREJBbnk6OlN0cmluZ1R5cGU6CisgICAgICAgIHJldHVybiBqc1N0cmluZyhl eGVjLCBpZGJBbnktPnN0cmluZygpKTsKICAgICBjYXNlIElEQkFueTo6RE9NU3RyaW5nTGlzdFR5 cGU6CiAgICAgICAgIHJldHVybiB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCwgaWRiQW55LT5kb21T dHJpbmdMaXN0KCkpOwogICAgIGNhc2UgSURCQW55OjpJREJDdXJzb3JUeXBlOgo=