90332 2012-06-30 00:48:53 -0700 [GTK] Need to bump libsoup requirements (for `soup_cookie_jar_get_cookie_list`) 2012-07-03 08:48:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 plaes webkit-unassigned cdumez gustavo webkit.review.bot xan.lopez oldest_to_newest 661012 0 plaes 2012-06-30 00:48:53 -0700 Getting following error when trying to build master: [snip] Source/WebCore/platform/network/soup/CookieJarSoup.cpp: In function ‘void WebCore::setCookies(WebCore::Document*, const WebCore::KURL&, const WTF::String&)’: Source/WebCore/platform/network/soup/CookieJarSoup.cpp:99:86: error: ‘soup_cookie_jar_get_cookie_list’ was not declared in this scope Source/WebCore/platform/network/soup/CookieJarSoup.cpp:117:92: error: ‘soup_cookie_jar_add_cookie_with_first_party’ was not declared in this scope [/snip] 661013 1 150310 plaes 2012-06-30 00:52:31 -0700 Created attachment 150310 webkit-bump-libsoup-to-2-39-3.patch 661014 2 150310 gustavo 2012-06-30 01:02:44 -0700 Comment on attachment 150310 webkit-bump-libsoup-to-2-39-3.patch Attachment 150310 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13110630 661015 3 plaes 2012-06-30 01:04:36 -0700 (In reply to comment #2) > (From update of attachment 150310 [details]) > Attachment 150310 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/13110630 > checking for LIBSOUP... no > configure: error: Package requirements (libsoup-2.4 >= 2.39.3) were not met: > > Requested 'libsoup-2.4 >= 2.39.3' but version of libsoup is 2.39.2 soup_cookie_jar_add_cookie_with_first_party() was added in 2.39.3 661016 4 150311 plaes 2012-06-30 01:08:08 -0700 Created attachment 150311 webkit-bump-libsoup-to-2-39-2.patch 661017 5 150311 cdumez 2012-06-30 01:40:33 -0700 Comment on attachment 150311 webkit-bump-libsoup-to-2-39-2.patch LGTM. Sorry I forgot to do that. 662255 6 150311 webkit.review.bot 2012-07-03 08:48:54 -0700 Comment on attachment 150311 webkit-bump-libsoup-to-2-39-2.patch Clearing flags on attachment: 150311 Committed r121772: <http://trac.webkit.org/changeset/121772> 662257 7 webkit.review.bot 2012-07-03 08:48:59 -0700 All reviewed patches have been landed. Closing bug. 150310 2012-06-30 00:52:31 -0700 2012-06-30 01:08:08 -0700 webkit-bump-libsoup-to-2-39-3.patch 0001-2012-06-30-Priit-Laes-plaes-plaes.org.patch text/plain 1456 plaes RnJvbSBkYjA3MDcwN2IxNmFhMDlhM2YyYWE3YThiZmMxYTQxY2VhMmIwZmU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFNh dCwgMzAgSnVuIDIwMTIgMTA6NTE6MTYgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA2LTMw ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBbR1RLXSBOZWVkIHRvIGJ1 bXAgbGlic291cCByZXF1aXJlbWVudHMgKGZvciBgc291cF9jb29raWVfamFyX2dldF9jb29raWVf bGlzdGApCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkw MzMyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIGNvbmZp Z3VyZS5hYzogQnVtcCBsaWJzb3VwIHJlcXVpcmVtZW50cyB0byAyLjM5LjMKLS0tCiBDaGFuZ2VM b2cgICAgfCAgICA5ICsrKysrKysrKwogY29uZmlndXJlLmFjIHwgICAgMiArLQogMiBmaWxlcyBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0No YW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWY0NmZjLi42ZGQyNzVhIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMzAgIFBy aWl0IExhZXMgIDxwbGFlc0BwbGFlcy5vcmc+CisKKyAgICAgICAgW0dUS10gTmVlZCB0byBidW1w IGxpYnNvdXAgcmVxdWlyZW1lbnRzIChmb3IgYHNvdXBfY29va2llX2phcl9nZXRfY29va2llX2xp c3RgKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAz MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNv bmZpZ3VyZS5hYzogQnVtcCBsaWJzb3VwIHJlcXVpcmVtZW50cyB0byAyLjM5LjMKKwogMjAxMi0w Ni0yOSAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAbm9raWEuY29tPgogCiAgICAgICAg IFtRdF1bV0syXSBQcml2YXRlIG5vbi1RdFF1aWNrIEFQSQpkaWZmIC0tZ2l0IGEvY29uZmlndXJl LmFjIGIvY29uZmlndXJlLmFjCmluZGV4IGU5Y2NmZmYzLi5iZTE2MmEyIDEwMDY0NAotLS0gYS9j b25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0zNzMsNyArMzczLDcgQEAgQ0FJUk9f UkVRVUlSRURfVkVSU0lPTj0xLjEwCiBGT05UQ09ORklHX1JFUVVJUkVEX1ZFUlNJT049Mi40CiBG UkVFVFlQRTJfUkVRVUlSRURfVkVSU0lPTj05LjAKIEdMSUJfUkVRVUlSRURfVkVSU0lPTj0yLjMy LjAKLUxJQlNPVVBfUkVRVUlSRURfVkVSU0lPTj0yLjM3LjkyCitMSUJTT1VQX1JFUVVJUkVEX1ZF UlNJT049Mi4zOS4zCiBMSUJYTUxfUkVRVUlSRURfVkVSU0lPTj0yLjYKIFBBTkdPX1JFUVVJUkVE X1ZFUlNJT049MS4yMS4wCiAKLS0gCjEuNy44LjYKCg== 150311 2012-06-30 01:08:08 -0700 2012-07-03 08:48:53 -0700 webkit-bump-libsoup-to-2-39-2.patch 0001-2012-06-30-Priit-Laes-plaes-plaes.org.patch text/plain 1456 plaes RnJvbSA5MjRkYzE2ODMyZDY2MzNhZjRlZDhhODM0YWRlZTMxM2UyOTliMjY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFNh dCwgMzAgSnVuIDIwMTIgMTA6NTE6MTYgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA2LTMw ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBbR1RLXSBOZWVkIHRvIGJ1 bXAgbGlic291cCByZXF1aXJlbWVudHMgKGZvciBgc291cF9jb29raWVfamFyX2dldF9jb29raWVf bGlzdGApCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkw MzMyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIGNvbmZp Z3VyZS5hYzogQnVtcCBsaWJzb3VwIHJlcXVpcmVtZW50cyB0byAyLjM5LjIKLS0tCiBDaGFuZ2VM b2cgICAgfCAgICA5ICsrKysrKysrKwogY29uZmlndXJlLmFjIHwgICAgMiArLQogMiBmaWxlcyBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0No YW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWY0NmZjLi40OGJlOWU3IDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMzAgIFBy aWl0IExhZXMgIDxwbGFlc0BwbGFlcy5vcmc+CisKKyAgICAgICAgW0dUS10gTmVlZCB0byBidW1w IGxpYnNvdXAgcmVxdWlyZW1lbnRzIChmb3IgYHNvdXBfY29va2llX2phcl9nZXRfY29va2llX2xp c3RgKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAz MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNv bmZpZ3VyZS5hYzogQnVtcCBsaWJzb3VwIHJlcXVpcmVtZW50cyB0byAyLjM5LjIKKwogMjAxMi0w Ni0yOSAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAbm9raWEuY29tPgogCiAgICAgICAg IFtRdF1bV0syXSBQcml2YXRlIG5vbi1RdFF1aWNrIEFQSQpkaWZmIC0tZ2l0IGEvY29uZmlndXJl LmFjIGIvY29uZmlndXJlLmFjCmluZGV4IGU5Y2NmZmYzLi5lZGM1NzQ0IDEwMDY0NAotLS0gYS9j b25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0zNzMsNyArMzczLDcgQEAgQ0FJUk9f UkVRVUlSRURfVkVSU0lPTj0xLjEwCiBGT05UQ09ORklHX1JFUVVJUkVEX1ZFUlNJT049Mi40CiBG UkVFVFlQRTJfUkVRVUlSRURfVkVSU0lPTj05LjAKIEdMSUJfUkVRVUlSRURfVkVSU0lPTj0yLjMy LjAKLUxJQlNPVVBfUkVRVUlSRURfVkVSU0lPTj0yLjM3LjkyCitMSUJTT1VQX1JFUVVJUkVEX1ZF UlNJT049Mi4zOS4yCiBMSUJYTUxfUkVRVUlSRURfVkVSU0lPTj0yLjYKIFBBTkdPX1JFUVVJUkVE X1ZFUlNJT049MS4yMS4wCiAKLS0gCjEuNy44LjYKCg==