90311 2012-06-29 14:30:23 -0700 Shape-inside / shape-outside should support percent-based measurements 2012-07-19 11:24:21 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://dev.w3.org/csswg/css3-exclusions/#shapes-from-svg-syntax P2 Normal --- 89671 1 betravis bjonesbe cmarcelo macpherson menard michelangelo webkit.review.bot oldest_to_newest 660788 0 betravis 2012-06-29 14:30:23 -0700 Wrap shapes currently only support lengths, they should support percentages as well 672571 1 153056 bjonesbe 2012-07-18 11:30:42 -0700 Created attachment 153056 Proposed bug fix Update the CSS Parser to accept percentage length values for exclusion shapes. Also add tests for this. 673644 2 153056 kling 2012-07-19 10:31:54 -0700 Comment on attachment 153056 Proposed bug fix LGTM. 673719 3 153056 webkit.review.bot 2012-07-19 11:24:15 -0700 Comment on attachment 153056 Proposed bug fix Clearing flags on attachment: 153056 Committed r123126: <http://trac.webkit.org/changeset/123126> 673720 4 webkit.review.bot 2012-07-19 11:24:21 -0700 All reviewed patches have been landed. Closing bug. 153056 2012-07-18 11:30:42 -0700 2012-07-19 11:24:15 -0700 Proposed bug fix 90311.patch text/plain 7272 bjonesbe ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YTU0Yzg1Li4zYzdlOTgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDct MTggIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAgICAgICAgU2hhcGUt aW5zaWRlIC8gc2hhcGUtb3V0c2lkZSBzaG91bGQgc3VwcG9ydCBwZXJjZW50LWJhc2VkIG1lYXN1 cmVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTAzMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCB0ZXN0cyBmb3IgcGVyY2VudCBiYXNlZCBsZW5ndGhzIGZvciBleGNsdXNpb24gc2hhcGVz LgorCisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3BhcnNpbmctd3JhcC1zaGFwZS1sZW5ndGhz LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMvcGFyc2luZy13cmFwLXNo YXBlLWxlbmd0aHMuaHRtbDoKKwogMjAxMi0wNy0xOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIENvbnZlcnQgc3ZnL2Nzcy9zY2llbnRpZmljLW51bWJlcnMuaHRt bCB0byBhIHRleHQgb25seSB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1 c2lvbnMvcGFyc2luZy13cmFwLXNoYXBlLWxlbmd0aHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9leGNsdXNpb25zL3BhcnNpbmctd3JhcC1zaGFwZS1sZW5ndGhzLWV4cGVjdGVkLnR4 dAppbmRleCAzY2YxOTI4Li5lMTU4Y2RkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V4 Y2x1c2lvbnMvcGFyc2luZy13cmFwLXNoYXBlLWxlbmd0aHMtZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9wYXJzaW5nLXdyYXAtc2hhcGUtbGVuZ3Rocy1leHBl Y3RlZC50eHQKQEAgLTIxLDYgKzIxLDE0IEBAIFBBU1MgaW5uZXJTdHlsZSgiLXdlYmtpdC1zaGFw ZS1pbnNpZGUiLCAiY2lyY2xlKDF2bWluLCAxdm1pbiwgMXZtaW4pIikgaXMgImNpcmNsCiBQQVNT IGNvbXB1dGVkU3R5bGUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZSguNXZ3LCAxdncs IDEuNXZ3KSIpIGlzICJjaXJjbGUoMC41dncsIDF2dywgMS41dncpIgogUEFTUyBjb21wdXRlZFN0 eWxlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJjaXJjbGUoLjV2aCwgMXZoLCAxLjV2aCkiKSBp cyAiY2lyY2xlKDAuNXZoLCAxdmgsIDEuNXZoKSIKIFBBU1MgY29tcHV0ZWRTdHlsZSgiLXdlYmtp dC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKC41dm1pbiwgMXZtaW4sIDEuNXZtaW4pIikgaXMgImNp cmNsZSgwLjV2bWluLCAxdm1pbiwgMS41dm1pbikiCitQQVNTIGlubmVyU3R5bGUoIi13ZWJraXQt c2hhcGUtaW5zaWRlIiwgImNpcmNsZSgxMDAlLCAxMDAlLCAxMDAlKSIpIGlzICJjaXJjbGUoMTAw JSwgMTAwJSwgMTAwJSkiCitQQVNTIGlubmVyU3R5bGUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwg InJlY3RhbmdsZSg0NSUsIDQ1JSwgOTAlLCA2MCUsIDI1JSwgMTAlKSIpIGlzICJyZWN0YW5nbGUo NDUlLCA0NSUsIDkwJSwgNjAlLCAyNSUsIDEwJSkiCitQQVNTIGlubmVyU3R5bGUoIi13ZWJraXQt c2hhcGUtaW5zaWRlIiwgImVsbGlwc2UoMTAwJSwgMTAwJSwgMTAwJSwgMTAwJSkiKSBpcyAiZWxs aXBzZSgxMDAlLCAxMDAlLCAxMDAlLCAxMDAlKSIKK1BBU1MgaW5uZXJTdHlsZSgiLXdlYmtpdC1z aGFwZS1pbnNpZGUiLCAicG9seWdvbigxMCUgMjAlLCAzMCUgNDAlLCA0MCUgNTAlKSIpIGlzICJw b2x5Z29uKG5vbnplcm8sIDEwJSAyMCUsIDMwJSA0MCUsIDQwJSA1MCUpIgorUEFTUyBjb21wdXRl ZFN0eWxlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJjaXJjbGUoNTAlLCAxMDAlLCAxNTAlKSIp IGlzICJjaXJjbGUoNTAlLCAxMDAlLCAxNTAlKSIKK1BBU1MgY29tcHV0ZWRTdHlsZSgiLXdlYmtp dC1zaGFwZS1pbnNpZGUiLCAicmVjdGFuZ2xlKDQ1JSwgNDUlLCA5MCUsIDYwJSwgMjUlLCAxMCUp IikgaXMgInJlY3RhbmdsZSg0NSUsIDQ1JSwgOTAlLCA2MCUsIDI1JSwgMTAlKSIKK1BBU1MgY29t cHV0ZWRTdHlsZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiZWxsaXBzZSgxMDAlLCAxMDAlLCAx MDAlLCAxMDAlKSIpIGlzICJlbGxpcHNlKDEwMCUsIDEwMCUsIDEwMCUsIDEwMCUpIgorUEFTUyBj b21wdXRlZFN0eWxlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJwb2x5Z29uKDEwJSAyMCUsIDMw JSA0MCUsIDQwJSA1MCUpIikgaXMgInBvbHlnb24obm9uemVybywgMTAlIDIwJSwgMzAlIDQwJSwg NDAlIDUwJSkiCiBQQVNTIGlubmVyU3R5bGUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNs ZSgxcHgsIDFweCwgMSkiKSBpcyBudWxsCiBQQVNTIGNvbXB1dGVkU3R5bGUoIi13ZWJraXQtc2hh cGUtaW5zaWRlIiwgImNpcmNsZSgxcHgsIDFweCwgMSkiKSBpcyAiYXV0byIKIFBBU1MgaW5uZXJT dHlsZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKDFweCwgMXB4LCBweCkiKSBpcyBu dWxsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvcGFyc2luZy13cmFw LXNoYXBlLWxlbmd0aHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9wYXJzaW5n LXdyYXAtc2hhcGUtbGVuZ3Rocy5odG1sCmluZGV4IGM2OWQ1ODcuLjI0MWQxMDkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9wYXJzaW5nLXdyYXAtc2hhcGUtbGVuZ3Ro cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9wYXJzaW5nLXdyYXAtc2hh cGUtbGVuZ3Rocy5odG1sCkBAIC03Miw2ICs3MiwxNyBAQCB0ZXN0Q29tcHV0ZWQoIi13ZWJraXQt c2hhcGUtaW5zaWRlIiwgImNpcmNsZSguNXZ3LCAxdncsIDEuNXZ3KSIsICJjaXJjbGUoMC41dncs CiB0ZXN0Q29tcHV0ZWQoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZSguNXZoLCAxdmgs IDEuNXZoKSIsICJjaXJjbGUoMC41dmgsIDF2aCwgMS41dmgpIik7CiB0ZXN0Q29tcHV0ZWQoIi13 ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZSguNXZtaW4sIDF2bWluLCAxLjV2bWluKSIsICJj aXJjbGUoMC41dm1pbiwgMXZtaW4sIDEuNXZtaW4pIik7CiAKKy8vIHBlcmNlbnRhZ2UgbGVuZ3Ro cyAtIHVuaXRzCit0ZXN0SW5uZXIoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZSgxMDAl LCAxMDAlLCAxMDAlKSIsICJjaXJjbGUoMTAwJSwgMTAwJSwgMTAwJSkiKTsKK3Rlc3RJbm5lcigi LXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAicmVjdGFuZ2xlKDQ1JSwgNDUlLCA5MCUsIDYwJSwgMjUl LCAxMCUpIiwgInJlY3RhbmdsZSg0NSUsIDQ1JSwgOTAlLCA2MCUsIDI1JSwgMTAlKSIpOwordGVz dElubmVyKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJlbGxpcHNlKDEwMCUsIDEwMCUsIDEwMCUs IDEwMCUpIiwgImVsbGlwc2UoMTAwJSwgMTAwJSwgMTAwJSwgMTAwJSkiKTsKK3Rlc3RJbm5lcigi LXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAicG9seWdvbigxMCUgMjAlLCAzMCUgNDAlLCA0MCUgNTAl KSIsICJwb2x5Z29uKG5vbnplcm8sIDEwJSAyMCUsIDMwJSA0MCUsIDQwJSA1MCUpIik7CisKK3Rl c3RDb21wdXRlZCgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKDUwJSwgMTAwJSwgMTUw JSkiLCAiY2lyY2xlKDUwJSwgMTAwJSwgMTUwJSkiKTsKK3Rlc3RDb21wdXRlZCgiLXdlYmtpdC1z aGFwZS1pbnNpZGUiLCAicmVjdGFuZ2xlKDQ1JSwgNDUlLCA5MCUsIDYwJSwgMjUlLCAxMCUpIiwg InJlY3RhbmdsZSg0NSUsIDQ1JSwgOTAlLCA2MCUsIDI1JSwgMTAlKSIpOwordGVzdENvbXB1dGVk KCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJlbGxpcHNlKDEwMCUsIDEwMCUsIDEwMCUsIDEwMCUp IiwgImVsbGlwc2UoMTAwJSwgMTAwJSwgMTAwJSwgMTAwJSkiKTsKK3Rlc3RDb21wdXRlZCgiLXdl YmtpdC1zaGFwZS1pbnNpZGUiLCAicG9seWdvbigxMCUgMjAlLCAzMCUgNDAlLCA0MCUgNTAlKSIs ICJwb2x5Z29uKG5vbnplcm8sIDEwJSAyMCUsIDMwJSA0MCUsIDQwJSA1MCUpIik7CisKIC8vIHJl amVjdCBub24tbGVuZ3RocwogbmVnYXRpdmVUZXN0KCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJj aXJjbGUoMXB4LCAxcHgsIDEpIik7CiBuZWdhdGl2ZVRlc3QoIi13ZWJraXQtc2hhcGUtaW5zaWRl IiwgImNpcmNsZSgxcHgsIDFweCwgcHgpIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBiMDU5Ni4uNjU4YjMx OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA3LTE4ICBCZW0gSm9uZXMtQmV5 ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFNoYXBlLWluc2lkZSAvIHNoYXBlLW91 dHNpZGUgc2hvdWxkIHN1cHBvcnQgcGVyY2VudC1iYXNlZCBtZWFzdXJlbWVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMzExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBDU1MgUGFy c2VyIHRvIGFjY2VwdCBwZXJjZW50YWdlIGxlbmd0aCB2YWx1ZXMgZm9yIGV4Y2x1c2lvbgorICAg ICAgICBzaGFwZXMuCisKKyAgICAgICAgVGVzdGluZyBhZGRlZCB0byBMYXlvdXRUZXN0cy9mYXN0 L2V4Y2x1c2lvbnMvcGFyc2luZy13cmFwLXNoYXBlLWxlbmd0aHMuaHRtbAorCisgICAgICAgICog Y3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRXhj bHVzaW9uU2hhcGVSZWN0YW5nbGUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJz ZUV4Y2x1c2lvblNoYXBlQ2lyY2xlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFy c2VFeGNsdXNpb25TaGFwZUVsbGlwc2UpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpw YXJzZUV4Y2x1c2lvblNoYXBlUG9seWdvbik6CisKIDIwMTItMDctMTggIFJvYiBCdWlzICA8cmJ1 aXNAcmltLmNvbT4KIAogICAgICAgICBBbGlnbm1lbnQgY3Jhc2ggaW4gTUlNRVNuaWZmZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggYmFhMzJkZi4uNjQwYWYwMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTQ0NjUsNyArNDQ2NSw3IEBAIFBhc3NSZWZQdHI8Q1NTV3JhcFNo YXBlPiBDU1NQYXJzZXI6OnBhcnNlRXhjbHVzaW9uU2hhcGVSZWN0YW5nbGUoQ1NTUGFyc2VyVmFs dWVMCiAgICAgdW5zaWduZWQgYXJndW1lbnROdW1iZXIgPSAwOwogICAgIENTU1BhcnNlclZhbHVl KiBhcmd1bWVudCA9IGFyZ3MtPmN1cnJlbnQoKTsKICAgICB3aGlsZSAoYXJndW1lbnQpIHsKLSAg ICAgICAgaWYgKCF2YWxpZFVuaXQoYXJndW1lbnQsIEZMZW5ndGgpKQorICAgICAgICBpZiAoIXZh bGlkVW5pdChhcmd1bWVudCwgRkxlbmd0aCB8IEZQZXJjZW50KSkKICAgICAgICAgICAgIHJldHVy biAwOwogCiAgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gbGVuZ3RoID0gY3JlYXRl UHJpbWl0aXZlTnVtZXJpY1ZhbHVlKGFyZ3VtZW50KTsKQEAgLTQ1MTgsNyArNDUxOCw3IEBAIFBh c3NSZWZQdHI8Q1NTV3JhcFNoYXBlPiBDU1NQYXJzZXI6OnBhcnNlRXhjbHVzaW9uU2hhcGVDaXJj bGUoQ1NTUGFyc2VyVmFsdWVMaXN0CiAgICAgdW5zaWduZWQgYXJndW1lbnROdW1iZXIgPSAwOwog ICAgIENTU1BhcnNlclZhbHVlKiBhcmd1bWVudCA9IGFyZ3MtPmN1cnJlbnQoKTsKICAgICB3aGls ZSAoYXJndW1lbnQpIHsKLSAgICAgICAgaWYgKCF2YWxpZFVuaXQoYXJndW1lbnQsIEZMZW5ndGgp KQorICAgICAgICBpZiAoIXZhbGlkVW5pdChhcmd1bWVudCwgRkxlbmd0aCB8IEZQZXJjZW50KSkK ICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1 ZT4gbGVuZ3RoID0gY3JlYXRlUHJpbWl0aXZlTnVtZXJpY1ZhbHVlKGFyZ3VtZW50KTsKQEAgLTQ1 NjEsNyArNDU2MSw3IEBAIFBhc3NSZWZQdHI8Q1NTV3JhcFNoYXBlPiBDU1NQYXJzZXI6OnBhcnNl RXhjbHVzaW9uU2hhcGVFbGxpcHNlKENTU1BhcnNlclZhbHVlTGlzCiAgICAgdW5zaWduZWQgYXJn dW1lbnROdW1iZXIgPSAwOwogICAgIENTU1BhcnNlclZhbHVlKiBhcmd1bWVudCA9IGFyZ3MtPmN1 cnJlbnQoKTsKICAgICB3aGlsZSAoYXJndW1lbnQpIHsKLSAgICAgICAgaWYgKCF2YWxpZFVuaXQo YXJndW1lbnQsIEZMZW5ndGgpKQorICAgICAgICBpZiAoIXZhbGlkVW5pdChhcmd1bWVudCwgRkxl bmd0aCB8IEZQZXJjZW50KSkKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIFJlZlB0 cjxDU1NQcmltaXRpdmVWYWx1ZT4gbGVuZ3RoID0gY3JlYXRlUHJpbWl0aXZlTnVtZXJpY1ZhbHVl KGFyZ3VtZW50KTsKQEAgLTQ2MjIsMTEgKzQ2MjIsMTEgQEAgUGFzc1JlZlB0cjxDU1NXcmFwU2hh cGU+IENTU1BhcnNlcjo6cGFyc2VFeGNsdXNpb25TaGFwZVBvbHlnb24oQ1NTUGFyc2VyVmFsdWVM aXMKIAogICAgIENTU1BhcnNlclZhbHVlKiBhcmd1bWVudFggPSBhcmd1bWVudDsKICAgICB3aGls ZSAoYXJndW1lbnRYKSB7Ci0gICAgICAgIGlmICghdmFsaWRVbml0KGFyZ3VtZW50WCwgRkxlbmd0 aCkpCisgICAgICAgIGlmICghdmFsaWRVbml0KGFyZ3VtZW50WCwgRkxlbmd0aCB8IEZQZXJjZW50 KSkKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIENTU1BhcnNlclZhbHVlKiBhcmd1 bWVudFkgPSBhcmdzLT5uZXh0KCk7Ci0gICAgICAgIGlmICghYXJndW1lbnRZIHx8ICF2YWxpZFVu aXQoYXJndW1lbnRZLCBGTGVuZ3RoKSkKKyAgICAgICAgaWYgKCFhcmd1bWVudFkgfHwgIXZhbGlk VW5pdChhcmd1bWVudFksIEZMZW5ndGggfCBGUGVyY2VudCkpCiAgICAgICAgICAgICByZXR1cm4g MDsKIAogICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHhMZW5ndGggPSBjcmVhdGVQ cmltaXRpdmVOdW1lcmljVmFsdWUoYXJndW1lbnRYKTsK