90302 2012-06-29 13:03:22 -0700 Remove warning about protected values when the Heap is being destroyed 2012-06-29 18:14:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren webkit.review.bot oldest_to_newest 660727 0 mhahnenberg 2012-06-29 13:03:22 -0700 Having to do book-keeping about whether values allocated from a certain VM are or are not protected makes the JSC API much more difficult to use correctly. Clients should be able to throw an entire VM away and not have to worry about unprotecting all of the values that they protected earlier. 660730 1 150241 mhahnenberg 2012-06-29 13:12:45 -0700 Created attachment 150241 Patch 660735 2 mhahnenberg 2012-06-29 13:15:13 -0700 <rdar://problem/11760002> 660759 3 150241 ggaren 2012-06-29 13:46:45 -0700 Comment on attachment 150241 Patch r=me 660903 4 150241 webkit.review.bot 2012-06-29 18:14:25 -0700 Comment on attachment 150241 Patch Clearing flags on attachment: 150241 Committed r121607: <http://trac.webkit.org/changeset/121607> 660904 5 webkit.review.bot 2012-06-29 18:14:29 -0700 All reviewed patches have been landed. Closing bug. 150241 2012-06-29 13:12:45 -0700 2012-06-29 18:14:25 -0700 Patch bug-90302-20120629131245.patch text/plain 1720 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxNTgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA2LTI5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIHdhcm5pbmcgYWJvdXQgcHJvdGVjdGVkIHZhbHVlcyB3aGVuIHRoZSBI ZWFwIGlzIGJlaW5nIGRlc3Ryb3llZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTAzMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBIYXZpbmcgdG8gZG8gYm9vay1rZWVwaW5nIGFib3V0IHdoZXRoZXIgdmFs dWVzIGFsbG9jYXRlZCBmcm9tIGEgY2VydGFpbiAKKyAgICAgICAgVk0gYXJlIG9yIGFyZSBub3Qg cHJvdGVjdGVkIG1ha2VzIHRoZSBKU0MgQVBJIG11Y2ggbW9yZSBkaWZmaWN1bHQgdG8gdXNlIAor ICAgICAgICBjb3JyZWN0bHkuIENsaWVudHMgc2hvdWxkIGJlIGFibGUgdG8gdGhyb3cgYW4gZW50 aXJlIFZNIGF3YXkgYW5kIG5vdCBoYXZlIAorICAgICAgICB0byB3b3JyeSBhYm91dCB1bnByb3Rl Y3RpbmcgYWxsIG9mIHRoZSB2YWx1ZXMgdGhhdCB0aGV5IHByb3RlY3RlZCBlYXJsaWVyLgorCisg ICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6bGFzdENoYW5jZVRv RmluYWxpemUpOgorCiAyMDEyLTA2LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgREZHIHJlY29tcGlsYXRpb24gaGV1cmlzdGljcyBzaG91bGQgYmUgYmFzZWQg b24gY291bnQsIG5vdCByYXRlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAko cmV2aXNpb24gMTIxNTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI2OSwxMCArMjY5LDYgQEAgdm9pZCBIZWFwOjpsYXN0Q2hhbmNl VG9GaW5hbGl6ZSgpCiAgICAgQVNTRVJUKCFtX2dsb2JhbERhdGEtPmR5bmFtaWNHbG9iYWxPYmpl Y3QpOwogICAgIEFTU0VSVChtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gTm9PcGVyYXRpb24pOwog Ci0gICAgLy8gRklYTUU6IE1ha2UgdGhpcyBhIHJlbGVhc2UtbW9kZSBjcmFzaCBvbmNlIHdlJ3Jl IHN1cmUgbm8gb25lJ3MgZG9pbmcgdGhpcy4KLSAgICBpZiAoc2l6ZV90IHNpemUgPSBtX3Byb3Rl Y3RlZFZhbHVlcy5zaXplKCkpCi0gICAgICAgIFdURkxvZ0Fsd2F5cygiRVJST1I6IEphdmFTY3Jp cHRDb3JlIGhlYXAgZGVhbGxvY2F0ZWQgd2hpbGUgJWxkIHZhbHVlcyB3ZXJlIHN0aWxsIHByb3Rl Y3RlZCIsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KHNpemUpKTsKLQogICAgIG1fb2JqZWN0 U3BhY2UubGFzdENoYW5jZVRvRmluYWxpemUoKTsKIAogI2lmIEVOQUJMRShTSU1QTEVfSEVBUF9Q Uk9GSUxJTkcpCg==