90300 2012-06-29 12:50:53 -0700 [chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer 2012-06-29 16:45:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs enne jbauman nduca webkit.review.bot oldest_to_newest 660718 0 jamesr 2012-06-29 12:50:53 -0700 [chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer 660719 1 150238 jamesr 2012-06-29 12:51:22 -0700 Created attachment 150238 Patch 660721 2 jamesr 2012-06-29 12:52:19 -0700 Motivation is to cut dependency on WebCore::Timer. Tested manually on FishIE, seems to work fine. Unit test coverage would be nice, but that's not a new issue. 660794 3 150238 enne 2012-06-29 14:43:29 -0700 Comment on attachment 150238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150238&action=review R=me. Looks reasonable to me. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:132 > + RateLimiterMap::iterator it = m_rateLimiters.begin(); > + if (it != m_rateLimiters.end()) > + it->second->stop(); It's kind of dodgy that we didn't have this before, since something that outlived the host could have taken a ref on the RateLimiter. 660813 4 jbauman 2012-06-29 15:06:19 -0700 I tested with something like this before, and noticed in traces that this would sometimes cause the rate limit task to be pushed into the next frame (after the composite), which could cause the frame time to be more erratic. 660825 5 jamesr 2012-06-29 15:25:10 -0700 Do you think the Timer-based version does something different? 660861 6 jamesr 2012-06-29 16:45:17 -0700 (In reply to comment #4) > I tested with something like this before, and noticed in traces that this would sometimes cause the rate limit task to be pushed into the next frame (after the composite), which could cause the frame time to be more erratic. I'm going to go ahead since the dependency is a big pain and I don't think this will change the timing much, but please file a bug if you see any bad behaviors. We also have canvas deferral on by default, which is another way to try to tackle some of these issues. 660862 7 jamesr 2012-06-29 16:45:47 -0700 Committed r121601: <http://trac.webkit.org/changeset/121601> 150238 2012-06-29 12:51:22 -0700 2012-06-29 14:43:29 -0700 Patch bug-90300-20120629125122.patch text/plain 5921 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZkZGJlZTBmMjYxZjBh Y2FhY2Q5OWY0NDlmOTg0NzJlMGI2ZmM0YS4uNjQyZTExZDA0NDU5MDUyYzg3YWE5MzhkZDk0ZTdh YmQ3NWM3MTM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA2LTI5ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBV c2UgQ0NUaHJlYWQ6OlRhc2sgaW4gY29tcG9zaXRvcidzIFJhdGVMaW1pdGVyIGluc3RlYWQgb2Yg VGltZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkw MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9SYXRlTGltaXRlci5jcHA6CisgICAgICAgIChSYXRl TGltaXRlcjo6VGFzayk6CisgICAgICAgIChXZWJDb3JlOjpSYXRlTGltaXRlcjo6VGFzazo6Y3Jl YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlJhdGVMaW1pdGVyOjpUYXNrOjp+VGFzayk6CisgICAg ICAgIChXZWJDb3JlOjpSYXRlTGltaXRlcjo6VGFzazo6VGFzayk6CisgICAgICAgIChXZWJDb3Jl KToKKyAgICAgICAgKFdlYkNvcmU6OlJhdGVMaW1pdGVyOjpSYXRlTGltaXRlcik6CisgICAgICAg IChXZWJDb3JlOjpSYXRlTGltaXRlcjo6c3RhcnQpOgorICAgICAgICAoV2ViQ29yZTo6UmF0ZUxp bWl0ZXI6OnN0b3ApOgorICAgICAgICAoV2ViQ29yZTo6UmF0ZUxpbWl0ZXI6OnJhdGVMaW1pdENv bnRleHQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1JhdGVMaW1pdGVy Lmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFJhdGVMaW1pdGVyKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0Ojp+Q0NMYXllclRyZWVIb3N0KToKKwogMjAx Mi0wNi0yOSAgRXJpYyBQZW5uZXIgIDxlcGVubmVyQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2No cm9taXVtXSBBZGRpbmcgUHJpb3JpdGl6ZWRUZXh0dXJlIGFuZCByZXBsYWNpbmcgQ29udGVudHNU ZXh0dXJlTWFuYWdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vUmF0ZUxpbWl0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vUmF0ZUxpbWl0ZXIuY3BwCmluZGV4IDIzMmYwNDcxOTgxMWM2ZGIxMmQ4 MWY1MjdkZThkMDUyNTJiZDNkMmIuLjU1YTE5MDI5MGEwYTVlNGU5OTA5OWM2OTNjZDU3MmQ4YThl ZjEzMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1JhdGVMaW1pdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9SYXRlTGltaXRlci5jcHAKQEAgLTI5LDEwICsyOSwzNSBAQAogCiAjaW5jbHVk ZSAiUmF0ZUxpbWl0ZXIuaCIKICNpbmNsdWRlICJUcmFjZUV2ZW50LmgiCisjaW5jbHVkZSAiY2Mv Q0NQcm94eS5oIgorI2luY2x1ZGUgImNjL0NDVGhyZWFkLmgiCiAjaW5jbHVkZSA8cHVibGljL1dl YkdyYXBoaWNzQ29udGV4dDNELmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgUmF0 ZUxpbWl0ZXI6OlRhc2sgOiBwdWJsaWMgQ0NUaHJlYWQ6OlRhc2sgeworcHVibGljOgorICAgIHN0 YXRpYyBQYXNzT3duUHRyPFRhc2s+IGNyZWF0ZShSYXRlTGltaXRlciogcmF0ZUxpbWl0ZXIpCisg ICAgeworICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IFRhc2socmF0ZUxpbWl0ZXIpKTsKKyAg ICB9CisgICAgdmlydHVhbCB+VGFzaygpIHsgfQorCitwcml2YXRlOgorICAgIGV4cGxpY2l0IFRh c2soUmF0ZUxpbWl0ZXIqIHJhdGVMaW1pdGVyKQorICAgICAgICA6IENDVGhyZWFkOjpUYXNrKHRo aXMpCisgICAgICAgICwgbV9yYXRlTGltaXRlcihyYXRlTGltaXRlcikKKyAgICB7CisgICAgfQor CisgICAgdmlydHVhbCB2b2lkIHBlcmZvcm1UYXNrKCkgT1ZFUlJJREUKKyAgICB7CisgICAgICAg IG1fcmF0ZUxpbWl0ZXItPnJhdGVMaW1pdENvbnRleHQoKTsKKyAgICB9CisKKyAgICBSZWZQdHI8 UmF0ZUxpbWl0ZXI+IG1fcmF0ZUxpbWl0ZXI7Cit9OworCiBQYXNzUmVmUHRyPFJhdGVMaW1pdGVy PiBSYXRlTGltaXRlcjo6Y3JlYXRlKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRl eHQsIFJhdGVMaW1pdGVyQ2xpZW50ICpjbGllbnQpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5l dyBSYXRlTGltaXRlcihjb250ZXh0LCBjbGllbnQpKTsKQEAgLTQwLDcgKzY1LDcgQEAgUGFzc1Jl ZlB0cjxSYXRlTGltaXRlcj4gUmF0ZUxpbWl0ZXI6OmNyZWF0ZShXZWJLaXQ6OldlYkdyYXBoaWNz Q29udGV4dDNEKiBjb250ZXgKIAogUmF0ZUxpbWl0ZXI6OlJhdGVMaW1pdGVyKFdlYktpdDo6V2Vi R3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIFJhdGVMaW1pdGVyQ2xpZW50ICpjbGllbnQpCiAg ICAgOiBtX2NvbnRleHQoY29udGV4dCkKLSAgICAsIG1fdGltZXIodGhpcywgJlJhdGVMaW1pdGVy OjpyYXRlTGltaXRDb250ZXh0KQorICAgICwgbV9hY3RpdmUoZmFsc2UpCiAgICAgLCBtX2NsaWVu dChjbGllbnQpCiB7CiAgICAgQVNTRVJUKGNvbnRleHQpOwpAQCAtNTIsMTkgKzc3LDI4IEBAIFJh dGVMaW1pdGVyOjp+UmF0ZUxpbWl0ZXIoKQogCiB2b2lkIFJhdGVMaW1pdGVyOjpzdGFydCgpCiB7 Ci0gICAgaWYgKCFtX3RpbWVyLmlzQWN0aXZlKCkpCi0gICAgICAgIG1fdGltZXIuc3RhcnRPbmVT aG90KDApOworICAgIGlmIChtX2FjdGl2ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgVFJBQ0Vf RVZFTlQwKCJjYyIsICJSYXRlTGltaXRlcjo6c3RhcnQiKTsKKyAgICBtX2FjdGl2ZSA9IHRydWU7 CisgICAgQ0NQcm94eTo6bWFpblRocmVhZCgpLT5wb3N0VGFzayhSYXRlTGltaXRlcjo6VGFzazo6 Y3JlYXRlKHRoaXMpKTsKIH0KIAogdm9pZCBSYXRlTGltaXRlcjo6c3RvcCgpCiB7Ci0gICAgbV90 aW1lci5zdG9wKCk7CisgICAgVFJBQ0VfRVZFTlQwKCJjYyIsICJSYXRlTGltaXRlcjo6c3RvcCIp OworICAgIG1fY2xpZW50ID0gMDsKIH0KIAotdm9pZCBSYXRlTGltaXRlcjo6cmF0ZUxpbWl0Q29u dGV4dChUaW1lcjxSYXRlTGltaXRlcj4qKQordm9pZCBSYXRlTGltaXRlcjo6cmF0ZUxpbWl0Q29u dGV4dCgpCiB7CisgICAgaWYgKCFtX2NsaWVudCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgVFJB Q0VfRVZFTlQwKCJjYyIsICJSYXRlTGltaXRlcjo6cmF0ZUxpbWl0Q29udGV4dCIpOwogCisgICAg bV9hY3RpdmUgPSBmYWxzZTsKICAgICBtX2NsaWVudC0+cmF0ZUxpbWl0KCk7CiAgICAgbV9jb250 ZXh0LT5yYXRlTGltaXRPZmZzY3JlZW5Db250ZXh0Q0hST01JVU0oKTsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1JhdGVMaW1pdGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9SYXRlTGltaXRlci5o CmluZGV4IGI3ODZiOTBkNDkwMDc5N2VlZjlhZWVlMDRlMGFhN2UzNWNjMjJmZGYuLjA1NDhmZGU1 ZTY1YjZiMzQ4MDFiODRkZjNlNTcxMzAxN2IyOWRhN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1JhdGVMaW1pdGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vUmF0ZUxpbWl0ZXIuaApAQCAtMjgs OSArMjgsOCBAQAogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCi0jaW5jbHVk ZSAiVGltZXIuaCIKKyNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9S ZWZDb3VudGVkLmg+Ci0jaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgV2ViS2l0 IHsKIGNsYXNzIFdlYkdyYXBoaWNzQ29udGV4dDNEOwpAQCAtNDMsMjEgKzQyLDI5IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgcmF0ZUxpbWl0KCkgPSAwOwogfTsKIAotLy8gQSBjbGFzcyBj b250YWluaW5nIGEgdGltZXIsIHdoaWNoIGNhbGxzIHJhdGVMaW1pdENIUk9NSVVNIG9uIGV4cGly eQorLy8gQSBSYXRlTGltaXRlciBjYW4gYmUgdXNlZCB0byBtYWtlIHN1cmUgdGhhdCBhIHNpbmds ZSBjb250ZXh0IGRvZXMgbm90IGRvbWluYXRlIGFsbCBleGVjdXRpb24gdGltZS4KKy8vIFRvIHVz ZSwgY29uc3RydWN0IGEgUmF0ZUxpbWl0ZXIgY2xhc3MgYXJvdW5kIHRoZSBjb250ZXh0IGFuZCBj YWxsIHN0YXJ0KCkgd2hlbmV2ZXIgY2FsbHMgYXJlIG1hZGUgb24gdGhlCisvLyBjb250ZXh0IG91 dHNpZGUgb2Ygbm9ybWFsIGZsb3cgY29udHJvbC4gUmF0ZUxpbWl0ZXIgd2lsbCBibG9jayBpZiB0 aGUgY29udGV4dCBpcyB0b28gZmFyIGFoZWFkIG9mIHRoZQorLy8gY29tcG9zaXRvci4KIGNsYXNz IFJhdGVMaW1pdGVyIDogcHVibGljIFJlZkNvdW50ZWQ8UmF0ZUxpbWl0ZXI+IHsKIHB1YmxpYzoK ICAgICBzdGF0aWMgUGFzc1JlZlB0cjxSYXRlTGltaXRlcj4gY3JlYXRlKFdlYktpdDo6V2ViR3Jh cGhpY3NDb250ZXh0M0QqLCBSYXRlTGltaXRlckNsaWVudCopOwogICAgIH5SYXRlTGltaXRlcigp OwogCiAgICAgdm9pZCBzdGFydCgpOworCisgICAgLy8gQ29udGV4dCBhbmQgY2xpZW50IHdpbGwg bm90IGJlIGFjY2Vzc2VkIGFmdGVyIHN0b3AoKS4KICAgICB2b2lkIHN0b3AoKTsKIAogcHJpdmF0 ZToKICAgICBSYXRlTGltaXRlcihXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEKiwgUmF0ZUxp bWl0ZXJDbGllbnQqKTsKIAorICAgIGNsYXNzIFRhc2s7CisgICAgZnJpZW5kIGNsYXNzIFRhc2s7 CisgICAgdm9pZCByYXRlTGltaXRDb250ZXh0KCk7CisKICAgICBXZWJLaXQ6OldlYkdyYXBoaWNz Q29udGV4dDNEKiBtX2NvbnRleHQ7Ci0gICAgVGltZXI8UmF0ZUxpbWl0ZXI+IG1fdGltZXI7Ci0g ICAgdm9pZCByYXRlTGltaXRDb250ZXh0KFRpbWVyPFJhdGVMaW1pdGVyPiopOworICAgIGJvb2wg bV9hY3RpdmU7CiAgICAgUmF0ZUxpbWl0ZXJDbGllbnQgKm1fY2xpZW50OwogfTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggZjk4MmI1YmI3ZWU1OTY3YzQ0NjgyNTA0NDFh MjRjZDVkZTFjZjYxZi4uYTJmOGJiY2JhOTY1NzY5YjBhM2EyMmNmMzI1YmQ4MGFmZTFjOGE5YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCkBAIC0xMjcsNiArMTI3LDkgQEAgQ0NM YXllclRyZWVIb3N0Ojp+Q0NMYXllclRyZWVIb3N0KCkKICAgICBtX3Byb3h5LT5zdG9wKCk7CiAg ICAgbV9wcm94eS5jbGVhcigpOwogICAgIG51bUxheWVyVHJlZUluc3RhbmNlcy0tOworICAgIFJh dGVMaW1pdGVyTWFwOjppdGVyYXRvciBpdCA9IG1fcmF0ZUxpbWl0ZXJzLmJlZ2luKCk7CisgICAg aWYgKGl0ICE9IG1fcmF0ZUxpbWl0ZXJzLmVuZCgpKQorICAgICAgICBpdC0+c2Vjb25kLT5zdG9w KCk7CiB9CiAKIHZvaWQgQ0NMYXllclRyZWVIb3N0OjpzZXRTdXJmYWNlUmVhZHkoKQo=