90295 2012-06-29 10:26:46 -0700 [BlackBerry] Allow surface resizing for use cases other than rotation 2012-06-30 04:57:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson manyoso mifenton tonikitoo webkit.review.bot oldest_to_newest 660609 0 jpetsovits 2012-06-29 10:26:46 -0700 Right now we rely on the window/backing buffer to be always big enough to cover all sizes that we're resizing the WebPage to. That's good for performance, but in some cases we'd like to cover a smaller area and would rather save memory than to avoid reallocations on resizing. Patch below. 660617 1 150215 jpetsovits 2012-06-29 10:35:07 -0700 Created attachment 150215 Patch 660734 2 anilsson 2012-06-29 13:14:34 -0700 This looks good to me, I volunteer to be "internal reviewer" =) 661027 3 150215 staikos 2012-06-30 04:48:40 -0700 Comment on attachment 150215 Patch r+ 661028 4 150215 webkit.review.bot 2012-06-30 04:56:56 -0700 Comment on attachment 150215 Patch Clearing flags on attachment: 150215 Committed r121626: <http://trac.webkit.org/changeset/121626> 661029 5 webkit.review.bot 2012-06-30 04:57:00 -0700 All reviewed patches have been landed. Closing bug. 150215 2012-06-29 10:35:07 -0700 2012-06-30 04:56:55 -0700 Patch bug-90295-20120629133434.patch text/plain 6941 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhYTkxYWU4ODk3ODViZWNiZTA4NDdhNGNiMjEzYjMxZjBkYWNlZWUxLi5kZDI0YjcyYzM3 MjE0ZGVmYzI2YzY3OGEyNzFkMjQ1ZjBkMmUzNGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMi0wNi0yOSAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBbGxvdyBzdXJmYWNlIHJl c2l6aW5nIGZvciB1c2UgY2FzZXMgb3RoZXIgdGhhbiByb3RhdGlvbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMjk1CisgICAgICAgIFJJTSBQUiAx NzE0NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB IG5ldyBBUEkgbWV0aG9kIHNldEhhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSgpIGlzCisgICAg ICAgIGludHJvZHVjZWQgZm9yIHRoYXQgZWZmZWN0LCBhbmQgdXNlZCBpbnNpZGUgb2YKKyAgICAg ICAgc2V0Vmlld3BvcnRTaXplKCkgdG8gbGV0IHRoZSBXZWJQYWdlQ2xpZW50IGRvIHRoZQorICAg ICAgICByZXNpemluZy4gTWV0aG9kcyBhcmUgcmVuYW1lZCB0byByZWZsZWN0IHRoYXQgdGhpcwor ICAgICAgICBpcyBub3QgZXhjbHVzaXZlbHkgbWVhbnQgZm9yIHJvdGF0aW9uIGFueW1vcmUuCisK KyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2VQcml2YXRlOjpXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYlBhZ2U6OnNldFNjcmVlbk9yaWVudGF0aW9uKToKKyAgICAgICAgKFdlYktpdCk6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OnNldEhhc1BlbmRpbmdTdXJm YWNlU2l6ZUNoYW5nZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2 YXRlOjpyZXNpemVTdXJmYWNlSWZOZWVkZWQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXplKToKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5oOgorICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisgICAgICAgICogQXBpL1dlYlBh Z2VfcC5oOgorICAgICAgICAoV2ViUGFnZVByaXZhdGUpOgorCiAyMDEyLTA2LTI4ICBKYWtvYiBQ ZXRzb3ZpdHMgIDxqcGV0c292aXRzQHJpbS5jb20+CiAKICAgICAgICAgQWRkIGJsaXRWaXNpYmxl Q29udGVudHMoKSBhcyBwdWJsaWMgQVBJLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKaW5kZXggYzY1YmY3MTg4MzM1NGE0NThhNGRiZDczNDlhOTBmYWVjODU4Y2IwMi4u ZTFkNjY2MTg1ZTExNTE5OGFmZGFmMzA5YmYwYWM4ZTJkYTU3ZTc4MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zOTcsNiArMzk3LDcgQEAgV2ViUGFnZVBy aXZhdGU6OldlYlBhZ2VQcml2YXRlKFdlYlBhZ2UqIHdlYlBhZ2UsIFdlYlBhZ2VDbGllbnQqIGNs aWVudCwgY29uc3QgSW4KICAgICAsIG1fbmVlZHNDb21taXQoZmFsc2UpCiAgICAgLCBtX3N1c3Bl bmRSb290TGF5ZXJDb21taXQoZmFsc2UpCiAjZW5kaWYKKyAgICAsIG1faGFzUGVuZGluZ1N1cmZh Y2VTaXplQ2hhbmdlKGZhbHNlKQogICAgICwgbV9wZW5kaW5nT3JpZW50YXRpb24oLTEpCiAgICAg LCBtX2Z1bGxzY3JlZW5WaWRlb05vZGUoMCkKICAgICAsIG1faGFzSW5SZWdpb25TY3JvbGxhYmxl QXJlYXMoZmFsc2UpCkBAIC0zNjA3LDYgKzM2MDgsMTIgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6 c2V0U2NyZWVuT3JpZW50YXRpb24oaW50IG9yaWVudGF0aW9uKQogdm9pZCBXZWJQYWdlOjpzZXRT Y3JlZW5PcmllbnRhdGlvbihpbnQgb3JpZW50YXRpb24pCiB7CiAgICAgZC0+bV9wZW5kaW5nT3Jp ZW50YXRpb24gPSBvcmllbnRhdGlvbjsKKyAgICBkLT5tX2hhc1BlbmRpbmdTdXJmYWNlU2l6ZUNo YW5nZSA9IHRydWU7Cit9CisKK3ZvaWQgV2ViUGFnZTo6c2V0SGFzUGVuZGluZ1N1cmZhY2VTaXpl Q2hhbmdlKCkKK3sKKyAgICBkLT5tX2hhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSA9IHRydWU7 CiB9CiAKIHZvaWQgV2ViUGFnZTo6YXBwbHlQZW5kaW5nT3JpZW50YXRpb25JZk5lZWRlZCgpCkBA IC0zNjE1LDcgKzM2MjIsNyBAQCB2b2lkIFdlYlBhZ2U6OmFwcGx5UGVuZGluZ09yaWVudGF0aW9u SWZOZWVkZWQoKQogICAgICAgICBkLT5zZXRTY3JlZW5PcmllbnRhdGlvbihkLT5tX3BlbmRpbmdP cmllbnRhdGlvbik7CiB9CiAKLXZvaWQgV2ViUGFnZVByaXZhdGU6OnNjcmVlblJvdGF0ZWQoKQor dm9pZCBXZWJQYWdlUHJpdmF0ZTo6cmVzaXplU3VyZmFjZUlmTmVlZGVkKCkKIHsKICAgICAvLyBU aGlzIGNhbGwgd2lsbCBjYXVzZSB0aGUgY2xpZW50IHRvIHJlYWxsb2NhdGUgdGhlIHdpbmRvdyBi dWZmZXIgdG8gbmV3IHNpemUsCiAgICAgLy8gd2hpY2ggbmVlZHMgdG8gYmUgc2VyaWFsaXplZCB3 aXRoIHVzYWdlIG9mIHRoZSB3aW5kb3cgYnVmZmVyLiBBY2NvbXBsaXNoCkBAIC0zNjIzLDE3ICsz NjMwLDE5IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNjcmVlblJvdGF0ZWQoKQogICAgIC8vIHRo ZSB3aW5kb3cgYnVmZmVyIGhhcHBlbnMgb24gdGhlIGNvbXBvc2l0aW5nIHRocmVhZC4KICAgICBp ZiAoIVBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1cnJl bnRUaHJlYWQoKSkgewogICAgICAgICBQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1lc3Nh Z2VDbGllbnQoKS0+ZGlzcGF0Y2hTeW5jTWVzc2FnZSgKLSAgICAgICAgICAgIFBsYXRmb3JtOjpj cmVhdGVNZXRob2RDYWxsTWVzc2FnZSgmV2ViUGFnZVByaXZhdGU6OnNjcmVlblJvdGF0ZWQsIHRo aXMpKTsKKyAgICAgICAgICAgIFBsYXRmb3JtOjpjcmVhdGVNZXRob2RDYWxsTWVzc2FnZSgmV2Vi UGFnZVByaXZhdGU6OnJlc2l6ZVN1cmZhY2VJZk5lZWRlZCwgdGhpcykpOwogICAgICAgICByZXR1 cm47CiAgICAgfQogCi0gICAgU3VyZmFjZVBvb2w6Omdsb2JhbFN1cmZhY2VQb29sKCktPm5vdGlm eVNjcmVlblJvdGF0ZWQoKTsKLSAgICBtX2NsaWVudC0+bm90aWZ5U2NyZWVuUm90YXRlZCgpOwor ICAgIGlmIChtX3BlbmRpbmdPcmllbnRhdGlvbiAhPSAtMSkKKyAgICAgICAgU3VyZmFjZVBvb2w6 Omdsb2JhbFN1cmZhY2VQb29sKCktPm5vdGlmeVNjcmVlblJvdGF0ZWQoKTsKKworICAgIG1fY2xp ZW50LT5yZXNpemVTdXJmYWNlSWZOZWVkZWQoKTsKIH0KIAogdm9pZCBXZWJQYWdlUHJpdmF0ZTo6 c2V0Vmlld3BvcnRTaXplKGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNp emUsIGJvb2wgZW5zdXJlRm9jdXNFbGVtZW50VmlzaWJsZSkKIHsKLSAgICBpZiAobV9wZW5kaW5n T3JpZW50YXRpb24gPT0gLTEgJiYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZSA9PSB0aGlz LT50cmFuc2Zvcm1lZEFjdHVhbFZpc2libGVTaXplKCkpCisgICAgaWYgKG1fcGVuZGluZ09yaWVu dGF0aW9uID09IC0xICYmICFtX2hhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSAmJiB0cmFuc2Zv cm1lZEFjdHVhbFZpc2libGVTaXplID09IHRoaXMtPnRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNp emUoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gU3VzcGVuZCBhbGwgc2NyZWVuIHVwZGF0 ZXMgdG8gdGhlIGJhY2tpbmdzdG9yZSB0byBtYWtlIHN1cmUgbm8tb25lIHRyaWVzIHRvIGJsaXQK QEAgLTM2NDcsMTEgKzM2NTYsMTMgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRT aXplKGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUKICAgICAgICAg c2V0U2hvdWxkUmVzZXRUaWxlc1doZW5TaG93bih0cnVlKTsKIAogICAgIGJvb2wgbmVlZHNMYXlv dXQgPSBmYWxzZTsKLQogICAgIGJvb2wgaGFzUGVuZGluZ09yaWVudGF0aW9uID0gbV9wZW5kaW5n T3JpZW50YXRpb24gIT0gLTE7Ci0gICAgaWYgKGhhc1BlbmRpbmdPcmllbnRhdGlvbikKLSAgICAg ICAgc2NyZWVuUm90YXRlZCgpOwotICAgIGVsc2UgeworCisgICAgaWYgKG1faGFzUGVuZGluZ1N1 cmZhY2VTaXplQ2hhbmdlKSB7CisgICAgICAgIHJlc2l6ZVN1cmZhY2VJZk5lZWRlZCgpOworICAg ICAgICBtX2hhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSA9IGZhbHNlOworICAgIH0KKyAgICBp ZiAoIWhhc1BlbmRpbmdPcmllbnRhdGlvbikgewogICAgICAgICAvLyBJZiB3ZSBhcmUgbm90IHJv dGF0aW5nIGFuZCB3ZSd2ZSBzdGFydGVkIGEgdmlld3BvcnQgcmVzaXplIHdpdGgKICAgICAgICAg Ly8gdGhlIFJlbmRlciB0cmVlIGluIGRpcnR5IHN0YXRlIChpLmUuIGl0IG5lZWRzIGxheW91dCks IGxldHMKICAgICAgICAgLy8gcmVzZXQgdGhlIG5lZWRzTGF5b3V0IGZsYWcgZm9yIG5vdyBidXQg c2V0IG91ciBvd24gJ25lZWRzTGF5b3V0Jy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmgKaW5kZXggOTZkNmRhYTllNmZlZWYzOWQzOGRhMmM1ZDVkZTlhZDFhNDJhNWZlMy4uZjg4 ZTJjNzU5YmVjNzk3MzIxN2M1YzNmNmQ1MjdhMjU3MDljM2JmNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTEyMSw2ICsxMjEsNyBAQCBwdWJsaWM6CiAgICAgYm9v bCBpc1Zpc2libGUoKSBjb25zdDsKIAogICAgIHZvaWQgc2V0U2NyZWVuT3JpZW50YXRpb24oaW50 KTsKKyAgICB2b2lkIHNldEhhc1BlbmRpbmdTdXJmYWNlU2l6ZUNoYW5nZSgpOwogICAgIHZvaWQg YXBwbHlQZW5kaW5nT3JpZW50YXRpb25JZk5lZWRlZCgpOwogCiAgICAgUGxhdGZvcm06OkludFNp emUgdmlld3BvcnRTaXplKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZUNsaWVudC5oCmluZGV4IDgxZWJjNGFiNmJjYWJjOTljMDYyNDQ5MWY1MjIzYmNmZjg3 NTJiNjIuLjJkMTMzZWFiYTg5NDgzYjMxMjFjN2IzNWRkYjUyOTQzZmM1ZjhkM2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCkBAIC0xMzEsNyArMTMx LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgUGxhdGZvcm06OkdyYXBoaWNzOjpXaW5kb3cqIHdp bmRvdygpIGNvbnN0ID0gMDsKIAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlDb250ZW50UmVuZGVy ZWQoY29uc3QgUGxhdGZvcm06OkludFJlY3QmKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIG5vdGlm eVNjcmVlblJvdGF0ZWQoKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHJlc2l6ZVN1cmZhY2VJZk5l ZWRlZCgpID0gMDsKIAogICAgIHZpcnR1YWwgdm9pZCBpbnB1dEZvY3VzR2FpbmVkKFBsYXRmb3Jt OjpCbGFja0JlcnJ5SW5wdXRUeXBlLCBpbnQgaW5wdXRTdHlsZSkgPSAwOwogICAgIHZpcnR1YWwg dm9pZCBpbnB1dEZvY3VzTG9zdCgpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2VfcC5oCmluZGV4IGE5ODcyZmI2NzZkZDk2Y2NmMTM4ZjMwOTdiNjM3ZWZhMTQzOGZkZDcu LmUxYjM5NWI0Zjc5NzJlN2IxZWM3NTg5OGY2ODBiMTgzYTBiZjExYmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaApAQCAtMzU4LDcgKzM1OCw3IEBAIHB1YmxpYzoK ICAgICAvLyBTY3JvbGwgYW5kL29yIHpvb20gc28gdGhhdCB0aGUgV2ViUGFnZSBmaXRzIHRoZSBu ZXcgYWN0dWFsCiAgICAgLy8gdmlzaWJsZSBzaXplLgogICAgIHZvaWQgc2V0Vmlld3BvcnRTaXpl KGNvbnN0IFdlYkNvcmU6OkludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUsIGJv b2wgZW5zdXJlRm9jdXNFbGVtZW50VmlzaWJsZSk7Ci0gICAgdm9pZCBzY3JlZW5Sb3RhdGVkKCk7 IC8vIEhlbHBlciBtZXRob2QgZm9yIHNldFZpZXdwb3J0U2l6ZSgpLgorICAgIHZvaWQgcmVzaXpl U3VyZmFjZUlmTmVlZGVkKCk7IC8vIEhlbHBlciBtZXRob2QgZm9yIHNldFZpZXdwb3J0U2l6ZSgp LgogCiAgICAgdm9pZCBzY2hlZHVsZURlZmVycmFibGVUaW1lcihXZWJDb3JlOjpUaW1lcjxXZWJQ YWdlUHJpdmF0ZT4qLCBkb3VibGUgdGltZU91dCk7CiAgICAgdm9pZCB1bnNjaGVkdWxlQWxsRGVm ZXJyYWJsZVRpbWVycygpOwpAQCAtNTU0LDYgKzU1NCw3IEBAIHB1YmxpYzoKICAgICBib29sIG1f c3VzcGVuZFJvb3RMYXllckNvbW1pdDsKICNlbmRpZgogCisgICAgYm9vbCBtX2hhc1BlbmRpbmdT dXJmYWNlU2l6ZUNoYW5nZTsKICAgICBpbnQgbV9wZW5kaW5nT3JpZW50YXRpb247CiAKICAgICBS ZWZQdHI8V2ViQ29yZTo6Tm9kZT4gbV9mdWxsc2NyZWVuVmlkZW9Ob2RlOwo=