90270 2012-06-29 04:13:57 -0700 [BlackBerry] crash in CookieDatabaseBackingStore. 2012-07-11 06:45:20 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned liachen mifenton staikos tonikitoo webkit.review.bot oldest_to_newest 660353 0 jasonliuwebkit 2012-06-29 04:13:57 -0700 playing around with the 'setting' on HTML browser swipe down the 'setting' up and down more than 5 times and going through different categories. eventually, browser chrome is turn into grey color. 660360 1 150135 jasonliuwebkit 2012-06-29 04:26:45 -0700 Created attachment 150135 Patch 660929 2 staikos 2012-06-29 18:59:40 -0700 If the db is null, won't it cause massive behavioural failure? 661236 3 jasonliuwebkit 2012-07-01 19:38:16 -0700 (In reply to comment #2) > If the db is null, won't it cause massive behavioural failure? There are not cookies from database. So users may input something again if this happens. 662193 4 150135 rwlbuis 2012-07-03 06:59:50 -0700 Comment on attachment 150135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150135&action=review > Source/WebCore/ChangeLog:8 > + It is hard to reproduce it now. And there is not a bad data base to analyse. Why is it hard to reproduce? Is there an internal PR? > Source/WebCore/ChangeLog:9 > + So add a guard for cookies pointer. Add an empty line here. > Source/WebCore/ChangeLog:10 > + No new tests, behavior has not changed. Not strictly true, behavior has changed for when cookies is null. 662656 5 jasonliuwebkit 2012-07-03 20:20:29 -0700 (In reply to comment #4) > (From update of attachment 150135 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150135&action=review > > > Source/WebCore/ChangeLog:8 > > + It is hard to reproduce it now. And there is not a bad data base to analyse. > > Why is it hard to reproduce? Is there an internal PR? > PR 158159, I didn't reproduce it. And Wei said it is hard, too. > > Source/WebCore/ChangeLog:9 > > + So add a guard for cookies pointer. > > Add an empty line here. > > > Source/WebCore/ChangeLog:10 > > + No new tests, behavior has not changed. > > Not strictly true, behavior has changed for when cookies is null. Because it is hard to reproduce, so I am not sure a test case is needed. 662931 6 150135 rwlbuis 2012-07-04 07:28:07 -0700 Comment on attachment 150135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150135&action=review R- for now, please mention internal PR and reword the ChangeLog a bit. >> Source/WebCore/ChangeLog:10 >> + No new tests, behavior has not changed. > > Not strictly true, behavior has changed for when cookies is null. I still think you need to explain better, maybe have somebody in the office help you with the ChangeLog? 663135 7 liachen 2012-07-04 13:18:11 -0700 I think following message is the real issue, somehow the database file is locked and we are unable to create a table. We need to fix this. Jul 04 19:25:28 3 10023 1 Thread 8 (warning!): ERROR: Could not create the table to store the cookies into. No cookie will be stored! /home/lyon/work/rebase/webkit/Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp(223) : void WebCore::CookieDatabaseBackingStore::invokeOpen(const WTF::String&) Jul 04 19:25:28 3 10023 1 Thread 8 (warning!): ERROR: SQLite Error Message: database is locked 666455 8 151622 jasonliuwebkit 2012-07-11 00:40:05 -0700 Created attachment 151622 Patch 666507 9 151642 jasonliuwebkit 2012-07-11 01:30:19 -0700 Created attachment 151642 Patch 666705 10 151642 staikos 2012-07-11 06:27:26 -0700 Comment on attachment 151642 Patch Seems ok. Technically you could have put the delete inside the if (cookies) too but it doesn't make any practical difference. 666714 11 151642 webkit.review.bot 2012-07-11 06:45:09 -0700 Comment on attachment 151642 Patch Clearing flags on attachment: 151642 Committed r122328: <http://trac.webkit.org/changeset/122328> 666715 12 webkit.review.bot 2012-07-11 06:45:20 -0700 All reviewed patches have been landed. Closing bug. 150135 2012-06-29 04:26:45 -0700 2012-07-11 00:39:46 -0700 Patch bug-90270-20120629192643.patch text/plain 1927 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRkMTYzNjdmNjBkOTRk OGQzOWRjZTU3MGQxZjM0M2QwYmJhNTg3Yi4uOGUzNjU3YWE2ZTE3MWNkODdhNjI2Njg4ODc0NjAy OWNiNWQwNDFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI5ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBjcmFzaCBvbiBIVE1MIGJyb3dzZXIgQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDI3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSXQg aXMgaGFyZCB0byByZXByb2R1Y2UgaXQgbm93LiBBbmQgdGhlcmUgaXMgbm90IGEgYmFkIGRhdGEg YmFzZSB0byBhbmFseXNlLgorICAgICAgICBTbyBhZGQgYSBndWFyZCBmb3IgY29va2llcyBwb2lu dGVyLgorICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIGhhcyBub3QgY2hhbmdlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUv Q29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29va2ll RGF0YWJhc2VCYWNraW5nU3RvcmU6OmdldENvb2tpZXNGcm9tRGF0YWJhc2UpOgorCiAyMDEyLTA2 LTI4ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEltcGxlbWVudCBmaWx0ZXIgdXJsKCkgZnVuY3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tp ZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUvQ29va2llRGF0YWJhc2VCYWNraW5nU3Rv cmUuY3BwCmluZGV4IGE3NmMwNDE4NDczMzg0MTBmZjRkNGUyZmIwMWMxMDU1YjQyNzM1ZDAuLmZl ZjFlMTJlOTE5Y2Q1NzI1OTZjZWVjNTQ0MTkwMDMzY2JjNzUyNjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUv Q29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2JsYWNrYmVycnkvQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUvQ29va2llRGF0YWJhc2VC YWNraW5nU3RvcmUuY3BwCkBAIC0zNDYsNyArMzQ2LDggQEAgdm9pZCBDb29raWVEYXRhYmFzZUJh Y2tpbmdTdG9yZTo6Z2V0Q29va2llc0Zyb21EYXRhYmFzZShWZWN0b3I8UGFyc2VkQ29va2llKj4m IHMKICAgICBUeXBlZFJlcGx5QnVmZmVyPCBWZWN0b3I8UGFyc2VkQ29va2llKj4qID4gcmVwbHlC dWZmZXIoMCk7CiAgICAgZGlzcGF0Y2hNZXNzYWdlKGNyZWF0ZU1ldGhvZENhbGxNZXNzYWdlV2l0 aFJldHVybigmQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmU6Omludm9rZUdldENvb2tpZXNXaXRo TGltaXQsICZyZXBseUJ1ZmZlciwgdGhpcywgbGltaXQpKTsKICAgICBWZWN0b3I8UGFyc2VkQ29v a2llKj4qIGNvb2tpZXMgPSByZXBseUJ1ZmZlci5wb2ludGVyKCk7Ci0gICAgc3RhY2tPZkNvb2tp ZXMuc3dhcCgqY29va2llcyk7CisgICAgaWYgKGNvb2tpZXMpCisgICAgICAgIHN0YWNrT2ZDb29r aWVzLnN3YXAoKmNvb2tpZXMpOwogICAgIGRlbGV0ZSBjb29raWVzOwogfQogCg== 151622 2012-07-11 00:40:05 -0700 2012-07-11 01:30:02 -0700 Patch bug-90270-20120711154001.patch text/plain 2857 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRkMTYzNjdmNjBkOTRk OGQzOWRjZTU3MGQxZjM0M2QwYmJhNTg3Yi4uOWY4ZGNhMGZlNDQ0MDI0MTRmOWJhYWQ2MDU4ODVm OWM3MTRmYTAwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA2LTI5ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBjcmFzaCBpbiBDb29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMjcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgb25lIGNhc2UgZm9yIHRo aXMgY3Jhc2guCisgICAgICAgIDEuIEEgYnJvd3NlciBjcmFzaGVzIGFuZCBsb2NrcyBjb29raWVz JyBkYXRhYmFzZSBmb3IgYSB3aGlsZS4KKyAgICAgICAgMi4gT3BlbiBhIG5ldyBicm93c2VyIHdo ZW4gdGhlIG9sZCBvbmUgZG9lc24ndCBmaW5pc2ggY3Jhc2hpbmcuCisgICAgICAgIDMuIFRoZSBu ZXcgb25lIHdyaXRlcyB0aGUgY29va2llcycgZGF0YWJhc2UgYW5kIHJlY2VpdmVzIGEgU1FMSVRF X0JVU1kgZXJyb3IgCisgICAgICAgICAgIGluIENvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlJ3Mg aW52b2tlT3Blbi4gU28gdGhpcyBkYXRhYmFzZSBpc24ndCBvcGVuZWQuCisgICAgICAgIDQuIGlu dm9rZUdldENvb2tpZXNXaXRoTGltaXQgcmV0dXJucyAwLgorICAgICAgICA1LiBDcmFzaCBoYXBw ZW5zIHdoZW4gdXNpbmcgYSBudWxsIHBvaW50ZXIuCisKKyAgICAgICAgQWRkIHJldHJ5IGZ1bmN0 aW9uIHNldEJ1c3lUaW1lb3V0KDEwMDApIGFuZCBhIGd1YXJkIGZvciBjb29raWVzJyBwb2ludGVy LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBjcmFzaCBpcyBoYXJkIHRvIHJlcHJvZHVj ZSwgYW5kIGl0IGhhcHBlbnMgb25seSBvbiBvdXIgcGxhdGZvcm0uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNl QmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZURhdGFiYXNlQmFja2lu Z1N0b3JlOjpnZXRDb29raWVzRnJvbURhdGFiYXNlKToKKwogMjAxMi0wNi0yOCAgU3RlcGhlbiBX aGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgZmls dGVyIHVybCgpIGZ1bmN0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YmxhY2tiZXJyeS9Db29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS9Db29raWVEYXRhYmFzZUJhY2tp bmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURh dGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcAppbmRleCBh NzZjMDQxODQ3MzM4NDEwZmY0ZDRlMmZiMDFjMTA1NWI0MjczNWQwLi5lOTZhYjgzYWE3NGM1MDVm YmM4NGQ1ZTE0MmM5MzFlOWM4MmI0ZGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNl QmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5 L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNw cApAQCAtMjE3LDYgKzIxNyw4IEBAIHZvaWQgQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmU6Omlu dm9rZU9wZW4oY29uc3QgU3RyaW5nJiBjb29raWVKYXIpCiAgICAgY3JlYXRlVGFibGVRdWVyeSAr PSBtX3RhYmxlTmFtZTsKICAgICAvLyBUaGlzIHRhYmxlIHNjaGVtYSBpcyBjb21wbGlhbnQgd2l0 aCBNb3ppbGxhJ3MuCiAgICAgY3JlYXRlVGFibGVRdWVyeSArPSAiICgiICsgZGF0YWJhc2VGaWVs ZHMgKyAiLCAiICsgcHJpbWFyeUtleUZpZWxkcysiKTsiOworICAgIC8vIFJldHJ5IHdoZW4gZGF0 YWJhc2UgaXMgbG9ja2VkLgorICAgIG1fZGIuc2V0QnVzeVRpbWVvdXQoMTAwMCk7CiAKICAgICBp ZiAoIW1fZGIuZXhlY3V0ZUNvbW1hbmQoY3JlYXRlVGFibGVRdWVyeSkpIHsKICAgICAgICAgTE9H X0VSUk9SKCJDb3VsZCBub3QgY3JlYXRlIHRoZSB0YWJsZSB0byBzdG9yZSB0aGUgY29va2llcyBp bnRvLiBObyBjb29raWUgd2lsbCBiZSBzdG9yZWQhIik7CkBAIC0zNDYsNyArMzQ4LDggQEAgdm9p ZCBDb29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZTo6Z2V0Q29va2llc0Zyb21EYXRhYmFzZShWZWN0 b3I8UGFyc2VkQ29va2llKj4mIHMKICAgICBUeXBlZFJlcGx5QnVmZmVyPCBWZWN0b3I8UGFyc2Vk Q29va2llKj4qID4gcmVwbHlCdWZmZXIoMCk7CiAgICAgZGlzcGF0Y2hNZXNzYWdlKGNyZWF0ZU1l dGhvZENhbGxNZXNzYWdlV2l0aFJldHVybigmQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmU6Omlu dm9rZUdldENvb2tpZXNXaXRoTGltaXQsICZyZXBseUJ1ZmZlciwgdGhpcywgbGltaXQpKTsKICAg ICBWZWN0b3I8UGFyc2VkQ29va2llKj4qIGNvb2tpZXMgPSByZXBseUJ1ZmZlci5wb2ludGVyKCk7 Ci0gICAgc3RhY2tPZkNvb2tpZXMuc3dhcCgqY29va2llcyk7CisgICAgaWYgKGNvb2tpZXMpCisg ICAgICAgIHN0YWNrT2ZDb29raWVzLnN3YXAoKmNvb2tpZXMpOwogICAgIGRlbGV0ZSBjb29raWVz OwogfQogCg== 151642 2012-07-11 01:30:19 -0700 2012-07-11 06:45:08 -0700 Patch bug-90270-20120711163015.patch text/plain 3307 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRkMTYzNjdmNjBkOTRk OGQzOWRjZTU3MGQxZjM0M2QwYmJhNTg3Yi4uMTU0YTE2ZDU3NDcxOWM1Yjc3NmM5NjVlNmU0MWQ0 MTY0MTFhOGQ5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA2LTI5ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBjcmFzaCBpbiBDb29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMjcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgb25lIGNhc2UgZm9yIHRo aXMgY3Jhc2guCisgICAgICAgIDEuIEEgYnJvd3NlciBjcmFzaGVzIGFuZCBsb2NrcyBjb29raWVz JyBkYXRhYmFzZSBmb3IgYSB3aGlsZS4KKyAgICAgICAgMi4gT3BlbiBhIG5ldyBicm93c2VyIHdo ZW4gdGhlIG9sZCBvbmUgZG9lc24ndCBmaW5pc2ggY3Jhc2hpbmcuCisgICAgICAgIDMuIFRoZSBu ZXcgb25lIHdyaXRlcyB0aGUgY29va2llcycgZGF0YWJhc2UgYW5kIHJlY2VpdmVzIGEgU1FMSVRF X0JVU1kgZXJyb3IKKyAgICAgICAgICAgaW4gQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUncyBp bnZva2VPcGVuLiBTbyB0aGlzIGRhdGFiYXNlIGlzbid0IG9wZW5lZC4KKyAgICAgICAgNC4gaW52 b2tlR2V0Q29va2llc1dpdGhMaW1pdCByZXR1cm5zIDAuCisgICAgICAgIDUuIENyYXNoIGhhcHBl bnMgd2hlbiB1c2luZyBhIG51bGwgcG9pbnRlci4KKworICAgICAgICBBZGQgZnVuY3Rpb24gc2V0 QnVzeVRpbWVvdXQoMTAwMCkgYW5kIGEgZ3VhcmQgZm9yIGNvb2tpZXMnIHBvaW50ZXIuCisgICAg ICAgIHNldEJ1c3lUaW1lb3V0IHdpbGwgY2FsbCBzcWxpdGUzX2J1c3lfdGltZW91dC4KKworICAg ICAgICBXaGVuIHRoZSBTUUxpdGUgZGF0YWJhc2UgaXMgYWNjZXNzZWQgZm9yIHJlYWRpbmcgaXQg aXMgbG9ja2VkIGZvciB3cml0aW5nCisgICAgICAgIHVudGlsIHRoZSByZWFkaW5nIGFjY2VzcyBp cyBmaW5pc2hlZC4gQW5vdGhlciBwcm9jZXNzIGNhbm5vdCBhY2Nlc3MgdGhlIGRhdGFiYXNlCisg ICAgICAgIHdoaWxlIGl0IGlzIGxvY2tlZC4gVGhlIHRpbWVvdXQgdGltZSBzZXRzIGEgbGltaXQg d2hpbGUgdGhpcyBwcm9jZXNzIHRyaWVzIHRvIGFjY2VzcworICAgICAgICB0aGUgbG9ja2VkIGRh dGFiYXNlLiBJZiB0aGUgZGF0YWJhc2UgaXMgdW5sb2NrZWQgd2l0aGluIHRoZSB0aW1lb3V0IHRp bWUgaXQgY2FuIGJlCisgICAgICAgIGFjY2Vzc2VkLCBvdGhlcndpc2UgYW4gYWNjZXNzIGZhaWxz LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBjcmFzaCBpcyBoYXJkIHRvIHJlcHJvZHVj ZSwgYW5kIGl0IGhhcHBlbnMgb25seSBvbiBvdXIgcGxhdGZvcm0uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNl QmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZURhdGFiYXNlQmFja2lu Z1N0b3JlOjpnZXRDb29raWVzRnJvbURhdGFiYXNlKToKKwogMjAxMi0wNi0yOCAgU3RlcGhlbiBX aGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgZmls dGVyIHVybCgpIGZ1bmN0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YmxhY2tiZXJyeS9Db29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS9Db29raWVEYXRhYmFzZUJhY2tp bmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURh dGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcAppbmRleCBh NzZjMDQxODQ3MzM4NDEwZmY0ZDRlMmZiMDFjMTA1NWI0MjczNWQwLi43NzA4NDM1ODU5MDM0MmRi ZDY5YTVkYmNhMzg5NjAwYmU2MTc1MmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNl QmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5 L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNw cApAQCAtMjE4LDYgKzIxOCw4IEBAIHZvaWQgQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmU6Omlu dm9rZU9wZW4oY29uc3QgU3RyaW5nJiBjb29raWVKYXIpCiAgICAgLy8gVGhpcyB0YWJsZSBzY2hl bWEgaXMgY29tcGxpYW50IHdpdGggTW96aWxsYSdzLgogICAgIGNyZWF0ZVRhYmxlUXVlcnkgKz0g IiAoIiArIGRhdGFiYXNlRmllbGRzICsgIiwgIiArIHByaW1hcnlLZXlGaWVsZHMrIik7IjsKIAor ICAgIG1fZGIuc2V0QnVzeVRpbWVvdXQoMTAwMCk7CisKICAgICBpZiAoIW1fZGIuZXhlY3V0ZUNv bW1hbmQoY3JlYXRlVGFibGVRdWVyeSkpIHsKICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZCBub3Qg Y3JlYXRlIHRoZSB0YWJsZSB0byBzdG9yZSB0aGUgY29va2llcyBpbnRvLiBObyBjb29raWUgd2ls bCBiZSBzdG9yZWQhIik7CiAgICAgICAgIExPR19FUlJPUigiU1FMaXRlIEVycm9yIE1lc3NhZ2U6 ICVzIiwgbV9kYi5sYXN0RXJyb3JNc2coKSk7CkBAIC0zNDYsNyArMzQ4LDggQEAgdm9pZCBDb29r aWVEYXRhYmFzZUJhY2tpbmdTdG9yZTo6Z2V0Q29va2llc0Zyb21EYXRhYmFzZShWZWN0b3I8UGFy c2VkQ29va2llKj4mIHMKICAgICBUeXBlZFJlcGx5QnVmZmVyPCBWZWN0b3I8UGFyc2VkQ29va2ll Kj4qID4gcmVwbHlCdWZmZXIoMCk7CiAgICAgZGlzcGF0Y2hNZXNzYWdlKGNyZWF0ZU1ldGhvZENh bGxNZXNzYWdlV2l0aFJldHVybigmQ29va2llRGF0YWJhc2VCYWNraW5nU3RvcmU6Omludm9rZUdl dENvb2tpZXNXaXRoTGltaXQsICZyZXBseUJ1ZmZlciwgdGhpcywgbGltaXQpKTsKICAgICBWZWN0 b3I8UGFyc2VkQ29va2llKj4qIGNvb2tpZXMgPSByZXBseUJ1ZmZlci5wb2ludGVyKCk7Ci0gICAg c3RhY2tPZkNvb2tpZXMuc3dhcCgqY29va2llcyk7CisgICAgaWYgKGNvb2tpZXMpCisgICAgICAg IHN0YWNrT2ZDb29raWVzLnN3YXAoKmNvb2tpZXMpOwogICAgIGRlbGV0ZSBjb29raWVzOwogfQog Cg==