90245 2012-06-28 21:20:25 -0700 updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING) 2012-06-29 20:42:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser jchaffraix simon.fraser oldest_to_newest 660117 0 simon.fraser 2012-06-28 21:20:25 -0700 RenderLayer::styleChanged() has: #if USE(ACCELERATED_COMPOSITING) updateDescendantDependentFlags(); updateTransform(); Seems like both should be outside the #ifdef 660958 1 150298 simon.fraser 2012-06-29 20:28:02 -0700 Created attachment 150298 Patch 660959 2 150298 mitz 2012-06-29 20:31:18 -0700 Comment on attachment 150298 Patch Do you have a test to prove this? 660960 3 simon.fraser 2012-06-29 20:32:14 -0700 I do not; i just noticed this when looking at the code. I'm not sure any of the top tier platforms build with accelerated compositing off any more. 660968 4 simon.fraser 2012-06-29 20:42:28 -0700 http://trac.webkit.org/changeset/121616 150298 2012-06-29 20:28:02 -0700 2012-06-29 20:31:18 -0700 Patch bug-90245-20120629202802.patch text/plain 1776 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRkMTYzNjdmNjBkOTRk OGQzOWRjZTU3MGQxZjM0M2QwYmJhNTg3Yi4uNzllNGU3NWI2NjY5MjlhZWFlYmQyMDg2MmVmZWU2 NmQ5NzEzYWZiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHVwZGF0ZURlc2Nl bmRhbnREZXBlbmRlbnRGbGFncygpIGlzIGluc2lkZSAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTAyNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB1 cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MoKSBhbmQgdXBkYXRlVHJhbnNmb3JtKCkgc2hv dWxkIGJlCisgICAgICAgIG91dHNpZGUgdGhlIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykg I2lmZGVmLiBUaGV5IGRvIHdvcmsKKyAgICAgICAgdGhhdCBpcyBuZWVkZWQgZXZlbiBpZiBhY2Nl bGVyYXRlZCBjb21wb3NpdGluZyBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6c3R5bGVDaGFu Z2VkKToKKwogMjAxMi0wNi0yOCAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgZmlsdGVyIHVybCgpIGZ1bmN0aW9uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMDM4ZjY2MTgxMmM2Mzk1NGRm YTk4YThmOWE3NDI1ZDZkZDMxNDQ1Ni4uOTM3M2I0OTVmOGNhODA1MzljYTA2NDg3YmFiZDBlYzAw MmRmZmJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC00 ODQzLDEwICs0ODQzLDEwIEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHlsZURp ZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKICAgICBib29sIGJhY2tpbmdE aWRDb21wb3NpdGVMYXllcnMgPSBpc0NvbXBvc2l0ZWQoKSAmJiBiYWNraW5nKCktPmNhbkNvbXBv c2l0ZUZpbHRlcnMoKTsKICNlbmRpZgogCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5H KQogICAgIHVwZGF0ZURlc2NlbmRhbnREZXBlbmRlbnRGbGFncygpOwogICAgIHVwZGF0ZVRyYW5z Zm9ybSgpOwogCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChjb21w b3NpdG9yKCktPnVwZGF0ZUxheWVyQ29tcG9zaXRpbmdTdGF0ZSh0aGlzKSkKICAgICAgICAgY29t cG9zaXRvcigpLT5zZXRDb21wb3NpdGluZ0xheWVyc05lZWRSZWJ1aWxkKCk7CiAgICAgZWxzZSBp ZiAob2xkU3R5bGUgJiYgKG9sZFN0eWxlLT5jbGlwKCkgIT0gcmVuZGVyZXIoKS0+c3R5bGUoKS0+ Y2xpcCgpIHx8IG9sZFN0eWxlLT5oYXNDbGlwKCkgIT0gcmVuZGVyZXIoKS0+c3R5bGUoKS0+aGFz Q2xpcCgpKSkK