90243 2012-06-28 20:44:50 -0700 garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url') 2012-06-29 20:37:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser ojan abarth dglazkov dpranke ojan simon.fraser webkit.review.bot oldest_to_newest 660104 0 simon.fraser 2012-06-28 20:44:50 -0700 Loading http://build.webkit.org/TestFailures/garden-o-matic.html?platform=apple, I get: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url') and it never gets past Loading commit data ... 660114 1 simon.fraser 2012-06-28 21:08:17 -0700 I'm seeing parse errors from net.jsonp for full_results.json files. If I try to validate them, validation fails with the ADD_RESULTS() stuff. How did this ever work? 660115 2 simon.fraser 2012-06-28 21:09:41 -0700 Also, the mac testers can now do testing out of order, so we can't just go by build number, and assume that the most recent build is the most recent revision. 660144 3 abarth 2012-06-28 22:37:38 -0700 net.jsonp strips out the ADD_RESULTS part of the response. 660167 4 ojan 2012-06-28 23:21:14 -0700 (In reply to comment #1) > I'm seeing parse errors from net.jsonp for full_results.json files. If I try to validate them, validation fails with the ADD_RESULTS() stuff. How did this ever work? Are you sure you diagnosed this right? I'm not seeing parse errors. I get an error on line 629 of results.js: net.jsonp(buildLocations[currentIndex].url, resultsCallback); Uncaught TypeError: Cannot read property 'url' of undefined So, somehow currentIndex is exceeding the bounds of buildLocations. This is the call that fetches full_results.json. 660168 5 ojan 2012-06-28 23:21:57 -0700 Also, I'm looking at http://trac.webkit.org/export/HEAD/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html?platform=apple since http://build.webkit.org/TestFailures isn't always up to date. I'm not really sure how/when that gets pushed. 660169 6 ojan 2012-06-28 23:24:36 -0700 Ugh. Sorry, I spoke before understanding the code in question. Ignore me. :( 660175 7 ojan 2012-06-28 23:35:29 -0700 That all said, I can't figure out what's going wrong here. It looks like we never hit the success clause in net.jsonp, but I can see in the inspector the some full_results.json requests are returning 200s with valid data. 660539 8 simon.fraser 2012-06-29 08:58:27 -0700 (In reply to comment #7) > That all said, I can't figure out what's going wrong here. It looks like we never hit the success clause in net.jsonp, but I can see in the inspector the some full_results.json requests are returning 200s with valid data. I understand why we can walk off the end of buildLocations. But I was seeing net.jsonp report parseErrors when fetching full_results.jsonp, so it was able to download results from the server, but all the results files failed to parse. That's why it hit the end of the list of buildLocations. 660669 9 simon.fraser 2012-06-29 11:34:35 -0700 Oddly I don't see the same issue on my work machine (or something was fixed overnight). 660818 10 ojan 2012-06-29 15:16:13 -0700 I'm pretty sure jQuery's ajax library is doing something crazy here. If I break in the error handler of $.ajax, I get a "parsererror" error. But if I look at the responseText, it's perfectly valid JSONP as best I can tell. jquery shouldn't even know that this is supposed to be json though. Maybe it's trying to parse the content as json for some reason? 660823 11 ojan 2012-06-29 15:19:00 -0700 Found the problem. Not sure how this ever worked. http://api.jquery.com/jQuery.ajax/ dataType Default: Intelligent Guess (xml, json, script, or html) The type of data that you're expecting back from the server. If none is specified, jQuery will try to infer it based on the MIME type of the response..."json": Evaluates the response as JSON and returns a JavaScript object. In jQuery 1.4 the JSON data is parsed in a strict manner; any malformed JSON is rejected and a parse error is thrown. (See json.org for more information on proper JSON formatting.) I think setting the dataType to jsonp might fix this. Or, we could just use XHR directly. We don't actually need any of jquery's magic here. We're just using it for onload/onerror anyways. 660824 12 abarth 2012-06-29 15:20:39 -0700 +1 for using XHR directly. We started out using jQuery but now regret it. 660866 13 150274 ojan 2012-06-29 16:53:54 -0700 Created attachment 150274 Patch 660867 14 ojan 2012-06-29 16:54:38 -0700 FWIW, I would guess that a server-side change to the content-type of the json files is what broke this. 660963 15 150274 webkit.review.bot 2012-06-29 20:37:08 -0700 Comment on attachment 150274 Patch Clearing flags on attachment: 150274 Committed r121617: <http://trac.webkit.org/changeset/121617> 660964 16 webkit.review.bot 2012-06-29 20:37:13 -0700 All reviewed patches have been landed. Closing bug. 150274 2012-06-29 16:53:54 -0700 2012-06-29 20:37:08 -0700 Patch bug-90243-20120629165354.patch text/plain 5057 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWRkMDUzYjk1YzRmOTJmMjE5MDRlOTFhNDM0NDgxMjAz YzljMjdjZi4uMTkyODliMDA3NGEzNGU1MzZiODhjMjU1NzNmZTQ0MzcyOGMzOGVhMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTA2LTI5ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgZ2FyZGVuLW8tbWF0aWMgYnJva2VuOiBUeXBlRXJyb3I6ICd1bmRlZmluZWQnIGlzIG5vdCBh biBvYmplY3QgKGV2YWx1YXRpbmcgJ2J1aWxkTG9jYXRpb25zW2N1cnJlbnRJbmRleF0udXJsJykK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMjQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgalF1ZXJ5IHdh cyB0cnlpbmcgdG8gYmUgdG9vIHNtYXJ0IGFuZCBwYXJzaW5nIHRoZSBqc29ucCBhcyBqc29uIGJl Y2F1c2Ugb2YgaXQncyBjb250ZW50LXR5cGUuCisgICAgICAgIEV4Y2lzZSBqUXVlcnkgYW5kIGp1 c3QgdXNlIFhIUiBkaXJlY3RseSBzaW5jZSBpdCdzIGVhc2llciB0byBtYWludGFpbiBzb21ldGhp bmcgd2hlcmUgd2UgY29udHJvbCBpdAorICAgICAgICBhbGwuCisKKyAgICAgICAgTm90IHJlYWxs eSBzdXJlIGhvdyB0byB1bml0dGVzdCB0aGlzLiBJIHRlc3RlZCBpdCBhbGwgbWFudWFsbHkgb2Yg Y291cnNlLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvbmV0LmpzOgorICAgICAgICBN YWRlIG5ldC5hamF4IGEgZHJvcC1pbiByZXBsYWNlbWVudCBmb3IgdGhlIGZlYXR1cmVzIG9mICQu YWpheCB0aGF0IHdlIHdlcmUgdXNpbmcuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWlf dW5pdHRlc3RzLmpzOgorICAgICAgICBOb3QgcmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgZmln dXJlZCBJJ2QgdXBkYXRlIHRoZSBmYWlsaW5nIHRlc3Qgd2hpbGUgSSB3YXMgYXQgaXQuCisKIDIw MTItMDYtMjkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg d2Via2l0cHk6IGFkZCBjb21tZW50IGFib3V0IGhvdyBkZXRlcm1pbmVfZnVsbF9wb3J0X25hbWUo KSB3b3JrcyBmb3IgYXBwbGUgcG9ydHMsIGZpeCAtd2syIGJ1ZwpkaWZmIC0tZ2l0IGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvbmV0LmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvbmV0Lmpz CmluZGV4IDBhNGJhYWU5Y2IyODJkNzQxMjUxMDA3NjUyNDVjNTA5NzJhODQ5MTMuLmNjMTQwNTdh ZDY1MWY4MWQyZDQ1NDU2ZjQ3MTc2NTYxOGUxMzExNWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9zY3JpcHRzL25ldC5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9uZXQuanMK QEAgLTI3LDIzICsyNyw1MSBAQCB2YXIgbmV0ID0gbmV0IHx8IHt9OwogCiAoZnVuY3Rpb24gKCkg ewogCi1uZXQucG9zdCA9ICQucG9zdDsKLW5ldC5nZXQgPSAkLmdldDsKLW5ldC5hamF4ID0gJC5h amF4OworLy8gRklYTUU6IEV4Y2lzZSB0aGlzIGxhc3QgYml0IG9mIGpxdWVyeSBhamF4IGNvZGUu CisvLyBUaGVyZSBhcmUgY2FsbGVycyB0aGF0IGRlcGVuZCBvbiBhdXRvbWF0aWNhbGx5IHBhcnNp bmcgdGhlIGNvbnRlbnQgYXMgSlNPTiBvciBYTUwKKy8vIGJhc2VkIG9mZiB0aGUgY29udGVudC10 eXBlLiBJbnN0ZWFkIHdlIHNob3VsZCBhZGQgbmV0Lmpzb24gYW5kIG5ldC54bWwgZm9yIHRob3Nl IGNhc2VzLgorbmV0LmdldCA9IGZ1bmN0aW9uKHVybCwgc3VjY2VzcykKK3sKKyAgICAkLmdldCh1 cmwsIHN1Y2Nlc3MpOworfTsKKworbmV0LmFqYXggPSBmdW5jdGlvbihvcHRpb25zKQoreworICAg IHZhciB4aHIgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsKKyAgICB2YXIgbWV0aG9kID0gb3B0aW9u cy50eXBlIHx8ICdHRVQnOworICAgIHZhciBhc3luYyA9IHRydWU7CisgICAgeGhyLm9wZW4obWV0 aG9kLCBvcHRpb25zLnVybCwgYXN5bmMpOworICAgIHhoci5vbmxvYWQgPSBmdW5jdGlvbigpIHsK KyAgICAgICAgaWYgKHhoci5zdGF0dXMgPT0gMjAwICYmIG9wdGlvbnMuc3VjY2VzcykKKyAgICAg ICAgICAgIG9wdGlvbnMuc3VjY2Vzcyh4aHIucmVzcG9uc2VUZXh0KTsKKyAgICAgICAgZWxzZSBp ZiAoeGhyLnN0YXR1cyAhPSAyMDAgJiYgb3B0aW9ucy5lcnJvcikKKyAgICAgICAgICAgIG9wdGlv bnMuZXJyb3IoKTsKKyAgICB9OworICAgIHhoci5vbmVycm9yID0gZnVuY3Rpb24oKSB7CisgICAg ICAgIGlmIChvcHRpb25zLmVycm9yKQorICAgICAgICAgICAgb3B0aW9ucy5lcnJvcigpOworICAg IH07CisgICAgeGhyLnNlbmQob3B0aW9ucy5kYXRhIHx8IG51bGwpOworfTsKKworbmV0LnBvc3Qg PSBmdW5jdGlvbih1cmwsIGRhdGEsIHN1Y2Nlc3MpCit7CisgICAgbmV0LmFqYXgoeworICAgICAg ICB1cmw6IHVybCwKKyAgICAgICAgdHlwZTogJ1BPU1QnLAorICAgICAgICBkYXRhOiBkYXRhLAor ICAgICAgICBzdWNjZXNzOiBzdWNjZXNzLAorICAgIH0pOworCit9OwogCiBuZXQucHJvYmUgPSBm dW5jdGlvbih1cmwsIG9wdGlvbnMpCiB7Ci0gICAgJC5hamF4KHsKKyAgICBuZXQuYWpheCh7CiAg ICAgICAgIHVybDogdXJsLAogICAgICAgICB0eXBlOiAnSEVBRCcsCi0gICAgICAgIHN1Y2Nlc3M6 IGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgaWYgKG9wdGlvbnMuc3VjY2VzcykKLSAgICAgICAg ICAgICAgICBvcHRpb25zLnN1Y2Nlc3MuY2FsbCgpOwotICAgICAgICB9LAotICAgICAgICBlcnJv cjogZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICBpZiAob3B0aW9ucy5lcnJvcikKLSAgICAgICAg ICAgICAgICBvcHRpb25zLmVycm9yLmNhbGwoKTsKLSAgICAgICAgfSwKKyAgICAgICAgc3VjY2Vz czogb3B0aW9ucy5zdWNjZXNzLAorICAgICAgICBlcnJvcjogb3B0aW9ucy5lcnJvciwKICAgICB9 KTsKIH07CiAKQEAgLTUyLDEyICs4MCwxMiBAQCBuZXQucHJvYmUgPSBmdW5jdGlvbih1cmwsIG9w dGlvbnMpCiAvLyBieSBzZXR0aW5nIENPUlMgaGVhZGVycy4KIG5ldC5qc29ucCA9IGZ1bmN0aW9u KHVybCwgY2FsbGJhY2spCiB7Ci0gICAgJC5hamF4KHsKKyAgICBuZXQuYWpheCh7CiAgICAgICAg IHVybDogdXJsLAogICAgICAgICBzdWNjZXNzOiBmdW5jdGlvbihqc29ucCkgewogICAgICAgICAg ICAgY2FsbGJhY2soYmFzZS5wYXJzZUpTT05QKGpzb25wKSk7CiAgICAgICAgIH0sCi0gICAgICAg IGVycm9yOiBmdW5jdGlvbihyZXF1ZXN0LCB0ZXh0U3RhdHVzLCBlcnJvclRocm93bikgeworICAg ICAgICBlcnJvcjogZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICBjYWxsYmFjayh7fSk7CiAgICAg ICAgIH0sCiAgICAgfSk7CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aV91 bml0dGVzdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aV91bml0dGVzdHMuanMKaW5k ZXggYTg2MTc3ZDYzZmMzYjUwODE0MWQ0NzhiMWVkMzRlNmJkYmIyZTEzNy4uNzRkZTNlNDFjYTYw MmE4Nzg2MGIxNjUxMzE2M2YxZDVhZDI4M2E0ZCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVz L3NjcmlwdHMvdWlfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3Vp X3VuaXR0ZXN0cy5qcwpAQCAtNTQsNyArNTQsNyBAQCB0ZXN0KCJ1aS5vbmViYXIiLCAzLCBmdW5j dGlvbigpIHsKICAgICBvbmViYXIgPSBuZXcgdWkub25lYmFyKCk7CiAgICAgb25lYmFyLmF0dGFj aCgpOwogICAgIGVxdWFsKG9uZWJhci5pbm5lckhUTUwsCi0gICAgICAgICc8ZGl2PjxzZWxlY3Qg aWQ9InBsYXRmb3JtLXBpY2tlciI+PG9wdGlvbj5BcHBsZTwvb3B0aW9uPjxvcHRpb24+Q2hyb21p dW08L29wdGlvbj48b3B0aW9uPkdUSzwvb3B0aW9uPjwvc2VsZWN0PjwvZGl2PicgKworICAgICAg ICAnPGRpdj48c2VsZWN0IGlkPSJwbGF0Zm9ybS1waWNrZXIiPjxvcHRpb24+QXBwbGU8L29wdGlv bj48b3B0aW9uPkNocm9taXVtPC9vcHRpb24+PG9wdGlvbj5HVEs8L29wdGlvbj48b3B0aW9uPlF0 PC9vcHRpb24+PC9zZWxlY3Q+PC9kaXY+JyArCiAgICAgICAgICc8dWwgY2xhc3M9InVpLXRhYnMt bmF2IHVpLWhlbHBlci1yZXNldCB1aS1oZWxwZXItY2xlYXJmaXggdWktd2lkZ2V0LWhlYWRlciB1 aS1jb3JuZXItYWxsIj4nICsKICAgICAgICAgICAgICc8bGkgY2xhc3M9InVpLXN0YXRlLWRlZmF1 bHQgdWktY29ybmVyLXRvcCB1aS10YWJzLXNlbGVjdGVkIHVpLXN0YXRlLWFjdGl2ZSI+PGEgaHJl Zj0iI3VuZXhwZWN0ZWQiPlVuZXhwZWN0ZWQgRmFpbHVyZXM8L2E+PC9saT4nICsKICAgICAgICAg ICAgICc8bGkgY2xhc3M9InVpLXN0YXRlLWRlZmF1bHQgdWktY29ybmVyLXRvcCI+PGEgaHJlZj0i I2V4cGVjdGVkIj5FeHBlY3RlZCBGYWlsdXJlczwvYT48L2xpPicgKwo=