90235 2012-06-28 18:15:20 -0700 [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables 2012-06-29 00:40:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tkent webkit.review.bot oldest_to_newest 660019 0 bashi 2012-06-28 18:15:20 -0700 As of r120234, Chromium mac port should pass LayoutTests/css3/font-feature-settings-rendering.html, but it's failing on bots (the current expectation is MISSING, though). http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=font-feature-settings-rendering When I tested the patch, I used 10.6 sdk. However, it seems that bots and Chrome official build use 10.5 sdk and CTFontCopyTable of 10.5 sdk doesn't work as expected. We need to use CGFontCopyTableForTag instead. 660026 1 150057 bashi 2012-06-28 18:20:48 -0700 Created attachment 150057 Patch 660029 2 bashi 2012-06-28 18:22:54 -0700 Kent-san, could you rubber-stamp? I checked the patch works with 10.5 sdk. 660030 3 150057 tkent 2012-06-28 18:25:36 -0700 Comment on attachment 150057 Patch rubber-stamped 660036 4 150057 bashi 2012-06-28 18:31:04 -0700 Comment on attachment 150057 Patch Thanks! 660072 5 150057 webkit.review.bot 2012-06-28 19:38:05 -0700 Comment on attachment 150057 Patch Clearing flags on attachment: 150057 Committed r121510: <http://trac.webkit.org/changeset/121510> 660073 6 webkit.review.bot 2012-06-28 19:38:09 -0700 All reviewed patches have been landed. Closing bug. 660225 7 tkent 2012-06-29 00:29:39 -0700 BTW, We won't support OS X 10.5 since M22. 660236 8 bashi 2012-06-29 00:40:51 -0700 (In reply to comment #7) > BTW, We won't support OS X 10.5 since M22. Thanks you for the heads-up. CGFontCopyTableForTag isn't deprecated so it should work. In any case, I'm happy to rewrite the code to use CoreText APIs after bots and official build start using 10.6 sdk (or later). 150057 2012-06-28 18:20:48 -0700 2012-06-28 19:38:04 -0700 Patch bug-90235-20120629102047.patch text/plain 1996 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzEzMDdiMDRkZGQ4OWU0 Njk3MGM2MDhhMGJjMjRiNGQ0ZGVhMzExMi4uOGMwZGZmMGFkZmQ0OWVhZjdiOGU0MTIyZTcwMmNm ZDE5M2ZjNzEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI4ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1d IENURm9udENvcHlUYWJsZSBvZiBNYWNPU1gxMC41IFNESyBkb2Vzbid0IHdvcmsgZm9yIGxheW91 dCB0YWJsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkwMjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIENHRm9udENvcHlUYWJsZUZvclRhZyBpbnN0ZWFkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gY3NzMy9mb250LWZlYXR1cmUtc2V0dGluZ3MtcmVuZGVyaW5nLmh0bWwgc2hvdWxkIHBhc3Mu IEknbGwgcmViYXNlIGV4cGVjdGF0aW9ucyBvbmNlIGJvdHMgZ2V0IHRoZSByZXN1bHQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ekZhY2VDb3JlVGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYXJmYnV6ekNvcmVUZXh0R2V0VGFibGUpOgorCiAy MDEyLTA2LTI4ICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJlckBnbWFpbC5jb20+CiAKICAgICAg ICAgW0dUS11bV2luXTogRml4IHBsdWdpbiBkcmF3aW5nIHRvIGFuIG9mZnNjcmVlbiBidWZmZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25n L0hhcmZCdXp6RmFjZUNvcmVUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2hhcmZidXp6L25nL0hhcmZCdXp6RmFjZUNvcmVUZXh0LmNwcAppbmRleCA2MjA5ZTcwNGJh OTljNGI1ZWE3ZjE3N2NlYTMyNTkwNmQyNDcxMjc1Li45NjY1ODlkYjk0N2I3M2M0YzdmZTkxYmIy MmMxZGI0MTgxOGJlYzNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ekZhY2VDb3JlVGV4dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpGYWNlQ29yZVRleHQu Y3BwCkBAIC0xMDksOCArMTA5LDEwIEBAIHN0YXRpYyB2b2lkIHJlbGVhc2VUYWJsZURhdGEodm9p ZCogdXNlckRhdGEpCiBzdGF0aWMgaGJfYmxvYl90KiBoYXJmYnV6ekNvcmVUZXh0R2V0VGFibGUo aGJfZmFjZV90KiBmYWNlLCBoYl90YWdfdCB0YWcsIHZvaWQqIHVzZXJEYXRhKQogewogICAgIEZv bnRQbGF0Zm9ybURhdGEqIHBsYXRmb3JtRGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Rm9udFBsYXRm b3JtRGF0YSo+KHVzZXJEYXRhKTsKLSAgICBDVEZvbnRSZWYgY3RGb250ID0gcGxhdGZvcm1EYXRh LT5jdEZvbnQoKTsKLSAgICBDRkRhdGFSZWYgY2ZEYXRhID0gQ1RGb250Q29weVRhYmxlKGN0Rm9u dCwgdGFnLCBrQ1RGb250VGFibGVPcHRpb25Ob09wdGlvbnMpOworICAgIC8vIEl0IHNlZW1zIHRo YXQgQ1RGb250Q29weVRhYmxlIG9mIE1hY09TWDEwLjUgc2RrIGRvZXNuJ3Qgd29yayBmb3IKKyAg ICAvLyBPcGVuVHlwZSBsYXlvdXQgdGFibGVzKEdERUYsIEdTVUIsIEdQT1MpLiBVc2UgQ0dGb250 Q29weVRhYmxlRm9yVGFnIGluc3RlYWQuCisgICAgQ0dGb250UmVmIGNnRm9udCA9IHBsYXRmb3Jt RGF0YS0+Y2dGb250KCk7CisgICAgQ0ZEYXRhUmVmIGNmRGF0YSA9IENHRm9udENvcHlUYWJsZUZv clRhZyhjZ0ZvbnQsIHRhZyk7CiAgICAgaWYgKCFjZkRhdGEpCiAgICAgICAgIHJldHVybiAwOwog Cg==