90223 2012-06-28 16:22:20 -0700 Update FIXME comment in XMLDocumentParser::wellFormed 2012-06-29 08:28:09 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned abarth webkit.review.bot oldest_to_newest 659937 0 skyul 2012-06-28 16:22:20 -0700 XMLDocumentParser::wellFormed is still used by the XMLHttpRequest to check if the responseXML was well formed. So it can't be removed. 659940 1 150041 skyul 2012-06-28 16:24:54 -0700 Created attachment 150041 Patch 660174 2 skyul 2012-06-28 23:33:44 -0700 BTW, it is weird to have wellFormed method in DecodedDataDocumentParser class because it is used only by the XMLDocumentParser. 660469 3 150041 abarth 2012-06-29 07:42:39 -0700 Comment on attachment 150041 Patch Thanks. Yeah, it's a bit odd to have in decoded document parser, but probably not problematic. 660518 4 150041 webkit.review.bot 2012-06-29 08:27:59 -0700 Comment on attachment 150041 Patch Clearing flags on attachment: 150041 Committed r121564: <http://trac.webkit.org/changeset/121564> 660519 5 webkit.review.bot 2012-06-29 08:28:09 -0700 All reviewed patches have been landed. Closing bug. 150041 2012-06-28 16:24:54 -0700 2012-06-29 08:27:59 -0700 Patch bug-90223-20120629082445.patch text/plain 1641 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZiYWIwYWZiNjA2NDJl ZDY0ZGMwMTQ4YzljOTBhZmMwZTAzYzZmYy4uMmY2ODIwNDg4NWQ0ZjEzZDQ0YzBjMjQwOWE3OTlh M2ZlYmFkZjk3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTI4ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgVXBkYXRlIEZJWE1F IGNvbW1lbnQgaW4gWE1MRG9jdW1lbnRQYXJzZXI6OndlbGxGb3JtZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMjIzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgWE1MRG9jdW1lbnRQYXJzZXI6OndlbGxG b3JtZWQgaXMgc3RpbGwgdXNlZCBieSB0aGUgWE1MSHR0cFJlcXVlc3QgdG8gY2hlY2sgaWYgdGhl IHJlc3BvbnNlWE1MIHdhcyB3ZWxsIGZvcm1lZC4KKyAgICAgICAgU28gaXQgY2FuJ3QgYmUgcmVt b3ZlZC4KKworICAgICAgICAqIHhtbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuaDoKKyAgICAg ICAgKFhNTERvY3VtZW50UGFyc2VyKToKKwogMjAxMi0wNi0yOCAgSGF5YXRvIEl0byAgPGhheWF0 b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ29tcG9zaXRlU2hhZG93VHJlZVdhbGtlciBzaG91 bGQgdXNlIEluc2VydGlvblBvaW50OjpoYXNEaXN0cmlidXRpb24oKSBpbnN0ZWFkIG9mIEluc2Vy dGlvblBvaW50Ojppc0FjdGl2ZSgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL3Bh cnNlci9YTUxEb2N1bWVudFBhcnNlci5oIGIvU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxE b2N1bWVudFBhcnNlci5oCmluZGV4IDYyMmNmOTAzMzFhMzNmNjQzYTMxZjNjOTkxZTUxZjE5YWIz OTA3NjEuLjJhNzI0NWU2MTMzMTk2MzdmODFmNjExZTMwODMxNDlmMDA2YmU3NGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyLmgKQEAgLTk0LDcgKzk0 LDcgQEAgY2xhc3MgVGV4dDsKIAogICAgICAgICBzdGF0aWMgYm9vbCBwYXJzZURvY3VtZW50RnJh Z21lbnQoY29uc3QgU3RyaW5nJiwgRG9jdW1lbnRGcmFnbWVudCosIEVsZW1lbnQqIHBhcmVudCA9 IDAsIEZyYWdtZW50U2NyaXB0aW5nUGVybWlzc2lvbiA9IEFsbG93U2NyaXB0aW5nQ29udGVudCk7 CiAKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgZnVuY3Rpb24gdXNlZCB0byBiZSB1c2VkIGJ5IFdN TC4gQ2FuIHdlIHJlbW92ZSBpdD8KKyAgICAgICAgLy8gVXNlZCBieSB0aGUgWE1MSHR0cFJlcXVl c3QgdG8gY2hlY2sgaWYgdGhlIHJlc3BvbnNlWE1MIHdhcyB3ZWxsIGZvcm1lZC4KICAgICAgICAg dmlydHVhbCBib29sIHdlbGxGb3JtZWQoKSBjb25zdCB7IHJldHVybiAhbV9zYXdFcnJvcjsgfQog CiAgICAgICAgIFRleHRQb3NpdGlvbiB0ZXh0UG9zaXRpb24oKSBjb25zdDsK