90212 2012-06-28 14:56:59 -0700 [chromium] Reset the device scale factor to 1 before each test is run 2012-06-28 17:01:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88121 1 tdanderson tdanderson abarth senorblanco tkent webkit.review.bot oldest_to_newest 659856 0 tdanderson 2012-06-28 14:56:59 -0700 Tests using testRunner.setBackingScaleFactor change the device scale factor but do not reset this back to 1 at the end of the test. This leads to a large number of flaky tests as noted in https://bugs.webkit.org/show_bug.cgi?id=83635 659867 1 150024 tdanderson 2012-06-28 15:12:07 -0700 Created attachment 150024 Patch 659870 2 150024 abarth 2012-06-28 15:15:20 -0700 Comment on attachment 150024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/ChangeLog:6 > + Reviewed by Adam Barth. You should leave this line with the NOBODY (OOPS)! string. The tools will fill it in based on who actually reviews the patch. 659873 3 150024 senorblanco 2012-06-28 15:20:11 -0700 Comment on attachment 150024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:653 > + m_shell->webView()->setDeviceScaleFactor(1.0); Nit: "Unless required in order to force floating point math, do not append .0, .f and .0f to floating point literals." 659887 4 150024 abarth 2012-06-28 15:36:38 -0700 Comment on attachment 150024 Patch Thanks. 659899 5 150031 tdanderson 2012-06-28 15:48:24 -0700 Created attachment 150031 Patch 659958 6 150031 abarth 2012-06-28 17:01:48 -0700 Comment on attachment 150031 Patch Clearing flags on attachment: 150031 Committed r121489: <http://trac.webkit.org/changeset/121489> 659959 7 abarth 2012-06-28 17:01:56 -0700 All reviewed patches have been landed. Closing bug. 150024 2012-06-28 15:12:07 -0700 2012-06-28 15:48:21 -0700 Patch bug-90212-20120628181207.patch text/plain 1476 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjAwNzJlZWMxNjRhNzk1MzE1NGQzNDZiNjBiYjAzZGI0 MWI1MzM0Yy4uMjQ2Y2VmNWYyMjEwNzFmZmU2MGRlYWY5YzkzZTFmYzM1NTZiMTk5MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTI4ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVzZXQgdGhlIGRldmljZSBzY2FsZSBmYWN0b3IgdG8g MSBiZWZvcmUgZWFjaCB0ZXN0IGlzIHJ1bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTAyMTIKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRo LgorCisgICAgICAgIFNvbWUgdGVzdHMgY2hhbmdlIHRoZSBkZXZpY2Ugc2NhbGUgZmFjdG9yLCBz byB0aGlzIG5lZWRzIHRvIGJlIHJlc2V0IHRvCisgICAgICAgIDEuMCBhdCB0aGUgc3RhcnQgb2Yg ZWFjaCB0ZXN0IHRvIGF2b2lkIHRlc3QgZmxha2luZXNzLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0 VGVzdENvbnRyb2xsZXI6OnJlc2V0KToKKwogMjAxMi0wNi0yOCAgQ2hyaXN0b3BoZSBEdW1leiAg PGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIEVuYWJsZSBzdXBw b3J0IGZvciBIVE1MNSBkYXRhbGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDQ1MGM0YjVhNWIwODUyOGFl ZGEwNWFhZWE1ZWVhYzUzMmJmM2U0ODMuLmQ2MDM4MGQ5OTk2ZTJjZGEyZDkxZTgwY2RkNDQ4ODU0 ZmEzNTMxMTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91 dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9M YXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAgLTY1MCw2ICs2NTAsNyBAQCB2b2lkIExheW91dFRl c3RDb250cm9sbGVyOjpyZXNldCgpCiAgICAgICAgIG1fc2hlbGwtPndlYlZpZXcoKS0+cmVtb3Zl QWxsVXNlckNvbnRlbnQoKTsKICAgICAgICAgV2ViS2l0OjpXZWJTaXplIGVtcHR5OwogICAgICAg ICBtX3NoZWxsLT53ZWJWaWV3KCktPmRpc2FibGVBdXRvUmVzaXplTW9kZSgpOworICAgICAgICBt X3NoZWxsLT53ZWJWaWV3KCktPnNldERldmljZVNjYWxlRmFjdG9yKDEuMCk7CiAgICAgfQogICAg IG1fZHVtcEFzVGV4dCA9IGZhbHNlOwogICAgIG1fZHVtcEFzQXVkaW8gPSBmYWxzZTsK 150031 2012-06-28 15:48:24 -0700 2012-06-28 17:01:48 -0700 Patch bug-90212-20120628184824.patch text/plain 1478 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjAwNzJlZWMxNjRhNzk1MzE1NGQzNDZiNjBiYjAzZGI0 MWI1MzM0Yy4uNjIxMTdhM2QyNjMzNjk2MWI2ZDJiMDc4MGIwMmIyMTkyNmU0ZjhlYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTI4ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVzZXQgdGhlIGRldmljZSBzY2FsZSBmYWN0b3IgdG8g MSBiZWZvcmUgZWFjaCB0ZXN0IGlzIHJ1bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTAyMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTb21lIHRlc3RzIGNoYW5nZSB0aGUgZGV2aWNlIHNjYWxlIGZhY3Rv ciwgc28gdGhpcyBuZWVkcyB0byBiZSByZXNldCB0bworICAgICAgICAxLjAgYXQgdGhlIHN0YXJ0 IG9mIGVhY2ggdGVzdCB0byBhdm9pZCB0ZXN0IGZsYWtpbmVzcy4KKworICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKExh eW91dFRlc3RDb250cm9sbGVyOjpyZXNldCk6CisKIDIwMTItMDYtMjggIENocmlzdG9waGUgRHVt ZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBFbmFibGUg c3VwcG9ydCBmb3IgSFRNTDUgZGF0YWxpc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAppbmRleCA0NTBjNGI1YTViMDg1 MjhhZWRhMDVhYWVhNWVlYWM1MzJiZjNlNDgzLi5lZmJmM2ZmNjllZmU0NmVjZTE1ZjYzMDE2MzM0 MTkyOWQ4OGUwNjE4IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9M YXlvdXRUZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCkBAIC02NTAsNiArNjUwLDcgQEAgdm9pZCBMYXlv dXRUZXN0Q29udHJvbGxlcjo6cmVzZXQoKQogICAgICAgICBtX3NoZWxsLT53ZWJWaWV3KCktPnJl bW92ZUFsbFVzZXJDb250ZW50KCk7CiAgICAgICAgIFdlYktpdDo6V2ViU2l6ZSBlbXB0eTsKICAg ICAgICAgbV9zaGVsbC0+d2ViVmlldygpLT5kaXNhYmxlQXV0b1Jlc2l6ZU1vZGUoKTsKKyAgICAg ICAgbV9zaGVsbC0+d2ViVmlldygpLT5zZXREZXZpY2VTY2FsZUZhY3RvcigxKTsKICAgICB9CiAg ICAgbV9kdW1wQXNUZXh0ID0gZmFsc2U7CiAgICAgbV9kdW1wQXNBdWRpbyA9IGZhbHNlOwo=