90188 2012-06-28 10:38:46 -0700 Web Inspector: Add toggle breakpoint shortcut. 2012-06-30 02:23:00 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein dubroy joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 659602 0 vsevik 2012-06-28 10:38:46 -0700 Patch to follow. 659605 1 149970 vsevik 2012-06-28 10:40:54 -0700 Created attachment 149970 Patch 660298 2 vsevik 2012-06-29 02:12:28 -0700 Committed r121535: <http://trac.webkit.org/changeset/121535> 661021 3 dubroy 2012-06-30 02:23:00 -0700 We should probably add F9 as a toggle breakpoint shortcut, since F10 and F11 already use the VS mappings, and it's helpful for those keys to be beside each other. As for Ctrl-B, does that match an existing editor? It seems like VS is F9 and Eclipse is Ctrl+Shift-B. Ctrl-B in VS opens the new breakpoint dialog, which is similar, but not quite the same. We might support a similar dialog (e.g. for creating a new conditional breakpoint), so I'd be inclined to go with Ctrl+Shift-B as the shortcut for toggle breakpoint (in addition to F9). 149970 2012-06-28 10:40:54 -0700 2012-06-29 01:14:27 -0700 Patch bug-90188-20120628214053.patch text/plain 6616 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU2ODA2Y2IzZTA4OGYw MDA0NTkyNmRhODlhNzQ1MDcyNDI1MzNmYi4uODI1MWFiZWJmMmNiNzQ5ZDUyNmUzN2JkMGVkOWY1 OTljYjlmNTMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA2LTI4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCB0b2dnbGUgYnJlYWtwb2ludCBzaG9ydGN1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3Jp cHRTb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0U291cmNl RnJhbWUucHJvdG90eXBlLl9vbk1vdXNlRG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2 YVNjcmlwdFNvdXJjZUZyYW1lLnByb3RvdHlwZS5fdG9nZ2xlQnJlYWtwb2ludCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFNvdXJjZUZyYW1lLnByb3RvdHlwZS50b2dnbGVCcmVh a3BvaW50T25DdXJyZW50TGluZSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3Jp cHRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlw ZS5fdG9nZ2xlQnJlYWtwb2ludCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVs LnByb3RvdHlwZS5fc2hvd091dGxpbmVEaWFsb2cpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnBy b3RvdHlwZS5zZWxlY3Rpb24pOgorCisyMDEyLTA2LTI4ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2 aWtAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEN1cnNvciBzaG91bGQg Zm9sbG93IGV4ZWN1dGlvbiBsaW5lIHdoZW4gZGVidWdnaW5nLgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAxODQKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9KYXZhU2NyaXB0U291cmNlRnJhbWUuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFtZS5q cwppbmRleCBiOGVjMzU2NzlkNTljNDg1NDQxYWIzMjBlZjQ5MGJiOTM0OTI1M2IwLi40OGM0Yjk1 OWRlOGMxYzc5ODUzYTRmMDU2M2M1YjhkY2E4NDEyOTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFtZS5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFtZS5q cwpAQCAtMzU5LDE0ICszNTksNyBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFNvdXJjZUZyYW1l LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgdmFyIGxpbmVOdW1i ZXIgPSB0YXJnZXQubGluZU51bWJlcjsKIAotICAgICAgICB2YXIgYnJlYWtwb2ludCA9IHRoaXMu X2JyZWFrcG9pbnRNYW5hZ2VyLmZpbmRCcmVha3BvaW50KHRoaXMuX2phdmFTY3JpcHRTb3VyY2Us IGxpbmVOdW1iZXIpOwotICAgICAgICBpZiAoYnJlYWtwb2ludCkgewotICAgICAgICAgICAgaWYg KGV2ZW50LnNoaWZ0S2V5KQotICAgICAgICAgICAgICAgIGJyZWFrcG9pbnQuc2V0RW5hYmxlZCgh YnJlYWtwb2ludC5lbmFibGVkKCkpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAg IGJyZWFrcG9pbnQucmVtb3ZlKCk7Ci0gICAgICAgIH0gZWxzZQotICAgICAgICAgICAgdGhpcy5f c2V0QnJlYWtwb2ludChsaW5lTnVtYmVyLCAiIiwgdHJ1ZSk7CisgICAgICAgIHRoaXMuX3RvZ2ds ZUJyZWFrcG9pbnQobGluZU51bWJlciwgZXZlbnQuc2hpZnRLZXkpOwogICAgICAgICBldmVudC5w cmV2ZW50RGVmYXVsdCgpOwogICAgIH0sCiAKQEAgLTUzMiw2ICs1MjUsMzAgQEAgV2ViSW5zcGVj dG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAg KiBAcGFyYW0ge251bWJlcn0gbGluZU51bWJlcgorICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gb25s eURpc2FibGUKKyAgICAgKi8KKyAgICBfdG9nZ2xlQnJlYWtwb2ludDogZnVuY3Rpb24obGluZU51 bWJlciwgb25seURpc2FibGUpCisgICAgeworICAgICAgICB2YXIgYnJlYWtwb2ludCA9IHRoaXMu X2JyZWFrcG9pbnRNYW5hZ2VyLmZpbmRCcmVha3BvaW50KHRoaXMuX2phdmFTY3JpcHRTb3VyY2Us IGxpbmVOdW1iZXIpOworICAgICAgICBpZiAoYnJlYWtwb2ludCkgeworICAgICAgICAgICAgaWYg KG9ubHlEaXNhYmxlKQorICAgICAgICAgICAgICAgIGJyZWFrcG9pbnQuc2V0RW5hYmxlZCghYnJl YWtwb2ludC5lbmFibGVkKCkpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGJy ZWFrcG9pbnQucmVtb3ZlKCk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgdGhpcy5fc2V0 QnJlYWtwb2ludChsaW5lTnVtYmVyLCAiIiwgdHJ1ZSk7CisgICAgfSwKKworICAgIHRvZ2dsZUJy ZWFrcG9pbnRPbkN1cnJlbnRMaW5lOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB2YXIgc2Vs ZWN0aW9uID0gdGhpcy50ZXh0Vmlld2VyLnNlbGVjdGlvbigpOworICAgICAgICBpZiAoIXNlbGVj dGlvbikKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdGhpcy5fdG9nZ2xlQnJlYWtwb2lu dChzZWxlY3Rpb24uc3RhcnRMaW5lLCBmYWxzZSk7CisgICAgfSwKKworICAgIC8qKgorICAgICAq IEBwYXJhbSB7bnVtYmVyfSBsaW5lTnVtYmVyCiAgICAgICogQHBhcmFtIHtzdHJpbmd9IGNvbmRp dGlvbgogICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gZW5hYmxlZAogICAgICAqLwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCA4 MDcwNTZkOTQ4MDZkZDVkMzg5NjUwZWNhNzg0ZjEwMDM4NzFiNjQ3Li4yODY5Nzc1YzA5ZTVhYTg0 YjY0Zjk0MWU1MWYxODJiZmQ0OGQ5Mjg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtMTMzLDYgKzEzMywxMCBAQCBXZWJJ bnNwZWN0b3IuU2NyaXB0c1BhbmVsID0gZnVuY3Rpb24odWlTb3VyY2VDb2RlUHJvdmlkZXJGb3JU ZXN0KQogICAgIGhlbHBTZWN0aW9uLmFkZEtleShvdXRsaW5lU2hvcnRjdXQubmFtZSwgV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJHbyB0byBtZW1iZXIiKSk7CiAgICAgdGhpcy5yZWdpc3RlclNob3J0 Y3V0KG91dGxpbmVTaG9ydGN1dC5rZXksIHRoaXMuX3Nob3dPdXRsaW5lRGlhbG9nLmJpbmQodGhp cykpOwogCisgICAgdmFyIGNyZWF0ZUJyZWFrcG9pbnRTaG9ydGN1dCA9IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0Lm1ha2VEZXNjcmlwdG9yKCJiIiwgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuTW9kaWZpZXJzLkN0cmxPck1ldGEpOworICAgIGhlbHBTZWN0aW9uLmFkZEtleShj cmVhdGVCcmVha3BvaW50U2hvcnRjdXQubmFtZSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUb2dn bGUgYnJlYWtwb2ludCIpKTsKKyAgICB0aGlzLnJlZ2lzdGVyU2hvcnRjdXQoY3JlYXRlQnJlYWtw b2ludFNob3J0Y3V0LmtleSwgdGhpcy5fdG9nZ2xlQnJlYWtwb2ludC5iaW5kKHRoaXMpKTsKKwog ICAgIHZhciBwYW5lbEVuYWJsZXJIZWFkaW5nID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJZb3Ug bmVlZCB0byBlbmFibGUgZGVidWdnaW5nIGJlZm9yZSB5b3UgY2FuIHVzZSB0aGUgU2NyaXB0cyBw YW5lbC4iKTsKICAgICB2YXIgcGFuZWxFbmFibGVyRGlzY2xhaW1lciA9IFdlYkluc3BlY3Rvci5V SVN0cmluZygiRW5hYmxpbmcgZGVidWdnaW5nIHdpbGwgbWFrZSBzY3JpcHRzIHJ1biBzbG93ZXIu Iik7CiAgICAgdmFyIHBhbmVsRW5hYmxlckJ1dHRvbiA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygi RW5hYmxlIERlYnVnZ2luZyIpOwpAQCAtOTUyLDE2ICs5NTYsMjggQEAgV2ViSW5zcGVjdG9yLlNj cmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuc2lkZWJhclBhbmVzLndhdGNo RXhwcmVzc2lvbnMuYWRkRXhwcmVzc2lvbihleHByZXNzaW9uKTsKICAgICB9LAogCisgICAgX3Rv Z2dsZUJyZWFrcG9pbnQ6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHZhciBzb3VyY2VGcmFt ZSA9IHRoaXMudmlzaWJsZVZpZXc7CisgICAgICAgIGlmICghc291cmNlRnJhbWUpCisgICAgICAg ICAgICByZXR1cm47CisKKyAgICAgICAgaWYgKHNvdXJjZUZyYW1lIGluc3RhbmNlb2YgV2ViSW5z cGVjdG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZSkgeworICAgICAgICAgICAgdmFyIGphdmFTY3Jp cHRTb3VyY2VGcmFtZSA9IC8qKiBAdHlwZSB7V2ViSW5zcGVjdG9yLkphdmFTY3JpcHRTb3VyY2VG cmFtZX0gKi8gc291cmNlRnJhbWU7CisgICAgICAgICAgICBqYXZhU2NyaXB0U291cmNlRnJhbWUu dG9nZ2xlQnJlYWtwb2ludE9uQ3VycmVudExpbmUoKTsKKyAgICAgICAgfSAgICAgICAgICAgIAor ICAgIH0sCisKICAgICBfc2hvd091dGxpbmVEaWFsb2c6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAg ICAgICB2YXIgdWlTb3VyY2VDb2RlID0gdGhpcy5fZWRpdG9yQ29udGFpbmVyLmN1cnJlbnRGaWxl KCk7Ci0gICAgICAgICBpZiAoIXVpU291cmNlQ29kZSkKLSAgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIHZhciB1aVNvdXJjZUNvZGUgPSB0aGlzLl9lZGl0b3JDb250YWluZXIuY3VycmVudEZp bGUoKTsKKyAgICAgICAgaWYgKCF1aVNvdXJjZUNvZGUpCisgICAgICAgICAgICByZXR1cm47CiAK LSAgICAgICAgIGlmICh1aVNvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuSmF2YVNj cmlwdFNvdXJjZSkKLSAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdE91dGxpbmVE aWFsb2cuc2hvdyh0aGlzLnZpc2libGVWaWV3LCB1aVNvdXJjZUNvZGUpOwotICAgICAgICAgZWxz ZSBpZiAodWlTb3VyY2VDb2RlIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlN0eWxlU291cmNlKQot ICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5TdHlsZVNoZWV0T3V0bGluZURpYWxvZy5zaG93KHRo aXMudmlzaWJsZVZpZXcsIC8qKiBAdHlwZSB7V2ViSW5zcGVjdG9yLlN0eWxlU291cmNlfSAqLyB1 aVNvdXJjZUNvZGUpOworICAgICAgICBpZiAodWlTb3VyY2VDb2RlIGluc3RhbmNlb2YgV2ViSW5z cGVjdG9yLkphdmFTY3JpcHRTb3VyY2UpCisgICAgICAgICAgICBXZWJJbnNwZWN0b3IuSmF2YVNj cmlwdE91dGxpbmVEaWFsb2cuc2hvdyh0aGlzLnZpc2libGVWaWV3LCB1aVNvdXJjZUNvZGUpOwor ICAgICAgICBlbHNlIGlmICh1aVNvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuU3R5 bGVTb3VyY2UpCisgICAgICAgICAgICBXZWJJbnNwZWN0b3IuU3R5bGVTaGVldE91dGxpbmVEaWFs b2cuc2hvdyh0aGlzLnZpc2libGVWaWV3LCAvKiogQHR5cGUge1dlYkluc3BlY3Rvci5TdHlsZVNv dXJjZX0gKi8gdWlTb3VyY2VDb2RlKTsKICAgICB9LAogCiAgICAgX2luc3RhbGxEZWJ1Z2dlclNp ZGViYXJDb250cm9sbGVyOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKaW5kZXggMWQ1YWQ3NWQxNmQ3M2MyMjM1ZWMxMzUy MGI0YmQwMjllYmYxMjI4Yi4uOTZmZThhZDU1ZGIwZGRiMjNmNmI4YWQ2ZjJlNWM3YjgwZTdmZDQx ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmll d2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdl ci5qcwpAQCAtMzA4LDYgKzMwOCwxNCBAQCBXZWJJbnNwZWN0b3IuVGV4dFZpZXdlci5wcm90b3R5 cGUgPSB7CiAgICAgfSwKIAogICAgIC8qKgorICAgICAqIEByZXR1cm4ge1dlYkluc3BlY3Rvci5U ZXh0UmFuZ2V9CisgICAgICovCisgICAgc2VsZWN0aW9uOiBmdW5jdGlvbih0ZXh0UmFuZ2UpCisg ICAgeworICAgICAgICByZXR1cm4gdGhpcy5fbWFpblBhbmVsLl9nZXRTZWxlY3Rpb24oKTsKKyAg ICB9LAorICAgIAorICAgIC8qKgogICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlRleHRSYW5n ZX0gdGV4dFJhbmdlCiAgICAgICovCiAgICAgc2V0U2VsZWN0aW9uOiBmdW5jdGlvbih0ZXh0UmFu Z2UpCg==