<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90185</bug_id>
          
          <creation_ts>2012-06-28 10:04:19 -0700</creation_ts>
          <short_desc>Deleting unused function in WebDeviceOrientation</short_desc>
          <delta_ts>2012-06-29 02:02:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Amy Ousterhout">aousterh</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>fishd</cc>
    
    <cc>hans</cc>
    
    <cc>jamesr</cc>
    
    <cc>tkent+wkapi</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>659574</commentid>
    <comment_count>0</comment_count>
    <who name="Amy Ousterhout">aousterh</who>
    <bug_when>2012-06-28 10:04:19 -0700</bug_when>
    <thetext>Deleting unused function in WebDeviceOrientation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659577</commentid>
    <comment_count>1</comment_count>
      <attachid>149965</attachid>
    <who name="Amy Ousterhout">aousterh</who>
    <bug_when>2012-06-28 10:09:15 -0700</bug_when>
    <thetext>Created attachment 149965
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659580</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-28 10:11:28 -0700</bug_when>
    <thetext>Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659649</commentid>
    <comment_count>3</comment_count>
      <attachid>149965</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-06-28 11:28:18 -0700</bug_when>
    <thetext>Comment on attachment 149965
Patch

I guess we can add this back if we end up needing it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>660287</commentid>
    <comment_count>4</comment_count>
      <attachid>149965</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-29 02:02:34 -0700</bug_when>
    <thetext>Comment on attachment 149965
Patch

Clearing flags on attachment: 149965

Committed r121532: &lt;http://trac.webkit.org/changeset/121532&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>660288</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-29 02:02:46 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>149965</attachid>
            <date>2012-06-28 10:09:15 -0700</date>
            <delta_ts>2012-06-29 02:02:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90185-20120628180915.patch</filename>
            <type>text/plain</type>
            <size>2874</size>
            <attacher name="Amy Ousterhout">aousterh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDhkMzU4OTgzYjgzZjM4YmE4MjBiODMxMWQyNTEyZjNlZDZiMGIyZmQuLmY2ZjFhODlmY2U2MzI3
MjJmYTQwZjU2NWZkODhiZmJjZWMyNjM1ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMjggIEFteSBPdXN0ZXJob3V0ICA8YW91c3RlcmhAY2hy
b21pdW0ub3JnPgorCisgICAgICAgIERlbGV0aW5nIHVudXNlZCBmdW5jdGlvbiBpbiBXZWJEZXZp
Y2VPcmllbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9OTAxODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBEZWxldGluZyB0aGUgdW51c2VkIGNvcHkgYXNzaWdubWVudCBmdW5jdGlvbiBpbiBXZWJE
ZXZpY2VPcmllbnRhdGlvbi4KKworICAgICAgICAqIHB1YmxpYy9XZWJEZXZpY2VPcmllbnRhdGlv
bi5oOgorICAgICAgICAoV2ViRGV2aWNlT3JpZW50YXRpb24pOgorICAgICAgICAqIHNyYy9XZWJE
ZXZpY2VPcmllbnRhdGlvbi5jcHA6CisKIDIwMTItMDYtMjYgIEp1biBNdWthaSAgPG11a2FpQGNo
cm9taXVtLm9yZz4KIAogICAgICAgICBBbGxvdyB1c2luZyA8aW5wdXQgdHlwZT0iY29sb3IiPiBV
SSBpbiBDaHJvbWVPUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj
L1dlYkRldmljZU9yaWVudGF0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X
ZWJEZXZpY2VPcmllbnRhdGlvbi5oCmluZGV4IDY2NTQwYmQ4YTVmN2MwZjkzZjMwYTUxNTIwNWMz
OGIxODI0OTIxYWYuLmY1NmMwMzI1Zjg3ZjdhMmU3Njk1ZGRhZTQzYTU0ODcxZWZmOWU1YmIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldmljZU9yaWVudGF0
aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2aWNlT3JpZW50
YXRpb24uaApAQCAtODcsNyArODcsNiBAQCBwdWJsaWM6CiAKICNpZiBXRUJLSVRfSU1QTEVNRU5U
QVRJT04KICAgICBXZWJEZXZpY2VPcmllbnRhdGlvbihjb25zdCBXZWJDb3JlOjpEZXZpY2VPcmll
bnRhdGlvbkRhdGEqKTsKLSAgICBXZWJEZXZpY2VPcmllbnRhdGlvbiYgb3BlcmF0b3I9KGNvbnN0
IFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uRGF0YSopOwogICAgIG9wZXJhdG9yIFdURjo6UGFz
c1JlZlB0cjxXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkRhdGE+KCkgY29uc3Q7CiAjZW5kaWYK
IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2aWNlT3JpZW50
YXRpb24uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2aWNlT3JpZW50YXRp
b24uY3BwCmluZGV4IDI0ZjdiYzgwMWNhZTliZWMyZTUyODkxMjc3ZGQ3ODNlMWNlZDhkNzUuLjg4
NTA3NjkyMTgzYzQ1MmI5NTMzMDlkNzE0NmEwYjdjMDMyNDZiMTQgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRldmljZU9yaWVudGF0aW9uLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEZXZpY2VPcmllbnRhdGlvbi5jcHAKQEAgLTU3LDMz
ICs1Nyw2IEBAIFdlYkRldmljZU9yaWVudGF0aW9uOjpXZWJEZXZpY2VPcmllbnRhdGlvbihjb25z
dCBXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkRhdGEqCiAgICAgbV9hYnNvbHV0ZSA9IG9yaWVu
dGF0aW9uLT5hYnNvbHV0ZSgpOwogfQogCi1XZWJEZXZpY2VPcmllbnRhdGlvbiYgV2ViRGV2aWNl
T3JpZW50YXRpb246Om9wZXJhdG9yPShjb25zdCBXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkRh
dGEqIG9yaWVudGF0aW9uKQotewotICAgIGlmICghb3JpZW50YXRpb24pIHsKLSAgICAgICAgbV9p
c051bGwgPSB0cnVlOwotICAgICAgICBtX2NhblByb3ZpZGVBbHBoYSA9IGZhbHNlOwotICAgICAg
ICBtX2FscGhhID0gMDsKLSAgICAgICAgbV9jYW5Qcm92aWRlQmV0YSA9IGZhbHNlOwotICAgICAg
ICBtX2JldGEgPSAwOwotICAgICAgICBtX2NhblByb3ZpZGVHYW1tYSA9IGZhbHNlOwotICAgICAg
ICBtX2dhbW1hID0gMDsKLSAgICAgICAgbV9jYW5Qcm92aWRlQWJzb2x1dGUgPSBmYWxzZTsKLSAg
ICAgICAgbV9hYnNvbHV0ZSA9IGZhbHNlOwotICAgICAgICByZXR1cm4gKnRoaXM7Ci0gICAgfQot
Ci0gICAgbV9pc051bGwgPSBmYWxzZTsKLSAgICBtX2NhblByb3ZpZGVBbHBoYSA9IG9yaWVudGF0
aW9uLT5jYW5Qcm92aWRlQWxwaGEoKTsKLSAgICBtX2FscGhhID0gb3JpZW50YXRpb24tPmFscGhh
KCk7Ci0gICAgbV9jYW5Qcm92aWRlQmV0YSA9IG9yaWVudGF0aW9uLT5jYW5Qcm92aWRlQmV0YSgp
OwotICAgIG1fYmV0YSA9IG9yaWVudGF0aW9uLT5iZXRhKCk7Ci0gICAgbV9jYW5Qcm92aWRlR2Ft
bWEgPSBvcmllbnRhdGlvbi0+Y2FuUHJvdmlkZUdhbW1hKCk7Ci0gICAgbV9nYW1tYSA9IG9yaWVu
dGF0aW9uLT5nYW1tYSgpOwotICAgIG1fY2FuUHJvdmlkZUFic29sdXRlID0gb3JpZW50YXRpb24t
PmNhblByb3ZpZGVBYnNvbHV0ZSgpOwotICAgIG1fYWJzb2x1dGUgPSBvcmllbnRhdGlvbi0+YWJz
b2x1dGUoKTsKLSAgICByZXR1cm4gKnRoaXM7Ci19Ci0KIFdlYkRldmljZU9yaWVudGF0aW9uOjpv
cGVyYXRvciBQYXNzUmVmUHRyPFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uRGF0YT4oKSBjb25z
dAogewogICAgIGlmIChtX2lzTnVsbCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>