90184 2012-06-28 09:32:27 -0700 Web Inspector: Cursor should follow execution line when debugging. 2012-06-30 02:00:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein dubroy joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 659560 0 vsevik 2012-06-28 09:32:27 -0700 This will allow us to implement "toggle breakpoint" shortcut nicely. Patch to follow. 659570 1 149964 vsevik 2012-06-28 09:52:55 -0700 Created attachment 149964 Patch 660294 2 vsevik 2012-06-29 02:09:26 -0700 Committed r121534: <http://trac.webkit.org/changeset/121534> 660659 3 pfeldman 2012-06-29 11:29:14 -0700 (In reply to comment #2) > Committed r121534: <http://trac.webkit.org/changeset/121534> Does Eclipse's / Idea's / VS's cursor follow execution line? Not sure we need a shortcut for toggling breakpoint, hence not sure we should change behavior for that. 660693 4 vsevik 2012-06-29 11:56:36 -0700 (In reply to comment #3) > (In reply to comment #2) > > Committed r121534: <http://trac.webkit.org/changeset/121534> > > Does Eclipse's / Idea's / VS's cursor follow execution line? Not sure we need a shortcut for toggling breakpoint, hence not sure we should change behavior for that. Sure they do. When debugging recently, I found out that the main reason for me to use mouse in devtools is toggling a breakpoint, it seems very natural to me to have such a shortcut. Often I set breakpoint on some high-level function, then trigger some action on the inspected page and then remove breakpoint and step in until I find low-level function I need and set breakpoint inside it. Almost all of this could be done without touching mouse. Imagine you trigger first breakpoint by running some console command - in this case you don't need to touch mouse at all. I am not insisting on any particular shortcut though. 660985 5 pfeldman 2012-06-29 21:55:15 -0700 > Often I set breakpoint on some high-level function, then trigger some action on the inspected page and then remove breakpoint and step in until I find low-level function I need and set breakpoint inside it. > Almost all of this could be done without touching mouse. > Imagine you trigger first breakpoint by running some console command - in this case you don't need to touch mouse at all. > > I am not insisting on any particular shortcut though. That all sounds reasonable, but I am not sure it is worth a shortcut. Could you answer the question about similar functionality in other IDEs? 661007 6 vsevik 2012-06-29 23:27:02 -0700 (In reply to comment #5) > > Often I set breakpoint on some high-level function, then trigger some action on the inspected page and then remove breakpoint and step in until I find low-level function I need and set breakpoint inside it. > > Almost all of this could be done without touching mouse. > > Imagine you trigger first breakpoint by running some console command - in this case you don't need to touch mouse at all. > > > > I am not insisting on any particular shortcut though. > > That all sounds reasonable, but I am not sure it is worth a shortcut. Could you answer the question about similar functionality in other IDEs? I thought I already did. This functionality is supported by all IDE you mentioned. 661008 7 pfeldman 2012-06-29 23:36:32 -0700 > > That all sounds reasonable, but I am not sure it is worth a shortcut. Could you answer the question about similar functionality in other IDEs? > > I thought I already did. This functionality is supported by all IDE you mentioned. This looks great then, thank you! 661020 8 dubroy 2012-06-30 02:00:09 -0700 Definitely seems reasonable to me. VS and Eclipse behave this way, and staying consistent with them seems like a good idea. 149964 2012-06-28 09:52:55 -0700 2012-06-29 01:16:48 -0700 Patch bug-90184-20120628205254.patch text/plain 7619 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2YwYmMzZWQxZmFlODA3 MWExZjAzZWJmZWY2OGFmNDFhNzhiMDYyNC4uMDU2ODA2Y2IzZTA4OGYwMDA0NTkyNmRhODlhNzQ1 MDcyNDI1MzNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA2LTI4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEN1cnNvciBzaG91bGQgZm9sbG93IGV4ZWN1dGlvbiBsaW5lIHdoZW4gZGVidWdnaW5nLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAxODQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBUZXh0 Vmlld2VyLnNldFNlbGVjdGlvbiBwdWJsaWMgbWV0aG9kIHRvIHNldCBjdXJzb3Igc2VsZWN0aW9u IGluIHRoZSBlZGl0b3IuCisgICAgICAgIEFkZGVkIFRleHRSYW5nZS5jcmVhdGVGcm9tTG9jYXRp b24gbWV0aG9kIHRvIGNyZWF0ZSBUZXh0UmFuZ2VzIHdpdGggdGhlIHNhbWUgc3RhcnQgYW5kIGVu ZCBwb2ludHMuCisgICAgICAgIERyaXZlLWJ5OiByZW1vdmVkIHVudXNlZCBfc2V0Q2FyZXRMb2Nh dGlvbigpIG1ldGhvZCBpbiBUZXh0Vmlld2VyLmpzCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5K YXZhU2NyaXB0U291cmNlRnJhbWUucHJvdG90eXBlLnNldEV4ZWN1dGlvbkxpbmUpOgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX3JldmVhbEV4ZWN1dGlvbkxpbmUpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX2VkaXRvclNlbGVjdGVk KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5zZXRTZWxlY3Rpb24pOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5zZXRDb250ZW50KToKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3JNb2RlbC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UZXh0UmFuZ2UuY3JlYXRlRnJvbUxvY2F0aW9uKToKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGV4dFZpZXdlci5wcm90b3R5cGUuc2V0U2VsZWN0aW9uKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5oaWdobGlnaHRMaW5lKToKKwogMjAxMi0w Ni0yOCAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQ bGF0Zm9ybV0gSW1wbGVtZW50IGZ1bmN0aW9ucyBmb3IgbG9jYWxpemVkIHRpbWUgZm9ybWF0IGlu Zm9ybWF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0phdmFTY3JpcHRTb3VyY2VGcmFtZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpzCmluZGV4IGMyMzFlMDM0ZDMwM2ZiOWQ2Y2I4 MGFhNzdmZDU3OTAyNzQ4YmU2OWYuLmI4ZWMzNTY3OWQ1OWM0ODU0NDFhYjMyMGVmNDkwYmI5MzQ5 MjUzYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2 YVNjcmlwdFNvdXJjZUZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpzCkBAIC00MzcsNiArNDM3LDggQEAgV2ViSW5z cGVjdG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0 aGlzLnRleHRWaWV3ZXIuYWRkRGVjb3JhdGlvbihsaW5lTnVtYmVyLCAid2Via2l0LWV4ZWN1dGlv bi1saW5lIik7CiAgICAgICAgICAgICB0aGlzLnJldmVhbExpbmUodGhpcy5fZXhlY3V0aW9uTGlu ZU51bWJlcik7CiAgICAgICAgIH0KKyAgICAgICAgaWYgKHRoaXMuY2FuRWRpdFNvdXJjZSgpKQor ICAgICAgICAgICAgdGhpcy5zZXRTZWxlY3Rpb24oV2ViSW5zcGVjdG9yLlRleHRSYW5nZS5jcmVh dGVGcm9tTG9jYXRpb24obGluZU51bWJlciwgMCkpOwogICAgIH0sCiAKICAgICBjbGVhckV4ZWN1 dGlvbkxpbmU6IGZ1bmN0aW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TY3JpcHRzUGFuZWwuanMKaW5kZXggMmQ2NGUyMGY5N2NhNTJmZjE4MjMzNmY4ZDc5 YmExMjg2OTc1Yzc0My4uODA3MDU2ZDk0ODA2ZGQ1ZDM4OTY1MGVjYTc4NGYxMDAzODcxYjY0NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFu ZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFu ZWwuanMKQEAgLTU0OCw2ICs1NDgsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3Rv dHlwZSA9IHsKICAgICAgICAgdGhpcy5fZWRpdG9yQ29udGFpbmVyLnVpU291cmNlQ29kZUFkZGVk KHVpTG9jYXRpb24udWlTb3VyY2VDb2RlKTsKICAgICAgICAgdmFyIHNvdXJjZUZyYW1lID0gdGhp cy5fc2hvd0ZpbGUodWlMb2NhdGlvbi51aVNvdXJjZUNvZGUpOwogICAgICAgICBzb3VyY2VGcmFt ZS5yZXZlYWxMaW5lKHVpTG9jYXRpb24ubGluZU51bWJlcik7CisgICAgICAgIHNvdXJjZUZyYW1l LmZvY3VzKCk7CiAgICAgfSwKIAogICAgIF9jYWxsRnJhbWVTZWxlY3RlZDogZnVuY3Rpb24oZXZl bnQpCkBAIC01NzgsOCArNTc5LDkgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5 cGUgPSB7CiAgICAgX2VkaXRvclNlbGVjdGVkOiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAg ICAgIHZhciB1aVNvdXJjZUNvZGUgPSAvKiogQHR5cGUge1dlYkluc3BlY3Rvci5VSVNvdXJjZUNv ZGV9ICovIGV2ZW50LmRhdGE7Ci0gICAgICAgIHRoaXMuX3Nob3dGaWxlKHVpU291cmNlQ29kZSk7 CisgICAgICAgIHZhciBzb3VyY2VGcmFtZSA9IHRoaXMuX3Nob3dGaWxlKHVpU291cmNlQ29kZSk7 CiAgICAgICAgIHRoaXMuX25hdmlnYXRvckNvbnRyb2xsZXIuaGlkZU5hdmlnYXRvck92ZXJsYXko KTsKKyAgICAgICAgc291cmNlRnJhbWUuZm9jdXMoKTsKICAgICB9LAogCiAgICAgX3NjcmlwdFNl bGVjdGVkOiBmdW5jdGlvbihldmVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCmluZGV4IDI2ODlhNzcyZGFlZjYzN2QxYjA1MmQ2ODhl NjQ0NmYxMGFkMmQ0NmYuLmQyZjFmMGMzMDFiNzg0MDcyNmE4N2NkNzg1NGY2YmZiMzY3MDZhMTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJh bWUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFt ZS5qcwpAQCAtMTc3LDYgKzE3NywxNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90 eXBlID0gewogICAgICAgICAgICAgdGhpcy5fbGluZVRvUmV2ZWFsID0gbGluZTsKICAgICB9LAog CisgICAgLyoqCisgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuVGV4dFJhbmdlfSB0ZXh0UmFu Z2UKKyAgICAgKi8KKyAgICBzZXRTZWxlY3Rpb246IGZ1bmN0aW9uKHRleHRSYW5nZSkKKyAgICB7 CisgICAgICAgIGlmICh0aGlzLmxvYWRlZCkKKyAgICAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIu c2V0U2VsZWN0aW9uKHRleHRSYW5nZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRoaXMu X3NlbGVjdGlvblRvU2V0ID0gdGV4dFJhbmdlOworICAgIH0sCisKICAgICBfY2xlYXJMaW5lVG9S ZXZlYWw6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9saW5lVG9SZXZl YWw7CkBAIC0yMTgsNiArMjI5LDExIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5 cGUgPSB7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5fbGluZVRvUmV2ZWFsOwogICAgICAgICB9 CiAKKyAgICAgICAgaWYgKHR5cGVvZiB0aGlzLl9zZWxlY3Rpb25Ub1NldCA9PT0gIm9iamVjdCIp IHsKKyAgICAgICAgICAgIHRoaXMuc2V0U2VsZWN0aW9uKHRoaXMuX3NlbGVjdGlvblRvU2V0KTsK KyAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9zZWxlY3Rpb25Ub1NldDsKKyAgICAgICAgfQorCiAg ICAgICAgIGlmICh0aGlzLl9kZWxheWVkRmluZFNlYXJjaE1hdGNoZXMpIHsKICAgICAgICAgICAg IHRoaXMuX2RlbGF5ZWRGaW5kU2VhcmNoTWF0Y2hlcygpOwogICAgICAgICAgICAgZGVsZXRlIHRo aXMuX2RlbGF5ZWRGaW5kU2VhcmNoTWF0Y2hlczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dEVkaXRvck1vZGVsLmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMKaW5kZXggN2E0MWRiNDZiNDBi YTc0ZjJmYzZjMzY2ZGFhMDVmZTk3YzE4MzY3Yy4uYzg2YWRiNTkzN2IyMmEwYTg2NWI3ZGE2NWU5 ODNiYTkxMmU1NDcyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMKQEAgLTQzLDYgKzQzLDExIEBAIFdlYkluc3BlY3Rv ci5UZXh0UmFuZ2UgPSBmdW5jdGlvbihzdGFydExpbmUsIHN0YXJ0Q29sdW1uLCBlbmRMaW5lLCBl bmRDb2x1bW4pCiAgICAgdGhpcy5lbmRDb2x1bW4gPSBlbmRDb2x1bW47CiB9CiAKK1dlYkluc3Bl Y3Rvci5UZXh0UmFuZ2UuY3JlYXRlRnJvbUxvY2F0aW9uID0gZnVuY3Rpb24obGluZSwgY29sdW1u KQoreworICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLlRleHRSYW5nZShsaW5lLCBjb2x1bW4s IGxpbmUsIGNvbHVtbik7Cit9CisKIFdlYkluc3BlY3Rvci5UZXh0UmFuZ2UucHJvdG90eXBlID0g ewogICAgIC8qKgogICAgICAqIEByZXR1cm4ge2Jvb2xlYW59CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKaW5kZXggZTM2ZTE5ZDY2MzAyYzUw MjdkZjdiYTAwNTJhZjMwODU1YzA4OTc2NC4uMWQ1YWQ3NWQxNmQ3M2MyMjM1ZWMxMzUyMGI0YmQw MjllYmYxMjI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9UZXh0Vmlld2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv VGV4dFZpZXdlci5qcwpAQCAtMzA3LDYgKzMwNywxNCBAQCBXZWJJbnNwZWN0b3IuVGV4dFZpZXdl ci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKKyAgICAvKioK KyAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5UZXh0UmFuZ2V9IHRleHRSYW5nZQorICAgICAq LworICAgIHNldFNlbGVjdGlvbjogZnVuY3Rpb24odGV4dFJhbmdlKQorICAgIHsKKyAgICAgICAg dGhpcy5fbWFpblBhbmVsLl9yZXN0b3JlU2VsZWN0aW9uKHRleHRSYW5nZSk7CisgICAgfSwKKyAg ICAKICAgICB3YXNTaG93bjogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgaWYgKCF0aGlzLnJl YWRPbmx5KCkpCkBAIC0xMDU5LDcgKzEwNjcsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1h aW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMucmV2ZWFsTGluZShsaW5lTnVtYmVy KTsKIAogICAgICAgICBpZiAoIXRoaXMuX3JlYWRPbmx5KQotICAgICAgICAgICAgdGhpcy5fcmVz dG9yZVNlbGVjdGlvbihuZXcgV2ViSW5zcGVjdG9yLlRleHRSYW5nZShsaW5lTnVtYmVyLCAwLCBs aW5lTnVtYmVyLCAwKSwgZmFsc2UpOworICAgICAgICAgICAgdGhpcy5fcmVzdG9yZVNlbGVjdGlv bihXZWJJbnNwZWN0b3IuVGV4dFJhbmdlLmNyZWF0ZUZyb21Mb2NhdGlvbihsaW5lTnVtYmVyLCAw KSwgZmFsc2UpOwogCiAgICAgICAgIHRoaXMuYWRkRGVjb3JhdGlvbihsaW5lTnVtYmVyLCAid2Vi a2l0LWhpZ2hsaWdodGVkLWxpbmUiKTsKICAgICB9LApAQCAtMTE2MCw3ICsxMTY4LDcgQEAgV2Vi SW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAg aW5kZW50RW5kTGluZS0tOwogCiAgICAgICAgIGZvciAodmFyIGxpbmVOdW1iZXIgPSByYW5nZS5z dGFydExpbmU7IGxpbmVOdW1iZXIgPD0gaW5kZW50RW5kTGluZTsgbGluZU51bWJlcisrKQotICAg ICAgICAgICAgdGhpcy5fdGV4dE1vZGVsLmVkaXRSYW5nZShuZXcgV2ViSW5zcGVjdG9yLlRleHRS YW5nZShsaW5lTnVtYmVyLCAwLCBsaW5lTnVtYmVyLCAwKSwgaW5kZW50KTsKKyAgICAgICAgICAg IHRoaXMuX3RleHRNb2RlbC5lZGl0UmFuZ2UobmV3IFdlYkluc3BlY3Rvci5UZXh0UmFuZ2UuY3Jl YXRlRnJvbUxvY2F0aW9uKGxpbmVOdW1iZXIsIDApLCBpbmRlbnQpOwogCiAgICAgICAgIHRoaXMu X2xhc3RFZGl0ZWRSYW5nZSA9IG5ld1JhbmdlOwogCkBAIC0xNTM0LDYgKzE1NDIsOSBAQCBXZWJJ bnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMu X2NhY2hlZFJvd3MucHVzaChsaW5lUm93KTsKICAgICB9LAogCisgICAgLyoqCisgICAgICogQHJl dHVybiB7V2ViSW5zcGVjdG9yLlRleHRSYW5nZX0KKyAgICAgKi8KICAgICBfZ2V0U2VsZWN0aW9u OiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIgc2VsZWN0aW9uID0gd2luZG93LmdldFNl bGVjdGlvbigpOwpAQCAtMTU2OCwxMiArMTU3OSw2IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y TWFpblBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKLSAgICBfc2V0Q2Fy ZXRMb2NhdGlvbjogZnVuY3Rpb24obGluZSwgY29sdW1uLCBzY3JvbGxJbnRvVmlldykKLSAgICB7 Ci0gICAgICAgIHZhciByYW5nZSA9IG5ldyBXZWJJbnNwZWN0b3IuVGV4dFJhbmdlKGxpbmUsIGNv bHVtbiwgbGluZSwgY29sdW1uKTsKLSAgICAgICAgdGhpcy5fcmVzdG9yZVNlbGVjdGlvbihyYW5n ZSwgc2Nyb2xsSW50b1ZpZXcpOwotICAgIH0sCi0KICAgICBfc2VsZWN0aW9uVG9Qb3NpdGlvbjog ZnVuY3Rpb24oY29udGFpbmVyLCBvZmZzZXQpCiAgICAgewogICAgICAgICBpZiAoY29udGFpbmVy ID09PSB0aGlzLl9jb250YWluZXIgJiYgb2Zmc2V0ID09PSAwKQo=