90179 2012-06-28 07:21:07 -0700 [chromium] Change WebViewImpl::textInputInfo to use root editable element. 2012-06-28 12:36:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olilan olilan abarth eric webkit.review.bot oldest_to_newest 659487 0 olilan 2012-06-28 07:21:07 -0700 [chromium] Change WebViewImpl::textInputInfo to use root editable element. 659492 1 149952 olilan 2012-06-28 07:27:09 -0700 Created attachment 149952 Patch 659515 2 149952 abarth 2012-06-28 08:29:43 -0700 Comment on attachment 149952 Patch Looks great. Thanks. 659696 3 149952 webkit.review.bot 2012-06-28 12:35:57 -0700 Comment on attachment 149952 Patch Clearing flags on attachment: 149952 Committed r121451: <http://trac.webkit.org/changeset/121451> 659697 4 webkit.review.bot 2012-06-28 12:36:01 -0700 All reviewed patches have been landed. Closing bug. 149952 2012-06-28 07:27:09 -0700 2012-06-28 12:35:56 -0700 Patch bug-90179-20120628152708.patch text/plain 6081 olilan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNiYTc3Yzg0MWM5YjI0MGQwMjFmMDhmM2IwOWYyMjk1NWFmMmQ5M2IuLjM1MDMzNmNmZjk0MzBk MWUzYTM3NzZlZDIzN2FkNDY2NGFmZWQ0MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTItMDYtMjggIE9saSBMYW4gIDxvbGlsYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2hhbmdlIFdlYlZpZXdJbXBsOjp0ZXh0SW5wdXRJbmZv IHRvIHVzZSByb290IGVkaXRhYmxlIGVsZW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDE3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYlZpZXdJbXBsOjp0ZXh0SW5wdXRJbmZvIGN1cnJlbnRs eSByZXR1cm5zIHRleHQgdmFsdWUgYW5kIG9mZnNldHMgcmVsYXRpdmUgdG8gdGhlCisgICAgICAg IGZvY3VzZWQgbm9kZS4gRm9yIGNvbnRlbnRlZGl0YWJsZSBub2RlcywgdGhpcyBtYXkgbm90IGdp dmUgdGhlIGV4cGVjdGVkIHJlc3VsdC4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhl IG1ldGhvZCB0byByZXR1cm4gdmFsdWUgYW5kIG9mZnNldHMgZm9yIHRoZSByb290IGVkaXRhYmxl IGVsZW1lbnQuCisgICAgICAgIFRoaXMgYWxzbyBhbGxvd3MgdGhlIGltcGxlbWVudGF0aW9uIHRv IGJlIHNpbXBsaWZpZWQgc29tZXdoYXQuCisKKyAgICAgICAgVGhpcyBhbHNvIGVuc3VyZXMgdGhh dCB0aGUgb2Zmc2V0cyByZXR1cm5lZCB3aWxsIHVzZSB0aGUgc2FtZSBiYXNpcyBhcyB0aGUgcmVj ZW50bHkgYWRkZWQKKyAgICAgICAgbWV0aG9kIEVkaXRvcjo6c2V0U2VsZWN0aW9uT2Zmc2V0cyAo YW5kIFdlYlZpZXdJbXBsOjpzZXRFZGl0YWJsZVNlbGVjdGlvbk9mZnNldHMpLgorCisgICAgICAg IFRlc3RpbmcgZm9yIHRleHRJbnB1dEluZm8gaGFzIGJlZW4gYWRkZWQgdG8gV2ViVmlld1Rlc3Qu CisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6dGV4dElucHV0SW5mbyk6CisgICAgICAgICogdGVzdHMvV2ViVmlld1Rlc3QuY3Bw OgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorCiAyMDEyLTA2LTI4ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTIxMzk1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwCmluZGV4IDI2ZGY0MzY0ZDBjNjkzYWE0MzFkMjkyNjM2ZmRhY2M5M2M3ZTNhNzguLmIzZmRk ZWYxZTdhMGFhMDY5MTQ4NzBiZWU1MTlmYWQzNzNlNzBmMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE5ODcsNyArMTk4Nyw3IEBAIFdlYlRleHRJ bnB1dEluZm8gV2ViVmlld0ltcGw6OnRleHRJbnB1dEluZm8oKQogICAgIGlmICghc2VsZWN0aW9u KQogICAgICAgICByZXR1cm4gaW5mbzsKIAotICAgIE5vZGUqIG5vZGUgPSBmb2N1c2VkV2ViQ29y ZU5vZGUoKTsKKyAgICBOb2RlKiBub2RlID0gc2VsZWN0aW9uLT5zZWxlY3Rpb24oKS5yb290RWRp dGFibGVFbGVtZW50KCk7CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm4gaW5mbzsKIApA QCAtMTk5NSwzMyArMTk5NSwyMiBAQCBXZWJUZXh0SW5wdXRJbmZvIFdlYlZpZXdJbXBsOjp0ZXh0 SW5wdXRJbmZvKCkKICAgICBpZiAoaW5mby50eXBlID09IFdlYlRleHRJbnB1dFR5cGVOb25lKQog ICAgICAgICByZXR1cm4gaW5mbzsKIAotICAgIGlmIChub2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1l czo6dGV4dGFyZWFUYWcpKQotICAgICAgICBpbmZvLnZhbHVlID0gc3RhdGljX2Nhc3Q8SFRNTFRl eHRBcmVhRWxlbWVudCo+KG5vZGUpLT52YWx1ZSgpOwotICAgIGVsc2UgaWYgKG5vZGUtPmhhc1Rh Z05hbWUoSFRNTE5hbWVzOjppbnB1dFRhZykpCi0gICAgICAgIGluZm8udmFsdWUgPSBzdGF0aWNf Y2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4obm9kZSktPnZhbHVlKCk7Ci0gICAgZWxzZSBpZiAobm9k ZS0+c2hvdWxkVXNlSW5wdXRNZXRob2QoKSkKLSAgICAgICAgaW5mby52YWx1ZSA9IG5vZGUtPm5v ZGVWYWx1ZSgpOwotICAgIGVsc2UKLSAgICAgICAgcmV0dXJuIGluZm87CisgICAgaW5mby52YWx1 ZSA9IHBsYWluVGV4dChyYW5nZU9mQ29udGVudHMobm9kZSkuZ2V0KCkpOwogCiAgICAgaWYgKGlu Zm8udmFsdWUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gaW5mbzsKIAotICAgIGlmIChub2Rl LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6dGV4dGFyZWFUYWcpIHx8IG5vZGUtPmhhc1RhZ05hbWUo SFRNTE5hbWVzOjppbnB1dFRhZykpIHsKLSAgICAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1l bnQqIGZvcm1FbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQq Pihub2RlKTsKLSAgICAgICAgaW5mby5zZWxlY3Rpb25TdGFydCA9IGZvcm1FbGVtZW50LT5zZWxl Y3Rpb25TdGFydCgpOwotICAgICAgICBpbmZvLnNlbGVjdGlvbkVuZCA9IGZvcm1FbGVtZW50LT5z ZWxlY3Rpb25FbmQoKTsKLSAgICAgICAgaWYgKGVkaXRvci0+aGFzQ29tcG9zaXRpb24oKSkgewot ICAgICAgICAgICAgaW5mby5jb21wb3NpdGlvblN0YXJ0ID0gZm9ybUVsZW1lbnQtPmluZGV4Rm9y VmlzaWJsZVBvc2l0aW9uKFBvc2l0aW9uKGVkaXRvci0+Y29tcG9zaXRpb25Ob2RlKCksIGVkaXRv ci0+Y29tcG9zaXRpb25TdGFydCgpKSk7Ci0gICAgICAgICAgICBpbmZvLmNvbXBvc2l0aW9uRW5k ID0gZm9ybUVsZW1lbnQtPmluZGV4Rm9yVmlzaWJsZVBvc2l0aW9uKFBvc2l0aW9uKGVkaXRvci0+ Y29tcG9zaXRpb25Ob2RlKCksIGVkaXRvci0+Y29tcG9zaXRpb25FbmQoKSkpOwotICAgICAgICB9 Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgaW5mby5zZWxlY3Rpb25TdGFydCA9IHNlbGVjdGlvbi0+ c3RhcnQoKS5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCk7Ci0gICAgICAgIGluZm8uc2Vs ZWN0aW9uRW5kID0gc2VsZWN0aW9uLT5lbmQoKS5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2Rl KCk7Ci0gICAgICAgIGlmIChlZGl0b3ItPmhhc0NvbXBvc2l0aW9uKCkpIHsKLSAgICAgICAgICAg IGluZm8uY29tcG9zaXRpb25TdGFydCA9IHN0YXRpY19jYXN0PGludD4oZWRpdG9yLT5jb21wb3Np dGlvblN0YXJ0KCkpOwotICAgICAgICAgICAgaW5mby5jb21wb3NpdGlvbkVuZCA9IHN0YXRpY19j YXN0PGludD4oZWRpdG9yLT5jb21wb3NpdGlvbkVuZCgpKTsKLSAgICAgICAgfQorICAgIHNpemVf dCBsb2NhdGlvbjsKKyAgICBzaXplX3QgbGVuZ3RoOworICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2Ug PSBzZWxlY3Rpb24tPnNlbGVjdGlvbigpLmZpcnN0UmFuZ2UoKTsKKyAgICBpZiAocmFuZ2UgJiYg VGV4dEl0ZXJhdG9yOjpnZXRMb2NhdGlvbkFuZExlbmd0aEZyb21SYW5nZShzZWxlY3Rpb24tPnJv b3RFZGl0YWJsZUVsZW1lbnQoKSwgcmFuZ2UuZ2V0KCksIGxvY2F0aW9uLCBsZW5ndGgpKSB7Cisg ICAgICAgIGluZm8uc2VsZWN0aW9uU3RhcnQgPSBsb2NhdGlvbjsKKyAgICAgICAgaW5mby5zZWxl Y3Rpb25FbmQgPSBsb2NhdGlvbiArIGxlbmd0aDsKKyAgICB9CisgICAgcmFuZ2UgPSBlZGl0b3It PmNvbXBvc2l0aW9uUmFuZ2UoKTsKKyAgICBpZiAocmFuZ2UgJiYgVGV4dEl0ZXJhdG9yOjpnZXRM b2NhdGlvbkFuZExlbmd0aEZyb21SYW5nZShzZWxlY3Rpb24tPnJvb3RFZGl0YWJsZUVsZW1lbnQo KSwgcmFuZ2UuZ2V0KCksIGxvY2F0aW9uLCBsZW5ndGgpKSB7CisgICAgICAgIGluZm8uY29tcG9z aXRpb25TdGFydCA9IGxvY2F0aW9uOworICAgICAgICBpbmZvLmNvbXBvc2l0aW9uRW5kID0gbG9j YXRpb24gKyBsZW5ndGg7CiAgICAgfQogCiAgICAgcmV0dXJuIGluZm87CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlZpZXdUZXN0LmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCmluZGV4IGY4NThmZTdiNTgxZTdiMTgz YzRiNGJkNWEzMzcyNzRiZTA2MTljNTkuLjhlY2NmMmM0YTY5YjI1YzViMWYxM2FhYjhmOGUwM2Yw NGMzYjA2OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmll d1Rlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3Qu Y3BwCkBAIC0zMDYsNyArMzA2LDcgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBESVNBQkxFRF9UZXh0 SW5wdXRUeXBlKQogCiB9CiAKLVRFU1RfRihXZWJWaWV3VGVzdCwgU2V0RWRpdGFibGVTZWxlY3Rp b25PZmZzZXRzKQorVEVTVF9GKFdlYlZpZXdUZXN0LCBTZXRFZGl0YWJsZVNlbGVjdGlvbk9mZnNl dHNBbmRUZXh0SW5wdXRJbmZvKQogewogICAgIEZyYW1lVGVzdEhlbHBlcnM6OnJlZ2lzdGVyTW9j a2VkVVJMTG9hZChtX2Jhc2VVUkwsICJpbnB1dF9maWVsZF9wb3B1bGF0ZWQuaHRtbCIpOwogICAg IFdlYlZpZXcqIHdlYlZpZXcgPSBGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9h ZChtX2Jhc2VVUkwgKyAiaW5wdXRfZmllbGRfcG9wdWxhdGVkLmh0bWwiKTsKQEAgLTMxNCw2ICsz MTQsMTIgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBTZXRFZGl0YWJsZVNlbGVjdGlvbk9mZnNldHMp CiAgICAgd2ViVmlldy0+c2V0RWRpdGFibGVTZWxlY3Rpb25PZmZzZXRzKDUsIDEzKTsKICAgICBX ZWJGcmFtZUltcGwqIGZyYW1lID0gc3RhdGljX2Nhc3Q8V2ViRnJhbWVJbXBsKj4od2ViVmlldy0+ bWFpbkZyYW1lKCkpOwogICAgIEVYUEVDVF9FUSgiNTY3ODlhYmMiLCBmcmFtZS0+c2VsZWN0aW9u QXNUZXh0KCkpOworICAgIFdlYlRleHRJbnB1dEluZm8gaW5mbyA9IHdlYlZpZXctPnRleHRJbnB1 dEluZm8oKTsKKyAgICBFWFBFQ1RfRVEoIjAxMjM0NTY3ODlhYmNkZWZnaGlqa2xtbm9wcXJzdHV2 d3h5eiIsIGluZm8udmFsdWUpOworICAgIEVYUEVDVF9FUSg1LCBpbmZvLnNlbGVjdGlvblN0YXJ0 KTsKKyAgICBFWFBFQ1RfRVEoMTMsIGluZm8uc2VsZWN0aW9uRW5kKTsKKyAgICBFWFBFQ1RfRVEo LTEsIGluZm8uY29tcG9zaXRpb25TdGFydCk7CisgICAgRVhQRUNUX0VRKC0xLCBpbmZvLmNvbXBv c2l0aW9uRW5kKTsKICAgICB3ZWJWaWV3LT5jbG9zZSgpOwogCiAgICAgRnJhbWVUZXN0SGVscGVy czo6cmVnaXN0ZXJNb2NrZWRVUkxMb2FkKG1fYmFzZVVSTCwgImNvbnRlbnRfZWRpdGFibGVfcG9w dWxhdGVkLmh0bWwiKTsKQEAgLTMyMiw2ICszMjgsMTIgQEAgVEVTVF9GKFdlYlZpZXdUZXN0LCBT ZXRFZGl0YWJsZVNlbGVjdGlvbk9mZnNldHMpCiAgICAgd2ViVmlldy0+c2V0RWRpdGFibGVTZWxl Y3Rpb25PZmZzZXRzKDgsIDE5KTsKICAgICBmcmFtZSA9IHN0YXRpY19jYXN0PFdlYkZyYW1lSW1w bCo+KHdlYlZpZXctPm1haW5GcmFtZSgpKTsKICAgICBFWFBFQ1RfRVEoIjg5YWJjZGVmZ2hpIiwg ZnJhbWUtPnNlbGVjdGlvbkFzVGV4dCgpKTsKKyAgICBpbmZvID0gd2ViVmlldy0+dGV4dElucHV0 SW5mbygpOworICAgIEVYUEVDVF9FUSgiMDEyMzQ1Njc4OWFiY2RlZmdoaWprbG1ub3BxcnN0dXZ3 eHl6IiwgaW5mby52YWx1ZSk7CisgICAgRVhQRUNUX0VRKDgsIGluZm8uc2VsZWN0aW9uU3RhcnQp OworICAgIEVYUEVDVF9FUSgxOSwgaW5mby5zZWxlY3Rpb25FbmQpOworICAgIEVYUEVDVF9FUSgt MSwgaW5mby5jb21wb3NpdGlvblN0YXJ0KTsKKyAgICBFWFBFQ1RfRVEoLTEsIGluZm8uY29tcG9z aXRpb25FbmQpOwogICAgIHdlYlZpZXctPmNsb3NlKCk7CiB9CiAK