90167 2012-06-28 06:02:20 -0700 [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS) 2012-06-28 07:27:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy apavlov apavlov koivisto ossy zherczeg oldest_to_newest 659447 0 ossy 2012-06-28 06:02:20 -0700 inspector/styles/inject-stylesheet.html makes the following tests flakey (TEXT PASS): - inspector/styles/styles-iframe.html - inspector/styles/styles-source-lines.html - inspector/styles/media-queries.html - tables/mozilla/bugs/bug27038-3.html This test introduced in http://trac.webkit.org/changeset/120600 and fixed by http://trac.webkit.org/changeset/120708. You can easily reproduce this bug with the following command: - Tools/Script/run-webkit-tests inspector/styles/inject-stylesheet.html inspector/styles/styles-iframe.html inspector/styles/styles-source-lines.html inspector/styles/media-queries.html tables/mozilla/bugs/bug27038-3.html diffs: --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/styles-iframe-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/styles-iframe-actual.txt @@ -11,6 +11,10 @@ media="screen" (styles-iframe.html) #main { (styles-iframe.html:5) background: blue; + +[expanded] +#main { (user stylesheet) +color: red; [expanded] div { (user agent stylesheet) @@ -28,6 +32,10 @@ background: green; [expanded] +#iframebody { (user stylesheet) +/-- overloaded --/ background: red; + +[expanded] body { (user agent stylesheet) display: block; margin: 8px; --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/styles-source-lines-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/styles-source-lines-actual.txt @@ -28,6 +28,10 @@ content: "Before"; [expanded] +#main { (user stylesheet) +/-- overloaded --/ color: red; + +[expanded] div { (user agent stylesheet) display: block; --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/media-queries-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/inspector/styles/media-queries-actual.txt @@ -25,6 +25,10 @@ background: blue; [expanded] +#main { (user stylesheet) +/-- overloaded --/ color: red; + +[expanded] div { (user agent stylesheet) display: block; --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/tables/mozilla/bugs/bug27038-3-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/tables/mozilla/bugs/bug27038-3-actual.txt @@ -6,14 +6,14 @@ RenderBlock {DIV} at (0,0) size 784x29 [bgcolor=#D0D0D0] RenderText {#text} at (315,0) size 154x29 text run at (315,0) width 154: "Font Size:6mm" - RenderTable {TABLE} at (0,29) size 784x143 [bgcolor=#008000] + RenderTable {TABLE} at (0,29) size 784x143 [color=#FF0000] [bgcolor=#008000] RenderTableSection {TBODY} at (0,0) size 784x143 RenderTableRow {TR} at (0,2) size 784x139 RenderTableCell {TD} at (2,2) size 389x139 [r=0 c=0 rs=1 cs=1] RenderBlock {DIV} at (1,1) size 387x29 [bgcolor=#D0D0D0] RenderText {#text} at (82,0) size 223x29 text run at (82,0) width 223: "Table height at 24mm" - RenderTable {TABLE} at (1,30) size 387x108 + RenderTable {TABLE} at (1,30) size 387x108 [color=#000000] RenderTableSection {THEAD} at (0,0) size 387x37 [bgcolor=#FF0000] RenderTableRow {TR} at (0,2) size 387x33 RenderTableCell {TD} at (2,2) size 383x33 [r=0 c=0 rs=1 cs=1] @@ -33,7 +33,7 @@ RenderBlock {DIV} at (1,1) size 387x29 [bgcolor=#D0D0D0] RenderText {#text} at (82,0) size 223x29 text run at (82,0) width 223: "Table height at 25mm" - RenderTable {TABLE} at (1,30) size 387x108 + RenderTable {TABLE} at (1,30) size 387x108 [color=#000000] RenderTableSection {THEAD} at (0,0) size 387x37 [bgcolor=#FF0000] RenderTableRow {TR} at (0,2) size 387x33 RenderTableCell {TD} at (2,2) size 383x33 [r=0 c=0 rs=1 cs=1] 659455 1 ossy 2012-06-28 06:22:20 -0700 I skipped it to make bots happier - http://trac.webkit.org/changeset/121427/trunk/LayoutTests/platform/qt/Skipped Please unskip it with the proper fix. 659483 2 149948 apavlov 2012-06-28 07:13:45 -0700 Created attachment 149948 Patch 659485 3 149948 ossy 2012-06-28 07:19:17 -0700 Comment on attachment 149948 Patch LGTM, r=me. Please unskip the test when you lands the patch. Thanks for the quick fix. ;-) 659493 4 apavlov 2012-06-28 07:27:44 -0700 Committed r121429: <http://trac.webkit.org/changeset/121429> 149948 2012-06-28 07:13:45 -0700 2012-06-28 07:19:17 -0700 Patch bug-90167-20120628181344.patch text/plain 4417 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDVlNjc0ZDBiOGI2 ZDFlMGJlMTVlNzEwYzRlNjhhZDI4NWM2NWQwZjIuLmQ1Y2U3YmI3MjRjMzc2OTA4N2YwMDVkYTk1 MGNiYTM4OTk1YzdiZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDYt MjggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBb UXRdIGluc3BlY3Rvci9zdHlsZXMvaW5qZWN0LXN0eWxlc2hlZXQuaHRtbCBtYWtlcyA0IHRlc3Rz IGZsYWtleSAoVEVYVCBQQVNTKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTAxNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcDoK KyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpyZW1vdmVVc2VyU3R5bGVTaGVldHMp OgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Lmg6CisK IDIwMTItMDYtMjUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU0xvY2sgc2hvdWxkIGJlIHBlci1KU0dsb2JhbERhdGEKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3Bw IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR dC5jcHAKaW5kZXggYWNjNjYzNWMzOGMwODNhYjgyZGJlZDEwOWNiNWFmMDAwZjJiOWM4MS4uZTkw MWM4ZDRjMmM2NzdlYzFhMDJhMDc1ZDU5MmU0MzcwNWU0NDg3ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR dC5jcHAKQEAgLTkxNyw2ICs5MTcsMTEgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 YWRkVXNlclN0eWxlU2hlZXQoUVdlYlBhZ2UqIHBhZ2UsIGNvbnN0IFFTdHJpbmcmIHMKICAgICBw YWdlLT5oYW5kbGUoKS0+cGFnZS0+Z3JvdXAoKS5hZGRVc2VyU3R5bGVTaGVldFRvV29ybGQobWFp blRocmVhZE5vcm1hbFdvcmxkKCksIHNvdXJjZUNvZGUsIFFVcmwoKSwgbnVsbHB0ciwgbnVsbHB0 ciwgV2ViQ29yZTo6SW5qZWN0SW5BbGxGcmFtZXMpOwogfQogCit2b2lkIER1bXBSZW5kZXJUcmVl U3VwcG9ydFF0OjpyZW1vdmVVc2VyU3R5bGVTaGVldHMoUVdlYlBhZ2UqIHBhZ2UpCit7CisgICAg cGFnZS0+aGFuZGxlKCktPnBhZ2UtPmdyb3VwKCkucmVtb3ZlVXNlclN0eWxlU2hlZXRzRnJvbVdv cmxkKG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKK30KKwogdm9pZCBEdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdDo6c2ltdWxhdGVEZXNrdG9wTm90aWZpY2F0aW9uQ2xpY2soY29uc3QgUVN0cmluZyYg dGl0bGUpCiB7CiAjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9U SUZJQ0FUSU9OUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaAppbmRleCAxNzYyOTAwMWEzNGI2OGM3OWJhZTJi NzBlZTdmNWNiNTRkY2JkYjIzLi43OThkYjI5MDExMjZjNTEwOTNhMTJlMDE4ZmZjMjY3Y2YwMzlk ZGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0LmgKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCkBAIC0xOTUsNiArMTk1LDcgQEAgcHVibGljOgogICAg IHN0YXRpYyBRU3RyaW5nIHBhZ2VTaXplQW5kTWFyZ2luc0luUGl4ZWxzKFFXZWJGcmFtZSogZnJh bWUsIGludCBwYWdlSW5kZXgsIGludCB3aWR0aCwgaW50IGhlaWdodCwgaW50IG1hcmdpblRvcCwg aW50IG1hcmdpblJpZ2h0LCBpbnQgbWFyZ2luQm90dG9tLCBpbnQgbWFyZ2luTGVmdCk7CiAgICAg c3RhdGljIFFTdHJpbmcgcGFnZVByb3BlcnR5KFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJp bmcmIHByb3BlcnR5TmFtZSwgaW50IHBhZ2VOdW1iZXIpOwogICAgIHN0YXRpYyB2b2lkIGFkZFVz ZXJTdHlsZVNoZWV0KFFXZWJQYWdlKiBwYWdlLCBjb25zdCBRU3RyaW5nJiBzb3VyY2VDb2RlKTsK KyAgICBzdGF0aWMgdm9pZCByZW1vdmVVc2VyU3R5bGVTaGVldHMoUVdlYlBhZ2UqKTsKICAgICBz dGF0aWMgdm9pZCBzaW11bGF0ZURlc2t0b3BOb3RpZmljYXRpb25DbGljayhjb25zdCBRU3RyaW5n JiB0aXRsZSk7CiAgICAgc3RhdGljIFFTdHJpbmcgdmlld3BvcnRBc1RleHQoUVdlYlBhZ2UqLCBp bnQgZGV2aWNlRFBJLCBjb25zdCBRU2l6ZSYgZGV2aWNlU2l6ZSwgY29uc3QgUVNpemUmIGF2YWls YWJsZVNpemUpOwogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggYmFhNzNkMDNiYTRhYmNhYTExYmRhMTA0NDVhZDhhOGVjNzYyOTRlNC4uYjM4OTk1 MWQ2MTZiYzRkNDc0OGE1MDZiMTYxMjFhNzQwN2U2YWI0NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTI4 ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1F0 XSBpbnNwZWN0b3Ivc3R5bGVzL2luamVjdC1zdHlsZXNoZWV0Lmh0bWwgbWFrZXMgNCB0ZXN0cyBm bGFrZXkgKFRFWFQgUEFTUykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwMTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRFJUIHNob3VsZCByZW1vdmUgdXNlciBzdHlsZXNoZWV0cyBmcm9tIHRoZSBwYWdl IGdyb3VwIHdoZW4gcmVzZXR0aW5nIGJlZm9yZSBydW5uaW5nIGFub3RoZXIgdGVzdC4KKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGVCZWZvcmVUZXN0 aW5nKToKKwogMjAxMi0wNi0yNyAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAg ICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzkwMDk2PiBCdWlsZGluZyB3aXRoaW4gWGNvZGUgc29t ZXRpbWVzIGRvZXMgYSBmdWxsIHJlYnVpbGQgYWZ0ZXIgYnVpbGRpbmcgdmlhIGJ1aWxkLXdlYmtp dApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAppbmRleCA5 ZDBhZTYyYWM4ZWEwMTRmNDRjOTAxODFhMDI2MzhjMTgwNDFhMmQ4Li5hYzFmYzBlMDIxMmQ4YjQ0 NDU5ZDBhN2M5MjE0MmM5NWNiNzRlMzc0IDEwMDc1NQotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9E dW1wUmVuZGVyVHJlZVF0LmNwcApAQCAtNTM2LDEwICs1MzYsMTEgQEAgdm9pZCBEdW1wUmVuZGVy VHJlZTo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcoY29uc3QgUVVybCYgdXJs KQogI2lmbmRlZiBRVF9OT19VTkRPU1RBQ0sKICAgICBtX3BhZ2UtPnVuZG9TdGFjaygpLT5jbGVh cigpOwogI2VuZGlmCi0gICAgCisKICAgICBjbGVhckhpc3RvcnkobV9wYWdlKTsKICAgICBEdW1w UmVuZGVyVHJlZVN1cHBvcnRRdDo6c2NhbGVQYWdlQnkobV9wYWdlLT5tYWluRnJhbWUoKSwgMSwg UVBvaW50KDAsIDApKTsKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y2xlYXJGcmFtZU5h bWUobV9wYWdlLT5tYWluRnJhbWUoKSk7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnJl bW92ZVVzZXJTdHlsZVNoZWV0cyhtX3BhZ2UpOwogCiAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS0+ c2V0U2Nyb2xsQmFyUG9saWN5KFF0OjpWZXJ0aWNhbCwgUXQ6OlNjcm9sbEJhckFzTmVlZGVkKTsK ICAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5zZXRTY3JvbGxCYXJQb2xpY3koUXQ6Okhvcml6b250 YWwsIFF0OjpTY3JvbGxCYXJBc05lZWRlZCk7Cg==