90159 2012-06-28 04:11:59 -0700 user-select: none cursor turns to I-beam on mouse dragging 2014-04-22 16:06:29 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID http://yves.vg/testcases/chrome/user_select_none_dragging.html InRadar P2 Normal --- 1 yves.vangoethem webkit-unassigned ap commit-queue darin enrica mitz rniwa vani.hegde webkit-bug-importer oldest_to_newest 659405 0 yves.vangoethem 2012-06-28 04:11:59 -0700 Observation: When you start selecting an area that has user-select:none; and drag the cursor around, it changes to a text cursor. Expected: The cursor should be default as defined. 932878 1 212536 vani.hegde 2013-09-24 22:07:25 -0700 Created attachment 212536 Patch 932880 2 vani.hegde 2013-09-24 22:13:36 -0700 This has got nothing to do with user-select:none. The bug here is cursor type being changed to text cursor(I-Beam cursor) during selection, even when the cursor type is explicitly set to be something else. This is committed in blink https://codereview.chromium.org/23461040/ 933077 3 rniwa 2013-09-25 10:41:42 -0700 It seems like this is done intentionally. I'm not sure changing this behavior is desirable. 933082 4 rniwa 2013-09-25 10:49:09 -0700 Hm... looking more closely, maybe this is a regression from http://trac.webkit.org/changeset/11490. 933087 5 212536 rniwa 2013-09-25 10:53:35 -0700 Comment on attachment 212536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review > Source/WebCore/page/EventHandler.cpp:1371 > + // During selection, use an I-beam no matter what we're over. We should probably rephrase this comment to something along the line of "use an I-beam regardless of the content beneath the cursor when cursor is not explicitly specified." since now we're respecting cursor CSS property during text selection. 933089 6 212536 rniwa 2013-09-25 10:56:03 -0700 Comment on attachment 212536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review > LayoutTests/editing/caret/selection-with-caret-type-progress.html:10 > + description('Tests whether explicitly set caret style is retained on performing text selection'); The description can be outside of this if. It would be nice if you had something like debug("This test requires eventSender") in the else clause. Better yet, explain how to manually test it. 933113 7 webkit-bug-importer 2013-09-25 11:17:09 -0700 <rdar://problem/15078860> 933334 8 vani.hegde 2013-09-25 20:14:06 -0700 (In reply to comment #5) > (From update of attachment 212536 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review > > > Source/WebCore/page/EventHandler.cpp:1371 > > + // During selection, use an I-beam no matter what we're over. > > We should probably rephrase this comment to something along the line of "use an I-beam regardless of the content beneath the cursor when cursor is not explicitly specified." > since now we're respecting cursor CSS property during text selection. Will do. 933338 9 212658 vani.hegde 2013-09-25 20:43:39 -0700 Created attachment 212658 Patch 933339 10 vani.hegde 2013-09-25 20:44:33 -0700 Uploaded patch with review comments incorporated. 934473 11 212658 commit-queue 2013-09-30 00:11:29 -0700 Comment on attachment 212658 Patch Clearing flags on attachment: 212658 Committed r156635: <http://trac.webkit.org/changeset/156635> 934474 12 commit-queue 2013-09-30 00:11:33 -0700 All reviewed patches have been landed. Closing bug. 969283 13 mitz 2014-01-17 15:34:46 -0800 (In reply to comment #11) > (From update of attachment 212658 [details]) > Clearing flags on attachment: 212658 > > Committed r156635: <http://trac.webkit.org/changeset/156635> This caused bug 127197. 1003086 14 rniwa 2014-04-22 16:02:36 -0700 (In reply to comment #13) > (In reply to comment #11) > > (From update of attachment 212658 [details] [details]) > > Clearing flags on attachment: 212658 > > > > Committed r156635: <http://trac.webkit.org/changeset/156635> > > This caused bug 127197. As I suspect, the old behavior was indeed intended. Revering the patch. 1003087 15 rniwa 2014-04-22 16:06:29 -0700 Reverted the patch in http://trac.webkit.org/changeset/167688. 212536 2013-09-24 22:07:25 -0700 2013-09-25 20:43:30 -0700 Patch bug-90159-20130925104240.patch text/plain 6617 vani.hegde U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZjZDZmZGY3YzNhZjEy ZTIwNTUwNDVjZDI0NTVhYjIzZjEzMTc3Yi4uOTM5MDg2MGM1OWRlMjQyM2ExNTRhMjUzOWRkN2Zi MjNmZjRiZWNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA5LTI0ICBWYW5p IEhlZ2RlICA8dmFuaS5oZWdkZUBzYW1zdW5nLmNvbT4KKworICAgICAgICB1c2VyLXNlbGVjdDog bm9uZSBjdXJzb3IgdHVybnMgdG8gSS1iZWFtIG9uIG1vdXNlIGRyYWdnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDE1OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdHJpZWQgdG8gc2VsZWN0 IHNvbWUgdGV4dCBpbiBhbiBhcmVhIHRoYXQgaGFzIHN0eWxlCisgICAgICAgIGN1cnNvcjpkZWZh dWx0IHNldCwgY3Vyc29yIHR5cGUgY2hhbmdlcyB0byB0ZXh0IGN1cnNvciBpZ25vcmluZworICAg ICAgICB0aGUgY3Vyc29yIHN0eWxlIHRoYXQgaXMgZXhwbGljaXRseSBzZXQuCisKKyAgICAgICAg V2hlbiB0aGUgY3Vyc29yIHN0eWxlIGlzIGV4cGxpY2l0bHkgc2V0IGFzIGRlZmF1bHQgKG9yIHNv bWV0aGluZyBlbHNlKSwKKyAgICAgICAgd2Ugc2hvdWxkIG5vdCBjaGFuZ2UgaXQgdG8gdGV4dCBj dXJzb3Igbm8gbWF0dGVyIHdoYXQgd2UgYXJlIG92ZXIKKyAgICAgICAgb3Igd2hhdCBvcGVyYXRp b24gd2UgYXJlIHBlcmZvcm1pbmcgKGJlIGl0IGhvdmVyaW5nIG92ZXIgdGhlIHRleHQKKyAgICAg ICAgb3Igc2VsZWN0aW5nIHRoZSB0ZXh0KS4KKworICAgICAgICBEdXJpbmcgdGV4dCBzZWxlY3Rp b24sIGNoYW5naW5nIHRoZSBjdXJzb3IgdHlwZSB0byB0ZXh0IG9ubHkgd2hlbgorICAgICAgICB0 aGVyZSBpcyBubyBleHBsaWNpdCBjdXJzb3IgdHlwZSBzZXQgZml4ZXMgdGhlIGlzc3VlLgorCisg ICAgICAgIFRlc3Q6IGVkaXRpbmcvY2FyZXQvc2VsZWN0aW9uLXdpdGgtY2FyZXQtdHlwZS1wcm9n cmVzcy5odG1sCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFdmVudEhhbmRsZXI6OnNlbGVjdEN1cnNvcik6CisgICAgICAgIER1cmluZyBzZWxl Y3Rpb24sIHNldCB0aGUgY3Vyc29yIHN0eWxlIHRvIHRleHQgb25seSBpZiB0aGVyZSBpcyBubwor ICAgICAgICBleHBsaWNpdCBjdXJzb3Igc3R5bGUgc2V0LgorCiAyMDEzLTA5LTI0ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgYSBjb250 cmFkaWN0aW9uIGZyb20gU2VsZWN0b3JDaGVja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKaW5kZXggN2I2YWQ0YmI1M2QxYmVmODBmZmZiOGEyN2NjZDMzMzc4Y2NmYzk3Yi4uY2Vk OWU4MDYyNGYyYjEzZDBlMTNmOGNiOTE3MjdkNzdjN2YxMzIyZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcApAQCAtMTMwNiwxNSArMTMwNiw2IEBAIE9wdGlvbmFsQ3Vyc29yIEV2 ZW50SGFuZGxlcjo6c2VsZWN0Q3Vyc29yKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgYm9v bCBzaGlmCiAgICAgICAgIGNhbmNlbEF1dG9IaWRlQ3Vyc29yVGltZXIoKTsKICNlbmRpZgogCi0g ICAgLy8gRHVyaW5nIHNlbGVjdGlvbiwgdXNlIGFuIEktYmVhbSBubyBtYXR0ZXIgd2hhdCB3ZSdy ZSBvdmVyLgotICAgIC8vIElmIGEgZHJhZyBtYXkgYmUgc3RhcnRpbmcgb3Igd2UncmUgY2FwdHVy aW5nIG1vdXNlIGV2ZW50cyBmb3IgYSBwYXJ0aWN1bGFyIG5vZGUsIGRvbid0IHRyZWF0IHRoaXMg YXMgYSBzZWxlY3Rpb24uCi0gICAgaWYgKG1fbW91c2VQcmVzc2VkICYmIG1fbW91c2VEb3duTWF5 U3RhcnRTZWxlY3QKLSNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQotICAgICAgICAmJiAhbV9tb3Vz ZURvd25NYXlTdGFydERyYWcKLSNlbmRpZgotICAgICAgICAmJiBtX2ZyYW1lLnNlbGVjdGlvbigp LmlzQ2FyZXRPclJhbmdlKCkgJiYgIW1fY2FwdHVyaW5nTW91c2VFdmVudHNOb2RlKQotICAgICAg ICByZXR1cm4gaUJlYW07Ci0KICAgICBpZiAocmVuZGVyZXIpIHsKICAgICAgICAgQ3Vyc29yIG92 ZXJyaWRlQ3Vyc29yOwogICAgICAgICBzd2l0Y2ggKHJlbmRlcmVyLT5nZXRDdXJzb3Iocm91bmRl ZEludFBvaW50KHJlc3VsdC5sb2NhbFBvaW50KCkpLCBvdmVycmlkZUN1cnNvcikpIHsKQEAgLTEz NzYsNiArMTM2NywxOCBAQCBPcHRpb25hbEN1cnNvciBFdmVudEhhbmRsZXI6OnNlbGVjdEN1cnNv cihjb25zdCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGJvb2wgc2hpZgogICAgICAgICAgICAgICAg ICAgICBpblJlc2l6ZXIgPSBsYXllci0+aXNQb2ludEluUmVzaXplQ29udHJvbCh2aWV3LT53aW5k b3dUb0NvbnRlbnRzKHJvdW5kZWRJbnRQb2ludChyZXN1bHQubG9jYWxQb2ludCgpKSkpOwogICAg ICAgICAgICAgfQogICAgICAgICB9CisKKyAgICAgICAgLy8gRHVyaW5nIHNlbGVjdGlvbiwgdXNl IGFuIEktYmVhbSBubyBtYXR0ZXIgd2hhdCB3ZSdyZSBvdmVyLgorICAgICAgICAvLyBJZiBhIGRy YWcgbWF5IGJlIHN0YXJ0aW5nIG9yIHdlJ3JlIGNhcHR1cmluZyBtb3VzZSBldmVudHMgZm9yIGEg cGFydGljdWxhciBub2RlLCBkb24ndCB0cmVhdCB0aGlzIGFzIGEgc2VsZWN0aW9uLgorICAgICAg ICBpZiAobV9tb3VzZVByZXNzZWQgJiYgbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdAorI2lmIEVO QUJMRShEUkFHX1NVUFBPUlQpCisgICAgICAgICAgICAmJiAhbV9tb3VzZURvd25NYXlTdGFydERy YWcKKyNlbmRpZgorICAgICAgICAgICAgJiYgbV9mcmFtZS5zZWxlY3Rpb24oKS5pc0NhcmV0T3JS YW5nZSgpCisgICAgICAgICAgICAmJiAhbV9jYXB0dXJpbmdNb3VzZUV2ZW50c05vZGUpIHsKKyAg ICAgICAgICAgIHJldHVybiBpQmVhbTsKKyAgICAgICAgfQorCiAgICAgICAgIGlmICgoZWRpdGFi bGUgfHwgKHJlbmRlcmVyICYmIHJlbmRlcmVyLT5pc1RleHQoKSAmJiBub2RlLT5jYW5TdGFydFNl bGVjdGlvbigpKSkgJiYgIWluUmVzaXplciAmJiAhcmVzdWx0LnNjcm9sbGJhcigpKQogICAgICAg ICAgICAgcmV0dXJuIGlCZWFtOwogICAgICAgICByZXR1cm4gcG9pbnRlckN1cnNvcigpOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGQ0MGE3MmIxODcwNDk0MzE3YjZkZDk5ZjU1YjFkYzgxNWE2MDg5NmQuLjVjYmMxNjU0MjVi ZGU4ZWQ2ZjQ3Yzc0OGYxOGYyM2ZiODdlZDg4YzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx My0wOS0yNCAgVmFuaSBIZWdkZSAgPHZhbmkuaGVnZGVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg dXNlci1zZWxlY3Q6IG5vbmUgY3Vyc29yIHR1cm5zIHRvIEktYmVhbSBvbiBtb3VzZSBkcmFnZ2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTAxNTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGNh c2UgYWRkZWQgdG8gdmVyaWZ5IHRoYXQgZXhwbGljaXRseSBzZXQgY3Vyc29yIHN0eWxlCisgICAg ICAgIGlzIHJldGFpbmVkIG9uIHBlcmZvcm1pbmcgdGV4dCBzZWxlY3Rpb24uCisKKyAgICAgICAg KiBlZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNhcmV0LXR5cGUtcHJvZ3Jlc3MtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNh cmV0LXR5cGUtcHJvZ3Jlc3MuaHRtbDogQWRkZWQuCisKIDIwMTMtMDktMjQgIE1hcmsgSGFobmVu YmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBvcF9nZXRfY2FsbGVlIHNo b3VsZG4ndCB1c2UgdmFsdWUgcHJvZmlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNhcmV0LXR5cGUtcHJvZ3Jlc3MtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9jYXJldC9zZWxlY3Rpb24td2l0aC1jYXJldC10eXBlLXBy b2dyZXNzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kMDE0ZDBhMjk4OWIyZTI3OGFkNzc5ZTgy ZDQ2ZWVjZWUxNzJkNGJhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9j YXJldC9zZWxlY3Rpb24td2l0aC1jYXJldC10eXBlLXByb2dyZXNzLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDExIEBACitUZXN0cyB3aGV0aGVyIGV4cGxpY2l0bHkgc2V0IGNhcmV0IHN0eWxlIGlz IHJldGFpbmVkIG9uIHBlcmZvcm1pbmcgdGV4dCBzZWxlY3Rpb24KKworT24gc3VjY2VzcywgeW91 IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg Q09NUExFVEUiLgorCisKK1RyeSBzZWxlY3RpbmcgdGhpcyB0ZXh0IGJ5IGRyYWdnaW5nIHRoZSBj dXJzb3IuIFByb2dyZXNzIGN1cnNvciBzaG91bGQgYmUgZGlzcGxheWVkIHdoaWxlIGRvaW5nIHNv LgorUEFTUyBjdXJyZW50Q3Vyc29yVHlwZSBpcyAiUHJvZ3Jlc3MiCitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZWRpdGluZy9jYXJldC9zZWxlY3Rpb24td2l0aC1jYXJldC10eXBlLXByb2dyZXNzLmh0bWwg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNhcmV0LXR5cGUtcHJv Z3Jlc3MuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hOGY5ZDQ2NjkwMzljZjNmZWM2OGFjZmE0YWQ1ZjA5NDQ3 YzFmOGUzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9jYXJldC9zZWxl Y3Rpb24td2l0aC1jYXJldC10eXBlLXByb2dyZXNzLmh0bWwKQEAgLTAsMCArMSwzNyBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8 ZGl2IHN0eWxlPSJjdXJzb3I6cHJvZ3Jlc3M7IGJvcmRlcjogMnB4IHNvbGlkIHJlZDsiIGlkPSJ0 ZXN0Ij5Ucnkgc2VsZWN0aW5nIHRoaXMgdGV4dCBieSBkcmFnZ2luZyB0aGUgY3Vyc29yLiBQcm9n cmVzcyBjdXJzb3Igc2hvdWxkIGJlIGRpc3BsYXllZCB3aGlsZSBkb2luZyBzby48L2Rpdj4KKzxk aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5ldmVudFNlbmRlciAm JiB3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgZGVzY3JpcHRpb24oJ1Rlc3RzIHdoZXRoZXIgZXhw bGljaXRseSBzZXQgY2FyZXQgc3R5bGUgaXMgcmV0YWluZWQgb24gcGVyZm9ybWluZyB0ZXh0IHNl bGVjdGlvbicpOworCisgICAgdmFyIGRpdiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0 Iik7CisgICAgZGl2LmZvY3VzKCk7CisKKyAgICB2YXIgeSA9IGRpdi5vZmZzZXRUb3AgKyBkaXYu b2Zmc2V0SGVpZ2h0IC8gMjsKKworICAgIGZ1bmN0aW9uIGxlYXBGb3J3YXJkQW5kTW92ZSh4KSB7 CisgICAgICAgIGV2ZW50U2VuZGVyLmxlYXBGb3J3YXJkKDIwMCk7CisgICAgICAgIGV2ZW50U2Vu ZGVyLm1vdXNlTW92ZVRvKGRpdi5vZmZzZXRMZWZ0ICsgeCwgeSk7CisgICAgfQorCisgICAgZXZl bnRTZW5kZXIuZHJhZ01vZGUgPSBmYWxzZTsKKyAgICBsZWFwRm9yd2FyZEFuZE1vdmUoZGl2Lm9m ZnNldExlZnQgKyA1KTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKworICAgIGxlYXBG b3J3YXJkQW5kTW92ZShkaXYub2Zmc2V0TGVmdCArIDEwKTsKKyAgICBsZWFwRm9yd2FyZEFuZE1v dmUoZGl2Lm9mZnNldExlZnQgKyAyMCk7CisgICAgbGVhcEZvcndhcmRBbmRNb3ZlKGRpdi5vZmZz ZXRXaWR0aCAtIDEwKTsKKworICAgIHZhciBjdXJzb3JJbmZvID0gd2luZG93LmludGVybmFscy5n ZXRDdXJyZW50Q3Vyc29ySW5mbyhkb2N1bWVudCk7CisgICAgdmFyIGN1cnJlbnRDdXJzb3JUeXBl ID0gY3Vyc29ySW5mby5zdWJzdHJpbmcoY3Vyc29ySW5mby5pbmRleE9mKCc9JykgKyAxLCBjdXJz b3JJbmZvLmxhc3RJbmRleE9mKCcgJykpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnY3Vy cmVudEN1cnNvclR5cGUnLCAnUHJvZ3Jlc3MnKTsKK30KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgo= 212658 2013-09-25 20:43:39 -0700 2013-09-30 00:11:29 -0700 Patch bug-90159-20130926091853.patch text/plain 6738 vani.hegde U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZjZDZmZGY3YzNhZjEy ZTIwNTUwNDVjZDI0NTVhYjIzZjEzMTc3Yi4uOTM5MDg2MGM1OWRlMjQyM2ExNTRhMjUzOWRkN2Zi MjNmZjRiZWNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA5LTI0ICBWYW5p IEhlZ2RlICA8dmFuaS5oZWdkZUBzYW1zdW5nLmNvbT4KKworICAgICAgICB1c2VyLXNlbGVjdDog bm9uZSBjdXJzb3IgdHVybnMgdG8gSS1iZWFtIG9uIG1vdXNlIGRyYWdnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDE1OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdHJpZWQgdG8gc2VsZWN0 IHNvbWUgdGV4dCBpbiBhbiBhcmVhIHRoYXQgaGFzIHN0eWxlCisgICAgICAgIGN1cnNvcjpkZWZh dWx0IHNldCwgY3Vyc29yIHR5cGUgY2hhbmdlcyB0byB0ZXh0IGN1cnNvciBpZ25vcmluZworICAg ICAgICB0aGUgY3Vyc29yIHN0eWxlIHRoYXQgaXMgZXhwbGljaXRseSBzZXQuCisKKyAgICAgICAg V2hlbiB0aGUgY3Vyc29yIHN0eWxlIGlzIGV4cGxpY2l0bHkgc2V0IGFzIGRlZmF1bHQgKG9yIHNv bWV0aGluZyBlbHNlKSwKKyAgICAgICAgd2Ugc2hvdWxkIG5vdCBjaGFuZ2UgaXQgdG8gdGV4dCBj dXJzb3Igbm8gbWF0dGVyIHdoYXQgd2UgYXJlIG92ZXIKKyAgICAgICAgb3Igd2hhdCBvcGVyYXRp b24gd2UgYXJlIHBlcmZvcm1pbmcgKGJlIGl0IGhvdmVyaW5nIG92ZXIgdGhlIHRleHQKKyAgICAg ICAgb3Igc2VsZWN0aW5nIHRoZSB0ZXh0KS4KKworICAgICAgICBEdXJpbmcgdGV4dCBzZWxlY3Rp b24sIGNoYW5naW5nIHRoZSBjdXJzb3IgdHlwZSB0byB0ZXh0IG9ubHkgd2hlbgorICAgICAgICB0 aGVyZSBpcyBubyBleHBsaWNpdCBjdXJzb3IgdHlwZSBzZXQgZml4ZXMgdGhlIGlzc3VlLgorCisg ICAgICAgIFRlc3Q6IGVkaXRpbmcvY2FyZXQvc2VsZWN0aW9uLXdpdGgtY2FyZXQtdHlwZS1wcm9n cmVzcy5odG1sCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFdmVudEhhbmRsZXI6OnNlbGVjdEN1cnNvcik6CisgICAgICAgIER1cmluZyBzZWxl Y3Rpb24sIHNldCB0aGUgY3Vyc29yIHN0eWxlIHRvIHRleHQgb25seSBpZiB0aGVyZSBpcyBubwor ICAgICAgICBleHBsaWNpdCBjdXJzb3Igc3R5bGUgc2V0LgorCiAyMDEzLTA5LTI0ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgYSBjb250 cmFkaWN0aW9uIGZyb20gU2VsZWN0b3JDaGVja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKaW5kZXggN2I2YWQ0YmI1M2QxYmVmODBmZmZiOGEyN2NjZDMzMzc4Y2NmYzk3Yi4uOWMy ZmU0MGRiYTdlMjM3MGU1Yzk1YWU0MzdkZGUyNmIwYzA2YjA3ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcApAQCAtMTMwNiwxNSArMTMwNiw2IEBAIE9wdGlvbmFsQ3Vyc29yIEV2 ZW50SGFuZGxlcjo6c2VsZWN0Q3Vyc29yKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgYm9v bCBzaGlmCiAgICAgICAgIGNhbmNlbEF1dG9IaWRlQ3Vyc29yVGltZXIoKTsKICNlbmRpZgogCi0g ICAgLy8gRHVyaW5nIHNlbGVjdGlvbiwgdXNlIGFuIEktYmVhbSBubyBtYXR0ZXIgd2hhdCB3ZSdy ZSBvdmVyLgotICAgIC8vIElmIGEgZHJhZyBtYXkgYmUgc3RhcnRpbmcgb3Igd2UncmUgY2FwdHVy aW5nIG1vdXNlIGV2ZW50cyBmb3IgYSBwYXJ0aWN1bGFyIG5vZGUsIGRvbid0IHRyZWF0IHRoaXMg YXMgYSBzZWxlY3Rpb24uCi0gICAgaWYgKG1fbW91c2VQcmVzc2VkICYmIG1fbW91c2VEb3duTWF5 U3RhcnRTZWxlY3QKLSNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQotICAgICAgICAmJiAhbV9tb3Vz ZURvd25NYXlTdGFydERyYWcKLSNlbmRpZgotICAgICAgICAmJiBtX2ZyYW1lLnNlbGVjdGlvbigp LmlzQ2FyZXRPclJhbmdlKCkgJiYgIW1fY2FwdHVyaW5nTW91c2VFdmVudHNOb2RlKQotICAgICAg ICByZXR1cm4gaUJlYW07Ci0KICAgICBpZiAocmVuZGVyZXIpIHsKICAgICAgICAgQ3Vyc29yIG92 ZXJyaWRlQ3Vyc29yOwogICAgICAgICBzd2l0Y2ggKHJlbmRlcmVyLT5nZXRDdXJzb3Iocm91bmRl ZEludFBvaW50KHJlc3VsdC5sb2NhbFBvaW50KCkpLCBvdmVycmlkZUN1cnNvcikpIHsKQEAgLTEz NzYsNiArMTM2NywxOCBAQCBPcHRpb25hbEN1cnNvciBFdmVudEhhbmRsZXI6OnNlbGVjdEN1cnNv cihjb25zdCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGJvb2wgc2hpZgogICAgICAgICAgICAgICAg ICAgICBpblJlc2l6ZXIgPSBsYXllci0+aXNQb2ludEluUmVzaXplQ29udHJvbCh2aWV3LT53aW5k b3dUb0NvbnRlbnRzKHJvdW5kZWRJbnRQb2ludChyZXN1bHQubG9jYWxQb2ludCgpKSkpOwogICAg ICAgICAgICAgfQogICAgICAgICB9CisKKyAgICAgICAgLy8gRHVyaW5nIHNlbGVjdGlvbiwgdXNl IGFuIEktYmVhbSByZWdhcmRsZXNzIG9mIHRoZSBjb250ZW50IGJlbmVhdGggdGhlIGN1cnNvciB3 aGVuIGN1cnNvciBzdHlsZSBpcyBub3QgZXhwbGljaXRseSBzcGVjaWZpZWQuCisgICAgICAgIC8v IElmIGEgZHJhZyBtYXkgYmUgc3RhcnRpbmcgb3Igd2UncmUgY2FwdHVyaW5nIG1vdXNlIGV2ZW50 cyBmb3IgYSBwYXJ0aWN1bGFyIG5vZGUsIGRvbid0IHRyZWF0IHRoaXMgYXMgYSBzZWxlY3Rpb24u CisgICAgICAgIGlmIChtX21vdXNlUHJlc3NlZCAmJiBtX21vdXNlRG93bk1heVN0YXJ0U2VsZWN0 CisjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKKyAgICAgICAgICAgICYmICFtX21vdXNlRG93bk1h eVN0YXJ0RHJhZworI2VuZGlmCisgICAgICAgICAgICAmJiBtX2ZyYW1lLnNlbGVjdGlvbigpLmlz Q2FyZXRPclJhbmdlKCkKKyAgICAgICAgICAgICYmICFtX2NhcHR1cmluZ01vdXNlRXZlbnRzTm9k ZSkgeworICAgICAgICAgICAgcmV0dXJuIGlCZWFtOworICAgICAgICB9CisKICAgICAgICAgaWYg KChlZGl0YWJsZSB8fCAocmVuZGVyZXIgJiYgcmVuZGVyZXItPmlzVGV4dCgpICYmIG5vZGUtPmNh blN0YXJ0U2VsZWN0aW9uKCkpKSAmJiAhaW5SZXNpemVyICYmICFyZXN1bHQuc2Nyb2xsYmFyKCkp CiAgICAgICAgICAgICByZXR1cm4gaUJlYW07CiAgICAgICAgIHJldHVybiBwb2ludGVyQ3Vyc29y KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggZDQwYTcyYjE4NzA0OTQzMTdiNmRkOTlmNTViMWRjODE1YTYwODk2ZC4uNWNi YzE2NTQyNWJkZThlZDZmNDdjNzQ4ZjE4ZjIzZmI4N2VkODhjOCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA5LTI0ICBWYW5pIEhlZ2RlICA8dmFuaS5oZWdkZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICB1c2VyLXNlbGVjdDogbm9uZSBjdXJzb3IgdHVybnMgdG8gSS1iZWFtIG9uIG1vdXNl IGRyYWdnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MDE1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3QgY2FzZSBhZGRlZCB0byB2ZXJpZnkgdGhhdCBleHBsaWNpdGx5IHNldCBjdXJzb3Igc3R5 bGUKKyAgICAgICAgaXMgcmV0YWluZWQgb24gcGVyZm9ybWluZyB0ZXh0IHNlbGVjdGlvbi4KKwor ICAgICAgICAqIGVkaXRpbmcvY2FyZXQvc2VsZWN0aW9uLXdpdGgtY2FyZXQtdHlwZS1wcm9ncmVz cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvY2FyZXQvc2VsZWN0aW9u LXdpdGgtY2FyZXQtdHlwZS1wcm9ncmVzcy5odG1sOiBBZGRlZC4KKwogMjAxMy0wOS0yNCAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIG9wX2dldF9j YWxsZWUgc2hvdWxkbid0IHVzZSB2YWx1ZSBwcm9maWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2VkaXRpbmcvY2FyZXQvc2VsZWN0aW9uLXdpdGgtY2FyZXQtdHlwZS1wcm9ncmVzcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNhcmV0 LXR5cGUtcHJvZ3Jlc3MtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYxZmQ3NDBjNzZlYjNmYjc0 MDUyNTEzYjJiNmU2ZTJmZTNhMjAwMzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9l ZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNhcmV0LXR5cGUtcHJvZ3Jlc3MtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3RzIHdoZXRoZXIgZXhwbGljaXRseSBzZXQgY2FyZXQg c3R5bGUgaXMgcmV0YWluZWQgb24gcGVyZm9ybWluZyB0ZXh0IHNlbGVjdGlvbgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworVHJ5IHNlbGVjdGluZyB0aGlzIHRleHQgYnkgZHJhZ2dp bmcgdGhlIG1vdXNlLgorUEFTUyBjdXJyZW50Q3Vyc29yVHlwZSBpcyAiUHJvZ3Jlc3MiCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9jYXJldC9zZWxlY3Rpb24td2l0aC1jYXJldC10eXBlLXBy b2dyZXNzLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2NhcmV0L3NlbGVjdGlvbi13aXRoLWNh cmV0LXR5cGUtcHJvZ3Jlc3MuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNmMwMzMzMzk3ZjhkZDM5YmNlMDE3 MzdlM2M5ZDYwODU2YTM2OWQwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9jYXJldC9zZWxlY3Rpb24td2l0aC1jYXJldC10eXBlLXByb2dyZXNzLmh0bWwKQEAgLTAsMCAr MSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IHN0eWxlPSJjdXJzb3I6cHJvZ3Jlc3M7IGJvcmRlcjogMnB4IHNvbGlk IHJlZDsiIGlkPSJ0ZXN0Ij5Ucnkgc2VsZWN0aW5nIHRoaXMgdGV4dCBieSBkcmFnZ2luZyB0aGUg bW91c2UuPC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi8u Li9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Rlc2NyaXB0 aW9uKCdUZXN0cyB3aGV0aGVyIGV4cGxpY2l0bHkgc2V0IGNhcmV0IHN0eWxlIGlzIHJldGFpbmVk IG9uIHBlcmZvcm1pbmcgdGV4dCBzZWxlY3Rpb24nKTsKK2lmICh3aW5kb3cuZXZlbnRTZW5kZXIg JiYgd2luZG93LmludGVybmFscykgeworICAgIHZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGVzdCIpOworICAgIGRpdi5mb2N1cygpOworCisgICAgdmFyIHkgPSBkaXYub2Zmc2V0 VG9wICsgZGl2Lm9mZnNldEhlaWdodCAvIDI7CisKKyAgICBmdW5jdGlvbiBsZWFwRm9yd2FyZEFu ZE1vdmUoeCkgeworICAgICAgICBldmVudFNlbmRlci5sZWFwRm9yd2FyZCgyMDApOworICAgICAg ICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhkaXYub2Zmc2V0TGVmdCArIHgsIHkpOworICAgIH0K KworICAgIGV2ZW50U2VuZGVyLmRyYWdNb2RlID0gZmFsc2U7CisgICAgbGVhcEZvcndhcmRBbmRN b3ZlKGRpdi5vZmZzZXRMZWZ0ICsgNSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisK KyAgICBsZWFwRm9yd2FyZEFuZE1vdmUoZGl2Lm9mZnNldExlZnQgKyAxMCk7CisgICAgbGVhcEZv cndhcmRBbmRNb3ZlKGRpdi5vZmZzZXRMZWZ0ICsgMjApOworICAgIGxlYXBGb3J3YXJkQW5kTW92 ZShkaXYub2Zmc2V0V2lkdGggLSAxMCk7CisKKyAgICB2YXIgY3Vyc29ySW5mbyA9IHdpbmRvdy5p bnRlcm5hbHMuZ2V0Q3VycmVudEN1cnNvckluZm8oZG9jdW1lbnQpOworICAgIHZhciBjdXJyZW50 Q3Vyc29yVHlwZSA9IGN1cnNvckluZm8uc3Vic3RyaW5nKGN1cnNvckluZm8uaW5kZXhPZignPScp ICsgMSwgY3Vyc29ySW5mby5sYXN0SW5kZXhPZignICcpKTsKKyAgICBzaG91bGRCZUVxdWFsVG9T dHJpbmcoJ2N1cnJlbnRDdXJzb3JUeXBlJywgJ1Byb2dyZXNzJyk7Cit9IGVsc2UgeworICAgIGRl YnVnKCdUbyB0ZXN0IG1hbnVhbGx5LCBzZWxlY3QgdGhlIHRleHQgd2l0aGluIHRoZSByZWQgYm9y ZGVyZWQgZGl2IGFib3ZlIGJ5IGRyYWdnaW5nIHRoZSBtb3VzZS4gUHJvZ3Jlc3MgY3Vyc29yIHNo b3VsZCBiZSBkaXNwbGF5ZWQgd2hpbGUgZG9pbmcgc28uJyk7Cit9Cis8L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K