9013 2006-05-20 05:16:20 -0700 Let correct CSS custom cursor declarations parse 2006-07-18 13:02:17 -0700 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 6001 1 ap ap rwlbuis oldest_to_newest 42990 0 ap 2006-05-20 05:16:20 -0700 Currently, WebKit would reject any compliant CSS custom cursor declaration, because it checks that there is only one value, while CSS mandates that a list of custom cursors should be followed with a named one. Even for a single value, the hot point position (as defined in CSS3) would break parsing. The attached patch lets compliant declarations parse, but doesn't implement fallback (that's bug 6001). WinIE doesn't require that a named cursor should always follow custom ones, so I don't check that there is more than one value. 42991 1 8433 ap 2006-05-20 05:17:17 -0700 Created attachment 8433 proposed fix 43033 2 8433 ap 2006-05-21 03:11:57 -0700 Comment on attachment 8433 proposed fix Rob is working on a real implementation that will make this hack unneeded. 49611 3 ap 2006-07-12 22:28:37 -0700 The patch in bug 6002 isn't finished yet, and I think it would be wrong to introduce custom cursor support that only works with invalid declarations, so I'm reopening this bug (proposing to land this now). 50226 4 8433 darin 2006-07-17 19:39:59 -0700 Comment on attachment 8433 proposed fix Looks OK, although it's missing a change log entry. 50227 5 8433 darin 2006-07-17 19:41:12 -0700 Comment on attachment 8433 proposed fix Ideally we'd check that the remaining items are URIs then legal cursor names. This will allow many incorrect cursor declarations to parse too. 50243 6 rwlbuis 2006-07-18 00:09:22 -0700 Hi Alexey, (In reply to comment #3) > The patch in bug 6002 isn't finished yet, and I think it would be wrong to > introduce custom cursor support that only works with invalid declarations, so > I'm reopening this bug (proposing to land this now). I got a bit busy and sidetracked, and since I am not too fond of implementing complex testcases (IIRC that was required for 6001/6002) I chose not to work on it. However IIRC it was not that far from finished, so if you feel it is important I can work on it and finish it soon. Nevertheless, any patches that improve webkit, even when they'll be replaced by other patches later, are fine by me :) Let me know on IRC how we can best approach the cursor work, if you have some time. Cheers, Rob. 50297 7 ap 2006-07-18 12:54:30 -0700 Committed revision 15505. (In reply to comment #5) > Ideally we'd check that the remaining items are URIs then legal cursor names. > This will allow many incorrect cursor declarations to parse too. Agreed; I just felt that simplicity of a patch was more important in this case. 8433 2006-05-20 05:17:17 -0700 2006-07-17 19:39:59 -0700 proposed fix 9013r1_patch.txt text/plain 2633 ap SW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9j c3MvY3NzcGFyc2VyLmNwcAkocmV2aXNpb24gMTQ0OTkpCisrKyBXZWJDb3JlL2Nzcy9jc3NwYXJz ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTksNyArNjU5LDcgQEAgYm9vbCBDU1NQYXJzZXI6 OnBhcnNlVmFsdWUoaW50IHByb3BJZCwgYgogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgQ1NT X1BST1BfQ1VSU09SOgotICAgICAgICAvLyAgWyBhdXRvIHwgY3Jvc3NoYWlyIHwgZGVmYXVsdCB8 IHBvaW50ZXIgfCBwcm9ncmVzcyB8IG1vdmUgfCBlLXJlc2l6ZSB8IG5lLXJlc2l6ZSB8CisgICAg ICAgIC8vIFs8dXJpPixdKiBbIGF1dG8gfCBjcm9zc2hhaXIgfCBkZWZhdWx0IHwgcG9pbnRlciB8 IHByb2dyZXNzIHwgbW92ZSB8IGUtcmVzaXplIHwgbmUtcmVzaXplIHwKICAgICAgICAgLy8gbnct cmVzaXplIHwgbi1yZXNpemUgfCBzZS1yZXNpemUgfCBzdy1yZXNpemUgfCBzLXJlc2l6ZSB8IHct cmVzaXplIHwgdGV4dCB8CiAgICAgICAgIC8vIHdhaXQgfCBoZWxwIF0gXSB8IGluaGVyaXQKICAg ICAgICAgaWYgKCFzdHJpY3QgJiYgaWQgPT0gQ1NTX1ZBTF9IQU5EKSB7IC8vIE1TSUUgNSBjb21w YXRpYmlsaXR5IDovCkBAIC02NzEsNyArNjcxLDEwIEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZh bHVlKGludCBwcm9wSWQsIGIKICAgICAgICAgICAgIFN0cmluZyB1cmkgPSBwYXJzZVVSTChkb21T dHJpbmcodmFsdWUtPnN0cmluZykpOwogICAgICAgICAgICAgaWYgKCF1cmkuaXNFbXB0eSgpKSB7 CiAgICAgICAgICAgICAgICAgcGFyc2VkVmFsdWUgPSBuZXcgQ1NTSW1hZ2VWYWx1ZShTdHJpbmco S1VSTChzdHlsZUVsZW1lbnQtPmJhc2VVUkwoKS5kZXByZWNhdGVkU3RyaW5nKCksIHVyaS5kZXBy ZWNhdGVkU3RyaW5nKCkpLnVybCgpKSwgc3R5bGVFbGVtZW50KTsKLSAgICAgICAgICAgICAgICB2 YWx1ZUxpc3QtPm5leHQoKTsKKyAgICAgICAgICAgICAgICAvLyBGSVhNRTogd2UgZG9uJ3Qgc3Vw cG9ydCBmYWxsYmFjayBjdXJzb3JzIHlldCwgYnV0IGlnbm9yaW5nIHRoZSByZW1haW5pbmcgdmFs dWVzCisgICAgICAgICAgICAgICAgLy8gd2lsbCBhdCBsZWFzdCBsZXQgY29tcGxpYW50IGRlY2xh cmF0aW9ucyBwYXJzZS4KKyAgICAgICAgICAgICAgICBhZGRQcm9wZXJ0eShwcm9wSWQsIHBhcnNl ZFZhbHVlLCBpbXBvcnRhbnQpOworICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAg ICAgICAgfQogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwpJbmRleDogV2ViQ29yZS9tYW51YWwt dGVzdHMvY3VzdG9tLWN1cnNvcnMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10 ZXN0cy9jdXN0b20tY3Vyc29ycy5odG1sCShyZXZpc2lvbiAxNDUwMSkKKysrIFdlYkNvcmUvbWFu dWFsLXRlc3RzL2N1c3RvbS1jdXJzb3JzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMsMyArMyw4 IEBAIE1vdmUgdGhlIGN1cnNvciBvdmVyIHRoZSBibHVlIGJveCAtIGl0IHMKIAogPGRpdiBzdHls ZT0id2lkdGg6MTAwcHg7aGVpZ2h0OjUwcHg7YmFja2dyb3VuZC1jb2xvcjpsaWdodGJsdWU7IGN1 cnNvcjp1cmwobm9uZXhpc3RlbnQucG5nKSwgYXV0bzsiPjxzcGFuIHN0eWxlPSJjdXJzb3I6dXJs KG5vbmV4aXN0ZW50LnBuZyksIGF1dG87Ij5zb21lIHRleHQ8L3NwYW4+PC9kaXY+CiA8ZGl2IHN0 eWxlPSJ3aWR0aDoxMDBweDtoZWlnaHQ6NTBweDtiYWNrZ3JvdW5kLWNvbG9yOmxpZ2h0Ymx1ZTsg Y3Vyc29yOnVybChub25leGlzdGVudC5wbmcpOyI+PC9kaXY+CisKKzxocj4KKzxhIGhyZWY9Imh0 dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk5MSI+QnVnIDYw MDE8L2E+OiBXZWJLaXQgZG9lcyBub3QgaGFuZGxlIGZhbGxiYWNrIGN1c3RvbSBjdXJzb3JzPHA+ CitNb3ZlIHRoZSBjdXJzb3Igb3ZlciB0aGUgYmx1ZSBib3ggLSBpdCBzaG91bGQgYmVjb21lIGEg aGVscCBjdXJzb3IgKHF1ZXN0aW9uIG1hcmspLgorPGRpdiBzdHlsZT0id2lkdGg6MTAwcHg7aGVp Z2h0OjEwMHB4O2JhY2tncm91bmQtY29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJsKHJlc291cmNl cy9oZWxwQ3Vyc29yLnRpZmYpLCBoZWxwOyI+PC9kaXY+CkluZGV4OiBXZWJDb3JlL21hbnVhbC10 ZXN0cy9yZXNvdXJjZXMvaGVscEN1cnNvci50aWZmCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6 IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5cGUgPSBhcHBsaWNhdGlv bi9vY3RldC1zdHJlYW0KClByb3BlcnR5IGNoYW5nZXMgb246IHJlc291cmNlcy9oZWxwQ3Vyc29y LnRpZmYKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgYXBwbGljYXRpb24vb2N0 ZXQtc3RyZWFtCgo=