90112 2012-06-27 16:48:19 -0700 nrwt: default timeout for debug bots broke in r121363 2012-06-28 12:55:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89706 1 dpranke dpranke abarth eric hclam ojan ossy simon.fraser tony oldest_to_newest 658966 0 dpranke 2012-06-27 16:48:19 -0700 nrwt: default timeout for debug bots broke in r121363 658969 1 149820 dpranke 2012-06-27 16:49:09 -0700 Created attachment 149820 Patch 658971 2 dpranke 2012-06-27 16:50:22 -0700 Committed r121384: <http://trac.webkit.org/changeset/121384> 659182 3 ossy 2012-06-27 22:01:50 -0700 It broke the GTK and Qt debug bots and made 0% test coverage ... Traceback (most recent call last): File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 456, in <module> sys.exit(main()) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 451, in main return run(port, options, args) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 82, in run warnings = _set_up_derived_options(port, options) File "/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 149, in _set_up_derived_options options.slow_time_out_ms = str(5 * int(options.time_out_ms)) ValueError: invalid literal for int() with base 10: '35000.0' 659196 4 ossy 2012-06-27 22:26:52 -0700 The following changes were rolled out to unbreak debug bots: http://trac.webkit.org/changeset/121363 http://trac.webkit.org/changeset/121367 - typo fix after r121363 http://trac.webkit.org/changeset/121384 - fix after r121363 http://trac.webkit.org/changeset/121390 - typo fix after r121390 Rollout landed in http://trac.webkit.org/changeset/121406 659214 5 simon.fraser 2012-06-27 22:37:42 -0700 Broke Mac on Mountain Lion also. 659719 6 dpranke 2012-06-28 12:55:50 -0700 closing, since the bug only manifested after r121363 and that was rolled out as well. I'll land the proper fix in bug 89706. 149820 2012-06-27 16:49:09 -0700 2012-06-27 16:49:09 -0700 Patch bug-90112-20120627164909.patch text/plain 5021 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWUzMTc0NmVkYzU5MzZmNjA1MTFkNWJiZTg3NzBiM2Ji ZThjZjNjNi4uMTY4ZTViZTQ2MTg3ZjMxZjUwMTY4MWVkYmVkNDUyZjcwYzQ2ODEwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDEyLTA2LTI3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IGRlZmF1bHQgdGltZW91dCBmb3IgZGVidWcgYm90cyBicm9rZSBpbiByMTIx MzYzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDEx MgorCisgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeC4KKworICAgICAgICBJIGZvcmdvdCB0 byBhY2NvdW50IGZvciByZWxlYXNlIGFuZCBkZWJ1ZyBoYXZpbmcgZGlmZmVyZW50CisgICAgICAg IGRlZmF1bHQgdmFsdWVzIDooLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKyAgICAgICAgKENocm9taXVtUG9ydC5kZWZhdWx0X3Rl c3RfdGltZW91dF9tcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC93ZWJraXQucHk6CisgICAgICAgIChXZWJLaXRQb3J0KToKKyAgICAgICAgKFdlYktpdFBv cnQuZGVmYXVsdF90ZXN0X3RpbWVvdXRfbXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0UG9y dFVuaXRUZXN0cy50ZXN0X2RlZmF1bHRfb3B0aW9ucyk6CisKKzIwMTItMDYtMjcgIERpcmsgUHJh bmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgd2Via2l0cHk6IGZpeCBhIGNv dXBsZSBvZiBpc3N1ZXMgcnVubmluZyB1bmRlciBjeWd3aW4KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMDM1CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IGU1NTdmMTUw YWJiOWZmMzA1ZDUwODFiOThjOTY0NTIzMWE4YzdhNmQuLmEzMWE3ZDc2NTRjNGEwZDM3NDUxZDli OTIyYjkxNTVkM2RlNzRiNGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtNTIsNyArNTIsNiBAQCBfbG9nID0gbG9n Z2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiBjbGFzcyBDaHJvbWl1bVBvcnQoV2ViS2l0UG9ydCk6 CiAgICAgIiIiQWJzdHJhY3QgYmFzZSBjbGFzcyBmb3IgQ2hyb21pdW0gaW1wbGVtZW50YXRpb25z IG9mIHRoZSBQb3J0IGNsYXNzLiIiIgogICAgIHBpeGVsX3Rlc3RzX29wdGlvbl9kZWZhdWx0ID0g VHJ1ZQotICAgIHRpbWVfb3V0X21zX29wdGlvbl9kZWZhdWx0ID0gNiAqIDEwMDAKIAogICAgIEFM TF9TWVNURU1TID0gKAogICAgICAgICAoJ2xlb3BhcmQnLCAneDg2JyksCkBAIC0xMTMsNiArMTEy LDkgQEAgY2xhc3MgQ2hyb21pdW1Qb3J0KFdlYktpdFBvcnQpOgogICAgICAgICAjIEFsbCBzdWIt Y2xhc3NlcyBvdmVycmlkZSB0aGlzLCBidXQgd2UgbmVlZCBhbiBpbml0aWFsIHZhbHVlIGZvciB0 ZXN0aW5nLgogICAgICAgICBzZWxmLl9jaHJvbWl1bV9iYXNlX2Rpcl9wYXRoID0gTm9uZQogCisg ICAgZGVmIGRlZmF1bHRfdGVzdF90aW1lb3V0X21zKHNlbGYpOgorICAgICAgICByZXR1cm4gNiAq IDEwMDAKKwogICAgIGRlZiBfY2hlY2tfZmlsZV9leGlzdHMoc2VsZiwgcGF0aF90b19maWxlLCBm aWxlX2Rlc2NyaXB0aW9uLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgb3ZlcnJpZGVfc3Rl cD1Ob25lLCBsb2dnaW5nPVRydWUpOgogICAgICAgICAiIiJWZXJpZnkgdGhlIGZpbGUgaXMgcHJl c2VudCB3aGVyZSBleHBlY3RlZCBvciBsb2cgYW4gZXJyb3IuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IGIzOTY4Mjc0ZmEx YTQxZmJkOWRhMzQ2NmIwZGQ2YmJjYzJlYzdlYzguLjdhYmJmNGFmM2UzMzc1YzdiMzg2ZjQzM2Zh Y2UyMTViNmQwMmQ5YzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC01MiwxNiArNTIsMjAgQEAgX2xvZyA9IGxvZ2dpbmcu Z2V0TG9nZ2VyKF9fbmFtZV9fKQogCiBjbGFzcyBXZWJLaXRQb3J0KFBvcnQpOgogICAgIHBpeGVs X3Rlc3RzX29wdGlvbl9kZWZhdWx0ID0gRmFsc2UgICMgRklYTUU6IERpc2FibGUgdW50aWwgdGhl eSBhcmUgcnVuIGJ5IGRlZmF1bHQgb24gYnVpbGQud2Via2l0Lm9yZy4KLSAgICB0aW1lX291dF9t c19vcHRpb25fZGVmYXVsdCA9IDM1ICogMTAwMAogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGhv c3QsIHBvcnRfbmFtZT1Ob25lLCAqKmt3YXJncyk6CiAgICAgICAgIFBvcnQuX19pbml0X18oc2Vs ZiwgaG9zdCwgcG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCiAgICAgICAgIHNlbGYuc2V0 X29wdGlvbl9kZWZhdWx0KCJwaXhlbF90ZXN0cyIsIHNlbGYucGl4ZWxfdGVzdHNfb3B0aW9uX2Rl ZmF1bHQpCiAKLSAgICAgICAgIyBGSVhNRTogLS1ndWFyZC1tYWxsb2MgaXMgb25seSBzdXBwb3J0 ZWQgb24gTWFjLCBzbyB0aGlzIGxvZ2ljIHNob3VsZCBiZSBpbiBtYWMucHkuCisgICAgZGVmIGRl ZmF1bHRfdGVzdF90aW1lb3V0X21zKHNlbGYpOgogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24o J2d1YXJkX21hbGxvYycpOgotICAgICAgICAgICAgc2VsZi50aW1lX291dF9tc19vcHRpb25fZGVm YXVsdCA9IDM1MCAqIDEwMDAKLSAgICAgICAgc2VsZi5zZXRfb3B0aW9uX2RlZmF1bHQoInRpbWVf b3V0X21zIiwgc2VsZi50aW1lX291dF9tc19vcHRpb25fZGVmYXVsdCkKKyAgICAgICAgICAgICMg RklYTUU6IC0tZ3VhcmQtbWFsbG9jIGlzIG9ubHkgc3VwcG9ydGVkIG9uIE1hYywgc28gdGhpcyBs b2dpYyBzaG91bGQgYmUgaW4gbWFjLnB5LgorICAgICAgICAgICAgcmV0dXJuIDM1MCAqIDEwMDAK KyAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uLmNvbmZpZ3VyYXRpb24gPT0gJ0RlYnVnJzoKKyAg ICAgICAgICAgICMgRklYTUU6IHRoZSBnZW5lcmljIGNvZGUgaW4gcnVuX3dlYmtpdF90ZXN0cy5w eSBtdWx0aXBsaWVzIHRoaXMgYnkgMiA6KC4KKyAgICAgICAgICAgICMgV2Ugd2FudCB0byB1c2Ug dGhlIHNhbWUgdGltZW91dCBmb3IgYm90aCByZWxlYXNlIGFuZCBkZWJ1Zy4KKyAgICAgICAgICAg IHJldHVybiAxNy41ICogMTAwMAorICAgICAgICByZXR1cm4gMzUgKiAxMDAwCiAKICAgICBkZWYg ZHJpdmVyX25hbWUoc2VsZik6CiAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0X3Rl c3RfcnVubmVyJyk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5CmluZGV4IGVhMzZmYjQ3ZmRhM2VlNmNh YzM0Y2Y5NDY2ZWZmZmZjYmUxZWI4OTUuLjVlOGQwYWM0ZWNhZTQ0ZDVkMGQwNDllNTU0YWJiMzFh MzA2ZjYxMWMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5CkBAIC02NiwxNiArNjYsMTQgQEAgY2xh c3MgVGVzdFdlYktpdFBvcnQoV2ViS2l0UG9ydCk6CiBjbGFzcyBXZWJLaXRQb3J0VW5pdFRlc3Rz KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgdGVzdF9kZWZhdWx0X29wdGlvbnMoc2VsZik6 CiAgICAgICAgICMgVGhlIFdlYktpdCBwb3J0cyBvdmVycmlkZSBuZXctcnVuLXdlYmtpdC10ZXN0 IGRlZmF1bHQgb3B0aW9ucy4KLSAgICAgICAgb3B0aW9ucyA9IE1vY2tPcHRpb25zKHBpeGVsX3Rl c3RzPU5vbmUsIHRpbWVfb3V0X21zPU5vbmUpCisgICAgICAgIG9wdGlvbnMgPSBNb2NrT3B0aW9u cyhwaXhlbF90ZXN0cz1Ob25lKQogICAgICAgICBwb3J0ID0gV2ViS2l0UG9ydChNb2NrU3lzdGVt SG9zdCgpLCBvcHRpb25zPW9wdGlvbnMpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQu X29wdGlvbnMucGl4ZWxfdGVzdHMsIEZhbHNlKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhw b3J0Ll9vcHRpb25zLnRpbWVfb3V0X21zLCAzNTAwMCkKIAogICAgICAgICAjIE5vdGUgdGhhdCB3 ZSBkb24ndCBvdmVycmlkZSBvcHRpb25zIGlmIHNwZWNpZmllZCBieSB0aGUgdXNlci4KLSAgICAg ICAgb3B0aW9ucyA9IE1vY2tPcHRpb25zKHBpeGVsX3Rlc3RzPVRydWUsIHRpbWVfb3V0X21zPTYw MDApCisgICAgICAgIG9wdGlvbnMgPSBNb2NrT3B0aW9ucyhwaXhlbF90ZXN0cz1UcnVlKQogICAg ICAgICBwb3J0ID0gV2ViS2l0UG9ydChNb2NrU3lzdGVtSG9zdCgpLCBvcHRpb25zPW9wdGlvbnMp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX29wdGlvbnMucGl4ZWxfdGVzdHMsIFRy dWUpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX29wdGlvbnMudGltZV9vdXRfbXMs IDYwMDApCiAKIAogY2xhc3MgV2ViS2l0UG9ydFRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENh c2UpOgo=