90099 2012-06-27 14:35:09 -0700 x86 disassembler confuses immediates with addresses 2012-06-27 14:45:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo webkit.review.bot oldest_to_newest 658881 0 fpizlo 2012-06-27 14:35:09 -0700 Consider the two following x86 instructions, written out verbosely: 1) load from address 0x12345 into register RAX 2) move immediate 0x12345 into register RAX In AT&T syntax, the two should be written thus: 1) mov 0x12345, %rax 2) mov $0x12345, %rax But our x86 disassembler (udis86) incorrectly writes both as "mov 0x12345, %rax". In short, it omits the "$" prefix for immediates. 658882 1 149797 fpizlo 2012-06-27 14:37:32 -0700 Created attachment 149797 the patch 658887 2 webkit.review.bot 2012-06-27 14:41:02 -0700 Attachment 149797 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space after ( in function call [whitespace/parens] [4] Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space before ) [whitespace/parens] [2] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 658892 3 149797 mhahnenberg 2012-06-27 14:44:08 -0700 Comment on attachment 149797 the patch r=me 658894 4 fpizlo 2012-06-27 14:45:46 -0700 Landed in http://trac.webkit.org/changeset/121374 149797 2012-06-27 14:37:32 -0700 2012-06-27 14:44:08 -0700 the patch fixattimm_patch_1.diff text/plain 1384 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMzczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA2LTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg eDg2IGRpc2Fzc2VtYmxlciBjb25mdXNlcyBpbW1lZGlhdGVzIHdpdGggYWRkcmVzc2VzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA5OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgUHJlcGVu ZCAiJCIgdG8gaW1tZWRpYXRlcyB0byBkaXNhbWJpZ3VhdGUgYmV0d2VlbiBpbW1lZGlhdGVzIGFu ZCBhZGRyZXNzZXMuIFRoaXMgaXMgaW4KKyAgICAgICAgYWNjb3JkYW5jZSB3aXRoIHRoZSBnYXMg YW5kIEFUJlQgc3ludGF4LgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZf c3luLWF0dC5jOgorICAgICAgICAoZ2VuX29wZXJhbmQpOgorCiAyMDEyLTA2LTI3ICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgY29tbWVudCBjbGFyaWZ5 aW5nIE9wdGlvbnM6OnNob3dEaXNhc3NlbWJseSB2ZXJzdXMgT3B0aW9uczo6c2hvd0RGR0Rpc2Fz c2VtYmx5LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYv dWRpczg2X3N5bi1hdHQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz YXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWF0dC5jCShyZXZpc2lvbiAxMjEyODApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWF0dC5j CSh3b3JraW5nIGNvcHkpCkBAIC0xMDksNyArMTA5LDcgQEAgZ2VuX29wZXJhbmQoc3RydWN0IHVk KiB1LCBzdHJ1Y3QgdWRfb3BlcgogICAgICAgICB9CiAgICAgICAgIGlmICggc2V4dF9zaXplIDwg NjQgKQogICAgICAgICAgICAgc2V4dF9tYXNrID0gKCAxdWxsIDw8IHNleHRfc2l6ZSApIC0gMTsK LSAgICAgICAgbWthc20oIHUsICIweCIgRk1UNjQgIngiLCBpbW0gJiBzZXh0X21hc2sgKTsgCisg ICAgICAgIG1rYXNtKCB1LCAiJDB4IiBGTVQ2NCAieCIsIGltbSAmIHNleHRfbWFzayApOyAKIAog CQlicmVhazsKICAgICB9Cg==