<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90098</bug_id>
          
          <creation_ts>2012-06-27 13:53:58 -0700</creation_ts>
          <short_desc>[GTK] LLint build fails with -g -02</short_desc>
          <delta_ts>2012-10-14 13:05:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>99270</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Alban Browaeys">prahal</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>kalevlember</cc>
    
    <cc>plaes</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>658847</commentid>
    <comment_count>0</comment_count>
      <attachid>149791</attachid>
    <who name="Alban Browaeys">prahal</who>
    <bug_when>2012-06-27 13:53:58 -0700</bug_when>
    <thetext>Created attachment 149791
fix llint build wwith -02 -g 

/usr/bin/ruby ./Source/JavaScriptCore/offlineasm/asm.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm Programs/LLIntOffsetsExtractor DerivedSources/JavaScriptCore/LLIntAssembly.h
 offsetsAndConfigurationIndex in Source/JavaScriptCore/offlineasm/offsets.rb raise an unhandled exception during build if -02 -g flags are used (ie set CFLAGS to &quot;-O0 -g&quot; and not set webkit debug configure switch which ends up with &quot;-00 -g - 02&quot; =&gt; &quot;-g -O2&quot;).
the exception is raised at:
raise if result.map{|v| v[1]}.uniq.size &lt; result.map{|v| v[1]}.size

It turns out that the way extractorTable is defined inside the LLIntOffsetsExtractor::dummy which itself is defined as a class member inside the class declaration leads to it behing defined in the assembly twice. That is the class member with -O2 is inlined (which is common for class members at least with g++). The static local variable extractorTable is thus duplicated for each translation unit. And ends up in the usual symbols  and the debug_info symbols. Ie twice. Then offsetsAndConfigurationIndex in Source/JavaScriptCore/offlineasm/offsets.rb  finds extractorTable magic numbers twice in the binary object and the result.map{|v| v[1]}.uniq.size &lt; result.map{|v| v[1]}.size becomes 1 &lt; 2 and the exception is raised.

Even if done by mistake (I intended to build -O0 -g) -g -02 is quite common for distribution that provide -dbg packages. So this issue might be major instead of normal.

Running:
$ /usr/bin/ruby ./Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h
$ g++ -DHAVE_CONFIG_H -I.  -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DENABLE_GLIB_SUPPORT=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DBUILDING_SOUP__=1 -DWTF_CHANGES -DBUILDING_WEBKIT2__=1 -DXP_UNIX -DMOZ_X11  -DWTF_USE_ICU_UNICODE=1   -DWTF_USE_GSTREAMER=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1  -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1  -DWTF_USE_GLX=1 -DWTF_USE_OPENGL=1  -DNDEBUG    -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF   -O0 -g -Wno-c++0x-compat -O2 -MT Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o -MD -MP -MF Source/JavaScriptCore/llint/.deps/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.Tpo -c -o Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o `test -f &apos;Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp&apos; || echo &apos;./&apos;`Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp
$ /usr/bin/ruby ./Source/JavaScriptCore/offlineasm/asm.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm Programs/LLIntOffsetsExtractor DerivedSources/JavaScriptCore/LLIntAssembly.h
from an existing build tree of webkit should give the above error.


The attached patch fixes this.


This is tested against git mirror master 4c742312f5b69a166256a28390aedc4c0bd45ac1, ie :

commit 4c742312f5b69a166256a28390aedc4c0bd45ac1
Author: commit-queue@webkit.org &lt;commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc&gt;
Date:   Thu Jun 21 02:03:44 2012 +0000

    Unreviewed, rolling out r120889.
    http://trac.webkit.org/changeset/120889
    https://bugs.webkit.org/show_bug.cgi?id=89630
    
    [Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer
    start failing (Requested by ukai on #webkit).
    
    Patch by Sheriff Bot &lt;webkit.review.bot@gmail.com&gt; on 2012-06-20
    
    Source/WebCore:
    
    * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
    (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
    
    Source/WebKit/chromium:
    
    * tests/CCLayerTreeHostImplTest.cpp:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120899 268f45cc-cd09-0410-ab3c-d5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>662231</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-07-03 08:23:14 -0700</bug_when>
    <thetext>How does your patch handle fat binaries?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>662251</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-07-03 08:46:05 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; Created an attachment (id=149791) [details]
&gt; fix llint build wwith -02 -g 
&gt; 
&gt; /usr/bin/ruby ./Source/JavaScriptCore/offlineasm/asm.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm Programs/LLIntOffsetsExtractor DerivedSources/JavaScriptCore/LLIntAssembly.h
&gt;  offsetsAndConfigurationIndex in Source/JavaScriptCore/offlineasm/offsets.rb raise an unhandled exception during build if -02 -g flags are used (ie set CFLAGS to &quot;-O0 -g&quot; and not set webkit debug configure switch which ends up with &quot;-00 -g - 02&quot; =&gt; &quot;-g -O2&quot;).
&gt; the exception is raised at:
&gt; raise if result.map{|v| v[1]}.uniq.size &lt; result.map{|v| v[1]}.size
&gt; 
&gt; It turns out that the way extractorTable is defined inside the LLIntOffsetsExtractor::dummy which itself is defined as a class member inside the class declaration leads to it behing defined in the assembly twice.

In that case, the correct solution is to simply remove the assertion and harden the code against duplicates (i.e. if it finds a duplicate then return the first one, or the last one, or the middle one, or whichever one you like).

On the other hand, your fix will break fat binary builds, which is a show-stopper for us.  A fat binary build produces a binary with two or more different builds in it; in that case the offsets extractor needs to find all of the extractor tables.  Your patch prevents finding all extractor tables because all but the first will have a corrupted magic number.

&gt; That is the class member with -O2 is inlined (which is common for class members at least with g++). The static local variable extractorTable is thus duplicated for each translation unit. And ends up in the usual symbols  and the debug_info symbols. Ie twice. Then offsetsAndConfigurationIndex in Source/JavaScriptCore/offlineasm/offsets.rb  finds extractorTable magic numbers twice in the binary object and the result.map{|v| v[1]}.uniq.size &lt; result.map{|v| v[1]}.size becomes 1 &lt; 2 and the exception is raised.
&gt; 
&gt; Even if done by mistake (I intended to build -O0 -g) -g -02 is quite common for distribution that provide -dbg packages. So this issue might be major instead of normal.
&gt; 
&gt; Running:
&gt; $ /usr/bin/ruby ./Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h
&gt; $ g++ -DHAVE_CONFIG_H -I.  -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DENABLE_GLIB_SUPPORT=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DBUILDING_SOUP__=1 -DWTF_CHANGES -DBUILDING_WEBKIT2__=1 -DXP_UNIX -DMOZ_X11  -DWTF_USE_ICU_UNICODE=1   -DWTF_USE_GSTREAMER=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1  -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1  -DWTF_USE_GLX=1 -DWTF_USE_OPENGL=1  -DNDEBUG    -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF   -O0 -g -Wno-c++0x-compat -O2 -MT Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o -MD -MP -MF Source/JavaScriptCore/llint/.deps/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.Tpo -c -o Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o `test -f &apos;Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp&apos; || echo &apos;./&apos;`Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp
&gt; $ /usr/bin/ruby ./Source/JavaScriptCore/offlineasm/asm.rb ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm Programs/LLIntOffsetsExtractor DerivedSources/JavaScriptCore/LLIntAssembly.h
&gt; from an existing build tree of webkit should give the above error.
&gt; 
&gt; 
&gt; The attached patch fixes this.
&gt; 
&gt; 
&gt; This is tested against git mirror master 4c742312f5b69a166256a28390aedc4c0bd45ac1, ie :
&gt; 
&gt; commit 4c742312f5b69a166256a28390aedc4c0bd45ac1
&gt; Author: commit-queue@webkit.org &lt;commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc&gt;
&gt; Date:   Thu Jun 21 02:03:44 2012 +0000
&gt; 
&gt;     Unreviewed, rolling out r120889.
&gt;     http://trac.webkit.org/changeset/120889
&gt;     https://bugs.webkit.org/show_bug.cgi?id=89630
&gt; 
&gt;     [Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer
&gt;     start failing (Requested by ukai on #webkit).
&gt; 
&gt;     Patch by Sheriff Bot &lt;webkit.review.bot@gmail.com&gt; on 2012-06-20
&gt; 
&gt;     Source/WebCore:
&gt; 
&gt;     * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
&gt;     (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
&gt; 
&gt;     Source/WebKit/chromium:
&gt; 
&gt;     * tests/CCLayerTreeHostImplTest.cpp:
&gt; 
&gt;     git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120899 268f45cc-cd09-0410-ab3c-d5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>663320</commentid>
    <comment_count>3</comment_count>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-07-04 22:47:14 -0700</bug_when>
    <thetext>Can&apos;t we add some extra checks, to see what target (regular elf vs fat binary) we are trying to build?

Also, some distros, like Gentoo allow splitting off the debugging info into separate files:
/usr/lib64/libwebkitgtk-3.0.so.0.13.2
/usr/lib64/debug/usr/lib64/libwebkitgtk-3.0.so.0.13.2.debug

[snip]
With splitdebug enabled, Portage will still strip the binaries installed in the system. But before doing that, all the useful debug information is copied to a &quot;.debug&quot; file, which is then installed inside /usr/lib/debug (the complete name of the file would be given by appending to that the path where the file is actually installed). The path to that file is then saved in the original file inside an ELF section called &quot;.gnu_debuglink&quot;, so that gdb knows which file to load the symbols from.
[/snip]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665544</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-07-10 00:45:57 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Can&apos;t we add some extra checks, to see what target (regular elf vs fat binary) we are trying to build?

Why?  Can&apos;t you just remove the assertion and be done with it?

&gt; 
&gt; Also, some distros, like Gentoo allow splitting off the debugging info into separate files:
&gt; /usr/lib64/libwebkitgtk-3.0.so.0.13.2
&gt; /usr/lib64/debug/usr/lib64/libwebkitgtk-3.0.so.0.13.2.debug

Why does this matter?  The offsets extractor doesn&apos;t care about debug data.

&gt; 
&gt; [snip]
&gt; With splitdebug enabled, Portage will still strip the binaries installed in the system. But before doing that, all the useful debug information is copied to a &quot;.debug&quot; file, which is then installed inside /usr/lib/debug (the complete name of the file would be given by appending to that the path where the file is actually installed). The path to that file is then saved in the original file inside an ELF section called &quot;.gnu_debuglink&quot;, so that gdb knows which file to load the symbols from.
&gt; [/snip]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665894</commentid>
    <comment_count>5</comment_count>
      <attachid>151491</attachid>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-07-10 11:14:50 -0700</bug_when>
    <thetext>Created attachment 151491
webkit-bug-90098-gtk-llint-build-failure.patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665931</commentid>
    <comment_count>6</comment_count>
      <attachid>151491</attachid>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-07-10 11:59:06 -0700</bug_when>
    <thetext>Comment on attachment 151491
webkit-bug-90098-gtk-llint-build-failure.patch

That approach fails with errors about duplicate symbols (unfortunately missed the CFLAGS on first try):
[snip]
{standard input}: Assembler messages:
{standard input}:4432: Error: symbol `llint_begin&apos; is already defined
{standard input}:4438: Error: symbol `llint_program_prologue&apos; is already defined
{standard input}:4460: Error: symbol `llint_eval_prologue&apos; is already defined
...
[/snip]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>666731</commentid>
    <comment_count>7</comment_count>
    <who name="Alban Browaeys">prahal</who>
    <bug_when>2012-07-11 07:11:32 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; Can&apos;t we add some extra checks, to see what target (regular elf vs fat binary) we are trying to build?
&gt; 
&gt; Why?  Can&apos;t you just remove the assertion and be done with it?
&gt; 
&gt; &gt; 
&gt; &gt; Also, some distros, like Gentoo allow splitting off the debugging info into separate files:
&gt; &gt; /usr/lib64/libwebkitgtk-3.0.so.0.13.2
&gt; &gt; /usr/lib64/debug/usr/lib64/libwebkitgtk-3.0.so.0.13.2.debug
&gt; 
&gt; Why does this matter?  The offsets extractor doesn&apos;t care about debug data.

&gt; &gt; [snip]
&gt; &gt; With splitdebug enabled, Portage will still strip the binaries installed in the system. But before doing that, all the useful debug information is copied to a &quot;.debug&quot; file, which is then installed inside /usr/lib/debug (the complete name of the file would be given by appending to that the path where the file is actually installed). The path to that file is then saved in the original file inside an ELF section called &quot;.gnu_debuglink&quot;, so that gdb knows which file to load the symbols from.
&gt; &gt; [/snip]

it cares about the debug_data because the debug_info section contains a duplicate of the array including the magic numbers . This is the issue from the start. duplicate which leads to the exception being raised comes from the debug info section. 
In fact this issue is critical to distributions as they all build with -g -02 &quot;then&quot; strip the symbols into another file. Thus build will always fails except for devs.

The issue is that the offsets are the same (thus duplicates) in the debug section than in the non debug section.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>666734</commentid>
    <comment_count>8</comment_count>
      <attachid>151701</attachid>
    <who name="Alban Browaeys">prahal</who>
    <bug_when>2012-07-11 07:16:03 -0700</bug_when>
    <thetext>Created attachment 151701
Avoid duplicate offsets for llint, discarding them.

This might work (using only the first of the duplicates). I currently fails to build Programs/WebKitPluginProcess though the issue seems unrelated. So patch no even tested .</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667792</commentid>
    <comment_count>9</comment_count>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-07-12 08:20:14 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; Created an attachment (id=151701) [details]
&gt; Avoid duplicate offsets for llint, discarding them.
&gt; 
&gt; This might work (using only the first of the duplicates). I currently fails to build Programs/WebKitPluginProcess though the issue seems unrelated. So patch no even tested .

Works for me!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668310</commentid>
    <comment_count>10</comment_count>
    <who name="Alban Browaeys">prahal</who>
    <bug_when>2012-07-12 15:26:42 -0700</bug_when>
    <thetext>&gt; &gt; This might work (using only the first of the duplicates). I currently fails to build Programs/WebKitPluginProcess though the issue seems unrelated. So patch no even tested .
&gt; 
&gt; Works for me!

Me too  !
in the end (the issue about malformed archive was bug 91154 which I just reported and came from the size libWebCore.a exceed the ar format limit when built with -g -02 , that is 4.4G)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668805</commentid>
    <comment_count>11</comment_count>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-07-13 03:10:08 -0700</bug_when>
    <thetext>Could you please create a proper patch (with ChangeLog and stuff, you can use Tools/Scripts/prepare-changelog script for that) and mark it up for review/commit queue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>704702</commentid>
    <comment_count>12</comment_count>
      <attachid>160565</attachid>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-08-25 10:18:19 -0700</bug_when>
    <thetext>Created attachment 160565
webkit-bug-90098-gtk-llint-build-failure.patch

I took the patch, added ChangeLog with original author name, so there it goes...

This build issue has been popping up mostly when building with &apos;-g -O2&apos; on various Linux distros.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>705436</commentid>
    <comment_count>13</comment_count>
      <attachid>160565</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-08-27 11:30:02 -0700</bug_when>
    <thetext>Comment on attachment 160565
webkit-bug-90098-gtk-llint-build-failure.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160565&amp;action=review

&gt; Source/JavaScriptCore/offlineasm/offsets.rb:158
&gt; +                #result &lt;&lt; [offsets, index]

You should just remove this line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706143</commentid>
    <comment_count>14</comment_count>
      <attachid>160922</attachid>
    <who name="Priit Laes (IRC: plaes)">plaes</who>
    <bug_when>2012-08-28 00:34:58 -0700</bug_when>
    <thetext>Created attachment 160922
webkit-bug-90098-gtk-llint-build-failure-v2.patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706406</commentid>
    <comment_count>15</comment_count>
      <attachid>160922</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 09:01:50 -0700</bug_when>
    <thetext>Comment on attachment 160922
webkit-bug-90098-gtk-llint-build-failure-v2.patch

Clearing flags on attachment: 160922

Committed r126886: &lt;http://trac.webkit.org/changeset/126886&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706407</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 09:01:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>149791</attachid>
            <date>2012-06-27 13:53:58 -0700</date>
            <delta_ts>2012-06-27 13:53:58 -0700</delta_ts>
            <desc>fix llint build wwith -02 -g </desc>
            <filename>0001-LLint-Fix-generation-of-headers-when-g-O2.txt</filename>
            <type>text/plain</type>
            <size>5310</size>
            <attacher name="Alban Browaeys">prahal</attacher>
            
              <data encoding="base64">RnJvbSAxN2Q0YjE4NWZlODYxMDFhNzI3ZThiZmQwMTJjZTdjYjhhODVlNDY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGJhbiBCcm93YWV5cyA8cHJhaGFsQHlhaG9vLmNvbT4KRGF0
ZTogVHVlLCAxOSBKdW4gMjAxMiAxNjoyMzoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIExMaW50
OiBGaXggZ2VuZXJhdGlvbiBvZiBoZWFkZXJzIHdoZW4gLWcgLU8yCgpUaGUgY3VycmVudCBleHRy
YWN0b3JBcnJheSBpcyBzdGF0aWMgaW5zaWRlIGEgbWVtYmVyLiBXaXRoIC1PMgp0aGUgbWVtYmVy
IGlzIG9mdGVuIGlubGluZWQuIElmIG9uZSBhZGQgLWcgdGhpcyBsZWFkcyB0byBkdXBsaWNhdGlv
bgpvZiB0aGUgYXJyYXkgaW4gdGhlIGJpbmFyeSB3aGljaCBicmVha3MgdGhlIG9mZnNldHMucmIg
Y2hlY2tzIGZvcgp1bmlxdWVuZXNzLgotLS0KIC4uLi9KYXZhU2NyaXB0Q29yZS9sbGludC9MTElu
dE9mZnNldHNFeHRyYWN0b3IuY3BwIHwgICAyMiArLS0tLS0tLQogLi4uL29mZmxpbmVhc20vZ2Vu
ZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5yYiAgICAgICAgfCAgIDU0ICsrKysrKysrKysrKysrKy0t
LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDMzIGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludE9mZnNldHNFeHRy
YWN0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50T2Zmc2V0c0V4dHJh
Y3Rvci5jcHAKaW5kZXggZjg2M2NiMi4uYWU3M2ExNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT
Y3JpcHRDb3JlL2xsaW50L0xMSW50T2Zmc2V0c0V4dHJhY3Rvci5jcHAKKysrIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2xsaW50L0xMSW50T2Zmc2V0c0V4dHJhY3Rvci5jcHAKQEAgLTUzLDI5ICs1
MywxMSBAQAogbmFtZXNwYWNlIEpTQyB7CiAKICNkZWZpbmUgT0ZGTElORV9BU01fT0ZGU0VUT0Yo
Y2xhenosIGZpZWxkKSBPQkpFQ1RfT0ZGU0VUT0YoY2xhenosIGZpZWxkKQorfSAvLyBuYW1lc3Bh
Y2UgSlNDCiAKLWNsYXNzIExMSW50T2Zmc2V0c0V4dHJhY3RvciB7Ci1wdWJsaWM6Ci0gICAgc3Rh
dGljIGNvbnN0IHVuc2lnbmVkKiBkdW1teSgpOwotfTsKLQotY29uc3QgdW5zaWduZWQqIExMSW50
T2Zmc2V0c0V4dHJhY3Rvcjo6ZHVtbXkoKQotewotI2lmIEVOQUJMRShKSVQpCi0vLyBUaGlzIGlz
IGEgZmlsZSBnZW5lcmF0ZWQgYnkgb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRzX2V4dHJhY3Rv
ci5yYiwgYW5kIGNvbnRhaW5zIGNvZGUKLS8vIHRvIGNyZWF0ZSBhIHRhYmxlIG9mIG9mZnNldHMs
IHNpemVzLCBhbmQgYSBoZWFkZXIgaWRlbnRpZnlpbmcgd2hhdCBjb21iaW5hdGlvbiBvZgotLy8g
UGxhdGZvcm0uaCBtYWNyb3Mgd2UgaGF2ZSBzZXQuIFdlIGluY2x1ZGUgaXQgaW5zaWRlIG9mIGEg
bWV0aG9kIG9uIExMSW50T2Zmc2V0c0V4dHJhY3RvcgotLy8gYmVjYXVzZSB0aGUgZmllbGRzIHdo
b3NlIG9mZnNldHMgd2UncmUgZXh0cmFjdGluZyBhcmUgbW9zdGx5IHByaXZhdGUuIFNvIHdlIG1h
a2UgdGhlaXIKLS8vIGNsYXNzZXMgZnJpZW5kcyB3aXRoIExMSW50T2Zmc2V0c0V4dHJhY3Rvciwg
YW5kIGluY2x1ZGUgdGhlIGhlYWRlciBoZXJlLCB0byBnZXQgdGhlIEMrKwotLy8gY29tcGlsZXIg
dG8ga2luZGx5IHN0ZXAgYXNpZGUgYW5kIHlpZWxkIHRvIG91ciBiZXN0IGludGVudGlvbnMuCiAj
aW5jbHVkZSAiTExJbnREZXNpcmVkT2Zmc2V0cy5oIgotICAgIHJldHVybiBleHRyYWN0b3JUYWJs
ZTsKLSNlbHNlCi0gICAgcmV0dXJuIDA7Ci0jZW5kaWYKLX0KIAotfSAvLyBuYW1lc3BhY2UgSlND
CisKIAogaW50IG1haW4oaW50LCBjaGFyKiopCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5yYgpp
bmRleCBiMmE4YzJjLi5jZjIzZjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
b2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiCisrKyBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmIKQEAgLTM4
LDExICszOCwxMyBAQCBvdXRwdXRGbG5tID0gQVJHVi5zaGlmdAogCiAkc3RkZXJyLnB1dHMgIm9m
ZmxpbmVhc206IFBhcnNpbmcgI3tpbnB1dEZsbm19IGFuZCBjcmVhdGluZyBvZmZzZXQgZXh0cmFj
dG9yICN7b3V0cHV0RmxubX0uIgogCi1kZWYgZW1pdE1hZ2ljTnVtYmVyCi0gICAgT0ZGU0VUX01B
R0lDX05VTUJFUlMuZWFjaCB7CitkZWYgZW1pdE1hZ2ljTnVtYmVyKGkpCisgICAgT0ZGU0VUX01B
R0lDX05VTUJFUlMuZWFjaCBkbwogICAgICAgICB8IG51bWJlciB8CiAgICAgICAgICRvdXRwdXQu
cHV0cyAiI3tudW1iZXJ9LCIKLSAgICB9CisgICAgICAgIGkgKz0gMQorICAgICAgICBlbmQKKyAg
ICAgICAgcmV0dXJuIGkKIGVuZAogCiBpbnB1dEhhc2ggPSAiLy8gb2ZmbGluZWFzbSBpbnB1dCBo
YXNoOiAje3BhcnNlSGFzaChpbnB1dEZsbm0pfSAje3NlbGZIYXNofSIKQEAgLTExNCwzMSArMTE2
LDU3IEBAIEZpbGUub3BlbihvdXRwdXRGbG5tLCAidyIpIHsKICAgICAgICAgc2l6ZXNMaXN0ID0g
YXN0LmZpbHRlcihTaXplb2YpLnVuaXEuc29ydAogICAgICAgICBsZW5ndGggKz0gT0ZGU0VUX0hF
QURFUl9NQUdJQ19OVU1CRVJTLnNpemUgKyAoT0ZGU0VUX01BR0lDX05VTUJFUlMuc2l6ZSArIDEp
ICogKDEgKyBvZmZzZXRzTGlzdC5zaXplICsgc2l6ZXNMaXN0LnNpemUpCiAgICAgfQotICAgIG91
dHAucHV0cyAic3RhdGljIGNvbnN0IHVuc2lnbmVkIGV4dHJhY3RvclRhYmxlWyN7bGVuZ3RofV0g
PSB7IgorICAgIG91dHAucHV0cyAibmFtZXNwYWNlIEpTQyB7IgorICAgIG91dHAucHV0cyAiY2xh
c3MgTExJbnRPZmZzZXRzRXh0cmFjdG9yIHsiCisgICAgb3V0cC5wdXRzICJwdWJsaWM6IgorICAg
IG91dHAucHV0cyAiICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBleHRyYWN0b3JUYWJsZVtdOyIK
KyAgICBvdXRwLnB1dHMgIiAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQqIGR1bW15KCk7IgorICAg
IG91dHAucHV0cyAifTsiCisgICAgb3V0cC5wdXRzICJjb25zdCB1bnNpZ25lZCogTExJbnRPZmZz
ZXRzRXh0cmFjdG9yOjpkdW1teSgpeyIKKyAgICBvdXRwLnB1dHMgICIjaWYgRU5BQkxFKEpJVCki
CisgICAgb3V0cC5wdXRzICIvLyBUaGlzIGlzIGEgZmlsZSBnZW5lcmF0ZWQgYnkgb2ZmbGluZWFz
bS9nZW5lcmF0ZV9vZmZzZXRzX2V4dHJhY3Rvci5yYiwgYW5kIGNvbnRhaW5zIGNvZGUiCisgICAg
b3V0cC5wdXRzICIvLyB0byBjcmVhdGUgYSB0YWJsZSBvZiBvZmZzZXRzLCBzaXplcywgYW5kIGEg
aGVhZGVyIGlkZW50aWZ5aW5nIHdoYXQgY29tYmluYXRpb24gb2YiCisgICAgb3V0cC5wdXRzICIv
LyBQbGF0Zm9ybS5oIG1hY3JvcyB3ZSBoYXZlIHNldC4gV2UgaW5jbHVkZSBpdCBpbnNpZGUgb2Yg
YSBtZXRob2Qgb24gTExJbnRPZmZzZXRzRXh0cmFjdG9yIgorICAgIG91dHAucHV0cyAiLy8gYmVj
YXVzZSB0aGUgZmllbGRzIHdob3NlIG9mZnNldHMgd2UncmUgZXh0cmFjdGluZyBhcmUgbW9zdGx5
IHByaXZhdGUuIFNvIHdlIG1ha2UgdGhlaXIiCisgICAgb3V0cC5wdXRzICIvLyBjbGFzc2VzIGZy
aWVuZHMgd2l0aCBMTEludE9mZnNldHNFeHRyYWN0b3IsIGFuZCBpbmNsdWRlIHRoZSBoZWFkZXIg
aGVyZSwgdG8gZ2V0IHRoZSBDKysiCisgICAgb3V0cC5wdXRzICIvLyBjb21waWxlciB0byBraW5k
bHkgc3RlcCBhc2lkZSBhbmQgeWllbGQgdG8gb3VyIGJlc3QgaW50ZW50aW9ucy4iCisgICAgb3V0
cC5wdXRzICIgICAgcmV0dXJuIExMSW50T2Zmc2V0c0V4dHJhY3Rvcjo6ZXh0cmFjdG9yVGFibGU7
IgorICAgIG91dHAucHV0cyAiI2Vsc2UiCisgICAgb3V0cC5wdXRzICIgICAgcmV0dXJuIDA7Igor
ICAgIG91dHAucHV0cyAiI2VuZGlmIgorICAgIG91dHAucHV0cyAifSIKKyAgICBvdXRwLnB1dHMg
ImNvbnN0IHVuc2lnbmVkIExMSW50T2Zmc2V0c0V4dHJhY3Rvcjo6ZXh0cmFjdG9yVGFibGVbI3ts
ZW5ndGh9XSA9IHsiCisKICAgICBlbWl0Q29kZUluQWxsQ29uZmlndXJhdGlvbnMocHJ1bmVkQVNU
KSB7CiAgICAgICAgIHwgc2V0dGluZ3MsIGFzdCwgYmFja2VuZCwgaW5kZXggfAotICAgICAgICBP
RkZTRVRfSEVBREVSX01BR0lDX05VTUJFUlMuZWFjaCB7CisgICAgICAgIGkgPSAwCisgICAgICAg
IE9GRlNFVF9IRUFERVJfTUFHSUNfTlVNQkVSUy5lYWNoIGRvCiAgICAgICAgICAgICB8IG51bWJl
ciB8CiAgICAgICAgICAgICAkb3V0cHV0LnB1dHMgIiN7bnVtYmVyfSwiCi0gICAgICAgIH0KKyAg
ICAgICAgICAgIGkgKz0gMQorICAgICAgICAgICAgZW5kCiAKICAgICAgICAgb2Zmc2V0c0xpc3Qg
PSBhc3QuZmlsdGVyKFN0cnVjdE9mZnNldCkudW5pcS5zb3J0CiAgICAgICAgIHNpemVzTGlzdCA9
IGFzdC5maWx0ZXIoU2l6ZW9mKS51bmlxLnNvcnQKICAgICAgICAgCi0gICAgICAgIGVtaXRNYWdp
Y051bWJlcgorICAgICAgICBpID0gZW1pdE1hZ2ljTnVtYmVyKGkpCiAgICAgICAgIG91dHAucHV0
cyAiI3tpbmRleH0sIgotICAgICAgICBvZmZzZXRzTGlzdC5lYWNoIHsKKyAgICAgICAgaSArPSAx
CisgICAgICAgIG9mZnNldHNMaXN0LmVhY2ggZG8KICAgICAgICAgICAgIHwgb2Zmc2V0IHwKLSAg
ICAgICAgICAgIGVtaXRNYWdpY051bWJlcgorICAgICAgICAgICAgaSA9IGVtaXRNYWdpY051bWJl
cihpKQogICAgICAgICAgICAgb3V0cC5wdXRzICJPRkZMSU5FX0FTTV9PRkZTRVRPRigje29mZnNl
dC5zdHJ1Y3R9LCAje29mZnNldC5maWVsZH0pLCIKLSAgICAgICAgfQotICAgICAgICBzaXplc0xp
c3QuZWFjaCB7CisgICAgICAgICAgICBpICs9IDEKKyAgICAgICAgICAgIGVuZAorICAgICAgICBz
aXplc0xpc3QuZWFjaCBkbwogICAgICAgICAgICAgfCBvZmZzZXQgfAotICAgICAgICAgICAgZW1p
dE1hZ2ljTnVtYmVyCisgICAgICAgICAgICBpID0gZW1pdE1hZ2ljTnVtYmVyKGkpCiAgICAgICAg
ICAgICBvdXRwLnB1dHMgInNpemVvZigje29mZnNldC5zdHJ1Y3R9KSwiCi0gICAgICAgIH0KKyAg
ICAgICAgICAgIGkgKz0gMQorICAgICAgICAgICAgZW5kCiAgICAgfQogICAgIG91dHAucHV0cyAi
fTsiCisgICAgb3V0cC5wdXRzICJ9IgogfQogCiAkc3RkZXJyLnB1dHMgIm9mZmxpbmVhc206IG9m
ZnNldCBleHRyYWN0b3IgI3tvdXRwdXRGbG5tfSBzdWNjZXNzZnVsbHkgZ2VuZXJhdGVkLiIKLS0g
CjEuNy4xMAoK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151491</attachid>
            <date>2012-07-10 11:14:50 -0700</date>
            <delta_ts>2012-08-25 10:18:19 -0700</delta_ts>
            <desc>webkit-bug-90098-gtk-llint-build-failure.patch</desc>
            <filename>0001-2012-07-10-Priit-Laes-plaes-plaes.org.patch</filename>
            <type>text/plain</type>
            <size>1775</size>
            <attacher name="Priit Laes (IRC: plaes)">plaes</attacher>
            
              <data encoding="base64">RnJvbSBmNDI0Y2RhYTBlY2Y3NGRiYmMyZDY1NTU5NjU3YzViOTU5ZjBhNWVhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFR1
ZSwgMTAgSnVsIDIwMTIgMjE6MTM6MzEgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA3LTEw
ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBbR1RLXSBMTGludCBidWls
ZCBmYWlscyB3aXRoIC1nIC0wMgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD05MDA5OAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAg
ICAgICAgTG9vc2VuIHRoZSBjaGVja3MgZm9yIGdlbmVyYXRlZCBzeW1ib2wgbWFwcGluZyB0YWJs
ZXMgYXMgc3VnZ2VzdGVkIGJ5CiAgICAgICAgRmlsaXAgUGl6bG8uCgogICAgICAgICogb2ZmbGlu
ZWFzbS9vZmZzZXRzLnJiOgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAg
ICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxp
bmVhc20vb2Zmc2V0cy5yYiB8ICAgIDEgLQogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z
KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGExY2JlZmEu
LjhkMzZmYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy
LTA3LTEwICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgorCisgICAgICAgIFtHVEtdIExM
aW50IGJ1aWxkIGZhaWxzIHdpdGggLWcgLTAyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD05MDA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIExvb3NlbiB0aGUgY2hlY2tzIGZvciBnZW5lcmF0ZWQgc3ltYm9s
IG1hcHBpbmcgdGFibGVzIGFzIHN1Z2dlc3RlZCBieQorICAgICAgICBGaWxpcCBQaXpsby4KKwor
ICAgICAgICAqIG9mZmxpbmVhc20vb2Zmc2V0cy5yYjoKKwogMjAxMi0wNy0xMCAgRmlsaXAgUGl6
bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyMjE2Nik6IEl0
IG1hZGUgMTcwIHRlc3RzIGNyYXNoIG9uIDMyIGJpdCBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvb2ZmbGluZWFzbS9vZmZzZXRzLnJiCmluZGV4IDRmMjczNGYuLmIxZWFmMmUgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vb2Zmc2V0cy5yYgpAQCAtMTYwLDcg
KzE2MCw2IEBAIGRlZiBvZmZzZXRzQW5kQ29uZmlndXJhdGlvbkluZGV4KGZpbGUpCiAgICAgfQog
ICAgIAogICAgIHJhaXNlIE1pc3NpbmdNYWdpY1ZhbHVlc0V4Y2VwdGlvbiB1bmxlc3MgcmVzdWx0
Lmxlbmd0aCA+PSAxCi0gICAgcmFpc2UgaWYgcmVzdWx0Lm1hcHt8dnwgdlsxXX0udW5pcS5zaXpl
IDwgcmVzdWx0Lm1hcHt8dnwgdlsxXX0uc2l6ZQogICAgIAogICAgIHJlc3VsdAogZW5kCi0tIAox
LjcuOC42Cgo=
</data>
<flag name="review"
          id="159955"
          type_id="1"
          status="-"
          setter="plaes"
    />
    <flag name="commit-queue"
          id="159956"
          type_id="3"
          status="-"
          setter="plaes"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151701</attachid>
            <date>2012-07-11 07:16:03 -0700</date>
            <delta_ts>2012-07-11 07:16:03 -0700</delta_ts>
            <desc>Avoid duplicate offsets for llint, discarding them.</desc>
            <filename>0001-Avoid-duplicate-offsets-for-llint-discarding-them.txt</filename>
            <type>text/plain</type>
            <size>1593</size>
            <attacher name="Alban Browaeys">prahal</attacher>
            
              <data encoding="base64">RnJvbSBkZTM3ZWVkOGJkNTQ2YWUyZmMwMDM2ZWE5YTIyODdmZWI4ZDRkOWQ2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGJhbiBCcm93YWV5cyA8cHJhaGFsQHlhaG9vLmNvbT4KRGF0
ZTogRnJpLCA2IEp1bCAyMDEyIDAyOjE5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gQXZvaWQg
ZHVwbGljYXRlIG9mZnNldHMgZm9yIGxsaW50LCBkaXNjYXJkaW5nIHRoZW0uCgotLS0KIFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIgfCAgICA5ICsrKysrLS0tLQog
MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9vZmZzZXRzLnJiIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vb2Zmc2V0cy5yYgppbmRleCA0ZjI3MzRmLi43ZDE5
ODIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9vZmZzZXRz
LnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIKQEAg
LTYwLDcgKzYwLDcgQEAgZW5kCiAKICMKICMgb2Zmc2V0c0FuZENvbmZpZ3VyYXRpb25JbmRleChh
c3QsIGZpbGUpIC0+Ci0jICAgICBbW29mZnNldHMsIGluZGV4XSwgLi4uXQorIyAgICAge1tvZmZz
ZXRzLCBpbmRleF0sIC4uLn0KICMKICMgUGFyc2VzIHRoZSBvZmZzZXRzIGZyb20gYSBmaWxlIGFu
ZCByZXR1cm5zIGEgbGlzdCBvZiBvZmZzZXRzIGFuZCB0aGUKICMgaW5kZXggb2YgdGhlIGNvbmZp
Z3VyYXRpb24gdGhhdCBpcyB2YWxpZCBpbiB0aGlzIGJ1aWxkIHRhcmdldC4KQEAgLTY4LDcgKzY4
LDcgQEAgZW5kCiAKIGRlZiBvZmZzZXRzQW5kQ29uZmlndXJhdGlvbkluZGV4KGZpbGUpCiAgICAg
ZW5kaWFubmVzc01hcmtlckJ5dGVzID0gbmlsCi0gICAgcmVzdWx0ID0gW10KKyAgICByZXN1bHQg
PSB7fQogICAgIAogICAgIGRlZiByZWFkSW50KGVuZGlhbm5lc3MsIGJ5dGVzKQogICAgICAgICBp
ZiBlbmRpYW5uZXNzID09IDpsaXR0bGUKQEAgLTE1NCwxMyArMTU0LDE0IEBAIGRlZiBvZmZzZXRz
QW5kQ29uZmlndXJhdGlvbkluZGV4KGZpbGUpCiAgICAgICAgICAgICAgICAgICAgIHwgZGF0YSB8
CiAgICAgICAgICAgICAgICAgICAgIG9mZnNldHMgPDwgcmVhZEludChlbmRpYW5uZXNzLCBkYXRh
KQogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICByZXN1bHQgPDwgW29mZnNldHMs
IGluZGV4XQorICAgICAgICAgICAgICAgIGlmIG5vdCByZXN1bHQuaGFzX2tleT8ob2Zmc2V0cykK
KyAgICAgICAgICAgICAgICAgICAgcmVzdWx0W29mZnNldHNdID0gaW5kZXgKKyAgICAgICAgICAg
ICAgICBlbmQKICAgICAgICAgICAgIH0KICAgICAgICAgZW5kCiAgICAgfQogICAgIAogICAgIHJh
aXNlIE1pc3NpbmdNYWdpY1ZhbHVlc0V4Y2VwdGlvbiB1bmxlc3MgcmVzdWx0Lmxlbmd0aCA+PSAx
Ci0gICAgcmFpc2UgaWYgcmVzdWx0Lm1hcHt8dnwgdlsxXX0udW5pcS5zaXplIDwgcmVzdWx0Lm1h
cHt8dnwgdlsxXX0uc2l6ZQogICAgIAogICAgIHJlc3VsdAogZW5kCi0tIAoxLjcuMTAuNAoK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>160565</attachid>
            <date>2012-08-25 10:18:19 -0700</date>
            <delta_ts>2012-08-28 00:34:58 -0700</delta_ts>
            <desc>webkit-bug-90098-gtk-llint-build-failure.patch</desc>
            <filename>0001-2012-08-25-Alban-Browaeys-prahal-yahoo.com.patch</filename>
            <type>text/plain</type>
            <size>2511</size>
            <attacher name="Priit Laes (IRC: plaes)">plaes</attacher>
            
              <data encoding="base64">RnJvbSA2Y2YzN2FkZDE0MThlZjExNWZlMDQ0YTY2ZTU2ZmQ3YjczYjFjZmM0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFNh
dCwgMjUgQXVnIDIwMTIgMjA6MTQ6MzQgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA4LTI1
ICBBbGJhbiBCcm93YWV5cyA8cHJhaGFsQHlhaG9vLmNvbT4KCiAgICAgICAgW0dUS10gTExpbnQg
YnVpbGQgZmFpbHMgd2l0aCAtZyAtMDIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTAwOTgKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CgogICAgICAgIEF2b2lkIGR1cGxpY2F0ZSBvZmZzZXRzIGZvciBsbGludCwgZGlzY2FyZGluZyB0
aGVtLgoKICAgICAgICAqIG9mZmxpbmVhc20vb2Zmc2V0cy5yYjoKLS0tCiBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIgfCAxMCArKysrKystLS0tCiAyIGZp
bGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKaW5kZXggNmJhNGY1My4uYjIwMDYzMCAxMDA2NDQKLS0tIGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDgtMjUgIEFsYmFuIEJyb3dhZXlzIDxwcmFoYWxA
eWFob28uY29tPgorCisgICAgICAgIFtHVEtdIExMaW50IGJ1aWxkIGZhaWxzIHdpdGggLWcgLTAy
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA5OAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIGR1
cGxpY2F0ZSBvZmZzZXRzIGZvciBsbGludCwgZGlzY2FyZGluZyB0aGVtLgorCisgICAgICAgICog
b2ZmbGluZWFzbS9vZmZzZXRzLnJiOgorCiAyMDEyLTA4LTI0ICBCZW5qYW1pbiBQb3VsYWluICA8
YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVuaWZ5IE51bWJlciB0byBTdHJpbmdJbXBs
IGNvbnZlcnNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt
L29mZnNldHMucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9vZmZzZXRzLnJi
CmluZGV4IDhhMDY0YTIuLjhiOGVmN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9vZmZsaW5lYXNtL29mZnNldHMucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxp
bmVhc20vb2Zmc2V0cy5yYgpAQCAtNjEsNyArNjEsNyBAQCBlbmQKIAogIwogIyBvZmZzZXRzQW5k
Q29uZmlndXJhdGlvbkluZGV4KGFzdCwgZmlsZSkgLT4KLSMgICAgIFtbb2Zmc2V0cywgaW5kZXhd
LCAuLi5dCisjICAgICB7W29mZnNldHMsIGluZGV4XSwgLi4ufQogIwogIyBQYXJzZXMgdGhlIG9m
ZnNldHMgZnJvbSBhIGZpbGUgYW5kIHJldHVybnMgYSBsaXN0IG9mIG9mZnNldHMgYW5kIHRoZQog
IyBpbmRleCBvZiB0aGUgY29uZmlndXJhdGlvbiB0aGF0IGlzIHZhbGlkIGluIHRoaXMgYnVpbGQg
dGFyZ2V0LgpAQCAtNjksNyArNjksNyBAQCBlbmQKIAogZGVmIG9mZnNldHNBbmRDb25maWd1cmF0
aW9uSW5kZXgoZmlsZSkKICAgICBlbmRpYW5uZXNzTWFya2VyQnl0ZXMgPSBuaWwKLSAgICByZXN1
bHQgPSBbXQorICAgIHJlc3VsdCA9IHt9CiAgICAgCiAgICAgZGVmIHJlYWRJbnQoZW5kaWFubmVz
cywgYnl0ZXMpCiAgICAgICAgIGlmIGVuZGlhbm5lc3MgPT0gOmxpdHRsZQpAQCAtMTU1LDEzICsx
NTUsMTUgQEAgZGVmIG9mZnNldHNBbmRDb25maWd1cmF0aW9uSW5kZXgoZmlsZSkKICAgICAgICAg
ICAgICAgICAgICAgfCBkYXRhIHwKICAgICAgICAgICAgICAgICAgICAgb2Zmc2V0cyA8PCByZWFk
SW50KGVuZGlhbm5lc3MsIGRhdGEpCiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAg
IHJlc3VsdCA8PCBbb2Zmc2V0cywgaW5kZXhdCisgICAgICAgICAgICAgICAgI3Jlc3VsdCA8PCBb
b2Zmc2V0cywgaW5kZXhdCisgICAgICAgICAgICAgICAgaWYgbm90IHJlc3VsdC5oYXNfa2V5Pyhv
ZmZzZXRzKQorICAgICAgICAgICAgICAgICAgICByZXN1bHRbb2Zmc2V0c10gPSBpbmRleAorICAg
ICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgfQogICAgICAgICBlbmQKICAgICB9CiAgICAg
CiAgICAgcmFpc2UgTWlzc2luZ01hZ2ljVmFsdWVzRXhjZXB0aW9uIHVubGVzcyByZXN1bHQubGVu
Z3RoID49IDEKLSAgICByYWlzZSBpZiByZXN1bHQubWFwe3x2fCB2WzFdfS51bmlxLnNpemUgPCBy
ZXN1bHQubWFwe3x2fCB2WzFdfS5zaXplCiAgICAgCiAgICAgcmVzdWx0CiBlbmQKLS0gCjEuNy4x
MgoK
</data>
<flag name="review"
          id="171149"
          type_id="1"
          status="-"
          setter="fpizlo"
    />
    <flag name="commit-queue"
          id="171150"
          type_id="3"
          status="-"
          setter="fpizlo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>160922</attachid>
            <date>2012-08-28 00:34:58 -0700</date>
            <delta_ts>2012-08-28 09:01:50 -0700</delta_ts>
            <desc>webkit-bug-90098-gtk-llint-build-failure-v2.patch</desc>
            <filename>0001-2012-08-25-Alban-Browaeys-prahal-yahoo.com.patch</filename>
            <type>text/plain</type>
            <size>2464</size>
            <attacher name="Priit Laes (IRC: plaes)">plaes</attacher>
            
              <data encoding="base64">RnJvbSA3M2Y0M2I4ZWZmMGZlZGM2MDA4N2JjZWYxYmNiZjQwMzc3N2NiMGFhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFNh
dCwgMjUgQXVnIDIwMTIgMjA6MTQ6MzQgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA4LTI1
ICBBbGJhbiBCcm93YWV5cyA8cHJhaGFsQHlhaG9vLmNvbT4KCiAgICAgICAgW0dUS10gTExpbnQg
YnVpbGQgZmFpbHMgd2l0aCAtZyAtMDIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTAwOTgKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CgogICAgICAgIEF2b2lkIGR1cGxpY2F0ZSBvZmZzZXRzIGZvciBsbGludCwgZGlzY2FyZGluZyB0
aGVtLgoKICAgICAgICAqIG9mZmxpbmVhc20vb2Zmc2V0cy5yYjoKLS0tCiBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIgfCAgOSArKysrKy0tLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZwppbmRleCBlMzc1ODZjLi4zYTgxZTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOC0yNSAgQWxiYW4gQnJvd2FleXMgPHByYWhhbEB5
YWhvby5jb20+CisKKyAgICAgICAgW0dUS10gTExpbnQgYnVpbGQgZmFpbHMgd2l0aCAtZyAtMDIK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMDk4CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgZHVw
bGljYXRlIG9mZnNldHMgZm9yIGxsaW50LCBkaXNjYXJkaW5nIHRoZW0uCisKKyAgICAgICAgKiBv
ZmZsaW5lYXNtL29mZnNldHMucmI6CisKIDIwMTItMDgtMjcgIFNoZXJpZmYgQm90ICA8d2Via2l0
LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0
IHIxMjY4MzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9v
ZmZzZXRzLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vb2Zmc2V0cy5yYgpp
bmRleCA4YTA2NGEyLi42MjcxODNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
b2ZmbGluZWFzbS9vZmZzZXRzLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l
YXNtL29mZnNldHMucmIKQEAgLTYxLDcgKzYxLDcgQEAgZW5kCiAKICMKICMgb2Zmc2V0c0FuZENv
bmZpZ3VyYXRpb25JbmRleChhc3QsIGZpbGUpIC0+Ci0jICAgICBbW29mZnNldHMsIGluZGV4XSwg
Li4uXQorIyAgICAge1tvZmZzZXRzLCBpbmRleF0sIC4uLn0KICMKICMgUGFyc2VzIHRoZSBvZmZz
ZXRzIGZyb20gYSBmaWxlIGFuZCByZXR1cm5zIGEgbGlzdCBvZiBvZmZzZXRzIGFuZCB0aGUKICMg
aW5kZXggb2YgdGhlIGNvbmZpZ3VyYXRpb24gdGhhdCBpcyB2YWxpZCBpbiB0aGlzIGJ1aWxkIHRh
cmdldC4KQEAgLTY5LDcgKzY5LDcgQEAgZW5kCiAKIGRlZiBvZmZzZXRzQW5kQ29uZmlndXJhdGlv
bkluZGV4KGZpbGUpCiAgICAgZW5kaWFubmVzc01hcmtlckJ5dGVzID0gbmlsCi0gICAgcmVzdWx0
ID0gW10KKyAgICByZXN1bHQgPSB7fQogICAgIAogICAgIGRlZiByZWFkSW50KGVuZGlhbm5lc3Ms
IGJ5dGVzKQogICAgICAgICBpZiBlbmRpYW5uZXNzID09IDpsaXR0bGUKQEAgLTE1NSwxMyArMTU1
LDE0IEBAIGRlZiBvZmZzZXRzQW5kQ29uZmlndXJhdGlvbkluZGV4KGZpbGUpCiAgICAgICAgICAg
ICAgICAgICAgIHwgZGF0YSB8CiAgICAgICAgICAgICAgICAgICAgIG9mZnNldHMgPDwgcmVhZElu
dChlbmRpYW5uZXNzLCBkYXRhKQogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBy
ZXN1bHQgPDwgW29mZnNldHMsIGluZGV4XQorICAgICAgICAgICAgICAgIGlmIG5vdCByZXN1bHQu
aGFzX2tleT8ob2Zmc2V0cykKKyAgICAgICAgICAgICAgICAgICAgcmVzdWx0W29mZnNldHNdID0g
aW5kZXgKKyAgICAgICAgICAgICAgICBlbmQKICAgICAgICAgICAgIH0KICAgICAgICAgZW5kCiAg
ICAgfQogICAgIAogICAgIHJhaXNlIE1pc3NpbmdNYWdpY1ZhbHVlc0V4Y2VwdGlvbiB1bmxlc3Mg
cmVzdWx0Lmxlbmd0aCA+PSAxCi0gICAgcmFpc2UgaWYgcmVzdWx0Lm1hcHt8dnwgdlsxXX0udW5p
cS5zaXplIDwgcmVzdWx0Lm1hcHt8dnwgdlsxXX0uc2l6ZQogICAgIAogICAgIHJlc3VsdAogZW5k
Ci0tIAoxLjcuMTIKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>