9009 2006-05-19 15:50:12 -0700 REGRESSION: ToT crash in WebCore at Zap2it 2006-05-20 01:43:52 -0700 1 1 1 Unclassified WebKit Tables 420+ Mac OS X 10.4 RESOLVED FIXED http://tvlistings5.zap2it.com/tvlistings/GridAction.do?zipcode=50010&lineupId=IA14479:X EasyFix, Regression P1 Normal --- 1 jon webkit-unassigned mitz oldest_to_newest 42956 0 jon 2006-05-19 15:50:12 -0700 Between r14345 and r14375, a change introduced a crasher with the following trace: 0 com.apple.WebCore 0x01a0ddb0 WebCore::RenderTableSection::paint(WebCore::RenderObject::PaintInfo&, int, int) + 704 (RefPtr.h:50) 1 com.apple.WebCore 0x01a0c740 WebCore::RenderTable::paint(WebCore::RenderObject::PaintInfo&, int, int) + 560 (RenderObject.h:135) 2 com.apple.WebCore 0x019be7b0 WebCore::RenderBlock::paintChildren(WebCore::RenderObject::PaintInfo&, int, int) + 512 (RenderBlock.cpp:1279) 3 com.apple.WebCore 0x019c4d64 WebCore::RenderBlock::paintObject(WebCore::RenderObject::PaintInfo&, int, int) + 292 (RenderBlock.cpp:1331) 4 com.apple.WebCore 0x019bda84 WebCore::RenderBlock::paint(WebCore::RenderObject::PaintInfo&, int, int) + 468 (RenderBlock.cpp:1254) 5 com.apple.WebCore 0x019c2314 WebCore::RenderBlock::paintFloats(WebCore::RenderObject::PaintInfo&, int, int, bool) + 436 (RenderBlock.cpp:1386) 6 com.apple.WebCore 0x019c4dd4 WebCore::RenderBlock::paintObject(WebCore::RenderObject::PaintInfo&, int, int) + 404 (RenderBlock.cpp:1344) 7 com.apple.WebCore 0x019bda84 WebCore::RenderBlock::paint(WebCore::RenderObject::PaintInfo&, int, int) + 468 (RenderBlock.cpp:1254) 8 com.apple.WebCore 0x019e7e7c WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, bool, WebCore::RenderObject*) + 892 (RenderLayer.cpp:1160) 9 com.apple.WebCore 0x019e7fd4 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, bool, WebCore::RenderObject*) + 1236 (RenderLayer.cpp:1185) 10 com.apple.WebCore 0x019e7fd4 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, bool, WebCore::RenderObject*) + 1236 (RenderLayer.cpp:1185) 11 com.apple.WebCore 0x0190aecc WebCore::Frame::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) + 156 (Frame.cpp:2809) 12 com.apple.WebCore 0x01943e6c -[WebCoreFrameBridge drawRect:] + 188 (WebCoreFrameBridge.mm:908) 13 com.apple.WebKit 0x0033bd2c -[WebHTMLView drawSingleRect:] + 284 (WebHTMLView.m:2577) 14 com.apple.WebKit 0x0033bef0 -[WebHTMLView drawRect:] + 288 (WebHTMLView.m:2625) 15 com.apple.AppKit 0x93765bf8 -[NSView _drawRect:clip:] + 2128 16 com.apple.AppKit 0x9376499c -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 736 17 com.apple.WebKit 0x00336d48 -[WebHTMLView(WebPrivate) _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 296 (WebHTMLView.m:823) 18 com.apple.AppKit 0x93764d48 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 19 com.apple.AppKit 0x9375e3f4 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 384 20 com.apple.AppKit 0x937536e8 -[NSView displayIfNeeded] + 248 21 com.apple.AppKit 0x9385a7d8 -[NSClipView _immediateScrollToPoint:] + 1384 22 com.apple.AppKit 0x9385a0e8 -[NSScrollView scrollClipView:toPoint:] + 252 23 com.apple.AppKit 0x937c8934 -[NSClipView _scrollTo:animate:] + 744 24 com.apple.AppKit 0x93859ec4 -[NSScrollView _doScroller:hitPart:multiplier:] + 788 25 com.apple.AppKit 0x93aee448 -[NSScrollView scrollWheel:] + 328 26 com.apple.AppKit 0x937ee318 forwardMethod + 92 27 com.apple.AppKit 0x93b65cfc -[NSView scrollWheel:] + 248 28 com.apple.WebKit 0x003268e4 -[WebClipView scrollWheel:] + 148 (WebClipView.m:109) 29 com.apple.WebKit 0x0033c460 -[WebHTMLView scrollWheel:] + 112 (WebHTMLView.m:2703) 30 com.apple.AppKit 0x9377c340 -[NSWindow sendEvent:] + 6424 31 com.apple.Safari 0x00021ca4 0x1000 + 134308 32 com.apple.AppKit 0x93724c74 -[NSApplication sendEvent:] + 4172 33 com.apple.Safari 0x000217a8 0x1000 + 133032 34 com.apple.AppKit 0x9371c0b0 -[NSApplication run] + 508 35 com.apple.AppKit 0x9380cbfc NSApplicationMain + 452 36 com.apple.Safari 0x0005cb98 0x1000 + 375704 37 com.apple.Safari 0x0005ca40 0x1000 + 375360 42957 1 mitz 2006-05-19 15:54:22 -0700 This is a regression for the fix for bug 6838. The fix is simply to return from RenderTableSection::paint() right at the beginning if totalRows == 0. 42975 2 8428 mitz 2006-05-19 23:58:40 -0700 Created attachment 8428 Patch w/test and change log 42980 3 8428 ap 2006-05-20 01:21:48 -0700 Comment on attachment 8428 Patch w/test and change log r=me 42982 4 ap 2006-05-20 01:43:52 -0700 Landed, r14500. 8428 2006-05-19 23:58:40 -0700 2006-05-20 01:21:48 -0700 Patch w/test and change log 9009_r1.patch text/plain 5883 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTkwMDkKKyAgICAgICAgICBSRUdSRVNTSU9OOiBUb1QgY3Jh c2ggaW4gV2ViQ29yZSBhdCBaYXAyaXQKKworICAgICAgICAqIGZhc3QvdGFibGUvZW1wdHktc2Vj dGlvbi1jcmFzaC1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAgICAgICogZmFzdC90YWJs ZS9lbXB0eS1zZWN0aW9uLWNyYXNoLWV4cGVjdGVkLnBuZzogQWRkZWQuCisgICAgICAgICogZmFz dC90YWJsZS9lbXB0eS1zZWN0aW9uLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDA2LTA1 LTE5ICBMZXZpIFdlaW50cmF1YiAgPGx3ZWludHJhdWJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IGp1c3Rpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGFibGUvZW1wdHktc2Vj dGlvbi1jcmFzaC1leHBlY3RlZC5wbmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3QgZGlzcGxheTogZmlsZSBt YXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGFwcGxpY2F0aW9uL29jdGV0 LXN0cmVhbQoKUHJvcGVydHkgY2hhbmdlcyBvbjogZW1wdHktc2VjdGlvbi1jcmFzaC1leHBlY3Rl ZC5wbmcKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgYXBwbGljYXRpb24vb2N0 ZXQtc3RyZWFtCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNy YXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2Vt cHR5LXNlY3Rpb24tY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwyNiBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRl ckNhbnZhcyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYw MAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVy Qm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTc2CisgICAgICBSZW5kZXJCbG9jayB7UH0g YXQgKDAsMCkgc2l6ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDAp IHNpemUgNTN4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA1MzogIlRlc3Qg Zm9yICIKKyAgICAgICAgUmVuZGVySW5saW5lIHtJfSBhdCAoMCwwKSBzaXplIDY2M3gxOAorICAg ICAgICAgIFJlbmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAzNDh4MTggW2NvbG9yPSMwMDAw RUVdCisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDUzLDApIHNpemUgMzQ4eDE4 CisgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICg1MywwKSB3aWR0aCAzNDg6ICJodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTkwMDkiCisgICAgICAgICAgUmVu ZGVyVGV4dCB7I3RleHR9IGF0ICg0MDEsMCkgc2l6ZSAzMTV4MTgKKyAgICAgICAgICAgIHRleHQg cnVuIGF0ICg0MDEsMCkgd2lkdGggNDogIiAiCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoNDA1 LDApIHdpZHRoIDMxMTogIlJFR1JFU1NJT046IFRvVCBjcmFzaCBpbiBXZWJDb3JlIGF0IFphcDJp dCIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICg3MTYsMCkgc2l6ZSA0eDE4CisgICAg ICAgICAgdGV4dCBydW4gYXQgKDcxNiwwKSB3aWR0aCA0OiAiLiIKKyAgICAgIFJlbmRlckJsb2Nr IHtQfSBhdCAoMCwzNCkgc2l6ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgMTQ4eDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMTQ4 OiAiTm8gY3Jhc2ggbWVhbnMgUEFTUy4iCitsYXllciBhdCAoOCwtMTApIHNpemUgMTAweDEyIGJh Y2tncm91bmRDbGlwIGF0ICgwLDApIHNpemUgODAweDYwMCBjbGlwIGF0ICgwLDApIHNpemUgODAw eDYwMCBvdXRsaW5lQ2xpcCBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVGFibGUge1RB QkxFfSBhdCAoOCwtMTApIHNpemUgMTAweDEyIFtib3JkZXI6ICg1cHggc29saWQgIzAwMDAwMCkg bm9uZV0KKyAgICBSZW5kZXJUYWJsZVNlY3Rpb24ge1RCT0RZfSBhdCAoMCw1KSBzaXplIDEwMHgw CisgICAgUmVuZGVyVGFibGVTZWN0aW9uIHtUQk9EWX0gYXQgKDAsNSkgc2l6ZSAxMDB4NworICAg ICAgUmVuZGVyVGFibGVSb3cge1RSfSBhdCAoMCwwKSBzaXplIDEwMHg3CisgICAgICAgIFJlbmRl clRhYmxlQ2VsbCB7VER9IGF0ICgwLDApIHNpemUgMTAweDcgW2JvcmRlcjogKDVweCBub25lICMw MDAwMDApXSBbcj0wIGM9MCBycz0xIGNzPTFdCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RhYmxl L2VtcHR5LXNlY3Rpb24tY3Jhc2gtZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNyYXNoLWV4cGVjdGVkLmNoZWNrc3Vt CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNy YXNoLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACis4ZGUxNWYx NzkyNjllNzkzZTVhNjE0OGNjMDU1MzI1NApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvdGFibGUvZW1wdHktc2VjdGlvbi1jcmFzaC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdGFibGUvZW1wdHktc2VjdGlvbi1jcmFzaC5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9lbXB0eS1zZWN0aW9uLWNy YXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzQgQEAKKzxodG1sPgorPGhlYWQ+Cisg ICAgPHRpdGxlPjwvdGl0bGU+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgor ICAgICAgICBmdW5jdGlvbiBmaW5pc2goKQorICAgICAgICB7CisgICAgICAgICAgICAvKiBTaW5j ZSB0aGUgY3Jhc2ggaGFwcGVucyBpbiBwYWludGluZyBjb2RlLCBmb3JjZSBwYWludGluZy4gVGhp cworICAgICAgICAgICAgICAgbWFrZXMgdGhlIHRlc3Qgd29yayBldmVuIHdoZW4gcnVuIHdpdGhv dXQgdGhlIC0tcGl4ZWwgb3B0aW9uLiAqLworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZGlzcGxheSgpOworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gdGVzdCgpCisgICAgICAgIHsKKyAg ICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgICAgICAg ICAgc2V0VGltZW91dChmaW5pc2gsIDApOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAg PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgorICAgIDxwPgorICAg ICAgICBUZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcv c2hvd19idWcuY2dpP2lkPTkwMDkiPmh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTAwOTwvYT4KKyAgICAgICAgUkVHUkVTU0lPTjogVG9UIGNyYXNoIGluIFdl YkNvcmUgYXQgWmFwMml0PC9pPi4KKyAgICA8L3A+CisgICAgPHA+CisgICAgICAgIE5vIGNyYXNo IG1lYW5zIFBBU1MuCisgICAgPC9wPgorICAgIDx0YWJsZSBzdHlsZT0icG9zaXRpb246IGFic29s dXRlOyB0b3A6IC0xMHB4OyBib3JkZXItY29sbGFwc2U6IGNvbGxhcHNlOyBib3JkZXItdG9wOiAx MHB4IHNvbGlkOyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7Ij4KKyAgICA8dGJvZHk+PC90 Ym9keT4KKyAgICA8dGJvZHk+PHRyPjx0ZD48L3RkPjwvdHI+PC90Ym9keT4KKyAgICA8L3RhYmxl PgorPC9ib2R5PgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDk5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwNi0wNS0jIyAgTWl0eiBQZXR0ZWwgIDxvcGVu ZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcv c2hvd19idWcuY2dpP2lkPTkwMDkKKyAgICAgICAgICBSRUdSRVNTSU9OOiBUb1QgY3Jhc2ggaW4g V2ViQ29yZSBhdCBaYXAyaXQKKworICAgICAgICBUZXN0OiBmYXN0L3RhYmxlL2VtcHR5LXNlY3Rp b24tY3Jhc2guaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZVNlY3Rpb246OnBhaW50KTogUmV0dXJu IGltbWVkaWF0ZWx5IGlmIHRoZSBzZWN0aW9uCisgICAgICAgIGhhcyAwIHJvd3Mgb3IgMCBjb2x1 bW5zLgorCiAyMDA2LTA1LTE5ICBMZXZpIFdlaW50cmF1YiAgPGx3ZWludHJhdWJAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IGp1c3Rpbi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRhYmxlU2VjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGVTZWN0aW9uLmNwcAkocmV2aXNpb24gMTQ0OTUpCisrKyBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjksNiArODI5 LDkgQEAgdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OnBhaW50KFBhaW50SW5mbwogICAgIHVuc2ln bmVkIGludCB0b3RhbFJvd3MgPSBncmlkUm93czsKICAgICB1bnNpZ25lZCBpbnQgdG90YWxDb2xz ID0gdGFibGUoKS0+Y29sdW1ucy5zaXplKCk7CiAKKyAgICBpZiAodG90YWxSb3dzID09IDAgfHwg dG90YWxDb2xzID09IDApCisgICAgICAgIHJldHVybjsKKwogICAgIHR4ICs9IG1feDsKICAgICB0 eSArPSBtX3k7CiAK