90083 2012-06-27 10:45:19 -0700 LayoutUnit::epsilon() is wrong 2012-07-02 15:41:55 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 behdad behdad eae eric webkit.review.bot oldest_to_newest 658703 0 behdad 2012-06-27 10:45:19 -0700 In platform/FractionalLayoutUnit.h: static float epsilon() { return 1 / kFixedPointDenominator; } That division is done as integers. So, if SUBPIXEL_LAYOUT is enabled, epsilon() always returns zero. 658811 1 149788 behdad 2012-06-27 13:16:09 -0700 Created attachment 149788 Patch 658842 2 eae 2012-06-27 13:49:07 -0700 Looks good to me. While I'd like to see a test for this I realize it isn't really feasible to add one given that the method isn't actually used anywhere yet. Eric, could you use your magic reviewing powers on this one? 661739 3 149788 eric 2012-07-02 14:50:09 -0700 Comment on attachment 149788 Patch Happy to. 661771 4 149788 webkit.review.bot 2012-07-02 15:41:49 -0700 Comment on attachment 149788 Patch Clearing flags on attachment: 149788 Committed r121709: <http://trac.webkit.org/changeset/121709> 661772 5 webkit.review.bot 2012-07-02 15:41:55 -0700 All reviewed patches have been landed. Closing bug. 149788 2012-06-27 13:16:09 -0700 2012-07-02 15:41:49 -0700 Patch bug-90083-20120627161609.patch text/plain 1403 behdad U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTgxZGZkZGYyMDlmN2M1 ZTVkZjhiNjUyZTkzMTBhMjZiMTNhMmZjZS4uZWJjNDM0MzY5M2JiNGNlODFhN2MyODVjNWZkNWE5 NTZjMDZhMDhlMyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI3ICBCZWhk YWQgRXNmYWhib2QgIDxiZWhkYWRAYmVoZGFkLm9yZz4KKworICAgICAgICBMYXlvdXRVbml0Ojpl cHNpbG9uKCkgaXMgd3JvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwMDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG8gZGl2aXNpb24gaW4gZmxvYXRzLCBub3QgaW50ZWdlcnMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBObyBjb2RlIHVzaW5nIHRoZSBhZmZlY3RlZCBmdW5jdGlvbi4KKworICAg ICAgICAqIHBsYXRmb3JtL0ZyYWN0aW9uYWxMYXlvdXRVbml0Lmg6CisgICAgICAgIChXZWJDb3Jl OjpGcmFjdGlvbmFsTGF5b3V0VW5pdDo6ZXBzaWxvbik6CisKIDIwMTItMDYtMjcgIEtlbnRhcm8g SGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVmYWN0b3IgVjhC aW5kaW5nUGVySXNvbGF0ZURhdGE6OmN1cnJlbnQoKSBhbmQgVjhCaW5kaW5nUGVySXNvbGF0ZURh dGE6OmdldCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GcmFjdGlvbmFs TGF5b3V0VW5pdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRnJhY3Rpb25hbExheW91dFVu aXQuaAppbmRleCBkMjAxZTEyMmI3ODMwYTUxYTZlOTU0ZGYxMTA0MjE4NTRiNThjY2RkLi43NjQx YTcxOGNjMzg4MWQ3MjY5Y2Q1ZjcyZjhkYWQwZGEzZDM5NGYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9GcmFjdGlvbmFsTGF5b3V0VW5pdC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0ZyYWN0aW9uYWxMYXlvdXRVbml0LmgKQEAgLTE1Myw3ICsxNTMsNyBAQCBw dWJsaWM6CiAgICAgICAgIHJldHVybiB0b0ludCgpOwogICAgIH0KIAotICAgIHN0YXRpYyBmbG9h dCBlcHNpbG9uKCkgeyByZXR1cm4gMSAvIGtGaXhlZFBvaW50RGVub21pbmF0b3I7IH0KKyAgICBz dGF0aWMgZmxvYXQgZXBzaWxvbigpIHsgcmV0dXJuIDEuMGYgLyBrRml4ZWRQb2ludERlbm9taW5h dG9yOyB9CiAgICAgc3RhdGljIGNvbnN0IEZyYWN0aW9uYWxMYXlvdXRVbml0IG1heCgpCiAgICAg ewogICAgICAgICBGcmFjdGlvbmFsTGF5b3V0VW5pdCBtOwo=