90076 2012-06-27 07:55:14 -0700 [EFL] [WK2] Don't call eina_iterator_free() if iterator is NULL 2012-07-03 03:04:32 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 658601 0 naginenis 2012-06-27 07:55:14 -0700 I'm seeing the following console log messages when Minibrowser opened. CRI<32386>: eina_iterator.c:98 eina_iterator_free() *** Eina Magic Check Failed !!! Input handle pointer is NULL ! *** NAUGHTY PROGRAMMER!!! *** SPANK SPANK SPANK!!! *** Now go fix your code. Tut tut tut! ERR<32386>: eina_iterator.c:99 eina_iterator_free() safety check failed: iterator == NULL 658612 1 149749 naginenis 2012-06-27 08:13:32 -0700 Created attachment 149749 Patch 658767 2 149749 rakuco 2012-06-27 12:10:02 -0700 Comment on attachment 149749 Patch Is this really needed? eina_iterator_free() should be a NOP if the iterator passed to it is NULL. 658798 3 naginenis 2012-06-27 12:53:38 -0700 (In reply to comment #2) > (From update of attachment 149749 [details]) > Is this really needed? eina_iterator_free() should be a NOP if the iterator passed to it is NULL. (In reply to comment #2) > (From update of attachment 149749 [details]) > Is this really needed? eina_iterator_free() should be a NOP if the iterator passed to it is NULL. We need it to get rid of these critical error messages on browser startup. 658914 4 rakuco 2012-06-27 15:14:41 -0700 I'd say it's a bug in Eina. I'll mail enlightenment-devel about this. 658918 5 rakuco 2012-06-27 15:26:22 -0700 (In reply to comment #4) > I'd say it's a bug in Eina. I'll mail enlightenment-devel about this. http://article.gmane.org/gmane.comp.window-managers.enlightenment.devel/42486 659312 6 naginenis 2012-06-28 00:58:22 -0700 (In reply to comment #5) > http://article.gmane.org/gmane.comp.window-managers.enlightenment.devel/42486 Thanks for discussing this on enlightenment-devel list. 659314 7 cdumez 2012-06-28 01:22:35 -0700 And the doc for eina_iterator_free() says it frees the iterator "if the iterator is not NULL". So the doc seems to hint that passing NULL is possible but then if you do it you get "SPANKED" :) 661386 8 149749 cdumez 2012-07-02 04:08:50 -0700 Comment on attachment 149749 Patch LGTM. Could we please land this ASAP? The output on stderr looks really bad. 661461 9 rakuco 2012-07-02 07:00:47 -0700 I still think it makes more sense to fix this one in Eina, I just haven't had time to follow up with a patch in that thread... 661514 10 rakuco 2012-07-02 08:42:28 -0700 (In reply to comment #9) > I still think it makes more sense to fix this one in Eina, I just haven't had time to follow up with a patch in that thread... I have now sent http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg42944.html 661877 11 kenneth 2012-07-02 18:46:21 -0700 (In reply to comment #10) > (In reply to comment #9) > > I still think it makes more sense to fix this one in Eina, I just haven't had time to follow up with a patch in that thread... > > I have now sent http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg42944.html Why not fix it in webkit for now adding a comment referring to this bug report? 661925 12 rakuco 2012-07-02 21:01:17 -0700 That's also possible, provided we don't forget to work on this later (it's likely we will). 662062 13 150561 naginenis 2012-07-03 02:04:36 -0700 Created attachment 150561 patch Added a comment. We can remove this once the magic check on _free removed in Eina. 662063 14 webkit.review.bot 2012-07-03 02:06:34 -0700 Attachment 150561 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/efl/FileSystemEfl.cpp:94: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 662065 15 150562 naginenis 2012-07-03 02:11:08 -0700 Created attachment 150562 Patch 662087 16 150562 webkit.review.bot 2012-07-03 03:04:27 -0700 Comment on attachment 150562 Patch Clearing flags on attachment: 150562 Committed r121752: <http://trac.webkit.org/changeset/121752> 662088 17 webkit.review.bot 2012-07-03 03:04:32 -0700 All reviewed patches have been landed. Closing bug. 149749 2012-06-27 08:13:32 -0700 2012-07-03 02:04:36 -0700 Patch 90076.patch text/plain 1454 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ODU2Y2ExLi42NDFhZDQwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRG9uJ3QgY2FsbCBlaW5hX2l0 ZXJhdG9yX2ZyZWUoKSBpZiBpdGVyYXRvciBpcyBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgdG8gcHJldmVudCBjYWxs aW5nIGVpbmFfaXRlcmF0b3JfZnJlZSgpIHdoZW4KKyAgICAgICAgaXRlcmF0b3IgaXMgTlVMTC4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZp b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpsaXN0RGlyZWN0b3J5KTogRWFybHkgcmV0dXJuIHdoZW4gaXRlcmF0b3IgaXMg TlVMTC4KKwogMjAxMi0wNi0yNiAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtQbGF0Zm9ybV0gQ2hhbmdlIGltcGxlbWVudGF0aW9uIG9mIExvY2FsZUlD VSBjbGFzcyB0byBzdXBwb3J0IG1vcmUgVURhdGVGb3JtYXQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAKaW5kZXggYzZiZmYxNS4uZmJmZjI3ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcApAQCAtOTEs NiArOTEsOSBAQCBWZWN0b3I8U3RyaW5nPiBsaXN0RGlyZWN0b3J5KGNvbnN0IFN0cmluZyYgcGF0 aCwgY29uc3QgU3RyaW5nJiBmaWx0ZXIpCiAgICAgY29uc3QgY2hhciAqZl9uYW1lOwogCiAgICAg RWluYV9JdGVyYXRvciogaXQgPSBlaW5hX2ZpbGVfbHMocGF0aC51dGY4KCkuZGF0YSgpKTsKKyAg ICBpZiAoIWl0KQorICAgICAgICByZXR1cm4gbWF0Y2hpbmdFbnRyaWVzOworCiAgICAgRUlOQV9J VEVSQVRPUl9GT1JFQUNIKGl0LCBmX25hbWUpIHsKICAgICAgICAgaWYgKCFmbm1hdGNoKGNmaWx0 ZXIuZGF0YSgpLCBmX25hbWUsIDApKQogICAgICAgICAgICAgbWF0Y2hpbmdFbnRyaWVzLmFwcGVu ZChTdHJpbmc6OmZyb21VVEY4KGZfbmFtZSkpOwo= 150561 2012-07-03 02:04:36 -0700 2012-07-03 02:11:08 -0700 patch 90076.patch text/plain 1735 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZjNmZDQ2Li40Y2U4ZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMDMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRG9uJ3QgY2FsbCBlaW5hX2l0 ZXJhdG9yX2ZyZWUoKSBpZiBpdGVyYXRvciBpcyBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgdG8gcHJldmVudCBjYWxs aW5nIGVpbmFfaXRlcmF0b3JfZnJlZSgpIHdoZW4KKyAgICAgICAgaXRlcmF0b3IgaXMgTlVMTC4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZp b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpsaXN0RGlyZWN0b3J5KTogRWFybHkgcmV0dXJuIHdoZW4gaXRlcmF0b3IgaXMg TlVMTC4KKwogMjAxMi0wNy0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CiAKICAgICAgICAgW1RleHR1cmVNYXBwZXJdIFRoZSBUZXh0dXJlTWFwcGVyIHNob3VsZCBz dXBwb3J0IGVkZ2UtZGlzdGFuY2UgYW50aS1hbnRpYWxpYXNpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcAppbmRleCAwY2FhZTg5Li45MTY1YmUzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwCkBAIC05 MSw2ICs5MSwxMiBAQCBWZWN0b3I8U3RyaW5nPiBsaXN0RGlyZWN0b3J5KGNvbnN0IFN0cmluZyYg cGF0aCwgY29uc3QgU3RyaW5nJiBmaWx0ZXIpCiAgICAgY29uc3QgY2hhciAqZl9uYW1lOwogCiAg ICAgRWluYV9JdGVyYXRvciogaXQgPSBlaW5hX2ZpbGVfbHMocGF0aC51dGY4KCkuZGF0YSgpKTsK KyAgICAvLyBGSVhNRTogRWFybHkgcmV0dXJuIGlmIHRoZSBpdGVyYXRvciBpcyBOVUxMIHRvIGF2 b2lkIGVycm9yIG1lc3NhZ2VzIGZyb20gZWluYV9pdGVyYXRvcl9mcmVlKCkuCisgICAgLy8gVGhp cyBjaGVjayBjYW4gYmUgcmVtb3ZlZCBvbmNlIHRoZSBtYWdpYyBjaGVjayBvbiBfZnJlZSgpIHJl bW92ZWQgaW4gRWluYS4KKyAgICAvLyBodHRwOi8vd3d3Lm1haWwtYXJjaGl2ZS5jb20vZW5saWdo dGVubWVudC1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQvbXNnNDI5NDQuaHRtbAorICAgIGlm ICghaXQpCisgICAgICAgIHJldHVybiBtYXRjaGluZ0VudHJpZXM7CisKICAgICBFSU5BX0lURVJB VE9SX0ZPUkVBQ0goaXQsIGZfbmFtZSkgewogICAgICAgICBpZiAoIWZubWF0Y2goY2ZpbHRlci5k YXRhKCksIGZfbmFtZSwgMCkpCiAgICAgICAgICAgICBtYXRjaGluZ0VudHJpZXMuYXBwZW5kKFN0 cmluZzo6ZnJvbVVURjgoZl9uYW1lKSk7Cg== 150562 2012-07-03 02:11:08 -0700 2012-07-03 03:04:27 -0700 Patch 90076.patch text/plain 1735 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZjNmZDQ2Li40Y2U4ZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMDMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRG9uJ3QgY2FsbCBlaW5hX2l0 ZXJhdG9yX2ZyZWUoKSBpZiBpdGVyYXRvciBpcyBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgdG8gcHJldmVudCBjYWxs aW5nIGVpbmFfaXRlcmF0b3JfZnJlZSgpIHdoZW4KKyAgICAgICAgaXRlcmF0b3IgaXMgTlVMTC4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZp b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpsaXN0RGlyZWN0b3J5KTogRWFybHkgcmV0dXJuIHdoZW4gaXRlcmF0b3IgaXMg TlVMTC4KKwogMjAxMi0wNy0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CiAKICAgICAgICAgW1RleHR1cmVNYXBwZXJdIFRoZSBUZXh0dXJlTWFwcGVyIHNob3VsZCBz dXBwb3J0IGVkZ2UtZGlzdGFuY2UgYW50aS1hbnRpYWxpYXNpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcAppbmRleCAwY2FhZTg5Li40MDc4ODIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwCkBAIC05 MSw2ICs5MSwxMiBAQCBWZWN0b3I8U3RyaW5nPiBsaXN0RGlyZWN0b3J5KGNvbnN0IFN0cmluZyYg cGF0aCwgY29uc3QgU3RyaW5nJiBmaWx0ZXIpCiAgICAgY29uc3QgY2hhciAqZl9uYW1lOwogCiAg ICAgRWluYV9JdGVyYXRvciogaXQgPSBlaW5hX2ZpbGVfbHMocGF0aC51dGY4KCkuZGF0YSgpKTsK KyAgICAvLyBGSVhNRTogRWFybHkgcmV0dXJuIGlmIHRoZSBpdGVyYXRvciBpcyBudWxsIHRvIGF2 b2lkIGVycm9yIG1lc3NhZ2VzIGZyb20gZWluYV9pdGVyYXRvcl9mcmVlKCkuCisgICAgLy8gVGhp cyBjaGVjayBjYW4gYmUgcmVtb3ZlZCBvbmNlIHRoZSBtYWdpYyBjaGVjayBvbiBfZnJlZSgpIHJl bW92ZWQgaW4gRWluYS4KKyAgICAvLyBodHRwOi8vd3d3Lm1haWwtYXJjaGl2ZS5jb20vZW5saWdo dGVubWVudC1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQvbXNnNDI5NDQuaHRtbAorICAgIGlm ICghaXQpCisgICAgICAgIHJldHVybiBtYXRjaGluZ0VudHJpZXM7CisKICAgICBFSU5BX0lURVJB VE9SX0ZPUkVBQ0goaXQsIGZfbmFtZSkgewogICAgICAgICBpZiAoIWZubWF0Y2goY2ZpbHRlci5k YXRhKCksIGZfbmFtZSwgMCkpCiAgICAgICAgICAgICBtYXRjaGluZ0VudHJpZXMuYXBwZW5kKFN0 cmluZzo6ZnJvbVVURjgoZl9uYW1lKSk7Cg==