90071 2012-06-27 06:45:14 -0700 REGRESSION(r121296): New zero-size background tests asserting on Mac. 2012-06-27 10:22:52 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling eric joethomas webkit.review.bot oldest_to_newest 658571 0 kling 2012-06-27 06:45:14 -0700 The zero-size background tests added/modified by <http://trac.webkit.org/changeset/121296> (bug 86942) are asserting on the mac bots: ASSERTION FAILED: patternTransform.isInvertible() /Volumes/Data/slave/lion-debug/build/Source/WebCore/platform/graphics/cg/ImageCG.cpp(232) : virtual void WebCore::Image::drawPattern(WebCore::GraphicsContext *, const WebCore::FloatRect &, const WebCore::AffineTransform &, const WebCore::FloatPoint &, WebCore::ColorSpace, WebCore::CompositeOperator, const WebCore::FloatRect &) 1 0x107dc5360 WebCore::Image::drawPattern(WebCore::GraphicsContext*, WebCore::FloatRect const&, WebCore::AffineTransform const&, WebCore::FloatPoint const&, WebCore::ColorSpace, WebCore::CompositeOperator, WebCore::FloatRect const&) 2 0x107dbba86 WebCore::Image::drawTiled(WebCore::GraphicsContext*, WebCore::FloatRect const&, WebCore::FloatPoint const&, WebCore::FloatSize const&, WebCore::ColorSpace, WebCore::CompositeOperator) 3 0x107c211b6 WebCore::GraphicsContext::drawTiledImage(WebCore::Image*, WebCore::ColorSpace, WebCore::IntRect const&, WebCore::IntPoint const&, WebCore::IntSize const&, WebCore::CompositeOperator, bool) 4 0x1086b0e11 WebCore::RenderBoxModelObject::paintFillLayerExtended(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::FractionalLayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::InlineFlowBox*, WebCore::FractionalLayoutSize const&, WebCore::CompositeOperator, WebCore::RenderObject*) 5 0x10869247e WebCore::RenderBox::paintFillLayer(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::FractionalLayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::CompositeOperator, WebCore::RenderObject*) 6 0x1086915c0 WebCore::RenderBox::paintFillLayers(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::FractionalLayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::CompositeOperator, WebCore::RenderObject*) 7 0x108691d05 WebCore::RenderBox::paintBackground(WebCore::PaintInfo const&, WebCore::FractionalLayoutRect const&, WebCore::BackgroundBleedAvoidance) 8 0x1086919a1 WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 9 0x10862e9e9 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 10 0x10862c073 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 11 0x10862e46e WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 12 0x10862dff5 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 13 0x10862eb62 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 14 0x10862c073 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 15 0x10862e46e WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 16 0x10862dff5 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 17 0x10862eb62 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 18 0x10862c073 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 19 0x10872a969 WebCore::RenderLayer::paintLayerContents(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 20 0x108729f77 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 21 0x108729619 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 22 0x10872b988 WebCore::RenderLayer::paintList(WTF::Vector<WebCore::RenderLayer*, 0ul>*, WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 23 0x10872ac79 WebCore::RenderLayer::paintLayerContents(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 24 0x108729f77 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 25 0x108729619 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 26 0x108728fd9 WebCore::RenderLayer::paint(WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, unsigned int) 27 0x107bdf824 WebCore::FrameView::paintContents(WebCore::GraphicsContext*, WebCore::IntRect const&) 28 0x10894af8c WebCore::ScrollView::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) 29 0x105b0ef14 WebKit::WebPage::drawRect(WebCore::GraphicsContext&, WebCore::IntRect const&) 30 0x10594e42f WebKit::DrawingAreaImpl::display(WebKit::UpdateInfo&) 31 0x10594d1f4 WebKit::DrawingAreaImpl::display() Tests in question: fast/backgrounds/zero-background-size.html (new) fast/backgrounds/size/zero.html (updated) 658611 1 joethomas 2012-06-27 08:11:02 -0700 With http://trac.webkit.org/changeset/121296, minimum size of the background-image is set to (0,0) as the spec mandates that. This makes the PatterTransform to be (0,0,0,0) and it hits the assertion. We also have a return statement after the assertion for the same condition. So I think we should remove this assertion as this is a valid case now. Please let me know your opinion on this. Thanks. 658664 2 149763 kling 2012-06-27 09:35:19 -0700 Created attachment 149763 Patch 658665 3 149763 mitz 2012-06-27 09:36:39 -0700 Comment on attachment 149763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149763&action=review > Source/WebCore/platform/graphics/cg/ImageCG.cpp:233 > // Avoid a hang under CGContextDrawTiledImage on release builds. This comment needs to be changed or removed, since the return that follows is no longer specific to release builds. 658674 4 149765 kling 2012-06-27 09:48:46 -0700 Created attachment 149765 Latch for panding 658695 5 149765 webkit.review.bot 2012-06-27 10:22:47 -0700 Comment on attachment 149765 Latch for panding Clearing flags on attachment: 149765 Committed r121347: <http://trac.webkit.org/changeset/121347> 658696 6 webkit.review.bot 2012-06-27 10:22:52 -0700 All reviewed patches have been landed. Closing bug. 149763 2012-06-27 09:35:19 -0700 2012-06-27 09:48:46 -0700 Patch bug-90071.diff text/plain 1311 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNmM3ODcyLi5kMDEyYzE1IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDYtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjEyMTI5Nik6IE5ldyB6ZXJvLXNpemUgYmFja2dyb3VuZCB0ZXN0cyBh c3NlcnRpbmcgb24gTWFjLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi85MDA3MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgQVNT RVJUKHBhdHRlcm5UcmFuc2Zvcm0uaXNJbnZlcnRpYmxlKCkpIGFzIHRoaXMgaXMgbm93IGEgdmFs aWQgc2NlbmFyaW8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlOjpkcmF3UGF0dGVybik6CisKIDIwMTItMDYtMjcg IEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbmV4 cGVjdGVkIGVuZCBvZiBzdHlsZSBzaGVldCBpbiBAZm9udC1mYWNlIHJ1bGUgZGlzY2FyZHMgaXQg cmF0aGVyIHRoYW4gY2xvc2VzIGFsbCBvcGVuIGNvbnN0cnVjdHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAKaW5kZXggOWRkNDU0MS4uMmZlY2Y2 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VD Ry5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5j cHAKQEAgLTIyOSw3ICsyMjksNiBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVybihHcmFwaGljc0Nv bnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgdGlsZVJlY3QsIGNvbnN0CiAgICAgaWYgKCFu YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBBU1NF UlQocGF0dGVyblRyYW5zZm9ybS5pc0ludmVydGlibGUoKSk7CiAgICAgaWYgKCFwYXR0ZXJuVHJh bnNmb3JtLmlzSW52ZXJ0aWJsZSgpKQogICAgICAgICAvLyBBdm9pZCBhIGhhbmcgdW5kZXIgQ0dD b250ZXh0RHJhd1RpbGVkSW1hZ2Ugb24gcmVsZWFzZSBidWlsZHMuCiAgICAgICAgIHJldHVybjsK 149765 2012-06-27 09:48:46 -0700 2012-06-27 10:22:47 -0700 Latch for panding bug-90071-land.diff text/plain 1365 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNmM3ODcyLi41ZTNmYzIxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDYtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjEyMTI5Nik6IE5ldyB6ZXJvLXNpemUgYmFja2dyb3VuZCB0ZXN0cyBh c3NlcnRpbmcgb24gTWFjLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi85MDA3MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgorCisgICAgICAgIFJlbW92ZSBBU1NF UlQocGF0dGVyblRyYW5zZm9ybS5pc0ludmVydGlibGUoKSkgYXMgdGhpcyBpcyBub3cgYSB2YWxp ZCBzY2VuYXJpby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToKKwogMjAxMi0wNi0yNyAg QWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVuZXhw ZWN0ZWQgZW5kIG9mIHN0eWxlIHNoZWV0IGluIEBmb250LWZhY2UgcnVsZSBkaXNjYXJkcyBpdCBy YXRoZXIgdGhhbiBjbG9zZXMgYWxsIG9wZW4gY29uc3RydWN0cwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcAppbmRleCA5ZGQ0NTQxLi5mZWQ5MTFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNH LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNw cApAQCAtMjI5LDkgKzIyOSw3IEBAIHZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29u dGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVjdCwgY29uc3QKICAgICBpZiAoIW5h dGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFTU0VS VChwYXR0ZXJuVHJhbnNmb3JtLmlzSW52ZXJ0aWJsZSgpKTsKICAgICBpZiAoIXBhdHRlcm5UcmFu c2Zvcm0uaXNJbnZlcnRpYmxlKCkpCi0gICAgICAgIC8vIEF2b2lkIGEgaGFuZyB1bmRlciBDR0Nv bnRleHREcmF3VGlsZWRJbWFnZSBvbiByZWxlYXNlIGJ1aWxkcy4KICAgICAgICAgcmV0dXJuOwog CiAgICAgQ0dDb250ZXh0UmVmIGNvbnRleHQgPSBjdHh0LT5wbGF0Zm9ybUNvbnRleHQoKTsK