90044 2012-06-26 22:22:26 -0700 [V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get() 2012-06-27 00:28:50 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet jochen webkit.review.bot oldest_to_newest 658335 0 haraken 2012-06-26 22:22:26 -0700 'static_cast<V8BindingPerIsolateData*>(isolate->GetData())' is duplicated in V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get(). 658336 1 149678 haraken 2012-06-26 22:24:01 -0700 Created attachment 149678 Patch 658414 2 149678 webkit.review.bot 2012-06-27 00:28:46 -0700 Comment on attachment 149678 Patch Clearing flags on attachment: 149678 Committed r121326: <http://trac.webkit.org/changeset/121326> 658415 3 webkit.review.bot 2012-06-27 00:28:50 -0700 All reviewed patches have been landed. Closing bug. 149678 2012-06-26 22:24:01 -0700 2012-06-27 00:28:46 -0700 Patch bug-90044-20120627142401.patch text/plain 2174 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU2YTAwM2YzODM0NTZi NTAwNjU0ZTM0M2JkZWRkNjk2NjhjZjM1YS4uZjMxMjIzOTA2OTY3NzJmN2UzNGVjMzQ3NjkwODEw ZGI2MjkwYzY4MCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTI2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlZmFjdG9y IFY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjpjdXJyZW50KCkgYW5kIFY4QmluZGluZ1Blcklzb2xh dGVEYXRhOjpnZXQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTAwNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAnc3RhdGljX2Nhc3Q8VjhCaW5kaW5nUGVySXNvbGF0ZURhdGEqPihpc29sYXRlLT5HZXRE YXRhKCkpJyBpcyBkdXBsaWNhdGVkCisgICAgICAgIGluIFY4QmluZGluZ1Blcklzb2xhdGVEYXRh OjpjdXJyZW50KCkgYW5kIFY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjpnZXQoKS4KKyAgICAgICAg VGhpcyBwYXRjaCByZW1vdmVzIHRoZSBkdXBsaWNhdGlvbi4KKworICAgICAgICBObyB0ZXN0cy4g Tm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5n Lmg6CisgICAgICAgIChXZWJDb3JlOjpWOEJpbmRpbmdQZXJJc29sYXRlRGF0YTo6Y3VycmVudCk6 CisKIDIwMTItMDYtMjYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgU3RvcCBjYWxsaW5nIG5vZGUoKSBhbmQgZGVwcmVjYXRlZEVkaXRpbmdPZmZzZXQoKSBpbiBj b21wYXJlUG9zaXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4 IDEwMjk2YTcwMGI1ZTM0NjA0MDllZGVlODQzOGU5OTAyZTM5MDZiOTUuLjllOWM1YmI1NzBiYTNl MTZlMjFjYzNlNWY5MWY5ZWU2MTk1Mzc0ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 QmluZGluZy5oCkBAIC0xMjAsMTYgKzEyMCwxMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg cHVibGljOgogICAgICAgICBzdGF0aWMgVjhCaW5kaW5nUGVySXNvbGF0ZURhdGEqIGNyZWF0ZSh2 ODo6SXNvbGF0ZSopOwogICAgICAgICBzdGF0aWMgdm9pZCBlbnN1cmVJbml0aWFsaXplZCh2ODo6 SXNvbGF0ZSopOwotICAgICAgICBzdGF0aWMgVjhCaW5kaW5nUGVySXNvbGF0ZURhdGEqIGdldCh2 ODo6SXNvbGF0ZSogaXNvbGF0ZSkKKyAgICAgICAgc3RhdGljIFY4QmluZGluZ1Blcklzb2xhdGVE YXRhKiBjdXJyZW50KHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKICAgICAgICAgeworICAgICAg ICAgICAgaWYgKFVOTElLRUxZKCFpc29sYXRlKSkKKyAgICAgICAgICAgICAgICBpc29sYXRlID0g djg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKTsKICAgICAgICAgICAgIEFTU0VSVChpc29sYXRlLT5H ZXREYXRhKCkpOwogICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFY4QmluZGluZ1Blcklz b2xhdGVEYXRhKj4oaXNvbGF0ZS0+R2V0RGF0YSgpKTsgCiAgICAgICAgIH0KLQotICAgICAgICBz dGF0aWMgVjhCaW5kaW5nUGVySXNvbGF0ZURhdGEqIGN1cnJlbnQodjg6Oklzb2xhdGUqIGlzb2xh dGUgPSAwKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gaXNvbGF0ZSA/IHN0YXRpY19j YXN0PFY4QmluZGluZ1Blcklzb2xhdGVEYXRhKj4oaXNvbGF0ZS0+R2V0RGF0YSgpKSA6IGdldCh2 ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKLSAgICAgICAgfQogICAgICAgICBzdGF0aWMgdm9p ZCBkaXNwb3NlKHY4OjpJc29sYXRlKik7CiAKICAgICAgICAgdHlwZWRlZiBIYXNoTWFwPFdyYXBw ZXJUeXBlSW5mbyosIHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5jdGlvblRlbXBsYXRlPiA+IFRlbXBs YXRlTWFwOwo=